Re: Build failed in Jenkins: osv-build #1157

2016-12-21 Thread Waldek Kozaczuk
I sent a patch that fixes the issue by reorganizing the module java-test and essentially making it require 'java' instead of 'java-base'. Unfortunately because scripts/module.py is order sensitive as far as image parameter goes and old 'java' module got broken into 'java-isolated' and 'openjdk7' th

[PATCH] Changed java-tests module to require module java

2016-12-21 Thread Waldemar Kozaczuk
This patch addresses a build issue where this build command would fail due to both jdk 7 and 8 included: scripts/build -j4 image=java-tests,openjdk8-fedora && scripts/test.py --name java.* Following build commands should work now: scripts/build -j4 image=java-tests && scripts/test.py --name java

Re: [PATCH v4] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread 'Rean Griffith' via OSv Development
Fixed (re-formatted and resubmitted) , 3-indent is the style from a previous life/company. thanks, Rean On Wed, Dec 21, 2016 at 2:16 PM, Nadav Har'El wrote: > Sorry for not having spotted this sooner, but is it possible (???) that > your patch uses a 3-space indentation style, while the rest of

[PATCH v5] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread 'rean' via OSv Development
- pthread_barrier* patch clean up (address review comments: r1) - pthread_barrier* patch clean up (address review comments: r2) - Abridged test output with 7 microsec usleep, 10 threads, 4 rounds of barrier crossings (tst-pthread-barrier.so) - pthread_barrier* patch clean up (address review commen

Re: [PATCH v4] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread Nadav Har'El
Sorry for not having spotted this sooner, but is it possible (???) that your patch uses a 3-space indentation style, while the rest of the OSv code uses the more usual 4-space indentation style? Can you please fix it to fit the OSv coding style? Thanks, Nadav. -- Nadav Har'El n...@scylladb.com

Re: [PATCH v3] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread 'Rean Griffith' via OSv Development
Hi Nadav, No worries. I've made the changes requested and re-submitted. thanks, Rean On Wed, Dec 21, 2016 at 12:13 AM, Nadav Har'El wrote: > > On Tue, Dec 20, 2016 at 8:05 PM, 'rean' via OSv Development < > osv-dev@googlegroups.com> wrote: > >> - pthread_barrier* patch clean up (address revie

[PATCH v4] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread 'rean' via OSv Development
- pthread_barrier* patch clean up (address review comments: r1) - pthread_barrier* patch clean up (address review comments: r2) - Abridged test output with 7 microsec usleep, 10 threads, 4 rounds of barrier crossings (tst-pthread-barrier.so) - pthread_barrier* patch clean up (address review commen

Build failed in Jenkins: osv-build #1159

2016-12-21 Thread avi
See Changes: [rickp] Add missing pthread_getname_np() -- [...truncated 10725 lines...] Adding /usr/lib/jvm/java/jre/lib/zi/SystemV/PST8... Adding /usr/lib/jvm/java/jre/lib/logging.proper

Re: Build failed in Jenkins: osv-build #1157

2016-12-21 Thread Nadav Har'El
On Wed, Dec 21, 2016 at 2:20 PM, Waldek Kozaczuk wrote: > Great catch. It looks like I missed to test this combination ('make check' > does not trigger this one). Does it mean that jenkins jobs do more than > make check? > Yes, it does a few more things we at some point deemed useful to check (a

[COMMIT osv master] Add missing pthread_getname_np()

2016-12-21 Thread Commit Bot
From: Rick Payne Committer: Nadav Har'El Branch: master Add missing pthread_getname_np() Signed-off-by: Rick Payne Message-Id: <20161221123601.5879-1-ri...@rossfell.co.uk> --- diff --git a/include/api/pthread.h b/include/api/pthread.h --- a/include/api/pthread.h +++ b/include/api/pthread.h @

[PATCH] Add missing pthread_getname_np()

2016-12-21 Thread Rick Payne
Signed-off-by: Rick Payne --- include/api/pthread.h | 1 + libc/pthread.cc | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/api/pthread.h b/include/api/pthread.h index 85743f7..105e8d4 100644 --- a/include/api/pthread.h +++ b/include/api/pthread.h @@ -212,6 +212,7 @@ void

Re: Build failed in Jenkins: osv-build #1157

2016-12-21 Thread Waldek Kozaczuk
Great catch. It looks like I missed to test this combination ('make check' does not trigger this one). Does it mean that jenkins jobs do more than make check? I will fix it. Waldek On Wed, Dec 21, 2016 at 4:39 AM, Nadav Har'El wrote: > > On Wed, Dec 21, 2016 at 9:59 AM, Nadav Har'El wrote: >

Re: Build failed in Jenkins: osv-build #1157

2016-12-21 Thread Nadav Har'El
On Wed, Dec 21, 2016 at 9:59 AM, Nadav Har'El wrote: > On Wed, Dec 21, 2016 at 9:41 AM, wrote: > >> See >> >> > Build (and test) run #1157 failed because it did not include the apps/ > update. Not great (no bisectability), but

Re: [PATCH v3] pthread_barrier*: Add OSv-specific pthread_barrier_init, wait, destroy + test

2016-12-21 Thread Nadav Har'El
On Tue, Dec 20, 2016 at 8:05 PM, 'rean' via OSv Development < osv-dev@googlegroups.com> wrote: > - pthread_barrier* patch clean up (address review comments: r1) > - pthread_barrier* patch clean up (address review comments: r2) > - Abridged test output with 7 microsec usleep, 10 threads, 4 rounds >

Build failed in Jenkins: osv-build #1158

2016-12-21 Thread avi
See Changes: [Nadav Har'El] Update apps/ submodule -- [...truncated 8998 lines...] Adding /usr/lib/jvm/java/jre/lib/zi/SystemV/PST8... Adding /usr/lib/jvm/java/jre/lib/logging.properties