[COMMIT osv master] tests/tst-kill: fix hang on Linux

From: Nadav Har'El Committer: Nadav Har'El Branch: master tests/tst-kill: fix hang on Linux The test for interrupted system call used signal(), but on Linux this function always restarts interrupted system calls - also blocking network system calls - so this test would hang on Linux. So fix it

[COMMIT osv master] tests/tst-kill: fix failing test on Linux

From: Nadav Har'El Committer: Nadav Har'El Branch: master tests/tst-kill: fix failing test on Linux We tested that killing a non-existant process 17 resulted in an error. But on Linux, it is quite possible that process 17 does exist, and this test will fail. So change it to an even less likely

Re: [PATCH 8/8] xenconsole: shared ring suport

On Mon, Mar 6, 2017 at 5:24 PM, Sergiy Kibrik wrote: > > On 03/05/2017 12:45 PM, Nadav Har'El wrote: > > > + > >> void XEN_Console::write(const char *str, size_t len) { >> - HYPERVISOR_console_write(str, len); >> +assert(len > 0); >> +if (!_interface) { >> +HYPERVISOR_conso

Re: [PATCH 8/8] xenconsole: shared ring suport

On 03/05/2017 12:45 PM, Nadav Har'El wrote: On Fri, Mar 3, 2017 at 11:45 AM, 'Sergiy Kibrik' via OSv Development mailto:osv-dev@googlegroups.com>> wrote: Complete driver to properly work with xl console utility, i.e. full read/write access. Driver is extended to work with shared stru

[COMMIT osv master] loader: fix log redirection append option

From: Justin Cinkelj Committer: Nadav Har'El Branch: master loader: fix log redirection append option The O_APPEND flag was missing when "--redirect=>>my.log ..." was used. Thus new output started to overwrite old content. Signed-off-by: Justin Cinkelj Message-Id: <20170306143706.10745-1-jus

Re: [PATCH 1/8] osv: xen: independent event interrupt bring up

On Mon, Mar 6, 2017 at 4:08 PM, Sergiy Kibrik wrote: > On 03/05/2017 11:08 AM, Nadav Har'El wrote: > > > On Fri, Mar 3, 2017 at 11:45 AM, 'Sergiy Kibrik' via OSv Development < > osv-dev@googlegroups.com> wrote: > >> Initialize Xen event interrupt separately from xenbus driver, so that >> events >

Re: [PATCH] loader: fix log redirection append option

Looks good. I wonder how I tested the original code ;-) I think my original intention was to do an lseek() - once - instead of O_APPEND - but this lseek is missing. O_APPEND should work too, it's somewhat of an overkill I guess, but should work. I'll commit this. -- Nadav Har'El n...@scylladb.com

[PATCH] loader: fix log redirection append option

The O_APPEND flag was missing when "--redirect=>>my.log ..." was used. Thus new output started to overwrite old content. Signed-off-by: Justin Cinkelj --- loader.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loader.cc b/loader.cc index 80a9c79..0398cd3 100644 --- a/loade

Re: [PATCH 2/8] osv: xen: split xenbus into generic & PCI parts

On 03/05/2017 11:44 AM, Nadav Har'El wrote: On Fri, Mar 3, 2017 at 11:45 AM, 'Sergiy Kibrik' via OSv Development mailto:osv-dev@googlegroups.com>> wrote: Xen platform PCI is x86-specific feature, not currently present on aarch64. For xenbus to work on both platforms the generic xenbus

Re: [PATCH 1/8] osv: xen: independent event interrupt bring up

On 03/05/2017 11:08 AM, Nadav Har'El wrote: On Fri, Mar 3, 2017 at 11:45 AM, 'Sergiy Kibrik' via OSv Development mailto:osv-dev@googlegroups.com>> wrote: Initialize Xen event interrupt separately from xenbus driver, so that events can be served before xenbus is up, or even in case when

[PATCH] tests/tst-kill: fix failing test on Linux

We tested that killing a non-existant process 17 resulted in an error. But on Linux, it is quite possible that process 17 does exist, and this test will fail. So change it to an even less likely to exist number. Signed-off-by: Nadav Har'El --- tests/tst-kill.cc | 2 +- 1 file changed, 1 insertio

[PATCH] tests/tst-kill: fix hang on Linux

The test for interrupted system call used signal(), but on Linux this function always restarts interrupted system calls - also blocking network system calls - so this test would hang on Linux. So fix it to use sigaction(), which properly interrupts the system call on both Linux and OSv. Signed-off

Jenkins build is back to normal : osv-build #1208

See -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsub

[COMMIT osv master] tests/tst-kill: make compilable on Linux as well

From: Nadav Har'El Committer: Nadav Har'El Branch: master tests/tst-kill: make compilable on Linux as well Stop using OSv-specific features (namely debug()) in this test, so we can also run it on Linux. This test currently hangs on Linux, because the test assumes that signal() sets system cal

[COMMIT osv master] scripts/setup.py: support for Fedora 25

From: Nadav Har'El Committer: Nadav Har'El Branch: master scripts/setup.py: support for Fedora 25 Signed-off-by: Nadav Har'El --- diff --git a/scripts/setup.py b/scripts/setup.py --- a/scripts/setup.py +++ b/scripts/setup.py @@ -77,7 +77,14 @@ class Fedora_24(object): ec2_post_insta

Build failed in Jenkins: osv-build #1207

See Changes: [Nadav Har'El] kill(): remove duplicate code -- Started by GitHub push by nyh [EnvInject] - Loading node environment variables. Building on master in

[COMMIT osv master] kill(): remove duplicate code

From: Nadav Har'El Committer: Nadav Har'El Branch: master kill(): remove duplicate code Just a few lines above, we had exactly the same code... No need to do it again. Signed-off-by: Nadav Har'El Message-Id: <20170306120113.18737-1-...@scylladb.com> --- diff --git a/libc/signal.cc b/libc/si

Build failed in Jenkins: osv-build #1206

See Changes: [justin.cinkelj] tests/tst-kill: set flag global to 0 before waiting for 1 -- Started by GitHub push by nyh [EnvInject] - Loading node environment var

[COMMIT osv master] tests/tst-kill: set flag global to 0 before waiting for 1

From: Justin Cinkelj Committer: Nadav Har'El Branch: master tests/tst-kill: set flag global to 0 before waiting for 1 The global was already set to 1 by kill above second wait loop. If test VM/program was "slow" enough, the signal handler got cleaned before "oldact.sa_handler == SIG_DFL" check

[PATCH] tests/tst-kill: set flag global to 0 before waiting for 1

The global was already set to 1 by kill above second wait loop. If test VM/program was "slow" enough, the signal handler got cleaned before "oldact.sa_handler == SIG_DFL" check (debug build, nested VM, slow enough report printout). The test tended to fail when VM run on physical host. Fixes #861 -

[PATCH] tests/tst-kill: make compilable on Linux as well

Stop using OSv-specific features (namely debug()) in this test, so we can also run it on Linux. This test currently hangs on Linux, because the test assumes that signal() sets system calls to not restart - while on Linux, they do. Signed-off-by: Nadav Har'El --- tests/tst-kill.cc | 13 -

[PATCH] kill(): remove duplicate code

Just a few lines above, we had exactly the same code... No need to do it again. Signed-off-by: Nadav Har'El --- libc/signal.cc | 4 1 file changed, 4 deletions(-) diff --git a/libc/signal.cc b/libc/signal.cc index b7351ee..832002c 100644 --- a/libc/signal.cc +++ b/libc/signal.cc @@ -353,10