Re: [PATCH v2] Add nginx

I also tried with/without cli, debug/release build, and did clean it before rebuild ./scripts/build -j4 mode=release clean ./scripts/build -j4 mode=release image=nginx And it still works justin_cinkelj@jcpc:~/devel/mikelangelo/osv-fc25/osv$ scripts/run.py --forward tcp:::80

Re: [PATCH v2] Add nginx

But... I tried this before, and it did work. Scratching my head now. What works for me. Building on FC25 justin_cinkelj@jcpc:~/devel/mikelangelo/osv-fc25/osv$ git log --pretty=oneline b88aa485e8beac18cb51f28dcbb710ed5bdcdab8 af_local: stub ioctl FIOASYNC 62839c888be763a3afb1051234ae9a6fef04e654

[COMMIT osv-apps master] Adjust grep expression used in lighttpd Makefile to filter out

From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master Adjust grep expression used in lighttpd Makefile to filter out On some host systems (used to build) ldd tool returns list with invalid pointers like so (the first line being the

Re: [PATCH v2] Add nginx

Hi, I tried this, and unfortunately it seems like is *is* calling sigsuspend, so the implemenation using IMPL() (and aborting) is not good enough: /home/nyh/osv.tmp2/osv$ scripts/run.py --forward tcp:::80 WARNING: unimplemented int sigsuspend(const sigset_t *mask) Aborted Backtrace in

[COMMIT osv master] signals: provide sigsuspend symbol

From: Justin Cinkelj Committer: Nadav Har'El Branch: master signals: provide sigsuspend symbol sigsuspend is used in nginx. With current (not yet commited) patch, it is never really called. Nginx master process code is used to execute worker code,

[PATCH v2] signals: provide sigsuspend symbol

sigsuspend is used in nginx. With current (not yet commited) patch, it is never really called. Nginx master process code is used to execute worker code, and this prevents master code to actually call sigsuspend. So UNIMPL implementation is sufficient for now. Signed-off-by: Justin Cinkelj

Re: [PATCH 1/2] af_local: stub ioctl FIOASYNC

On 07/18/2017 01:18 PM, Nadav Har'El wrote: Thanks. One question below: On Tue, Jul 18, 2017 at 12:16 PM, Justin Cinkelj > wrote: nginx doesn't start if ioctl with cmd=FIOASYNC fails. Stub it, so that nginx can start unpatched.

Re: [PATCH] signals: stub sigsuspend

-- On Tue, Jul 18, 2017 at 12:50 PM, Justin Cinkelj wrote: > sigsuspend is used in nginx. With current (not yet commited) patch, it > is never really called. Nginx master process code is used to execute > worker code, and this prevents master code to actually call

[COMMIT osv master] fcntl: stub F_SETOWN

From: Justin Cinkelj Committer: Nadav Har'El Branch: master fcntl: stub F_SETOWN fcntl(F_SETOWN) is used in nginx. We stub it so that nginx can be started unmodified. Signed-off-by: Justin Cinkelj Message-Id:

Re: [PATCH 1/2] af_local: stub ioctl FIOASYNC

Thanks. One question below: On Tue, Jul 18, 2017 at 12:16 PM, Justin Cinkelj wrote: > nginx doesn't start if ioctl with cmd=FIOASYNC fails. Stub it, so that > nginx can start unpatched. > > Signed-off-by: Justin Cinkelj > --- > libc/af_local.cc

Re: [PATCH] Add nginx

The v2 patch: The real sigsuspend patch (4 of them) are not required. But, the stubs for sigsuspend, ioctl(FIOASYNC) and fcntl(F_SETOWN) are now required :) In nginx.conf, I removed keepalive_timeout, as it is not really required. And in makefile $(MAKE) is used instead of 'make -j4', so that

[PATCH] signals: stub sigsuspend

sigsuspend is used in nginx. With current (not yet commited) patch, it is never really called. Nginx master process code is used to execute worker code, and this prevents master code to actually call sigsuspend. So stub implementation is sufficient for now. Signed-off-by: Justin Cinkelj

[PATCH 0/2] stub ioctl(FIOASYNC) and fcntl(F_SETOWN)

Both ioctl(FIOASYNC) and fcntl(F_SETOWN) are used in nginx. We stub them, so than nginx doesn't need to be patched. Or at least, only fork+execve will require a pathc. Justin Cinkelj (2): af_local: stub ioctl FIOASYNC fcntl: stub F_SETOWN fs/vfs/main.cc | 3 +++ libc/af_local.cc | 18