Build failed in Jenkins: osv-build-nightly #1636

See Changes: [Nadav Har'El] Update apps submodule [jwkozaczuk] Support non-fPIC shared objects [Nadav Har'El] tests makefile: clean up non-fpic compilation -

Re: Build failed in Jenkins: osv-build #1429

No I have realized that another method, I have added, make_text_writable uses a loop with r-value. Honestly I am not sure if that has some side-effect I am not understanding. Any clues? Waldek On Monday, October 29, 2018 at 1:32:18 PM UTC-4, Waldek Kozaczuk wrote: > > I ran all the tests twi

Re: Bug report: soabort() will free *so twice:

Adding Charles to the thread. On Mon, Oct 29, 2018 at 2:24 PM Waldek Kozaczuk wrote: > I think that this code in tcp_usr_abort has to be changed - > https://github.com/cloudius-systems/osv/blob/master/bsd/sys/netinet/tcp_usrreq.cc#L909-L924. > If first "if" with two conditions is true than the s

Re: Bug report: soabort() will free *so twice:

I think that this code in tcp_usr_abort has to be changed - https://github.com/cloudius-systems/osv/blob/master/bsd/sys/netinet/tcp_usrreq.cc#L909-L924. If first "if" with two conditions is true than the second is as well (unless inp_flags get changed by tcp_drop()) and even this statement mig

Re: Build failed in Jenkins: osv-build #1429

I ran all the tests twice again on both Ubuntu and Fedora and all passed. I wonder if the fact I extracted the get_segment_mmap_permissions() method somehow inadvertently changes phdr.p_flags and then this assert fails. Maybe some gcc optimization and we have different gcc on the build machine.

Re: Bug report: soabort() will free *so twice:

I wonder if https://github.com/cloudius-systems/osv/issues/936 is related to this? -- Nadav Har'El n...@scylladb.com On Tue, Oct 23, 2018 at 6:22 PM Geraldo Netto wrote: > Hello Jack/All, > > Nice catch, as soon as I can I'll check that > > I guess we can do a recursive grep for sofree to chec

Re: Build failed in Jenkins: osv-build #1429

This definitely seems possibly related to the changes I made. But how come I cannot reproduce it on both Ubuntu and Fedora on both my machine and virtual machines? Clean? On Monday, October 29, 2018 at 11:55:16 AM UTC-4, Nadav Har'El wrote: > > > > On Mon, Oct 29, 2018 at 5:33 PM > wrote: > >>

Re: Build failed in Jenkins: osv-build #1429

On Mon, Oct 29, 2018 at 5:33 PM wrote: > See < > http://jenkins.cloudius-systems.com:8080/job/osv-build/1429/display/redirect?page=changes > > > > Changes: > > [jwkozaczuk] Support non-fPIC shared objects > > [Nadav Har'El] tests makefile: clean up non-fpic compilation > ... > LD build/release.

Build failed in Jenkins: osv-build #1429

See Changes: [jwkozaczuk] Support non-fPIC shared objects [Nadav Har'El] tests makefile: clean up non-fpic compilation -- [...truncated 129.49 KB...] [INFO] [1m

[COMMIT osv master] Support non-fPIC shared objects

From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master Support non-fPIC shared objects This patch enhances ELF dynamic loader to support position dependent shared libraries. It does it by detecting presence of DT_TEXTREL marker and temporarilily making PT_LOAD sections writable so that

[COMMIT osv master] tests makefile: clean up non-fpic compilation

From: Nadav Har'El Committer: Nadav Har'El Branch: master tests makefile: clean up non-fpic compilation The "LD" line printed when compiling the non-fpic test was wrong ($* was not defined). This fixes this, but furthermore avoids the duplication of the entirely separate rule for the non-fpic

Re: Build failed in Jenkins: osv-build-nightly #1635

Hi Avi, is it possible that something on the Jenkins setup (on "thor"?) changed, and now the "boost-static" package is no longer installed? Could you please run OSv's scripts/setup.py to make sure all the required packages are there? Thanks, Nadav. -- Nadav Har'El n...@scylladb.com On Mon, Oct

[PATCH V2] Support non-fPIC shared objects

This patch enhances ELF dynamic loader to support position dependent shared libraries. It does it by detecting presence of DT_TEXTREL marker and temporarilily making PT_LOAD sections writable so that corresponding references in code get updated to point to correct addresses in memory. Eventuall

Re: [PATCH] Support non-fPIC shared objects

On Mon, Oct 29, 2018 at 2:28 PM Waldek Kozaczuk wrote: > > On Mon, Oct 29, 2018 at 07:23 Nadav Har'El wrote: > >> Hi. Looks good. Just one question about the test - why is >> misc-non-fpic.so a shared object that another >> test runs, instead of just being an indepedent test of its own, >> tst-n

Re: [PATCH] Support non-fPIC shared objects

On Mon, Oct 29, 2018 at 07:23 Nadav Har'El wrote: > Hi. Looks good. Just one question about the test - why is misc-non-fpic.so > a shared object that another > test runs, instead of just being an indepedent test of its own, > tst-non-fpic.so (that we compile a bit differently > from the other tes

Re: [PATCH] Support non-fPIC shared objects

Hi. Looks good. Just one question about the test - why is misc-non-fpic.so a shared object that another test runs, instead of just being an indepedent test of its own, tst-non-fpic.so (that we compile a bit differently from the other tests)? On Thu, Oct 25, 2018 at 1:10 AM Waldemar Kozaczuk wrote

[PATCH] Support non-fPIC shared objects

Nadav, Does this patch look OK to you to commit? Thanks, Waldek -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr...@googlegroups.com. For mo

[COMMIT osv master] Update apps submodule

From: Nadav Har'El Committer: Nadav Har'El Branch: master Update apps submodule Signed-off-by: Nadav Har'El --- diff --git a/apps b/apps --- a/apps +++ b/apps @@ -1 +1 @@ -Subproject commit 97ba1afacabdf6ba15c5757e79ad6af62dd79a9e +Subproject commit d9e5aa10e33c82218f9138d4f556c066d02fad90

[COMMIT osv-apps master] Fix gccgo-example

From: Nadav Har'El Committer: Nadav Har'El Branch: master Fix gccgo-example Changes to the gccgo runtime library made it necessary to change the main() starting a go program, and the gccgo-example app now longer works. However, since libgobegin.a is now compiled as -fPIC (see https://patchwor

Re: Better support non-shared unmodified pie Linux executables

On Mon, Oct 29, 2018 at 3:52 AM Waldek Kozaczuk wrote: > The title of this issue > Did you intend to create a bug-tracker issue, but accidentally sent it as an email? > is a little bit a misnomer as OSv supports running unmodified Linux pie > executables very well. However there are some gaps