Re: [osv-dev] [PATCH] Start using memory below kernel

2019-06-11 Thread Waldek Kozaczuk
I think that code is correct. In general the arithmetic on void* is not allowed. But in GNU C/C++ void size is assumed as char. So it looks like ++addr increments the address by 1 not 8 as I was guessing. Therefore size— seems to be correct. Then the code seem to align up the address by single

Re: [osv-dev] [PATCH] Start using memory below kernel

2019-06-11 Thread Waldek Kozaczuk
On Tuesday, June 11, 2019 at 1:12:04 PM UTC-4, Nadav Har'El wrote: > > > On Wed, Jun 5, 2019 at 7:33 AM Waldemar Kozaczuk > wrote: > >> This patch improves memory utilization by >> making OSv use area below where kernel is loaded. >> >> This normally saves only 1M + 640K (low memory) >> howewer

Re: [osv-dev] [PATCH] Start using memory below kernel

2019-06-11 Thread Nadav Har'El
On Wed, Jun 5, 2019 at 7:33 AM Waldemar Kozaczuk wrote: > This patch improves memory utilization by > making OSv use area below where kernel is loaded. > > This normally saves only 1M + 640K (low memory) > howewer makes bigger difference when kernel_base in > Makefile is bumped higher. So if one

[osv-dev] [COMMIT osv master] Start using memory below kernel

2019-06-11 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master Start using memory below kernel This patch improves memory utilization by making OSv use area below where kernel is loaded. This normally saves only 1M + 640K (low memory) howewer makes bigger difference when kernel_base in Makefi