On Thu, Nov 28, 2019 at 10:04 PM Waldek Kozaczuk
wrote:
>
>
>>>
>>>
>>> Please note I have removed this line from the tests Makefile:
> -$(boost-tests:%=$(out)/tests/%): CXXFLAGS += -D_GLIBCXX_USE_CXX11_ABI=0 \
> I do not fully understand the significance of it nor the reasons for it in
> the fir
This is related to https://github.com/cloudius-systems/osv/issues/743.
I have been trying to eliminate ancient libgcc_s.so from usr.manifest.skel
and replace it with the version from host. When I do that most (C++ only?)
apps fail like so:
Cmdline: /java_isolated.so -cp /tests/java/tests.jar
i
On Thursday, November 28, 2019 at 3:08:53 AM UTC-5, Nadav Har'El wrote:
>
>
> On Thu, Nov 28, 2019 at 8:00 AM Waldek Kozaczuk > wrote:
>
>> I have been trying to upgrade unit tests to use boost from host instead
>> of depending on externals. One one the previous patches I sent fixed
>> compila
From: yuchenq
Committer: Nadav Har'El
Branch: master
osv: fix keyboard reset, add pci reset
The original keyboard reset does not wait a for short period, so we see
the triple fault being triggered even if the keyboard reset is
successful sometimes. Added a wait there to make sure the keyboard
On Thu, Nov 28, 2019 at 4:29 PM 'YuChen Qian' via OSv Development <
osv-dev@googlegroups.com> wrote:
> From: yuchenq
>
> The original keyboard reset does not wait a for short period, so we see
> the triple fault being triggered even if the keyboard reset is
> successful sometimes. Added a wait th
On Thu, Nov 28, 2019 at 4:03 PM wrote:
> Thanks for the comment :) Please see my reply in the comments.
>
> On 27.11.19 15:43, Nadav Har'El wrote:
>
>
> +u8 v = processor::inb(0x0cf9) & ~6;
>> +processor::outb(v|2, 0x0cf9); // request hard reset
>> +usleep(50);
>> +processor::outb
From: Nadav Har'El
Committer: Waldemar Kozaczuk
Branch: master
tests: fix compilation warning in tests/tst-run.cc
It is generally a bad idea to catch exceptions by value, because it
forces an unnecessary copy of the caught value. It's even worse when
the type is polymorphic - in that case the
From: Nadav Har'El
Committer: Waldemar Kozaczuk
Branch: master
tests: fix warning in tst-symlink
The compiler correctly warns that we can't fill 4097 bytes of an array
size 4096 (=PATH_MAX). I don't know why this code had 4097 in the first
place.
The test still passes with this fix, and the w
From: Nadav Har'El
Committer: Waldemar Kozaczuk
Branch: master
tests: fix warning in tst-mmap.cc
When building tests, we get this warning:
tst-mmap.hh:76:19: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
76 | char byte = **(volatile
From: yuchenq
The original keyboard reset does not wait a for short period, so we see
the triple fault being triggered even if the keyboard reset is
successful sometimes. Added a wait there to make sure the keyboard reset
completes before triggering the triple fault.
Added PCI reset, and enabled
Thanks for the comment :) Please see my reply in the comments.
On 27.11.19 15:43, Nadav Har'El wrote:
Hi, thanks for the patch! I have some questions:
On Wed, Nov 27, 2019 at 3:46 PM 'YuChen Qian' via OSv Development
mailto:osv-dev@googlegroups.com>> wrote:
The original keyboard reset do
It is generally a bad idea to catch exceptions by value, because it
forces an unnecessary copy of the caught value. It's even worse when
the type is polymorphic - in that case the copy will only be a slice
of the original type. This is why recent compilers started to warn
when code catches a polymo
The compiler correctly warns that we can't fill 4097 bytes of an array
size 4096 (=PATH_MAX). I don't know why this code had 4097 in the first
place.
The test still passes with this fix, and the warning is gone.
Refs #976.
Signed-off-by: Nadav Har'El
---
tests/tst-symlink.cc | 2 +-
1 file cha
When building tests, we get this warning:
tst-mmap.hh:76:19: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
76 | char byte = **(volatile char**)&func;
| ^~
I think this code was actually wrong...
On Thu, Nov 28, 2019 at 8:00 AM Waldek Kozaczuk
wrote:
> I have been trying to upgrade unit tests to use boost from host instead of
> depending on externals. One one the previous patches I sent fixed
> compilation errors.
>
> However when I update the tests makefile and manifest file I see that s
From: Waldemar Kozaczuk
Committer: Nadav Har'El
Branch: master
unit tests: replace deprecated BOOST_MESSAGE with BOOST_TEST_MESSAGE
This patch resolves compilations errors with newer versions
of boost.
Signed-off-by: Waldemar Kozaczuk
Message-Id: <20191128054258.13240-1-jwkozac...@gmail.com>
16 matches
Mail list logo
