[osv-dev] [PATCH 2/2] Implement RTLD_NEXT

2020-01-02 Thread Zhiting Zhu
This patch depends on the patch that adds the dl_test module. Test cases are all passed in linux but some fail on osv. Signed-off-by: Zhiting Zhu --- core/elf.cc | 25 + include/osv/elf.hh | 1 + libc/dlfcn.cc | 5 +- modules/tests/Makefile | 2 + modules/t

[osv-dev] [PATCH 1/2] extract test files from bionic

2020-01-02 Thread Zhiting Zhu
This test files are for testing dlfcn related functions Signed-off-by: Zhiting Zhu --- .gitignore| 2 + modules/dl_tests/Makefile | 106 ++ 2 files changed, 108 insertions(+) create mode 100644 modules/dl_tests/Makefile diff --git a/.gitign

Re: [osv-dev] [PATCH] implement RTLD_NEXT

2020-01-02 Thread zhiting zhu
The tests I commented out is for running them on linux. The dlerror output is different from glibc and I commented out the one used in linux. The additional tests that's added in tst-dlfcn.cc is copy from dlfcn_test.cpp in bionic and change the test framework from gtest to boost unit test. I can'

Re: [osv-dev] [PATCH] implement RTLD_NEXT

2020-01-02 Thread Waldek Kozaczuk
I am not sure I fully grasp the difference between RTLD_GLOBAL and RTLD_LOCAL, but I think right OSv behaves as if RTLD_GLOBAL was passed which I think is wrong per http://man7.org/linux/man-pages/man3/dlopen.3.html which states that RTLD_LOCAL is the default when neither flag is set. The symbo

[osv-dev] Re: [PATCH V2] elf: ignore versioning table if symbol is looked up by object itself

2020-01-02 Thread Waldek Kozaczuk
Is there anything wrong/deficient with this patch that prevents us from applying it? On Thursday, December 26, 2019 at 10:22:46 PM UTC-5, Waldek Kozaczuk wrote: > > The commit > https://github.com/cloudius-systems/osv/commit/ed1eed7a567ec17138c65f0a5628c2311603c712 > > enhanced dynamic linker

[osv-dev] Re: [PATCH] elf: make symbols visible to the object itself from threads created by INIT functions

2020-01-02 Thread Waldek Kozaczuk
Is there anything wrong/deficient with this patch that prevents us from applying it? On Thursday, December 26, 2019 at 10:34:50 PM UTC-5, Waldek Kozaczuk wrote: > > As the issue #1067 explains, sometimes INIT functions create threads that > reference > symbols from the object being initialzed.

Re: [osv-dev] [PATCH V2] arm: do not relocate DTB, instead read it ahead of time

2020-01-02 Thread Nadav Har'El
Thanks. I can confirm that this fixes the arm problem (I built on Fedora 30), so I committed. I don't know enough about what this DTB thing is supposed to be and whether we might actually need it after the boot, but if we do, we can fix that then, I guess... -- Nadav Har'El n...@scylladb.com On

[osv-dev] [COMMIT osv master] arm: do not relocate DTB, instead read it ahead of time

2020-01-02 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master arm: do not relocate DTB, instead read it ahead of time As noted in one of the email threads, the aarch64 build of OSv fails to boot with the following error: "dtb_setup: failed to move dtb (dtb too large?)". It turns out that

Re: [osv-dev] aarch64 resurrected

2020-01-02 Thread Nadav Har'El
On Thu, Jan 2, 2020 at 7:17 AM Waldek Kozaczuk wrote: > Happy New Year everyone! > > A couple of days ago I sent a patch that fixes an issue with large DTB and > thus brings the arm port of OSv back to life. > Thanks, great. I can confirm the "dtb too large?" problem. I'll review and commit your