Re: [osv-dev] Fail to read data from large file

2020-01-13 Thread Nadav Har'El
On Tue, Jan 14, 2020 at 9:28 AM Lewis Tian wrote: > When I run pagerank on Ubuntu, the code works fine. (the graph data is > stored in web-NotreDame.txt, 21M) > 21M isn't very large, it shouldn't present any special problems. We probably have a bug that isn't just about file size: > taseikyo@u

[osv-dev] Fail to read data from large file

2020-01-13 Thread Lewis Tian
When I run pagerank on Ubuntu, the code works fine. (the graph data is stored in web-NotreDame.txt, 21M) taseikyo@ubuntu:~/Desktop/osv/apps/my-pagerank-test$ ls Makefile module.py pagerank.c usr.manifest web-NotreDame.txt taseikyo@ubuntu:~/Desktop/osv/apps/my-pagerank-test$ make cc -pie -o p

[osv-dev] [COMMIT osv master] elf: ignore versioning table if symbol is looked up by object itself

2020-01-13 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master elf: ignore versioning table if symbol is looked up by object itself The commit https://github.com/cloudius-systems/osv/commit/ed1eed7a567ec17138c65f0a5628c2311603c712 enhanced dynamic linker to skip old symbols per versions

Re: [osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-13 Thread zhiting zhu
On Mon, Jan 13, 2020 at 3:48 AM Nadav Har'El wrote: > Please see comments below. You forgot to change one part of the patch. > > On Mon, Jan 13, 2020 at 4:40 AM zhiting zhu > wrote: > >> This version only contains one iteration over the module list. >> >> On Sun, Jan 12, 2020 at 8:39 PM Zhiting

[osv-dev] [PATCH 3/3] Implement RTLD_NEXT

2020-01-13 Thread Zhiting Zhu
Signed-off-by: Zhiting Zhu --- core/elf.cc| 33 + include/osv/elf.hh | 1 + libc/dlfcn.cc | 4 ++-- tests/tst-dlfcn.cc | 2 +- 4 files changed, 37 insertions(+), 3 deletions(-) diff --git a/core/elf.cc b/core/elf.cc index 882b4d49..badbb7b0 100644

Re: [osv-dev] [PATCH 1/3] Add dlsym tests

2020-01-13 Thread Waldek Kozaczuk
I just wanted to say that it was me that got Zhiting on the road of creating the separate module. I just wanted to avoid the licensing issues and incorporating bionic code as is. But if there is a way to avoid the git clone, dl_tests altogether and no issues with licensing the better. Btw I will c

Re: [osv-dev] [PATCH V3] elf: ignore versioning table if symbol is looked up by object itself

2020-01-13 Thread Waldek Kozaczuk
I just wanted to say in general that I am not super happy we had to come up with this patch. But it blocks us from getting rid of externals. On Mon, Jan 13, 2020 at 06:24 Nadav Har'El wrote: > On Mon, Jan 13, 2020 at 7:14 AM Waldemar Kozaczuk > wrote: > >> The commit >> https://github.com/clou

Re: [osv-dev] [PATCH V3] elf: ignore versioning table if symbol is looked up by object itself

2020-01-13 Thread Nadav Har'El
On Mon, Jan 13, 2020 at 7:14 AM Waldemar Kozaczuk wrote: > The commit > https://github.com/cloudius-systems/osv/commit/ed1eed7a567ec17138c65f0a5628c2311603c712 > enhanced dynamic linker to skip old symbols per versions table. > Unfortunately > the relevant code did not take into account whether t

Re: [osv-dev] [PATCH 1/3] Add dlsym tests

2020-01-13 Thread Nadav Har'El
Hi, thank. Please see my answers and requests inline. On Mon, Jan 13, 2020 at 4:39 AM zhiting zhu wrote: > > > On Sun, Jan 12, 2020 at 4:02 PM Nadav Har'El wrote: > >> Thanks for the answers. I have some followup questions below. >> >> On Sun, Jan 12, 2020 at 10:36 PM zhiting zhu >> wrote: >>

Re: [osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-13 Thread Nadav Har'El
Please see comments below. You forgot to change one part of the patch. On Mon, Jan 13, 2020 at 4:40 AM zhiting zhu wrote: > This version only contains one iteration over the module list. > > On Sun, Jan 12, 2020 at 8:39 PM Zhiting Zhu > wrote: > >> Signed-off-by: Zhiting Zhu >> --- >> core/el