[osv-dev] Build failed in Jenkins: osv-build #1579

2020-03-15 Thread jenkins
See Changes: [jwkozaczuk] libc: make timerfd_* functions handle wall clock jumps [jwkozaczuk] libc: refine how timerfd_* functions handle wall clock jumps -- [...truncated 5

[osv-dev] Jenkins build is back to normal : osv-build-nightly #2091

2020-03-15 Thread jenkins
See -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receiving emails from it, send an email to osv-dev+unsubscr.

Re: [osv-dev] [PATCH v2 3/3] virtio: expose shared memory regions

2020-03-15 Thread Waldek Kozaczuk
It looks good to me. On Sun, Mar 15, 2020 at 07:47 Fotis Xenakis wrote: > Signed-off-by: Fotis Xenakis > --- > drivers/virtio-device.hh | 2 ++ > drivers/virtio-mmio.hh | 1 + > drivers/virtio-pci-device.cc | 24 > drivers/virtio-pci-device.hh | 4 >

[osv-dev] Re: [PATCH v2 2/3] virtio-pci: discover shared memory regions

2020-03-15 Thread Waldek Kozaczuk
I think you are trying to bite too much in this patch. I would suggest taking a more incremental approach and just implement void virtio_modern_pci_device::parse_virtio_capabilities() like you had in V1 patch and any other necessary changes to virtio_modern_pci_device() as minimal as possible t

[osv-dev] Re: [PATCH v2 1/3] pci: add batch capability discovery

2020-03-15 Thread Waldek Kozaczuk
On Sunday, March 15, 2020 at 5:38:27 PM UTC-4, Fotis Xenakis wrote: > > Τη Κυριακή, 15 Μαρτίου 2020 - 10:14:46 μ.μ. UTC+2, ο χρήστης Waldek > Kozaczuk έγραψε: >> >> Like it overall but see my suggestion below. >> On Sunday, March 15, 2020 at 7:43:49 AM UTC-4, Fotis Xenakis wrote: >>> >>> Signed-

[osv-dev] Re: [PATCH v2 1/3] pci: add batch capability discovery

2020-03-15 Thread Fotis Xenakis
Τη Κυριακή, 15 Μαρτίου 2020 - 10:14:46 μ.μ. UTC+2, ο χρήστης Waldek Kozaczuk έγραψε: > > Like it overall but see my suggestion below. > On Sunday, March 15, 2020 at 7:43:49 AM UTC-4, Fotis Xenakis wrote: >> >> Signed-off-by: Fotis Xenakis >> --- >> drivers/pci-function.cc | 39

[osv-dev] Re: [PATCH v2 1/3] pci: add batch capability discovery

2020-03-15 Thread Waldek Kozaczuk
Like it overall but see my suggestion below. On Sunday, March 15, 2020 at 7:43:49 AM UTC-4, Fotis Xenakis wrote: > > Signed-off-by: Fotis Xenakis > > --- > drivers/pci-function.cc | 39 +-- > drivers/pci-function.hh | 1 + > 2 files changed, 34 insertions(+

[osv-dev] [COMMIT osv master] libc: refine how timerfd_* functions handle wall clock jumps

2020-03-15 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master libc: refine how timerfd_* functions handle wall clock jumps This patch adjusts logic in timerfd::read() to re-arm clock when clock jumps backwards to the same expiration time point which is still ahead of us. Signed-off-by: W

Re: [osv-dev] [COMMIT osv master] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Waldek Kozaczuk
No worries. The time-related code has always been quite tricky to reason about:-) On Sunday, March 15, 2020 at 3:33:18 PM UTC-4, Nadav Har'El wrote: > > On Sun, Mar 15, 2020 at 9:25 PM Commit Bot > wrote: > >> From: Waldemar Kozaczuk > >> Committer: Waldemar Kozaczuk > >> Branch: master >> >> li

Re: [osv-dev] [COMMIT osv master] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Nadav Har'El
On Sun, Mar 15, 2020 at 9:25 PM Commit Bot wrote: > From: Waldemar Kozaczuk > Committer: Waldemar Kozaczuk > Branch: master > > libc: make timerfd_* functions handle wall clock jumps > > When wall clock jumps backwards triggered for example by host clock > change and propagated through kvmclock

[osv-dev] [COMMIT osv master] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master libc: make timerfd_* functions handle wall clock jumps When wall clock jumps backwards triggered for example by host clock change and propagated through kvmclock synchronization mechanism implemented by the commit https://gith

Re: [osv-dev] [PATCH] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Nadav Har'El
On Sun, Mar 15, 2020 at 5:36 PM Waldek Kozaczuk wrote: > You might be right. But does it mean we can count on wake up mechanism to > wake up up every _interval according to monotonic or real-time clock. > I don't understand what your version guarantees - imagine we ask to be woken up every *seco

Re: [osv-dev] [PATCH] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Waldek Kozaczuk
You might be right. But does it mean we can count on wake up mechanism to wake up up every _interval according to monotonic or real-time clock. I am honestly a bit at loss in my reasoning:-) On Sun, Mar 15, 2020 at 11:30 Nadav Har'El wrote: > On Fri, Mar 13, 2020 at 3:47 AM Waldemar Kozaczuk >

[osv-dev] Build failed in Jenkins: osv-build #1578

2020-03-15 Thread jenkins
See Changes: [foxen] pci: allow 64-bit BAR offsets [jwkozaczuk] travis: clean the build tree just in case [jwkozaczuk] externals: eliminate aarch64 gcc and boost libraries from externals [jwkozaczuk] dl_tests: fix

Re: [osv-dev] [PATCH] libc: make timerfd_* functions handle wall clock jumps

2020-03-15 Thread Nadav Har'El
On Fri, Mar 13, 2020 at 3:47 AM Waldemar Kozaczuk wrote: > When wall clock jumps backwards triggered for example by host clock > change and propagated through kvmclock synchronization mechanism > implemented by the commit > https://github.com/cloudius-systems/osv/commit/e694d066d20d87897d4a9b6dc7

[osv-dev] Build failed in Jenkins: osv-build-nightly #2090

2020-03-15 Thread jenkins
See Changes: [foxen] pci: allow 64-bit BAR offsets [jwkozaczuk] travis: clean the build tree just in case [jwkozaczuk] externals: eliminate aarch64 gcc and boost libraries from externals [jwkozaczuk] dl_te

[osv-dev] [PATCH v2 3/3] virtio: expose shared memory regions

2020-03-15 Thread Fotis Xenakis
Signed-off-by: Fotis Xenakis --- drivers/virtio-device.hh | 2 ++ drivers/virtio-mmio.hh | 1 + drivers/virtio-pci-device.cc | 24 drivers/virtio-pci-device.hh | 4 4 files changed, 31 insertions(+) diff --git a/drivers/virtio-device.hh b/drivers/virtio

[osv-dev] [PATCH v2 2/3] virtio-pci: discover shared memory regions

2020-03-15 Thread Fotis Xenakis
The latest virtio spec adds shared memory regions: "Shared memory regions are an additional facility available to devices that need a region of memory that’s continuously shared between the device and the driver, rather than passed between them in the way virtqueue elements are." In virtio over PC

[osv-dev] [PATCH v2 1/3] pci: add batch capability discovery

2020-03-15 Thread Fotis Xenakis
Signed-off-by: Fotis Xenakis --- drivers/pci-function.cc | 39 +-- drivers/pci-function.hh | 1 + 2 files changed, 34 insertions(+), 6 deletions(-) diff --git a/drivers/pci-function.cc b/drivers/pci-function.cc index 369f22e9..2cc8b837 100644 --- a/drivers/pc

[osv-dev] [PATCH v2 0/3] virtio: enable shared memory regions

2020-03-15 Thread Fotis Xenakis
Changes since previous version: - Refactored the discovery of the shm regions, taking into account Waldek's input. I think this results in simpler code: the generic PCI code (drivers/pci-function.cc) returns the offsets of all capabilities of a given device and the virtio code (drivers/virtio

[osv-dev] [COMMIT osv master] cloud-init: replace boost program_options with light options utility functions

2020-03-15 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master cloud-init: replace boost program_options with light options utility functions Signed-off-by: Waldemar Kozaczuk Message-Id: <20200314011653.17792-1-jwkozac...@gmail.com> --- diff --git a/modules/cloud-init/cloud-init.cc b/modules/