Re: [PATCH] Implemented multiboot mode

2018-08-30 Thread Waldek Kozaczuk
I am abandoning this patch and sending another smaller one that is hopefully less controversial. On Monday, August 6, 2018 at 11:37:22 AM UTC-4, Nadav Har'El wrote: > > > On Mon, Aug 6, 2018 at 6:17 PM, Nadav Har'El > wrote: > >> >> Oh, I found the problem. It is OSv's bug, on the way we define

Re: [PATCH] Implemented multiboot mode

2018-08-06 Thread Nadav Har'El
On Mon, Aug 6, 2018 at 6:17 PM, Nadav Har'El wrote: > > Oh, I found the problem. It is OSv's bug, on the way we define uint64_t > (we define it ourselves, we don't use gcc's headers): > In: > > include/api/x64/bits/alltypes.h.sh:TYPEDEF unsigned long uint64_t; > > This is incorrect for

Re: [PATCH] Implemented multiboot mode

2018-08-06 Thread Nadav Har'El
On Tue, Jul 31, 2018 at 9:08 PM, Waldek Kozaczuk wrote: > When possible, it's a worthy goal to have a kernel and usr.img which can >> work for all platforms (xen, qemu, qemu-with-kernel, etc.) and we don't >> need >> to recompile for each different cloud platform. I didn't fully understand >> if