Re: [PATCH] Remove soisconnected() from syncache_socket()

2018-04-29 Thread Waldek Kozaczuk
Let’s put it this way - to best of my understanding I think my patch is correct. But my understanding of this code is still pretty limited. Ideally if Asias or Pekka could review it. Waldek Sent from my iPhone > On Apr 29, 2018, at 19:13, Nadav Har'El wrote: > > >> On Mon, Apr 30, 2018 at

Re: [PATCH] Remove soisconnected() from syncache_socket()

2018-04-29 Thread Nadav Har'El
On Mon, Apr 30, 2018 at 1:56 AM, Waldek Kozaczuk wrote: > See my comments below. > > On Sunday, April 29, 2018 at 6:41:01 PM UTC-4, Nadav Har'El wrote: > >> >> On Thu, Apr 26, 2018 at 8:43 AM, Waldemar Kozaczuk >> wrote: >> >>> This patch fixes an intermittent issue happening in TCP stack code >

Re: [PATCH] Remove soisconnected() from syncache_socket()

2018-04-29 Thread Waldek Kozaczuk
See my comments below. On Sunday, April 29, 2018 at 6:41:01 PM UTC-4, Nadav Har'El wrote: > > > On Thu, Apr 26, 2018 at 8:43 AM, Waldemar Kozaczuk > wrote: > >> This patch fixes an intermittent issue happening in TCP stack code >> during session 3-way handshake protocol due to inconsistent state

Re: [PATCH] Remove soisconnected() from syncache_socket()

2018-04-29 Thread Nadav Har'El
On Thu, Apr 26, 2018 at 8:43 AM, Waldemar Kozaczuk wrote: > This patch fixes an intermittent issue happening in TCP stack code > during session 3-way handshake protocol due to inconsistent state > of transmission control block (TCB) data structure. Specifically > right after server sends SYN+ACK

Re: [PATCH] Remove soisconnected() from syncache_socket()

2018-04-29 Thread Waldek Kozaczuk
This patch shall fix tst-tcp-nbwrite test. Sent from my iPhone > On Apr 26, 2018, at 01:43, Waldemar Kozaczuk wrote: > > tst-tcp-nbwrite test -- You received this message because you are subscribed to the Google Groups "OSv Development" group. To unsubscribe from this group and stop receivi

[PATCH] Remove soisconnected() from syncache_socket()

2018-04-25 Thread Waldemar Kozaczuk
This patch fixes an intermittent issue happening in TCP stack code during session 3-way handshake protocol due to inconsistent state of transmission control block (TCB) data structure. Specifically right after server sends SYN+ACK to client the function syncache_socket() would prematurely invoke so