Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-28 Thread Nadav Har'El
By the way, a question: When running with "-V" (--verbose), do you see a warning about a stubbed "pthread_key_delete" function? -- Nadav Har'El n...@scylladb.com On Sun, Aug 28, 2016 at 12:42 PM, Nadav Har'El wrote: > > On Fri, Aug 26, 2016 at 2:55 PM, Justin Cinkelj

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-25 Thread Nadav Har'El
I just sent another RFC patch which should cause osv_execve to wait until app_runtime() is the new application's. I haven't really tested it much beyond the usual "make check" - can you please try it out? Thanks, Nadav. -- Nadav Har'El n...@scylladb.com On Wed, Aug 24, 2016 at 7:21 AM, Justin

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-23 Thread Justin Cinkelj
On 08/23/2016 11:58 PM, Nadav Har'El wrote: On Tue, Aug 23, 2016 at 3:28 PM, Justin Cinkelj > wrote: @nadav With second RFC patch, osv_execve dosn't return thread_id==0 any more. (code after RFC-2 pathc) The

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-23 Thread Nadav Har'El
On Tue, Aug 23, 2016 at 3:28 PM, Justin Cinkelj wrote: > > @nadav > With second RFC patch, osv_execve dosn't return thread_id==0 any more. > > > (code after RFC-2 pathc) The application::start_and_join() line > sched::thread::current()->set_app_runtime(runtime()); has to

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-23 Thread Justin Cinkelj
@nadav With second RFC patch, osv_execve dosn't return thread_id==0 any more. On 08/23/2016 02:01 PM, Nadav Har'El wrote: On Tue, Aug 23, 2016 at 1:03 AM, Nadav Har'El > wrote: On Tue, Aug 23, 2016 at 12:32 AM, Nadav Har'El

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-22 Thread Nadav Har'El
On Tue, Aug 23, 2016 at 12:32 AM, Nadav Har'El wrote: > > On Mon, Aug 22, 2016 at 6:51 PM, Justin Cinkelj > wrote: > >> Seems that here and there, osv_execve returns with thread_id still at 0, >> instead of containing new thread id. >> So a little

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-22 Thread Justin Cinkelj
On 08/21/2016 04:38 PM, Nadav Har'El wrote: On Sun, Aug 21, 2016 at 5:22 PM, Nadav Har'El > wrote: Hi Justin, Unless I'm misunderstanding something, I think there is a race in your code: osv_execve() spawns a new thread to run a

Re: [PATCH 2/2] app: return main thread id to the caller

2016-08-22 Thread Justin Cinkelj
On 08/21/2016 04:22 PM, Nadav Har'El wrote: Hi Justin, Unless I'm misunderstanding something, I think there is a race in your code: osv_execve() spawns a new thread to run a function thread_run_app_in_namespace(), and this will eventually set the value pointed by pid_t *thread_id. But