On Fri, Feb 16, 2018 at 5:19 AM, geraldo netto <geraldone...@gmail.com>
wrote:
> Signed-off-by: geraldo netto <geraldone...@gmail.com>
> ---
> scripts/manifest_common.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/manifest_common.py b/scripts/manifest_common.py
> index 58b0794..bfe5837 100644
> --- a/scripts/manifest_common.py
> +++ b/scripts/manifest_common.py
> @@ -52,10 +52,10 @@ def read_manifest(fn):
> comment = re.compile("^[ \t]*(|#.*|\[manifest])$")
> with open(fn, 'r') as f:
> for line in f:
> - line = line.rstrip();
> + line = line.rstrip()
> if comment.match(line): continue
> - components = line.split(": ", 2)
> - guestpath = components[0].strip();
> + components = line.split(":", 2)
>
While this used to be the case in the past, I wonder if it's a good idea.
It means we can never have a filename with a colon in it.
Wouldn't it make more sense to just fix the one or very few packages which
still have a colon without space, like I did in
commit dfdf08f6b9554af357e245992e0deadc6228d790?
I see a missing space in apps/ImageMagick/Makefile in one place. I couldn't
find any other such problem. If that's the only
one I think it's better to fix it.
+ guestpath = components[0].strip()
> hostpath = components[1].strip()
> ret.append((guestpath, hostpath))
> return ret
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "OSv Development" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to osv-dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups "OSv
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to osv-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
