Re: [osv-dev] [PATCH] libc: replace unistd/ttyname.c with the musl copy

2020-08-02 Thread Nadav Har'El
On Mon, Aug 3, 2020 at 1:48 AM Waldemar Kozaczuk wrote: > This patch eliminates one more file - unistd/ttyname.c - that is > identical with the musl copy except for extra 'memset(buf, 0, > sizeof(buf));' line > which does not seem necessary. This is true. Since we call ttyname_r(), it should ta

[osv-dev] [PATCH] libc: replace unistd/ttyname.c with the musl copy

2020-08-02 Thread Waldemar Kozaczuk
This patch eliminates one more file - unistd/ttyname.c - that is identical with the musl copy except for extra 'memset(buf, 0, sizeof(buf));' line which does not seem necessary. There is already existing unit test that verifies ttyname() and ttyname_r() behavior. This patch also cleans up OSv spe