Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-02 Thread Nadav Har'El
On Tue, Jul 2, 2019 at 5:39 AM Waldek Kozaczuk wrote: > I have just applied a patch fixing it. Now depending on which filesystem > OSv runs we get same or different major:minor: > > ./scripts/manifest_from_host.sh -w cat && ./scripts/build -j4 fs=rofs > --append-manifest && ./scripts/run.py -e '/

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-01 Thread Waldek Kozaczuk
I have just applied a patch fixing it. Now depending on which filesystem OSv runs we get same or different major:minor: ./scripts/manifest_from_host.sh -w cat && ./scripts/build -j4 fs=rofs --append-manifest && ./scripts/run.py -e '/cat /proc/self/maps' ... OSv v0.53.0-43-gef0696c5 eth0: 192.168

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-01 Thread Waldek Kozaczuk
I have just applied a patch fixing it. Now depending on which filesystem OSv runs we get same or different major:minor: ./scripts/manifest_from_host.sh -w cat && ./scripts/build -j4 fs=rofs --append-manifest && ./scripts/run.py -e '/cat /proc/self/maps' ... OSv v0.53.0-43-gef0696c5 eth0: 192.168

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-07-01 Thread Nadav Har'El
On Mon, Jul 1, 2019 at 7:26 AM Waldek Kozaczuk wrote: > Also where would I get the values for this xx:yy pair from? > > On Sunday, June 30, 2019 at 7:37:09 AM UTC-4, Waldek Kozaczuk wrote: >> >> We could. But that could be a separate patch. For now I do not care about >> it. >> > >> Do you have s

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-06-30 Thread Waldek Kozaczuk
Also where would I get the values for this xx:yy pair from? On Sunday, June 30, 2019 at 7:37:09 AM UTC-4, Waldek Kozaczuk wrote: > > We could. But that could be a separate patch. For now I do not care about > it. > > Do you have strong objections to commit this patch without the device-I’d? >

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-06-30 Thread Waldek Kozaczuk
We could. But that could be a separate patch. For now I do not care about it. Do you have strong objections to commit this patch without the device-I’d? It is enough to fix my GraalVM example. Sent from my iPhone > On Jun 30, 2019, at 04:34, Nadav Har'El wrote: > > Looks good to me, but I w

Re: [osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-06-30 Thread Nadav Har'El
Looks good to me, but I wonder, together with the inode, shouldn't we also save the device id, so we can print that too (that is the 00:00 we print now)? -- Nadav Har'El n...@scylladb.com On Sun, Jun 30, 2019 at 7:14 AM Waldemar Kozaczuk wrote: > This patch refines the implementation of procfs

[osv-dev] [PATCH] procfs: populate maps file with i-node numbers

2019-06-29 Thread Waldemar Kozaczuk
This patch refines the implementation of procfs to generate maps file that contains correct file i-node numbers instead of 0s for file VMAs as shown below: 0-0 ---p 00:00 0 1000-10001000 r--p 00:00 3 /libvdso.so 10001000-10002000 r-xp 1000 00:00 3 /libvdso