Re: [osv-dev] [PATCH] serial console: refactor common logic to allow re-use when implementing mmio version

2020-06-21 Thread Nadav Har'El
Hi, thanks. Some nitpicks below: On Sun, Jun 21, 2020 at 7:40 AM Waldemar Kozaczuk wrote: > This patch extracts generic logic of serial console into a base class > isa-serial-base that abstracts reading and writing a byte. The > specializations > like isa-serial (add mmio-isa-serial in later

[osv-dev] [PATCH] serial console: refactor common logic to allow re-use when implementing mmio version

2020-06-20 Thread Waldemar Kozaczuk
This patch extracts generic logic of serial console into a base class isa-serial-base that abstracts reading and writing a byte. The specializations like isa-serial (add mmio-isa-serial in later patch) provide specific way of reading and writing a byte in form of lambda functions. Signed-off-by: