Re: [osv-dev] [PATCH 1/2] add new C-wrappers to expose module API

2022-01-19 Thread Waldek Kozaczuk
Thanks for your review. I have addressed the first two of your suggestions. On Wednesday, January 19, 2022 at 3:47:09 AM UTC-5 Nadav Har'El wrote: > > Looks good. Just a couple of nitpicks below. > > On Mon, Jan 17, 2022 at 7:55 AM Waldemar Kozaczuk > wrote: > >> The commit

Re: [osv-dev] [PATCH 1/2] add new C-wrappers to expose module API

2022-01-19 Thread Nadav Har'El
Looks good. Just a couple of nitpicks below. On Mon, Jan 17, 2022 at 7:55 AM Waldemar Kozaczuk wrote: > The commit af2d371a61f6ab1eb5a066a0c3e93230faf6611c introduced ability > to build OSv kernel with most symbols but subset of glibc hidden. > The regular Linux glibc apps should run fine on

[osv-dev] [PATCH 1/2] add new C-wrappers to expose module API

2022-01-16 Thread Waldemar Kozaczuk
The commit af2d371a61f6ab1eb5a066a0c3e93230faf6611c introduced ability to build OSv kernel with most symbols but subset of glibc hidden. The regular Linux glibc apps should run fine on such kernel, but unfortunately many unit tests and various internal OSv apps (so called modules) do not as they