[osv-dev] [PATCH 2/3] lzloader: fix memset() implementation

2020-05-23 Thread Nadav Har'El
Some compilers apparently optimize code in fastlz/ to call memset(), so the uncompressing boot loader, fastlz/lzloader.cc, needs to implement this function. The current implementation called the "builtin" memset, which, if you look at the compilation result, actually calls memset() and results in e

Re: [osv-dev] [PATCH 2/3] lzloader: fix memset() implementation

2020-05-24 Thread Rick Payne
I think this is also related to 913. I'll try without my patch (which we've been having to use since then). Rick On Sat, 2020-05-23 at 23:47 +0300, Nadav Har'El wrote: > Some compilers apparently optimize code in fastlz/ to call memset(), > so > the uncompressing boot loader, fastlz/lzloader.cc

Re: [osv-dev] [PATCH 2/3] lzloader: fix memset() implementation

2020-05-24 Thread Nadav Har'El
On Mon, May 25, 2020 at 7:31 AM Rick Payne wrote: > > I think this is also related to 913. Indeed! :-) I had a sense of deja-vu with this memset() loop, and dug up the patch I wrote back then and just updated it. > I'll try without my patch (which > we've been having to use since then). > Do

Re: [osv-dev] [PATCH 2/3] lzloader: fix memset() implementation

2020-05-25 Thread Rick Payne
On Mon, 2020-05-25 at 09:15 +0300, Nadav Har'El wrote: > > Do you mean > https://github.com/cloudius-systems/osv/commit/d52cb12546ff2acd5255a2ac8897891e421f07dc > which just turned off optimization? Yes. > At the time, I suggested the memset() fix for #913, because seemed to > me like an "obvio