Re: [osv-dev] [PATCH v3 1/2] Lookup symbol deeper

2020-01-19 Thread Nadav Har'El
Looks mostly good, sorry for having so many iterations... Just one tiny issue below about setting each item in the set twice, and one style comment. On Thu, Jan 16, 2020 at 8:31 PM Zhiting Zhu wrote: > dlsym function doesn't seem to lookup symbol deep enough. This > patch includes a bfs version

[osv-dev] [PATCH v3 1/2] Lookup symbol deeper

2020-01-16 Thread Zhiting Zhu
dlsym function doesn't seem to lookup symbol deep enough. This patch includes a bfs version of collect dependencies. This patch fixes test_dlsym_from_sofile_with_preload and dlsym_with_dependencies. Signed-off-by: Waldemar Kozaczuk Signed-off-by: Zhiting Zhu --- core/elf.cc| 38