[osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-15 Thread Waldek Kozaczuk
Any reason we should not apply this patch? I have opened new issue - https://github.com/cloudius-systems/osv/issues/1072 - to cover things we want to fix in dlopen/dlsym. Zhiting please verify I have not missed anything and add what I missed. Now we can reference this issue. On Monday, Januar

Re: [osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-13 Thread zhiting zhu
On Mon, Jan 13, 2020 at 3:48 AM Nadav Har'El wrote: > Please see comments below. You forgot to change one part of the patch. > > On Mon, Jan 13, 2020 at 4:40 AM zhiting zhu > wrote: > >> This version only contains one iteration over the module list. >> >> On Sun, Jan 12, 2020 at 8:39 PM Zhiting

Re: [osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-13 Thread Nadav Har'El
Please see comments below. You forgot to change one part of the patch. On Mon, Jan 13, 2020 at 4:40 AM zhiting zhu wrote: > This version only contains one iteration over the module list. > > On Sun, Jan 12, 2020 at 8:39 PM Zhiting Zhu > wrote: > >> Signed-off-by: Zhiting Zhu >> --- >> core/el

[osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-12 Thread zhiting zhu
This version only contains one iteration over the module list. On Sun, Jan 12, 2020 at 8:39 PM Zhiting Zhu wrote: > Signed-off-by: Zhiting Zhu > --- > core/elf.cc| 31 +++ > include/osv/elf.hh | 1 + > libc/dlfcn.cc | 5 +++-- > tests/tst-dlfcn.cc |