Re: [osv-dev] runtime.cc:confstr() bug

2019-07-03 Thread Waldek Kozaczuk
I am glad. This bug was causing Python 3.7 to blow up like this: #0 0x403ad602 in processor::cli_hlt () at arch/x64/processor.hh:247 #1 arch::halt_no_interrupts () at arch/x64/arch.hh:48 #2 osv::halt () at arch/x64/power.cc:26 #3 0x40241ac4 in abort (fmt=fmt@entry=0x406372db "A

Re: [osv-dev] runtime.cc:confstr() bug

2019-07-03 Thread Nadav Har'El
On Wed, Jul 3, 2019 at 8:24 AM Waldek Kozaczuk wrote: > I think that according to this - https://linux.die.net/man/3/confstr - we > have a bug in this code: > > size_t confstr(int name, char* buf, size_t len) > { > char tmp[1]; > if (!buf) { > buf = tmp; > len = 1; > }

[osv-dev] runtime.cc:confstr() bug

2019-07-02 Thread Waldek Kozaczuk
I think that according to this - https://linux.die.net/man/3/confstr - we have a bug in this code: size_t confstr(int name, char* buf, size_t len) { char tmp[1]; if (!buf) { buf = tmp; len = 1; } auto set = [=] (const char* v) { return snprintf(buf, len, "%s", v);