Re: [ovs-dev] [PATCH] datapath: compat: vxlan: Avoid possible NULL dereference in vxlan_gro_receive.

2016-11-13 Thread 张东亚
Hi, Maybe it's caused by I manually copy patch to web gmail, thanks a lot for merging that. 2016-11-14 12:49 GMT+08:00 Pravin Shelar : > On Sun, Nov 13, 2016 at 6:59 PM, 张东亚 wrote: > > With Linux kernel that does not have HAVE_UDP_OFFLOAD_ARG_UOFF macro > > detected, > > struct vxlan_sock *vs

Re: [ovs-dev] [PATCH] datapath: compat: vxlan: Avoid possible NULL dereference in vxlan_gro_receive.

2016-11-13 Thread Pravin Shelar
On Sun, Nov 13, 2016 at 6:59 PM, 张东亚 wrote: > With Linux kernel that does not have HAVE_UDP_OFFLOAD_ARG_UOFF macro > detected, > struct vxlan_sock *vs will be NULL, which will make kernel crash when > receiving > VXLAN packet that have RCO flag turn on or even invalid packet that is > destined > t

[ovs-dev] [PATCH] datapath: compat: vxlan: Avoid possible NULL dereference in vxlan_gro_receive.

2016-11-13 Thread 张东亚
With Linux kernel that does not have HAVE_UDP_OFFLOAD_ARG_UOFF macro detected, struct vxlan_sock *vs will be NULL, which will make kernel crash when receiving VXLAN packet that have RCO flag turn on or even invalid packet that is destined to VXLAN port which have the bit on in the RCO flag position

Re: [ovs-dev] [PATCH 3/4] ovs-tcpdump: Fix error handling when parsing parameter.

2016-11-13 Thread nickcooper-zhangtonghao
Hi Aaron You ignore an error case. Run the tcpdump with invalid option or argument. In this case, process will raise directly KeyboardInterrupt exception, not run the while loop any more. We should return an error code with sys.exit(1). What’s more, in this error case, the subprocess has exited al

[ovs-dev] [PATCH 3/3] ofproto: Drop flows between protected ports

2016-11-13 Thread Ben Kelly
Protected ports can not forward frames to other protected ports. Unprotected ports can receive and forward frames to protected and other unprotected ports. Signed-off-by: Ben Kelly --- ofproto/ofproto-dpif-xlate.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/ofproto/o

[ovs-dev] [PATCH 2/3] ofproto: Add protected property to bundle

2016-11-13 Thread Ben Kelly
Propagate the protected mode setting from port to xbundle, so that ofproto* can make decisions. Signed-off-by: Ben Kelly --- ofproto/ofproto-dpif-xlate.c | 12 +++- ofproto/ofproto-dpif-xlate.h | 2 +- ofproto/ofproto-dpif.c | 11 ++- ofproto/ofproto.h| 2 ++

[ovs-dev] [PATCH 1/3] ovsschema: Add protected column to Port table

2016-11-13 Thread Ben Kelly
Supports setting of protected mode true/false per port e.g. # ovs-vsctl set port virtX protected=1/0 Signed-off-by: Ben Kelly --- vswitchd/vswitch.ovsschema | 4 +++- vswitchd/vswitch.xml | 8 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/vswitchd/vswitch.ovssch

[ovs-dev] [PATCH 0/3] ovs-vswitchd: Port protected mode

2016-11-13 Thread Ben Kelly
Port protected mode is available in some switching ASICs (b53 etc) and Cisco also implements this feature. (http://www.cisco.com/en/US/docs/switches/lan/catalyst3850/software/release/3.2_0_se/multibook/configuration_guide/b_consolidated_config_guide_3850_chapter_011101.html) Protected ports will