[ovs-dev] [PATCH v3 2/3] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

2017-02-02 Thread Mickey Spiegel
This patch extends gratuitous ARP support for NAT addresses so that it applies to centralized NAT rules on a distributed router, in addition to the existing gratuitous ARP support for NAT addresses on gateway routers. Gratuitous ARP packets for centralized NAT rules on a distributed router are

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

2017-02-02 Thread Jarno Rajahalme
> On Feb 2, 2017, at 3:04 PM, Abhijit Kumbhare > wrote: > > Jarno, > > Can you please attend the next Thursday OpenDaylight OpenFlow Plugin meeting? > We would like to discuss the OpenDaylight bundles implementation – but would > also like to discuss the OvS

[ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

2017-02-02 Thread jmcdowall
From: John McDowall This patchset is the first round at having Service Function Chaining functionality through OVN. The implementation is done entirely on the northbound side of OVN. It is a bump on the wire implementation, so no attempt is being made in keeping

[ovs-dev] [PATCH 2/2] Consistently format specifiers for vlan_tci_to_pcp

2017-02-02 Thread Shu Shen
Format strings in ds_put_format() for printing out returned values from vlan_tci_to_pcp() were updated to ensure PRIu8 or PRIx8 are used for portability. Signed-off-by: Shu Shen --- lib/dpctl.c| 2 +- lib/match.c| 2 +- lib/odp-util.c | 4 ++-- 3 files changed, 4

[ovs-dev] [PATCH v2] packet: proper return type for vlan_tci_to_pcp()

2017-02-02 Thread Shu Shen
On macOS, PRIu8 and PRIx8 the specifiers are not promoted to 'u' and 'x' respectively. For example, for PRIu*, on Mac OS, /usr/include/inttypes.h: # define __PRI_8_LENGTH_MODIFIER__ "hh" # define __PRI_64_LENGTH_MODIFIER__ "ll" # define PRIu8 __PRI_8_LENGTH_MODIFIER__ "u" #

Re: [ovs-dev] [RFC PATCH v4 6/6] dpif-netlink: add GENEVE creation support

2017-02-02 Thread Joe Stringer
On 18 January 2017 at 11:45, Eric Garver wrote: > Creates GENEVE devices using rtnetlink and tunnel metadata. > > Co-Authored-by: Thadeu Lima de Souza Cascardo > Co-Authored-by: Eric Garver > Signed-off-by: Eric Garver Same

Re: [ovs-dev] OVS - ODL Sync on OF Bundle in 1.3

2017-02-02 Thread Abhijit Kumbhare
Jarno, Can you please attend the next Thursday OpenDaylight OpenFlow Plugin meeting? We would like to discuss the OpenDaylight bundles implementation – but would also like to discuss the OvS bundles implementation since we will very likely be interacting with the OvS bundles. The meeting time

Re: [ovs-dev] [RFC PATCH v4 5/6] dpif-netlink: add GRE creation support

2017-02-02 Thread Joe Stringer
On 18 January 2017 at 11:45, Eric Garver wrote: > Creates GRE devices using rtnetlink and tunnel metadata. > > Co-Authored-by: Thadeu Lima de Souza Cascardo > Co-Authored-by: Eric Garver > Signed-off-by: Eric Garver Same comments

Re: [ovs-dev] [RFC PATCH v4 4/6] dpif-netlink: add VXLAN creation support

2017-02-02 Thread Joe Stringer
On 18 January 2017 at 11:45, Eric Garver wrote: > Creates VXLAN devices using rtnetlink and tunnel metadata. > > Co-Authored-by: Thadeu Lima de Souza Cascardo > Co-Authored-by: Eric Garver > Signed-off-by: Eric Garver > --- >

Re: [ovs-dev] [RFC PATCH v4 2/6] dpif-netlink: break out code to add compat and non-compat vports

2017-02-02 Thread Joe Stringer
On 18 January 2017 at 11:45, Eric Garver wrote: > From: Thadeu Lima de Souza Cascardo > > The vport type for adding tunnels is now compatibility code and any new > features > from tunnels must configure the tunnel as an interface using the tunnel > metadata >

Re: [ovs-dev] [PATCH v2] ofp-actions: Fix variable length meta-flow field usage in flow actions.

2017-02-02 Thread Joe Stringer
On 1 February 2017 at 11:06, Joe Stringer wrote: > On 31 January 2017 at 16:57, Joe Stringer wrote: >> /* Returns true if a variable length meta-flow field 'mff' is not mapped in >> * the 'vl_mff_map'. */ >> bool >> -mf_vl_mff_not_mapped(const struct mf_field

Re: [ovs-dev] [PATCH 3/3] rhel: Fix ifup and ifdown after DPDK naming change.

2017-02-02 Thread Ben Pfaff
On Tue, Jan 24, 2017 at 06:21:53PM -0800, Daniele Di Proietto wrote: > Names like dpdk0 and dpdk1 are not enough to identify a DPDK interface. > We could update README.RHEL.rst and add > > OVS_EXTRA='set Interface ${DEVICE} options:dpdk-devargs=:01:00.0' > > but a better solution is to add

Re: [ovs-dev] [PATCH 0/6] Fix tunnel information destination port

2017-02-02 Thread Ben Pfaff
OK, great, I applied them to branch-2.7 now too. On Thu, Feb 02, 2017 at 07:12:20PM +, Sairam Venugopal wrote: > Hi Ben, > > Yes, it will be good to have these on 2.7 as well. > > Thanks, > Sairam > > -Original Message- > From: ovs-dev-boun...@openvswitch.org >

Re: [ovs-dev] [PATCH] ofp-actions: Fix tunnel meatdata subfield length in flow action

2017-02-02 Thread Ben Pfaff
OK, great, thanks. On Thu, Feb 02, 2017 at 11:01:19AM -0800, Yi-Hung Wei wrote: > Hi Ben, > > This patch is updated by [PATCH v2] ofp-actions: Fix variable length > meta-flow field usage in flow actions, and it is applied to master > yesterday. > > Best, > > -Yi-Hung > > On Thu, Feb 2, 2017

Re: [ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

2017-02-02 Thread Guru Shetty
On 2 February 2017 at 10:12, Ben Pfaff wrote: > On Wed, Feb 01, 2017 at 11:52:14PM -0800, Gurucharan Shetty wrote: > > The code to wait for a particular type of flow > > in ovs-vswitchd was not specific enough. This commit > > changes that and to be doubly sure, also uses the > >

[ovs-dev] [PATCH v5 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-02-02 Thread Anand Kumar
This patch adds functionalities to support IPv4 fragments, which will be used by Conntrack module. Added a new structure to hold the Ipv4 fragments and a hash table to hold Ipv4 datagram entries. Also added a clean up thread that runs every minute to delete the expired IPv4 datagram entries. The

Re: [ovs-dev] [PATCH 0/6] Fix tunnel information destination port

2017-02-02 Thread Ben Pfaff
On Tue, Jan 10, 2017 at 04:48:28PM +, Alin Serdean wrote: > Deploying a simple environment using VXLAN encapsulation at the moment > does not work under Hyper-V. The tunnel information sent > by the userspace is not fully treated in the datapath. > > To be more specific every packet that

Re: [ovs-dev] [PATCH] ofp-actions: Fix tunnel meatdata subfield length in flow action

2017-02-02 Thread Ben Pfaff
On Mon, Jan 09, 2017 at 06:09:33PM -0800, Yi-Hung Wei wrote: > Previously, if a flow action that involves a tunnel metadata subfield is > dumpped from vswitchd, the replied subfield length in the OXM header is > filled with the maximum possible field length, instead of the length > configured in

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > > > On

Re: [ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

2017-02-02 Thread Ben Pfaff
On Wed, Feb 01, 2017 at 11:52:14PM -0800, Gurucharan Shetty wrote: > The code to wait for a particular type of flow > in ovs-vswitchd was not specific enough. This commit > changes that and to be doubly sure, also uses the > sync command. > > Reported-by: Andy Zhou > Reported-by:

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 10:40:31AM -0500, Russell Bryant wrote: > On Thu, Feb 2, 2017 at 10:32 AM, Numan Siddique wrote: > > > On Wed, Feb 1, 2017 at 4:31 AM, Ben Pfaff wrote: > > > > > On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote: > > > >

[ovs-dev] [PATCH] system-ovn.at: Fix race conditions.

2017-02-02 Thread Gurucharan Shetty
The code to wait for a particular type of flow in ovs-vswitchd was not specific enough. This commit changes that and to be doubly sure, also uses the sync command. Reported-by: Andy Zhou Reported-by: Joe Stringer Signed-off-by: Gurucharan Shetty ---

Re: [ovs-dev] [PATCH v2] sflow: Expose ethernet stats via sFlow

2017-02-02 Thread Neil McKee
Robert, It's great to get the multicast and broadcast counters in there. I do wonder if it's worth including the whole ethernet stats block just to distinguish alignment / FCS / frame-too-long errors, given that total errors is already a counter in the generic block. I know that some follow

Re: [ovs-dev] [PATCH] tests: MPLS translate causes issues on slow systems

2017-02-02 Thread Ben Pfaff
On Wed, Feb 01, 2017 at 02:39:36PM +, Alin Serdean wrote: > On slow systems ofproto/trace in combination with a recirculation ID > causes issues because the flow is evicted before the second packet > can reach it. Thanks, applied to master, branch-2.7, and branch-2.6.

Re: [ovs-dev] [PATCH] ovn-trace: Style improvements.

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 02:18:31AM -0500, Russell Bryant wrote: > On Fri, Jan 13, 2017 at 2:30 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > ovn/utilities/ovn-trace.c | 12 +--- > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > >

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Fix memory leak and bug in setup_qos().

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 12:44:02PM +0530, Numan Siddique wrote: > On Wed, Feb 1, 2017 at 10:52 PM, Ben Pfaff wrote: > > > The caller of netdev_get_qos() is responsible for freeing its 'details' > > smap. > > > > > Is this patch a good candidate for back porting to 2.6 branch since

Re: [ovs-dev] [PATCH 2/2] ovn-controller: Configure interface QoS only if it would actually be used.

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 01:33:36AM -0500, Russell Bryant wrote: > On Wed, Feb 1, 2017 at 12:22 PM, Ben Pfaff wrote: > > > Until now, ovn-controller has unconditionally configured linux-htb on > > physical interfaces. QoS is pretty much always trouble, but it's even more > >

Re: [ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 02:04:07AM -0500, Russell Bryant wrote: > We missed calling netdev_close in a couple of places. One was in an error > condition rarely hit. The second was just introduced and would be hit in > all cases where QoS is not in use. > > Fixes: dc2dab6e6de5 ("ovn-controller:

Re: [ovs-dev] [PATCH] docs: Add OVS and OVN headings to pages.

2017-02-02 Thread Ben Pfaff
On Thu, Feb 02, 2017 at 02:02:34AM -0500, Russell Bryant wrote: > Update the "deep dive" and "howto" pages with headings that more clearly > indicate the separate lists of OVS or OVN content. Also add a link to > ovn-architecture from the "deep dive" page as it seems quite relevant > there. > >

Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes Implementation

2017-02-02 Thread Ben Pfaff
On Wed, Dec 28, 2016 at 07:41:48PM +, Rodriguez Betancourt, Esteban wrote: > In the C IDL, allows to create multicolumn indexes in the > tables, that are keep synched with the data in the replica. > > Signed-off-by: Esteban Rodriguez Betancourt "git am" refuses to apply

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > > > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > > > On

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 07:20:35PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 05:10:28PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 06:21:55PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 03:06:21PM +, Daniel P. Berrange wrote: > > > > On

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Maxime Coquelin
On 02/02/2017 06:09 PM, Michael S. Tsirkin wrote: On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: It depends

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Michael S. Tsirkin
On Thu, Feb 02, 2017 at 11:47:57AM -0500, Laine Stump wrote: > On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > It depends where / how in OVS it needs to be

Re: [ovs-dev] [PATCH v2 1/1] doc: Remove "experimental" warning for userspace.

2017-02-02 Thread Kevin Traynor
On 02/02/2017 04:44 PM, Ian Stokes wrote: > Remove the experimental warning tag in documentation regarding OVS deployed > via userspace. > > Signed-off-by: Ian Stokes > --- > Documentation/intro/install/dpdk.rst |3 --- > Documentation/intro/install/userspace.rst

Re: [ovs-dev] [PATCH] doc: Update DPDK version for 2.7 release.

2017-02-02 Thread Kevin Traynor
On 02/02/2017 04:30 PM, Ian Stokes wrote: > Add DPDK version required for the OVS 2.7 release in documentation. > > Signed-off-by: Ian Stokes Acked-by: Kevin Traynor > --- > Documentation/faq/releases.rst |1 + > 1 files changed, 1

Re: [ovs-dev] [PATCH 2/4 v4] lib:Data structures: Skiplist implementation

2017-02-02 Thread Ben Pfaff
On Wed, Dec 28, 2016 at 07:41:46PM +, Rodriguez Betancourt, Esteban wrote: > Skiplist implementation intended for the IDL compound indexes > feature. > > Signed-off-by: Esteban Rodriguez Betancourt Thanks! Is there a value to having max_levels as a configurable parameter

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Laine Stump
On 02/02/2017 10:06 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: It depends where / how in OVS it needs to be set. The only stuff libvirt does with OVS is to run 'add-port' and 'del-port'

[ovs-dev] [PATCH v2 0/1] Remove experimental tag for OVS userspace

2017-02-02 Thread Ian Stokes
Since the introduction of DPDK to OVS, the userspace deployment of OVS has been considered "experimental". A number of areas were identified to be improved upon before the tag could be removed. There has been a conscious effort to address these areas. The improvements to userspace (specifically

Re: [ovs-dev] [PATCH 1/1] doc: Remove "experimental" warning for userspace.

2017-02-02 Thread Stokes, Ian
> On 02/02/2017 03:21 PM, Ian Stokes wrote: > > Remove the experimental warning tag in documentation regarding OVS > > deployed via userspace. > > > > Signed-off-by: Ian Stokes > > --- > > Documentation/intro/install/dpdk.rst |3 --- > >

Re: [ovs-dev] [PATCH 1/1] doc: Remove "experimental" warning for userspace.

2017-02-02 Thread Kevin Traynor
On 02/02/2017 03:21 PM, Ian Stokes wrote: > Remove the experimental warning tag in documentation regarding OVS deployed > via userspace. > > Signed-off-by: Ian Stokes > --- > Documentation/intro/install/dpdk.rst |3 --- > Documentation/intro/install/userspace.rst

Re: [ovs-dev] [PATCH] doc: Update DPDK version for 2.7 relesase.

2017-02-02 Thread Stokes, Ian
> Subject: [PATCH] doc: Update DPDK version for 2.7 relesase. > > Add DPDK version required for the OVS 2.7 release in documentation. > > Signed-off-by: Ian Stokes > --- > Documentation/faq/releases.rst |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > >

[ovs-dev] [PATCH] doc: Update DPDK version for 2.7 relesase.

2017-02-02 Thread Ian Stokes
Add DPDK version required for the OVS 2.7 release in documentation. Signed-off-by: Ian Stokes --- Documentation/faq/releases.rst |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

2017-02-02 Thread Russell Bryant
On Thu, Feb 2, 2017 at 10:32 AM, Numan Siddique wrote: > On Wed, Feb 1, 2017 at 4:31 AM, Ben Pfaff wrote: > > > On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote: > > > ovn-controller by default enables tunnel encapsulation checksums > > > for

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

2017-02-02 Thread Numan Siddique
On Wed, Feb 1, 2017 at 4:31 AM, Ben Pfaff wrote: > On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote: > > ovn-controller by default enables tunnel encapsulation checksums > > for geneve tunnels. With this patch user can set the desired value > > in

[ovs-dev] [PATCH 1/1] doc: Remove "experimental" warning for userspace.

2017-02-02 Thread Ian Stokes
Remove the experimental warning tag in documentation regarding OVS deployed via userspace. Signed-off-by: Ian Stokes --- Documentation/intro/install/dpdk.rst |3 --- Documentation/intro/install/userspace.rst |4 README.rst|

[ovs-dev] [PATCH RFC 0/1] Remove experimental tag for OVS userspace

2017-02-02 Thread Ian Stokes
Since the introduction of DPDK to OVS, the userspace deployment of OVS has been considered "experimental". A number of areas were identified to be improved upon before the tag could be removed. There has been a conscious effort to address these areas. The improvements to userspace (specifically

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

2017-02-02 Thread Daniel P. Berrange
On Thu, Feb 02, 2017 at 03:14:01PM +0100, Maxime Coquelin wrote: > > > On 02/01/2017 12:41 PM, Daniel P. Berrange wrote: > > > > It depends where / how in OVS it needs to be set. The only stuff libvirt > > does with OVS is to run 'add-port' and 'del-port' commands via the ovs > > cli tool. We