[ovs-dev] Inter VM communication using ovs-dpdk

2017-03-03 Thread Priyanka
Hi, We have a OVS-DPDK (version 2.5) setup on our host running ubuntu 14.04. We followed: https://github.com/openvswitch/ovs/blob/branch-2.5/INSTALL.DPDK.md We were able to install and start the OVS, create bridge, create dpdk0 and dpdkvhostuser interface using commands as below: $OVS_DIR/ut

[ovs-dev] [PATCH 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

2017-03-03 Thread nickcooper-zhangtonghao
If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH 2/2] mcast-snooping: Avoid segfault for vswitchd.

2017-03-03 Thread nickcooper-zhangtonghao
The ports which are attached mrouters or hosts, were destroyed by users via ovs-vsctl commands. Currently the vswitch will segfault if users use "ovs-appctl mdb/show" to show mdb info. This patch avoids a segfault. or ofputil_port_to_string(ofbundle_get_a_port(bundle)->up.ofp_port, Signed-of

Re: [ovs-dev] [ovs-discuss][ovn][dhcp]Could ovn remove restriction of option 3(router)

2017-03-03 Thread Numan Siddique
On Fri, Mar 3, 2017 at 7:04 AM, Dong Jun wrote: > > > On 2017/3/3 1:33, Ben Pfaff wrote: > >> On Thu, Mar 02, 2017 at 07:15:48PM +0800, Dong Jun wrote: >> >>> An router IP MUST be set to dhcp v4 option for option 3, but not all >>> subnet >>> do have a gateway IP. Furthermore, if i set 0.0.0.0 t

[ovs-dev] [PATCH v2 1/2] mcast-snooping: Flush ports mdb when VLAN configuration changed.

2017-03-03 Thread nickcooper-zhangtonghao
If VLAN configuration(e.g. id, mode) change occurs, the IGMP snooping-learned multicast groups from this port on the VLAN are deleted. This avoids a MCAST_ENTRY_DEFAULT_IDLE_TIME delay before mdb is updated again. Hardware switches (e.g. cisco) also do that. Signed-off-by: nickcooper-zhangtonghao

[ovs-dev] [PATCH v2 2/2] mcast-snooping: Avoid segfault for vswitchd.

2017-03-03 Thread nickcooper-zhangtonghao
The ports which are attached mrouters or hosts, were destroyed by users via ovs-vsctl commands. Currently the vswitch will segfault if users use "ovs-appctl mdb/show" to show mdb info. This patch avoids a segfault. ofproto_unixctl_mcast_snooping_show ofproto/ofproto-dpif.c:4781 process_com

[ovs-dev] [PATCH] mcast-snooping: Add and improve mcast-snooping tests.

2017-03-03 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- tests/mcast-snooping.at | 112 1 file changed, 112 insertions(+) diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index c03aba3..90de8b3 100644 --- a/tests/mcast-snooping.at +++ b/tests/mcas

Re: [ovs-dev] [PATCH] fedora: Add python3-openvswitch split package

2017-03-03 Thread Flavio Leitner
On Thu, Mar 02, 2017 at 04:13:17PM -0500, Leif Madsen wrote: > On Thu, Mar 2, 2017 at 3:44 PM, Russell Bryant wrote: > > > > > On Thu, Mar 2, 2017 at 3:42 PM, Leif Madsen wrote: > > > >> Just an FYI that this patch breaks CentOS 7 builds because of the > >> python3-devel dependency. Might need t

[ovs-dev] [PATCH] ofproto-dpif : propagate may_enable flag as link aliveness

2017-03-03 Thread László Sürü
Hi, hereby I'm sending the implementation of link liveness propagation functionality including the additional functionalities requested last year (last activity at Wed Mar 16 23:13:24 UTC 2016). The idea is to use OFPPS_LIVE bit to propagate link aliveness state towards the controller also whe

Re: [ovs-dev] [ovs-discuss][ovn][dhcp]Could ovn remove restriction of option 3(router)

2017-03-03 Thread Ben Pfaff
On Fri, Mar 03, 2017 at 03:10:30PM +0530, Numan Siddique wrote: > On Fri, Mar 3, 2017 at 7:04 AM, Dong Jun wrote: > > > > > > > On 2017/3/3 1:33, Ben Pfaff wrote: > > > >> On Thu, Mar 02, 2017 at 07:15:48PM +0800, Dong Jun wrote: > >> > >>> An router IP MUST be set to dhcp v4 option for option 3,

Re: [ovs-dev] [PATCH v2 11/22] netlink: Simplify nl_msg_start_nested().

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > Since there is no data to copy nl_msg_put_unspec_uninit() may be used > directly, rather than via nl_msg_put_unspec(). > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev mailing lis

Re: [ovs-dev] [PATCH v2 15/22] odp: Support conntrack orig tuple key.

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > Userspace support for datapath original direction conntrack tuple. > > Signed-off-by: Jarno Rajahalme Thanks for the submission. Some feedback below. > diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h > index

Re: [ovs-dev] [PATCH 1/7] userspace: Add packet_type in dp_packet and flow

2017-03-03 Thread Ben Pfaff
On Fri, Feb 03, 2017 at 10:38:31AM +, Jan Scheurich wrote: > This commit adds a packet_type attribute to the structs dp_packet and flow > to explicitly carry the type of the packet as preparation for the > introduction of the so-called packet type-aware pipeline (PTAP) in OVS. > > The packet_t

Re: [ovs-dev] [PATCH 2/7] userspace: Support for push_eth and pop_eth actions

2017-03-03 Thread Ben Pfaff
On Fri, Feb 03, 2017 at 10:39:48AM +, Jan Scheurich wrote: > Add support for actions push_eth and pop_eth to the netdev datapath and > the supporting libraries. This patch relies on the support for these actions > in the kernel datapath to be present. > > Signed-off-by: Lorand Jakab > Signed-

Re: [ovs-dev] [PATCH v2 16/22] actions: Add resubmit with conntrack tuple.

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > Add resubmit option to use the Conntrack original direction tuple > swapped with the corresponding packet header fields during the lookup. > This could allow the same ACL table be used for admitting return > and/or related traffic as is used f

Re: [ovs-dev] [PATCH v2 09/22] datapath: Refactor labels initialization.

2017-03-03 Thread Jarno Rajahalme
> On Mar 2, 2017, at 5:26 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme > wrote: >> Upstream commit: >> >>Refactoring conntrack labels initialization makes changes in later >>patches easier to review. >> >>Signed-off-by: Jarno Raja

Re: [ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-03-03 Thread Ben Pfaff
On Fri, Feb 03, 2017 at 10:40:09AM +, Jan Scheurich wrote: > Ports have a new layer3 attribute if they send/receive L3 packets. > > The packet_type included in structs dp_packet and flow is considered in > ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and > vlan_tci, vl

Re: [ovs-dev] [PATCH 4/7] ofproto-dpif-upcall: Intialize dump-seq of new flow to zero

2017-03-03 Thread Ben Pfaff
On Fri, Feb 03, 2017 at 10:40:20AM +, Jan Scheurich wrote: > This forces updating of flow stat at the next re-validation, even for > flows that are being created when the revalidation has already commenced. > > It enables reliable testing of fast path flow stats using ovs-appctl > time/warp af

Re: [ovs-dev] [PATCH v2 12/22] lib: Check match and action prerequisities with 'match'.

2017-03-03 Thread Jarno Rajahalme
> On Mar 2, 2017, at 5:34 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme > wrote: >> Supply the match mask to prerequisities checking when available. This >> allows checking for zero-valued matches. Non-zero valued matches >> imply the presense

Re: [ovs-dev] [PATCH 5/7] userspace: L3 tunnel support for GRE and LISP

2017-03-03 Thread Ben Pfaff
I'm going to defer review on this and the later patches to the next version. Thanks, Ben. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 13/22] datapath: Add original direction conntrack tuple to sw_flow_key.

2017-03-03 Thread Jarno Rajahalme
> On Mar 2, 2017, at 5:57 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme > wrote: >> Upstream commit: >> >>commit 9dd7f8907c3705dc7a7a375d1c6e30b06e6daffc >>Author: Jarno Rajahalme >>Date: Thu Feb 9 11:21:59 2017 -0800 >> >>o

Re: [ovs-dev] [PATCH v2 14/22] flow: Make room after ct_state.

2017-03-03 Thread Jarno Rajahalme
> On Mar 2, 2017, at 6:41 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme > wrote: >> 'ct_state' currently only needs 8 bits, so we can make room for a new >> CT field introduced in the next patch. >> >> Signed-off-by: Jarno Rajahalme >> --- >>

Re: [ovs-dev] [PATCH 2/2] datapath: Simplify do_execute_actions().

2017-03-03 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Mar 2, 2017, at 7:29 PM, Joe Stringer wrote: > > From: andy zhou > > Upstream commit: >commit 5b8784aaf29be20ba8d363e1124d7436d42ef9bf >Author: Andy Zhou >Date: Fri Jan 27 13:45:28 2017 -0800 > >openvswitch: Simplify do_execute_actions(). > >

Re: [ovs-dev] [PATCH 1/2] datapath: maintain correct checksum state in conntrack actions.

2017-03-03 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Mar 2, 2017, at 7:29 PM, Joe Stringer wrote: > > From: Lance Richardson > > Upstream commit: >commit 75f01a4c9cc291ff5cb28ca1216adb163b7a20ee >Author: Lance Richardson >Date: Thu Jan 12 19:33:18 2017 -0500 > >openvswitch: maintain correct check

Re: [ovs-dev] [PATCH 2/2] mcast-snooping: Avoid segfault for vswitchd.

2017-03-03 Thread Ben Pfaff
Thank you for the bug fixes. I applied them to master, branch-2.7, and branch-2.6. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] mcast-snooping: Add and improve mcast-snooping tests.

2017-03-03 Thread Ben Pfaff
On Fri, Mar 03, 2017 at 03:08:47AM -0800, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Thank you for writing a test. I applied it to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listi

Re: [ovs-dev] [PATCH 3/3] lacp: Fix formatting typo.

2017-03-03 Thread Ben Pfaff
On Thu, Mar 02, 2017 at 05:02:53AM -0800, nickcooper-zhangtonghao wrote: > Signed-off-by: nickcooper-zhangtonghao Thank you for the patches. I applied them to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listin

[ovs-dev] Cómo Vender con Éxito + 11 temas

2017-03-03 Thread Ventas - Plan Integral -descuentos de mes
Plan Integral Indispensable para los Responsables de Ventas 12 conferencias en cada Plan, pregrabadas, inéditas, para capacitar a todo su personal. Al adquirir el Plan de Capacitación, usted obtiene acceso a 12 temas enfocados al área de Ventas; temas especializados que han sido cuidadosamente

Re: [ovs-dev] [PATCH v2 09/22] datapath: Refactor labels initialization.

2017-03-03 Thread Joe Stringer
On 3/03/2017 10:37, "Jarno Rajahalme" wrote: On Mar 2, 2017, at 5:26 PM, Joe Stringer wrote: On 28 February 2017 at 17:17, Jarno Rajahalme wrote: Upstream commit: Refactoring conntrack labels initialization makes changes in later patches easier to review. Signed-off-by: Jarno Raja

[ovs-dev] [PATCH] conntrack: Fix checks for TCP, UDP, and IPv6 header sizes.

2017-03-03 Thread Ben Pfaff
Otherwise a malformed packet could cause a read up to about 40 bytes past the end of the packet. The packet would still likely be dropped because of checksum verification. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- lib/conntrack.c | 14 -- 1 file changed, 12 inserti

Re: [ovs-dev] [PATCH v2 15/22] odp: Support conntrack orig tuple key.

2017-03-03 Thread Jarno Rajahalme
Thanks for the review Joe! > On Mar 3, 2017, at 10:09 AM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme wrote: >> Userspace support for datapath original direction conntrack tuple. >> >> Signed-off-by: Jarno Rajahalme > > Thanks for the submission. Some feedback below

Re: [ovs-dev] [PATCH v2 15/22] odp: Support conntrack orig tuple key.

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 14:36, Jarno Rajahalme wrote: > Thanks for the review Joe! > >> On Mar 3, 2017, at 10:09 AM, Joe Stringer wrote: >> >> On 28 February 2017 at 17:17, Jarno Rajahalme wrote: >>> Userspace support for datapath original direction conntrack tuple. >>> >>> Signed-off-by: Jarno Rajah

Re: [ovs-dev] [PATCH v2 01/22] datapath: make ndo_get_stats64 a void function

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > From: stephen hemminger > > Upstream commit: > > commit bc1f44709cf27fb2a5766cadafe7e2ad5e9cb221 > Author: stephen hemminger > Date: Fri Jan 6 19:12:52 2017 -0800 > > net: make ndo_get_stats64 a void function > > The ne

Re: [ovs-dev] [PATCH 1/2] datapath: maintain correct checksum state in conntrack actions.

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 11:04, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied. (This was already applied to branch-2.7). ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] datapath: Simplify do_execute_actions().

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 11:03, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme Thanks, applied. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 17/22] compat: nf_ct_delete compat.

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > Upstream commit: > > commit f330a7fdbe1611104622faff7e614a246a7d20f0 > Author: Florian Westphal > Date: Thu Aug 25 15:33:31 2016 +0200 > > netfilter: conntrack: get rid of conntrack timer > > With stats enabled this eats

Re: [ovs-dev] [PATCH v2 19/22] conntrack: Force commit.

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > Userspace support for force commit. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 21/22] tests: Add an FTP test without conntrack.

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > If FTP tests with conntrack fail, it is informative to know if the > problem is with the FTP client and/or server, or with conntrack > itself. > > Signed-off-by: Jarno Rajahalme > --- > tests/system-traffic.at | 29 ++

Re: [ovs-dev] [PATCH v2 22/22] datapath: Allow compiling against Linux 4.10

2017-03-03 Thread Joe Stringer
On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > OVS in-tree datapath compiles against Linux 4.10 kernel, so allow it. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer We should probably update the .travis.yml soon, syncing with the currently supported versions on kernel.org. __

Re: [ovs-dev] [PATCH v2 16/22] actions: Add resubmit with conntrack tuple.

2017-03-03 Thread Jarno Rajahalme
> On Mar 3, 2017, at 10:35 AM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme > wrote: >> Add resubmit option to use the Conntrack original direction tuple >> swapped with the corresponding packet header fields during the lookup. >> This could allow

Re: [ovs-dev] [PATCH v2 09/22] datapath: Refactor labels initialization.

2017-03-03 Thread Jarno Rajahalme
> On Mar 3, 2017, at 1:44 PM, Joe Stringer wrote: > > > > On 3/03/2017 10:37, "Jarno Rajahalme" mailto:ja...@ovn.org>> > wrote: > >> On Mar 2, 2017, at 5:26 PM, Joe Stringer > > wrote: >> >> On 28 February 2017 at 17:17, Jarno Rajahalme > > wrote:

Re: [ovs-dev] [PATCH v2 14/22] flow: Make room after ct_state.

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 10:51, Jarno Rajahalme wrote: > > On Mar 2, 2017, at 6:41 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > > 'ct_state' currently only needs 8 bits, so we can make room for a new > CT field introduced in the next patch. > > Signed-off-by: Jarn

Re: [ovs-dev] [PATCH v2 22/22] datapath: Allow compiling against Linux 4.10

2017-03-03 Thread Jarno Rajahalme
> On Mar 3, 2017, at 3:43 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme wrote: >> OVS in-tree datapath compiles against Linux 4.10 kernel, so allow it. >> >> Signed-off-by: Jarno Rajahalme > > Acked-by: Joe Stringer > > We should probably update the .travis.yml

Re: [ovs-dev] [PATCH v2 22/22] datapath: Allow compiling against Linux 4.10

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 16:16, Jarno Rajahalme wrote: > >> On Mar 3, 2017, at 3:43 PM, Joe Stringer wrote: >> >> On 28 February 2017 at 17:17, Jarno Rajahalme wrote: >>> OVS in-tree datapath compiles against Linux 4.10 kernel, so allow it. >>> >>> Signed-off-by: Jarno Rajahalme >> >> Acked-by: Joe S

Re: [ovs-dev] [PATCH v2 09/22] datapath: Refactor labels initialization.

2017-03-03 Thread Joe Stringer
On 3 March 2017 at 16:04, Jarno Rajahalme wrote: > > On Mar 3, 2017, at 1:44 PM, Joe Stringer wrote: > > > > On 3/03/2017 10:37, "Jarno Rajahalme" wrote: > > > On Mar 2, 2017, at 5:26 PM, Joe Stringer wrote: > > On 28 February 2017 at 17:17, Jarno Rajahalme wrote: > > Upstream commit: > >R

Re: [ovs-dev] [PATCH] conntrack: Fix checks for TCP, UDP, and IPv6 header sizes.

2017-03-03 Thread Daniele Di Proietto
2017-03-03 14:08 GMT-08:00 Ben Pfaff : > Otherwise a malformed packet could cause a read up to about 40 bytes past > the end of the packet. The packet would still likely be dropped because > of checksum verification. > > Reported-by: Bhargava Shastry > Signed-off-by: Ben Pfaff Oops, thanks for

Re: [ovs-dev] [PATCH] tun-metadata: Fix memory leak in tun_metadata_table_mod().

2017-03-03 Thread Joe Stringer
On 7 February 2017 at 13:14, Yi-Hung Wei wrote: > In testcase "tunnel - Geneve metadata", valgrind reports a memory leak with > the following call stack. > xcalloc (util.c:95) > tun_metadata_alloc (tun-metadata.c:89) > tun_metadata_table_mod (tun-metadata.c:151) > handle_tlv_table_

Re: [ovs-dev] [PATCH] rhel: remove duplicate line from rhel/automake.mk

2017-03-03 Thread Joe Stringer
On 9 February 2017 at 13:30, Lance Richardson wrote: > Fixes: commit 55f36be59122 ("rhel: Firewall service files for OVN.") > Signed-off-by: Lance Richardson Thanks, LGTM. Applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvs

Re: [ovs-dev] [PATCH] conntrack: Fix checks for TCP, UDP, and IPv6 header sizes.

2017-03-03 Thread Ben Pfaff
On Fri, Mar 03, 2017 at 05:00:38PM -0800, Daniele Di Proietto wrote: > 2017-03-03 14:08 GMT-08:00 Ben Pfaff : > > Otherwise a malformed packet could cause a read up to about 40 bytes past > > the end of the packet. The packet would still likely be dropped because > > of checksum verification. > >

[ovs-dev] [PATCH v2] conntrack: Fix checks for TCP, UDP, and IPv6 header sizes.

2017-03-03 Thread Ben Pfaff
Otherwise a malformed packet could cause a read up to about 40 bytes past the end of the packet. The packet would still likely be dropped because of checksum verification. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff --- v1->v2: Eliminate duplicate check in extract_l3_ipv6(). Thanks