Re: [ovs-dev] [PATCH] dpdk: Redirect DPDK log to OVS logging subsystem.

2017-03-05 Thread Ilya Maximets
On 02.03.2017 22:22, Aaron Conole wrote: > Ilya Maximets writes: > >> This should be helpful for have all the logs in one place. >> 'ovs-appctl vlog' commands for 'dpdk' module can be used >> to configure the log level. Lower bound for DPDK logging >> (--log-level) still

[ovs-dev] [PATCH v2] dpdk: Redirect DPDK log to OVS logging subsystem.

2017-03-05 Thread Ilya Maximets
This should be helpful for have all the logs in one place. 'ovs-appctl vlog' commands for 'dpdk' module can be used to configure the log level. Lower bound for DPDK logging (--log-level) still can be passed through 'dpdk-extra' field. Signed-off-by: Ilya Maximets ---

Re: [ovs-dev] [PATCH 5/7] userspace: L3 tunnel support for GRE and LISP

2017-03-05 Thread Jan Scheurich
> I'm going to defer review on this and the later patches to the next > version. OK. We'll post an updated series when the open issues are sorted out. The biggest issue is the display format of packet_type (due to volume of unit test updates involved). The other open question to solve is

Re: [ovs-dev] [PATCH 4/7] ofproto-dpif-upcall: Intialize dump-seq of new flow to zero

2017-03-05 Thread Jan Scheurich
> > This forces updating of flow stat at the next re-validation, even for > > flows that are being created when the revalidation has already commenced. > > > > It enables reliable testing of fast path flow stats using ovs-appctl > > time/warp after flow creation. > > > > Signed-off-by: Jan

Re: [ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

2017-03-05 Thread Jan Scheurich
> Please don't add comments about changes, like this one. Readers should > not have to understand the history to understand the code: > +if (put->flags & DPIF_FP_MODIFY) { > +/* Removed the additional check > + * flow_equal(, _flow->flow) as a) the > +

Re: [ovs-dev] [PATCH 2/7] userspace: Support for push_eth and pop_eth actions

2017-03-05 Thread Jan Scheurich
> > Signed-off-by: Lorand Jakab > > Signed-off-by: Simon Horman > > Signed-off-by: Jiri Benc > > Signed-off-by: Yi Yang > > Signed-off-by: Jean Tourrilhes > > Signed-off-by: Jan Scheurich

Re: [ovs-dev] [PATCH 1/7] userspace: Add packet_type in dp_packet and flow

2017-03-05 Thread Jan Scheurich
Hi Ben, Thanks for the review. Please find some answers below. Jan > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Friday, 03 March, 2017 19:14 > To: Jan Scheurich > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 1/7] userspace: