Re: [ovs-dev] [ovs-dev, RFC] ovn: Revised support for service function chaining

2017-03-15 Thread Mickey Spiegel
On Mon, Mar 13, 2017 at 1:28 PM, John McDowall < jmcdow...@paloaltonetworks.com> wrote: > This patch set is an alternative implementation of service function > chaining (SFC) for OVS/OVN. The major change from the previous patch is > that the overloading of the ACL stage in ovn-northd.c has been r

[ovs-dev] [PATCH branch-2.7 24/25] compat: nf_ct_delete compat.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit f330a7fdbe1611104622faff7e614a246a7d20f0 Author: Florian Westphal Date: Thu Aug 25 15:33:31 2016 +0200 netfilter: conntrack: get rid of conntrack timer With stats enabled this eats 80 bytes on x86_64 per nf_conn entry, as Eric Dumazet pointed ou

[ovs-dev] [PATCH branch-2.7 25/25] lib: Indicate if netlink message had labels.

2017-03-15 Thread Jarno Rajahalme
Conntrack update events include labels only if they have changed. Record the presence of labels in the netlink message to OVS internal representation, so that the user may keep the old labels when an update does not modify them. Fixes: 6830a0c0e6bf ("netlink-conntrack: New module.") Signed-off-by:

[ovs-dev] [PATCH branch-2.7 19/25] datapath: Simplify labels length logic.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit b87cec3814ccc7f6afb0a1378ee7e5110d07cdd3 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:56 2017 -0800 openvswitch: Simplify labels length logic. Since 23014011ba42 ("netfilter: conntrack: support a fixed size of 128 distinct labels"), the size of

[ovs-dev] [PATCH branch-2.7 23/25] nx-match: Fix oxm decode.

2017-03-15 Thread Jarno Rajahalme
From: Yi-Hung Wei decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME messages, where we need exact match on the oxm header. Therefore, change oxm_decode_loose() to oxm_decode() that takes an extra argument to indicate whether we want strict or loose match. Fixes: 7befb20d0f70

[ovs-dev] [PATCH branch-2.7 22/25] ofp-util: Ignore unknown fields in ofputil_decode_packet_in2().

2017-03-15 Thread Jarno Rajahalme
The decoder of packet_in messages should not fail on encountering unknown metadata fields. This allows the switch to add new features without breaking controllers. The controllers should, however, copy the metadata fields from the packet_int to packet_out so that the switch gets back the full met

[ovs-dev] [PATCH branch-2.7 21/25] datapath: Inherit master's labels.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit 09aa98ad496d6b11a698b258bc64d7f64c55d682 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:58 2017 -0800 openvswitch: Inherit master's labels. We avoid calling into nf_conntrack_in() for expected connections, as that would remove the expectation tha

[ovs-dev] [PATCH branch-2.7 07/25] datapath: remove unnecessary EXPORT_SYMBOLs

2017-03-15 Thread Jarno Rajahalme
From: Jiri Benc Upstream commit: commit 76e4cc7731a1e0c07e202999b9834f9d9be66de4 Author: Jiri Benc Date: Wed Oct 19 11:26:37 2016 +0200 openvswitch: remove unnecessary EXPORT_SYMBOLs Some symbols exported to other modules are really used only by openvswitch.ko. Remove

[ovs-dev] [PATCH branch-2.7 20/25] datapath: Refactor labels initialization.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: Refactoring conntrack labels initialization makes changes in later patches easier to review. Signed-off-by: Jarno Rajahalme Acked-by: Pravin B Shelar Acked-by: Joe Stringer Signed-off-by: David S. Miller Signed-off-by: Jarno Rajahalme Acked-by: Joe S

[ovs-dev] [PATCH branch-2.7 18/25] datapath: Unionize ovs_key_ct_label with a u32 array.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit cb80d58fae76d8ea93555149b2b16e19b89a1f4f Author: Jarno Rajahalme Date: Thu Feb 9 11:21:55 2017 -0800 openvswitch: Unionize ovs_key_ct_label with a u32 array. Make the array of labels in struct ovs_key_ct_label an union, adding a u32 array of the

[ovs-dev] [PATCH branch-2.7 11/25] datapath: make ndo_get_stats64 a void function

2017-03-15 Thread Jarno Rajahalme
From: stephen hemminger Upstream commit: commit bc1f44709cf27fb2a5766cadafe7e2ad5e9cb221 Author: stephen hemminger Date: Fri Jan 6 19:12:52 2017 -0800 net: make ndo_get_stats64 a void function The network device operation for reading statistics is only called in one p

[ovs-dev] [PATCH branch-2.7 06/25] datapath: remove unused functions

2017-03-15 Thread Jarno Rajahalme
From: Jiri Benc Upstream commit: commit f33eb0cf9984f79e8643eaac888e4b6a06a8e221 Author: Jiri Benc Date: Wed Oct 19 11:26:36 2016 +0200 openvswitch: remove unused functions ovs_vport_deferred_free is not used anywhere. It's the only caller of free_vport_rcu thus this

[ovs-dev] [PATCH branch-2.7 16/25] datapath: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit 9ff464db50e437eef131f719cc2e9902eea9c607 Author: Jarno Rajahalme Date: Thu Feb 9 11:21:53 2017 -0800 openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted. The conntrack lookup for existing connections fails to invert the packet 5-

[ovs-dev] [PATCH branch-2.7 17/25] datapath: Do not trigger events for unconfirmed connections.

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit 193e30967897f3a8b6f9f137ac30571d832c2c5c Author: Jarno Rajahalme Date: Thu Feb 9 11:21:54 2017 -0800 openvswitch: Do not trigger events for unconfirmed connections. Receiving change events before the 'new' event for the connection has been receiv

[ovs-dev] [PATCH branch-2.7 15/25] datapath: Fix comments for skb->_nfct

2017-03-15 Thread Jarno Rajahalme
Upstream commit: commit 5e17da634a21b1200853fe82ba67d6571f2beabe Author: Jarno Rajahalme Date: Thu Feb 9 11:21:52 2017 -0800 openvswitch: Fix comments for skb->_nfct Fix comments referring to skb 'nfct' and 'nfctinfo' fields now that they are combined into '_nfct'.

[ovs-dev] [PATCH branch-2.7 14/25] datapath: add and use nf_ct_set helper

2017-03-15 Thread Jarno Rajahalme
From: Florian Westphal Upstream commit: commit c74454fadd5ea6fc866ffe2c417a0dba56b2bf1c Author: Florian Westphal Date: Mon Jan 23 18:21:57 2017 +0100 netfilter: add and use nf_ct_set helper Add a helper to assign a nf_conn entry and the ctinfo bits to an sk_buff. Thi

[ovs-dev] [PATCH branch-2.7 13/25] datapath: add and use skb_nfct helper

2017-03-15 Thread Jarno Rajahalme
From: Florian Westphal Upstream commit: commit cb9c68363efb6d1f950ec55fb06e031ee70db5fc Author: Florian Westphal Date: Mon Jan 23 18:21:56 2017 +0100 skbuff: add and use skb_nfct helper Followup patch renames skb->nfct and changes its type so add a helper to avoid in

[ovs-dev] [PATCH branch-2.7 12/25] datapath: Allow compiling against Linux 4.10

2017-03-15 Thread Jarno Rajahalme
OVS in-tree datapath compiles against Linux 4.10 kernel, so allow it. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- acinclude.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/acinclude.m4 b/acinclude.m4 index 052a18f..b34c0fd 100644 --- a/acinclude.m4 +++ b

[ovs-dev] [PATCH branch-2.7 09/25] datapath: handle NF_REPEAT from nf_conntrack_in()

2017-03-15 Thread Jarno Rajahalme
From: Pablo Neira Ayuso Upstream commit: commit 08733a0cb7decce40bbbd0331a0449465f13c444 Author: Pablo Neira Ayuso Date: Thu Nov 3 10:56:43 2016 +0100 netfilter: handle NF_REPEAT from nf_conntrack_in() NF_REPEAT is only needed from nf_conntrack_in() under a very specific

[ovs-dev] [PATCH branch-2.7 10/25] datapath: netns: make struct pernet_operations::id unsigned int.

2017-03-15 Thread Jarno Rajahalme
From: Alexey Dobriyan Upstream commit: commit c7d03a00b56fc23c3a01a8353789ad257363e281 Author: Alexey Dobriyan Date: Thu Nov 17 04:58:21 2016 +0300 netns: make struct pernet_operations::id unsigned int Make struct pernet_operations::id unsigned. There are 2 reasons t

[ovs-dev] [PATCH branch-2.7 08/25] datapath: use core MTU range checking in core net infra

2017-03-15 Thread Jarno Rajahalme
From: Jarod Wilson Upstream commit: commit 61e84623ace35ce48975e8f90bbbac7557c43d61 Author: Jarod Wilson Date: Fri Oct 7 22:04:33 2016 -0400 net: centralize net_device min/max MTU checking While looking into an MTU issue with sfc, I started noticing that almost every

[ovs-dev] [PATCH branch-2.7 05/25] datapath: add NETIF_F_HW_VLAN_STAG_TX to internal dev.

2017-03-15 Thread Jarno Rajahalme
From: Jiri Benc Upstream commit: commit 3145c037e74926dea9241a3f68ada6f294b0119a Author: Jiri Benc Date: Mon Oct 10 17:02:44 2016 +0200 openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev The internal device does support 802.1AD offloading since 018c1dda5ff1 ("op

[ovs-dev] [PATCH branch-2.7 04/25] datapath: avoid resetting flow key while installing new flow.

2017-03-15 Thread Jarno Rajahalme
From: pravin shelar Upstream commit: commit 2279994d07ab67ff7a1d09bfbd65588332dfb6d8 Author: pravin shelar Date: Mon Sep 19 13:51:00 2016 -0700 openvswitch: avoid resetting flow key while installing new flow. since commit commit db74a3335e0f6 ("openvswitch: use percpu

[ovs-dev] [PATCH branch-2.7 03/25] datapath: Fix Frame-size larger than 1024 bytes warning.

2017-03-15 Thread Jarno Rajahalme
From: pravin shelar Upstream commit: commit 190aa3e77880a05332ea1ccb382a51285d57adb5 Author: pravin shelar Date: Mon Sep 19 13:50:59 2016 -0700 openvswitch: Fix Frame-size larger than 1024 bytes warning. There is no need to declare separate key on stack, we can just u

[ovs-dev] [PATCH branch-2.7 02/25] datapath: use percpu flow stats

2017-03-15 Thread Jarno Rajahalme
From: Thadeu Lima de Souza Cascardo Upstream commit: commit db74a3335e0f645e3139c80bcfc90feb01d8e304 Author: Thadeu Lima de Souza Cascardo Date: Thu Sep 15 19:11:53 2016 -0300 openvswitch: use percpu flow stats Instead of using flow stats per NUMA node, use it per CPU. Wh

[ovs-dev] [PATCH branch-2.7 01/25] datapath: fix flow stats accounting when node 0 is not possible

2017-03-15 Thread Jarno Rajahalme
From: Thadeu Lima de Souza Cascardo Upstream commit: commit 40773966ccf1985a1b2bb570a03cbeaf1cbd4e00 Author: Thadeu Lima de Souza Cascardo Date: Thu Sep 15 19:11:52 2016 -0300 openvswitch: fix flow stats accounting when node 0 is not possible On a system with only node 1

[ovs-dev] [PATCH branch-2.7 00/25] Backports for branch-2.7

2017-03-15 Thread Jarno Rajahalme
These are (mostly) datapath backports from master that fix existing features in branch-2.7 and/or make the datapath compilable with later Linux kernel code. Alexey Dobriyan (1): datapath: netns: make struct pernet_operations::id unsigned int. Florian Westphal (2): datapath: add and use skb_nf

Re: [ovs-dev] [branch-2.7 1/4] nx-match: Fix oxm decode.

2017-03-15 Thread Jarno Rajahalme
IMO we should also backport the patch (“ofp-util: Ignore unknown fields in ofputil_decode_packet_in2().”) this patch fixed. jarno > On Mar 15, 2017, at 4:01 PM, Joe Stringer wrote: > > From: Yi-Hung Wei > > decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME > messages, wh

[ovs-dev] [branch-2.7 3/4] ofproto: Add ref counting for variable length mf_fields.

2017-03-15 Thread Joe Stringer
From: Yi-Hung Wei Currently, a controller may potentially trigger a segmentation fault if it accidentally removes a TLV mapping that is still used by an active flow. To resolve this issue, in this patch, we maintain reference counting for each dynamically allocated variable length mf_fields, so t

[ovs-dev] [branch-2.7 4/4] ofproto: Move tun_table and vl_mff_map deletion.

2017-03-15 Thread Joe Stringer
From: Yi-Hung Wei In this patch, we move the tun_table and vl_mff_map deletion in ofproto_destory__() to be in the following order. 1. Delete all the flows. 2. Delete vl_mff_map. 3. Delete tun_table. The rationale behind this order is that a flow may use a variable length mf_field, an

[ovs-dev] [branch-2.7 2/4] nx-match: Use vl_mff_map to parse match field.

2017-03-15 Thread Joe Stringer
From: Yi-Hung Wei vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs") to account variable length mf_field, and it is used to decode variable length mf_field in ofp_action. In this patch, vl_mff_map is further used to decode the variable length match

[ovs-dev] [branch-2.7 1/4] nx-match: Fix oxm decode.

2017-03-15 Thread Joe Stringer
From: Yi-Hung Wei decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME messages, where we need exact match on the oxm header. It's also used by OVN to parse NXT_PACKET_IN2 messages. For the switch, strict prerequisites should be applied but for the controller, this should not be t

[ovs-dev] [branch-2.7 0/4] Backport of variable length metaflow field fixes.

2017-03-15 Thread Joe Stringer
Commit 04f48a68c428 ("ofp-actions: Fix variable length meta-flow OXMs."), on branch-2.7 as 9554b03d6ab7, attempted to address incorrect encode and decode of variable length metaflow fields where the OXM/NXM encoding of the variable length fields would incorrectly serialize the length. The patch add

Re: [ovs-dev] [PATCH v3 4/4] ofproto: Move tun_table and vl_mff_map deletion.

2017-03-15 Thread Joe Stringer
On 13 March 2017 at 11:28, Yi-Hung Wei wrote: > In this patch, we move the tun_table and vl_mff_map deletion in > ofproto_destory__() to be in the following order. > 1. Delete all the flows. > 2. Delete vl_mff_map. > 3. Delete tun_table. > The rationale behind this order is that a flow

Re: [ovs-dev] [PATCH v3 3/4] ofproto: Add ref counting for variable length mf_fields.

2017-03-15 Thread Joe Stringer
On 13 March 2017 at 11:28, Yi-Hung Wei wrote: > Currently, a controller may potentially trigger a segmentation fault if it > accidentally removes a TLV mapping that is still used by an active flow. > To resolve this issue, in this patch, we maintain reference counting for each > dynamically alloca

Re: [ovs-dev] [PATCH v3 2/4] nx-match: Use vl_mff_map to parse match field.

2017-03-15 Thread Joe Stringer
On 13 March 2017 at 11:28, Yi-Hung Wei wrote: > vl_mff_map is introduced in commit 04f48a68c428 ("ofp-actions: Fix variable > length meta-flow OXMs") to account variable length mf_field, and it is used > to decode variable length mf_field in ofp_action. In this patch, vl_mff_map > is further used

Re: [ovs-dev] [PATCH v3 1/4] nx-match: Fix oxm decode.

2017-03-15 Thread Joe Stringer
On 13 March 2017 at 11:27, Yi-Hung Wei wrote: > decode_nx_packet_in2() may be used by the switch to parse NXT_RESUME messages, > where we need exact match on the oxm header. Therefore, change > oxm_decode_loose() to oxm_decode() that takes an extra argument to indicate > whether > we want strict

Re: [ovs-dev] [PATCH 1/7] Add support for 802.1ad (QinQ tunneling)

2017-03-15 Thread Andy Zhou
On Wed, Mar 1, 2017 at 2:47 PM, Eric Garver wrote: > Flow key handling changes: > - Add VLAN header array in struct flow, to record multiple 802.1q VLAN >headers. > - Add dpif multi-VLAN capability probing. If datapath supports >multi-VLAN, increase the maximum depth of nested OVS_KEY_AT

Re: [ovs-dev] [PATCH] Document OVN support in ovs-sandbox.

2017-03-15 Thread Russell Bryant
On Wed, Mar 15, 2017 at 4:37 AM, Numan Siddique wrote: > On Tue, Mar 14, 2017 at 1:56 AM, Russell Bryant wrote: >> >> A previous commit removed the original ovs-sandbox based OVN tutorial >> because it became too outdated and difficult to maintain. However, >> the use of ovs-sandbox for basic OV

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

2017-03-15 Thread Aaron Conole
Markos Chandras writes: > Hi Aaron, > > On 03/09/2017 03:35 PM, Aaron Conole wrote: >> The Open vSwitch run, log, and DB directories are installed as part of the >> normal `make install` process. However, this means they are created with >> user and group ownership that may conflict with the des

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

2017-03-15 Thread Mickey Spiegel
On Wed, Mar 15, 2017 at 7:18 AM, Lance Richardson wrote: > > From: "Mickey Spiegel" > > To: "Lance Richardson" > > Cc: "Russell Bryant" , "devovs" > > Sent: Tuesday, March 14, 2017 3:06:53 PM > > Subject: Re: [ovs-dev] OVN: Compromised Chassis Mitigation > > > > Hi Mickey, > > Thanks for the e

Re: [ovs-dev] [ dev-openvswitch ] sflow configuration

2017-03-15 Thread Ben Pfaff
On Wed, Mar 15, 2017 at 02:52:19PM +0100, nicolas prochazka wrote: > Hello, > How can i configure agentSubId in sflow configuration . It doesn't look like OVS supports configuring the subid. ___ dev mailing list d...@openvswitch.org https://mail.openvswi

Re: [ovs-dev] OVN: Compromised Chassis Mitigation

2017-03-15 Thread Lance Richardson
> From: "Mickey Spiegel" > To: "Lance Richardson" > Cc: "Russell Bryant" , "devovs" > Sent: Tuesday, March 14, 2017 3:06:53 PM > Subject: Re: [ovs-dev] OVN: Compromised Chassis Mitigation > Hi Mickey, Thanks for the excellent feedback. Here's the latest pass: 1) Add a new column, "role", of

[ovs-dev] [ dev-openvswitch ] sflow configuration

2017-03-15 Thread nicolas prochazka
Hello, How can i configure agentSubId in sflow configuration . [nicolas-kabylake-8259511d-ffc3-3191-1428-f44d30684975]ovs-vsctl list sflow _uuid : 72794c6b-4b70-46b5-887f-31e622684c38 agent : neoEtap external_ids: {} header : 128 polling

[ovs-dev] Call DR JAMES ADAMS No + 27 748 044 206 IRREVOCABLE PAYMENT ORDER VIA ATM CARD

2017-03-15 Thread Call DR JAMES ADAMS No + 27 748 044 206 IRREVOCABLE PAYMENT ORDER VIA ATM CARD
 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] Uw Outlook e-mail account wachtwoord verloopt vandaag

2017-03-15 Thread Aliah Cortes
From: Aliah Cortes Sent: Wednesday, March 15, 2017 2:43 AM To: Aliah Cortes Subject: Uw Outlook e-mail account wachtwoord verloopt vandaag Beste E-mail gebruiker. Uw Outlook e-mail account wachtwoord verloopt vandaag, en u wordt gevraagd om te upgraden binnen 24 uur, anders zal uw Outlook e-ma

[ovs-dev] [PATCH] netdev-dpdk: add dpdk interface strip_vlan option

2017-03-15 Thread Zang MingJie
dpdk-strip-vlan option specifies whether strip vlan for the dpdk interface. Signed-off-by: Zang MingJie --- lib/netdev-dpdk.c| 23 ++- vswitchd/vswitch.xml | 7 +++ 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c i

Re: [ovs-dev] [PATCH] Document OVN support in ovs-sandbox.

2017-03-15 Thread Numan Siddique
On Tue, Mar 14, 2017 at 1:56 AM, Russell Bryant wrote: > A previous commit removed the original ovs-sandbox based OVN tutorial > because it became too outdated and difficult to maintain. However, > the use of ovs-sandbox for basic OVN development and testing is incredibly > useful, so we should

Re: [ovs-dev] [PATCH] ofproto: Add appctl command to show Datapath features

2017-03-15 Thread Andy Zhou
On Tue, Mar 14, 2017 at 6:19 PM, Joe Stringer wrote: > On 13 March 2017 at 14:21, Andy Zhou wrote: >> Exporting Datapath runtime detected features can be useful for >> both debugging and for writing system unit testing easier. >> >> Signed-off-by: Andy Zhou > > Can we perform some kind of build-

Re: [ovs-dev] [PATCH] ovn-northd: Skip icmp4 packets destined for router ports from conntrack

2017-03-15 Thread Numan Siddique
Adding Joe and Jarno to CC. On Tue, Mar 14, 2017 at 9:01 PM, Lance Richardson wrote: > > > - Original Message - > > From: "Numan Siddique" > > To: "Russell Bryant" > > Cc: "ovs dev" > > Sent: Tuesday, March 14, 2017 11:21:33 AM > > Subject: Re: [ovs-dev] [PATCH] ovn-northd: Skip icm