Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

From: ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean Sent: Friday, May 19, 2017 4:28 PM To: Ben Pfaff Cc: ovs dev; Guru Shetty Subject: Re: [ovs-dev] [PATCH v2] Windows lib: Use

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Saturday, May 20, 2017 2:25 AM > To: Alin Serdean > Cc: Guru Shetty ; ovs dev > Subject: Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

OK, I backported all the way to branch-2.5, dropping the wmi changes in 2.6 and 2.5. On Fri, May 19, 2017 at 10:56:33PM +, Alin Serdean wrote: > Branch-2.7 at least please. Branch-2.6 and branch-2.5 does not have the wmi.c > file > > > -Original Message- > > From:

Re: [ovs-dev] [PATCH v2 3/3] build-windows: cccl fail compilation on Wimplicit-function-declaration

On Fri, May 19, 2017 at 08:25:11PM +, Alin Serdean wrote: > Gcc compiler argument -Wall contains -Wimplicit-function-declaration which > gives warnings when a function is used before declared. > Map VStudio compiler error C4013 to it. > More info on C4013: >

Re: [ovs-dev] [PATCH v2 2/3] windows: add includes to daemon-windows

On Fri, May 19, 2017 at 08:25:11PM +, Alin Serdean wrote: > Add fatal-signal.h include since it uses: fatal_signal_atexit_handler > and fatal_signal_add_hook > > Use the defined getpid() function and also include since > it is defined in include/windows/unistd.h . > > Signed-off-by: Alin

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

Branch-2.7 at least please. Branch-2.6 and branch-2.5 does not have the wmi.c file > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Saturday, May 20, 2017 1:52 AM > To: Guru Shetty > Cc:

Re: [ovs-dev] [PATCH v5 0/7] create tunnel devices using rtnetlink interface

On Fri, 2017-05-19 at 09:22 -0400, Eric Garver wrote: > On Thu, May 18, 2017 at 07:48:56PM -0700, Greg Rose wrote: > > On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote: > > > On 18 May 2017 at 15:35, Greg Rose wrote: > > > > On Thu, 2017-05-18 at 16:10 -0400, Eric

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

On Fri, May 19, 2017 at 03:20:41PM -0700, Guru Shetty wrote: > On 19 May 2017 at 14:59, Shashank Ram wrote: > > > xmalloc checks if the size is valid before allocating > > memory, and also if the allocation was successful. > > > > Signed-off-by: Shashank Ram >

Re: [ovs-dev] [PATCH 3/3] dpif-netlink-rtnl: Use OVS_NOT_REACHED in verify.

On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote: > The vport_type_to_kind() call at the top of dpif_netlink_rtnl_verify() > ensures that these cases can never be hit, so use OVS_NOT_REACHED() > instead of setting the err to EOPNOTSUPP. > > Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 2/3] dpif-netlink-rtnl: Use getlink() in common verify path.

On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote: > The calls here were duplicated across each tunnel protocol. > > Signed-off-by: Joe Stringer > --- > lib/dpif-netlink-rtnl.c | 100 > +--- > 1 file changed, 43 insertions(+), 57

Re: [ovs-dev] [PATCH 1/3] dpif-netlink-rtnl: Tidy up some code.

On Fri, 2017-05-19 at 13:27 -0700, Joe Stringer wrote: > Simplify and refactor a couple of bits of code for improved readability. > > Signed-off-by: Joe Stringer > --- > lib/dpif-netlink-rtnl.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > >

Re: [ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

On 19 May 2017 at 14:59, Shashank Ram wrote: > xmalloc checks if the size is valid before allocating > memory, and also if the allocation was successful. > > Signed-off-by: Shashank Ram > Applied, thanks! > --- > lib/netdev-windows.c | 14 ++ >

[ovs-dev] [PATCH v2] Windows lib: Use xmalloc instead of malloc

xmalloc checks if the size is valid before allocating memory, and also if the allocation was successful. Signed-off-by: Shashank Ram --- lib/netdev-windows.c | 14 ++ lib/wmi.c| 14 ++ 2 files changed, 4 insertions(+), 24 deletions(-) diff

Re: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

Sure, will send out a v2. Thanks, Shashank From: Alin Serdean Sent: Friday, May 19, 2017 2:51:27 PM To: Shashank Ram; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc Thanks for

Re: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

Thanks for the patch! Xmalloc also check if the allocation was successful. Mind also removing the checks for null afterwards? Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Shashank Ram > Sent:

Re: [ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

Acked-by: Sairam Venugopal On 5/19/17, 2:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: >xmalloc checks if the size is valid before allocating >memory. > >Signed-off-by: Shashank

[ovs-dev] [PATCH] lib Windows: Use xmalloc instead of malloc

xmalloc checks if the size is valid before allocating memory. Signed-off-by: Shashank Ram --- lib/netdev-windows.c | 4 ++-- lib/wmi.c| 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c index

[ovs-dev] [PATCH] windows: Set service status when stop is issued

If the service manager issued a stop service, the control handler registered by the running daemon should report that service changed state. Signed-off-by: Alin Gabriel Serdean --- lib/daemon-windows.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [ovs-dev] [PATCH ovs V8 05/26] dpif: Save added ports in a port map for netdev flow api use

On Tue, May 16, 2017 at 12:16:46PM +0300, Roi Dayan wrote: > > > On 08/05/2017 15:49, Simon Horman wrote: > >On Wed, May 03, 2017 at 06:07:56PM +0300, Roi Dayan wrote: > >>From: Paul Blakey > >> > >>To use netdev flow offloading api, dpifs needs to iterate over > >>added

Re: [ovs-dev] [PATCH] Fix flake8 check

On 19 May 2017 at 05:35, Marcin Mirecki wrote: > On Fri, May 19, 2017 at 2:16 PM, Numan Siddique wrote: > >> >> -- Forwarded message -- >> From: Numan Siddique >> Date: Fri, May 19, 2017 at 11:09 AM >> Subject: Re:

Re: [ovs-dev] [PATCH v5 0/7] create tunnel devices using rtnetlink interface

On 19 May 2017 at 06:22, Eric Garver wrote: > On Thu, May 18, 2017 at 07:48:56PM -0700, Greg Rose wrote: >> On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote: >> > On 18 May 2017 at 15:35, Greg Rose wrote: >> > > On Thu, 2017-05-18 at 16:10 -0400, Eric

[ovs-dev] [PATCH 2/3] dpif-netlink-rtnl: Use getlink() in common verify path.

The calls here were duplicated across each tunnel protocol. Signed-off-by: Joe Stringer --- lib/dpif-netlink-rtnl.c | 100 +--- 1 file changed, 43 insertions(+), 57 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c

[ovs-dev] [PATCH 3/3] dpif-netlink-rtnl: Use OVS_NOT_REACHED in verify.

The vport_type_to_kind() call at the top of dpif_netlink_rtnl_verify() ensures that these cases can never be hit, so use OVS_NOT_REACHED() instead of setting the err to EOPNOTSUPP. Signed-off-by: Joe Stringer --- lib/dpif-netlink-rtnl.c | 2 +- 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH 1/3] dpif-netlink-rtnl: Tidy up some code.

Simplify and refactor a couple of bits of code for improved readability. Signed-off-by: Joe Stringer --- lib/dpif-netlink-rtnl.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c index

[ovs-dev] [PATCH 0/3] Minor refactor on dpif-netlink-rtnl.

This is a short collection of minor style tidyups for the recently merged rtnetlink series. We converge a bit more code into common paths. Joe Stringer (3): dpif-netlink-rtnl: Tidy up some code. dpif-netlink-rtnl: Use getlink() in common verify path. dpif-netlink-rtnl: Use OVS_NOT_REACHED

[ovs-dev] [PATCH v2 2/3] windows: add includes to daemon-windows

Add fatal-signal.h include since it uses: fatal_signal_atexit_handler and fatal_signal_add_hook Use the defined getpid() function and also include since it is defined in include/windows/unistd.h . Signed-off-by: Alin Gabriel Serdean --- v2: change fprintf %d to

[ovs-dev] [PATCH v2 3/3] build-windows: cccl fail compilation on Wimplicit-function-declaration

Gcc compiler argument -Wall contains -Wimplicit-function-declaration which gives warnings when a function is used before declared. Map VStudio compiler error C4013 to it. More info on C4013: https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx At the moment we cannot switch to the equivalent

[ovs-dev] [PATCH v2 1/3] windows: add definition of getpid and getcwd

getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has _getcwd which is defined in : https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx getpid - is used in several files (i.e. lib/vlog.c). getpid is also and deprecated and _getpid should be used:

Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT module in conntrack

> -Original Message- > From: Sairam Venugopal [mailto:vsai...@vmware.com] > Sent: Wednesday, May 17, 2017 9:05 PM > To: Yin Lin ; d...@openvswitch.org > Cc: Alin Serdean > Subject: Re: [ovs-dev] [PATCH v7 2/4] datapath-windows: Add NAT

Re: [ovs-dev] [RFC] packets: Do not initialize ct_orig_tuple.

On 17 May 2017 at 17:54, Joe Stringer wrote: > On 17 May 2017 at 16:26, Darrell Ball wrote: >> >> >> On 5/17/17, 2:19 PM, "Joe Stringer" wrote: >> >> On 16 May 2017 at 21:01, Darrell Ball wrote: >> > >> > >> > On

Re: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py

On Fri, May 19, 2017 at 10:01:19AM +, Bodireddy, Bhanuprakash wrote: > >-Original Message- > >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > >boun...@openvswitch.org] On Behalf Of Stephen Finucane > >Sent: Friday, May 19, 2017 10:15 AM > >To: d...@openvswitch.org > >Subject:

Re: [ovs-dev] [PATCH] coding-style: Fix typo.

On Fri, May 19, 2017 at 07:24:37AM -0700, Greg Rose wrote: > On Thu, 2017-05-18 at 21:27 -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > Documentation/internals/contributing/coding-style.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

On 5/19/17, 6:39 AM, "Ilya Maximets" wrote: On 18.05.2017 16:34, Aaron Conole wrote: > Hi Ilya, > > Ilya Maximets writes: > >> On 17.05.2017 18:32, Darrell Ball wrote: >>> >>> >>> On 5/17/17, 7:59 AM, "Ilya

Re: [ovs-dev] [PATCH] coding-style: Fix typo.

On Thu, 2017-05-18 at 21:27 -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > Documentation/internals/contributing/coding-style.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/internals/contributing/coding-style.rst >

[ovs-dev] Loligo & Cooked Shrimps

Cooked Peeled Cat Tiger Shrimps 10 x 1 kilo / 750 grs net weight Price per box - 10 box - palet   61/70 € 6,25 - € 5,95 - € 5,75   71/90 € 5,95 - € 5,65 - € 5,45 90/120 € 5,45 - € 5,15 - € 4,95 100/200 € 5,25 - € 4,95 - € 4,75 200/300 € 4,95 - € 4,65 - € 4,45 300/500 € 4,50 - € 4,30 - € 4,15

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Use uint8_t for port_id.

On 18.05.2017 16:34, Aaron Conole wrote: > Hi Ilya, > > Ilya Maximets writes: > >> On 17.05.2017 18:32, Darrell Ball wrote: >>> >>> >>> On 5/17/17, 7:59 AM, "Ilya Maximets" wrote: >>> >>> I guess, we need some more opinions about this. >>>

[ovs-dev] [PATCH v4 3/3] netdev-dpdk: Use uint8_t for port_id.

Currently, signed integer is used for 'port_id' variable and '-1' as identifier of bad or uninitialized 'port_id'. This inconsistent with dpdk library and, also, in few cases, leads to passing '-1' to dpdk functions where uint8_t expected. Such behaviour doesn't produce any issues, but it's

[ovs-dev] [PATCH v4 2/3] netdev-dpdk: Fix device leak on port deletion.

Currently, once created device in dpdk will exist forever even after del-port operation untill we manually call 'ovs-appctl netdev-dpdk/detach ', where is not the port's name but the name of dpdk eth device or pci address. Few issues with current implementation: 1. Different API for

[ovs-dev] [PATCH v4 1/3] netdev-dpdk: Fix double attaching of virtual devices.

'devargs' for virtual devices contains not only name but also a list of arguments like this: 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' or 'eth_af_packet0,iface=eth0' We must cut off the arguments from this string before calling 'rte_eth_dev_get_port_by_name()'

[ovs-dev] [PATCH v4 0/3] Hotplug fixes & port_id refactoring

Version 4: * 3rd patch: Introduced typedef dpdk_port_t. Version 3: * 1st patch: Fixed memory leak on error path. (Darrell Ball) (bad initial patch split) * Discussion about patch #3 goes in replies to v1. Re-sent for now (rebased on modified

Re: [ovs-dev] [PATCH v5 0/7] create tunnel devices using rtnetlink interface

On Thu, May 18, 2017 at 07:48:56PM -0700, Greg Rose wrote: > On Thu, 2017-05-18 at 15:53 -0700, Joe Stringer wrote: > > On 18 May 2017 at 15:35, Greg Rose wrote: > > > On Thu, 2017-05-18 at 16:10 -0400, Eric Garver wrote: > > >> This series adds support for the creation of

Re: [ovs-dev] [PATCH] Fix flake8 check

On Fri, May 19, 2017 at 2:16 PM, Numan Siddique wrote: > > -- Forwarded message -- > From: Numan Siddique > Date: Fri, May 19, 2017 at 11:09 AM > Subject: Re: [ovs-dev] [PATCH] Fix flake8 check > To: Terry Wilson >

Re: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13

> From: nusid...@redhat.com > To: d...@openvswitch.org > Sent: Monday, 15 May, 2017 11:39:25 AM > Subject: [ovs-dev] [PATCH v2] python ovs: Fix SSL exceptions with pyOpenSSL v0.13 > > From: Numan Siddique > > Centos provides pyOpenSSL version pyOpenSSL-0.13.1-3.el7.x86_64.

Re: [ovs-dev] [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

On 18/05/17 09:11, Greg KH wrote: So backporting that one patch solves the issue here? Can you please verify it, and let me know before I apply it? thanks, greg k-h yes, I can do that. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py

>-Original Message- >From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >boun...@openvswitch.org] On Behalf Of Stephen Finucane >Sent: Friday, May 19, 2017 10:15 AM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py > >flake8 doesn't like us

[ovs-dev] [PATCH v2 5/6] userspace: Complete Packet In handling

From: Jan Scheurich Send packet_in for non-Ethernet packets. Include packet_type in Packet In for ptap bridges. Signed-off-by: Jan Scheurich --- lib/flow.c | 4 lib/ofp-print.c | 3 +--

[ovs-dev] [PATCH v2 4/6] tests: Added unit tests in packet-type-aware.at

From: Jan Scheurich Packet type-aware unit tests. ptap - create packet-type-aware bridge ptap - legal flow entries in ptap bridge ptap - triangle bridge setup with L2 and L3 GRE tunnels First and second unit tests perform basic verification. The third one is a

[ovs-dev] [PATCH v2 6/6] userspace: Introduce OF 1.5 packet-out

Introduce OpenFlow 1.5 packet-out Partly based on Jean Tourrilhes's work. Add test cases for OF1.5 packet-out Add negative test case for OF1.5 packet-out Modify wildcarding and packet-out test printout. Signed-off-by: Jean Tourrilhes Signed-off-by: Zoltan Balogh

[ovs-dev] [PATCH v2 2/6] userspace: Add bridge property 'packet-type-aware'

From: Jan Scheurich New boolean parameter "other-config:packet-type-aware' in bridge table. Pass non-Ethernet packets unchanged into packet-type-aware bridges. Do not convert packet type when sending packet from packet-type-aware bridge to a port. Only include field

[ovs-dev] [PATCH v2 1/6] userspace: Add OXM field MFF_PACKET_TYPE

From: Jan Scheurich Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite for matching L3 protocols (MPLS, IP, IPv6, ARP etc). Change the meta-flow definition of packet_type field to use the new custom format MFS_PACKET_TYPE representing

[ovs-dev] [PATCH v2 0/6] userspace: Packet type-aware pipeline

This patch set is the 2nd part of an initiative presented by Jan Scheurich: https://mail.openvswitch.org/pipermail/ovs-dev/2017-May/332367.html It takes the patch set referred by the link above as a bases. The goal is to deal with non-Ethernet packets in OVS for advanced use cases like L3

Re: [ovs-dev] [RFC 1/2] doc: Reduce duplication in 'man_pages'

On Fri, 2017-05-19 at 09:11 +, Bodireddy, Bhanuprakash wrote: > The make fails with below error on my fedora 22 Target.  > > error.log-- > > Documentation/conf.py:126:9: F812 list comprehension redefines > 'filename' from

[ovs-dev] [PATCH] doc: Resolve pep8 warnings in conf.py

flake8 doesn't like us redefining variables in loops. Signed-off-by: Stephen Finucane Reported-by: Bhanuprakash Bodireddy Fixes: f15010f ("doc: Reduce duplication in 'man_pages'") Cc: Ben Pfaff --- Documentation/conf.py | 6

Re: [ovs-dev] [RFC 1/2] doc: Reduce duplication in 'man_pages'

The make fails with below error on my fedora 22 Target. error.log-- Documentation/conf.py:126:9: F812 list comprehension redefines 'filename' from line 59 Makefile:5848: recipe for target 'flake8-check' failed make[2]: ***

Re: [ovs-dev] [PATCH v5] netdev-dpdk: fix ifindex assignment for DPDK ports

On 18/05/2017 22:41, Ben Pfaff wrote: On Thu, May 18, 2017 at 06:09:21PM +, Darrell Ball wrote: On 4/4/17, 5:47 PM, "Darrell Ball" wrote: On 4/4/17, 3:09 AM, "Lal, PrzemyslawX" wrote: On 04/04/2017 06:14,

[ovs-dev] [PATCH v3 2/5] rstp: Add rstp port name for human reading.

This patch is useful to debug rstp subsystem and log the port name instead of port number. This patch will also be used to display rstp info for next patches. Signed-off-by: nickcooper-zhangtonghao Acked-by: Jarno Rajahalme --- lib/rstp-common.h | 1 +

[ovs-dev] [PATCH v3 5/5] stp: Add link-state checking support for stp ports.

When bridge stp enabled, we can enable the stp ports despite ports are down. When initializing, this patch checks link-state of ports and enable or disable them according to their link-state. This patch also allow user to enable and disable a port when bridge stp is running. If a stp port is in

[ovs-dev] [PATCH v3 4/5] rstp: Increment the rstp port num counter.

OvS only supports RSTP_MAX_PORTS rstp ports while max port num of stp is STP_MAX_PORTS. This patch increments the rstp port num counter, otherwise the counter is 0 and the checking above will always fail. Signed-off-by: nickcooper-zhangtonghao --- vswitchd/bridge.c | 4

[ovs-dev] [PATCH v3 3/5] rstp: Add the 'ovs-appctl rstp/show' command.

The rstp/show command will help users and developers to get more details about rstp. This patch works together with the previous patches. Signed-off-by: nickcooper-zhangtonghao --- NEWS | 3 +- lib/rstp.c | 114

[ovs-dev] [PATCH v3 1/5] rstp: Init a recursive mutex for rstp.

* This patch will be used for next patch. The 'rstp/show' command, which uses the mutex, calls functions which also use the mutex. We should init it as a recursive mutex. * Because of recursive mutex, this patch remove the OVS_EXCLUDED in list/rstp.[ch] files. * Some rstp tests of OvS, which run

Re: [ovs-dev] [PATCH v2 1/5] rstp: Init a recursive mutex for rstp.

> On May 19, 2017, at 6:47 AM, Ben Pfaff wrote: > > On Wed, May 10, 2017 at 04:15:02AM -0700, nickcooper-zhangtonghao wrote: >> * This patch will be used for next patch. The 'rstp/show' command, >> which uses the mutex, calls functions which also use the mutex. >> We should init