Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

Great idea, this can process actions like "ct(...nat),recirc(...),output(...)" correctly, output packet will be a NATed packet Before implementing your idea, how deal with my patch? 1: drop it 2:accept it for fixing limited scenario (i will do checkpatch) What's your suggestion? 在

[ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

tart a virtual machine with its backend tap device attached to a brought up linux bridge. If we delete the linux bridge when vm is still running, we'll get the following error when trying to create a ovs bridge with the same name. The reason is that ovs-router subsystem add the linux bridge

Re: [ovs-dev] [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when deleted

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, June 15, 2017 5:25 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Wed, Jun 14, 2017 at 01:44:37PM +0800,

[ovs-dev] [PATCH] datapath-windows: use NlAttrGet() in Conntrack.c

Couple of minor fixes that got flagged with a static checker. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Conntrack.c| 14 ++ datapath-windows/ovsext/Netlink/Netlink.c | 2 +- datapath-windows/ovsext/Netlink/NetlinkProto.h | 2 +- 3

Re: [ovs-dev] [PATCH 31/31] fixup: Allow non-Ethernet packets anywhere.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 31/31] fixup: Allow non-Ethernet

Re: [ovs-dev] [PATCH 25/31] fixup: Don't suppress packet_type.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 25/31] fixup: Don't suppress

Re: [ovs-dev] [PATCH 30/31] fixup: Update test expected results.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 30/31] fixup: Update test expected

Re: [ovs-dev] [PATCH 26/31] fixup: Remove root-only test.

Originally this test was using patch ports to carry tunnels instead of the veth pairs and didn't require root privileges. When "Avoid recirculation at tx to tunnel ports" was merged and we rebased to master tunnel over patch ports were broken and we decided as a work-around to replace patch

Re: [ovs-dev] [PATCH 28/31] fixup: Make tests set legacy-l3-pipeline instead of packet-type-aware.

See discussion for patch 15/31. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 28/31]

Re: [ovs-dev] [PATCH 22/31] fixup: Adapt tests to revised policy.

Agreed. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 22/31] fixup: Adapt tests to

Re: [ovs-dev] [PATCH 20/31] fixup: Clarify how legacy L3 tunnels work.

See my response to patch 15/31. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 20/31]

Re: [ovs-dev] [PATCH 19/31] fixup: Coding style.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 19/31] fixup: Coding style. > >

Re: [ovs-dev] [PATCH 18/31] fixup: Fix locking in netdev-native-tnl.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 18/31] fixup: Fix locking in

Re: [ovs-dev] [PATCH 15/31] fixup: Change from global modal behavior to L3 tunnel only mode.

We do understand your motivation for proposing this. But such change is a significant and requires careful consideration. We need to satisfy four main requirements: 1. Legacy controllers that are not packet-type aware must not be affected by the introduction of packet_type in OVS. The

Re: [ovs-dev] [PATCH] openflow.rst: Update to reflect current status.

On 06/14/2017 08:21 AM, Ben Pfaff wrote: OpenFlow 1.1 and 1.2 support is complete. Simon Horman is not known to be working on flow entry notifications. Signed-off-by: Ben Pfaff --- Documentation/topics/openflow.rst | 23 +++ 1 file changed, 3

Re: [ovs-dev] [PATCH] ovs-ctl: allow gdb as a wrapper

Ben Pfaff writes: > On Mon, Jun 12, 2017 at 04:39:51PM -0400, Aaron Conole wrote: >> It has been useful to attach gdb to the running process. With this commit >> we make it a little easier, as the daemon will have a gdbserver process >> attached and listening on a specific port.

Re: [ovs-dev] [PATCH v2] tnl-ports: Remove netdevs in netdev_hash when deleted

On Wed, Jun 14, 2017 at 01:44:37PM +0800, fukaige wrote: > Start a virtual machine with its backend tap device attached to a brought up > linux bridge. > If we delete the linux bridge when vm is still running, we'll get the > following error when > trying to create a ovs bridge with the same

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: add support for per-flow drop counters

On Tue, Jun 13, 2017 at 02:25:15PM +0100, Przemyslaw Szczerbik wrote: > Patch based on RFC 5102, section 5.10. It implements per-flow drop counters: > - droppedPacketDeltaCount > - droppedPacketTotalCount > - droppedOctetDeltaCount > - droppedOctetTotalCount > > In order to determine if packet is

Re: [ovs-dev] [PATCH] ovs-ctl: allow gdb as a wrapper

On Mon, Jun 12, 2017 at 04:39:51PM -0400, Aaron Conole wrote: > It has been useful to attach gdb to the running process. With this commit > we make it a little easier, as the daemon will have a gdbserver process > attached and listening on a specific port. > > Signed-off-by: Aaron Conole

Re: [ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

On Fri, Jun 09, 2017 at 01:26:51PM +0530, SatyaValli wrote: > commit 49a3592b2878a33033e5fd2e6e5ce82ebccef780 > Author: Satya Valli > > OpenVswitch: OF1.5/EXT-334 Extensible Flow Entry Statistics > > OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining

Re: [ovs-dev] [PATCH v3] netdev-dpdk: round up mbuf_size to cache_line_size

On Tue, Jun 13, 2017 at 10:52:03AM +0530, santosh wrote: > Hi Ben, > > On Monday 12 June 2017 08:30 PM, Stokes, Ian wrote: > > >> Some pmd driver(e.g: vNIC thunderx PMD) want mbuf_size to be multiple of > >> cache_line_size. With out this fix, Netdev-dpdk initialization would fail > >> for those

Re: [ovs-dev] [PATCH 0/2] Debian: refactor development packages

On Thu, Jun 08, 2017 at 01:47:01PM -0700, b...@skyportsystems.com wrote: > From: Ben Warren > > The existing packages were not configured properly for > cross-compilation. In particular, development packages and their > dependencies should not require executables. > >

Re: [ovs-dev] [PATCH] Add a git-checkpatches script

On Thu, Jun 08, 2017 at 12:39:27PM +, majop...@redhat.com wrote: > From: Miguel Angel Ajo > > This utility script exports the on the tail of your current branch, > and runs utilities/checkpatch.py on each of them. > > Signed-off-by: Miguel Angel Ajo

[ovs-dev] [PATCH] checkpatch: Support checking recent commits in the current repo.

Requested-by: Miguel Angel Ajo Signed-off-by: Ben Pfaff --- utilities/checkpatch.py | 65 + 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

On 14 June 2017 at 11:43, Joe Stringer wrote: > On 14 June 2017 at 05:04, wei wrote: >> ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be >> executed together. > > Hi, thanks for the contribution. > > There's a few things in this patch

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

As discussed on IRC let's meet tomorrow at 9am EST to talk about the topic on IRC. El 14 jun. 2017 9:02 p. m., "Russell Bryant" escribió: On Wed, Jun 14, 2017 at 2:40 PM, Miguel Angel Ajo Pelayo wrote: > Hi, sorry, I didn't see your comments this

Re: [ovs-dev] [PATCH] ovs-ofctl: New option "--no-stats" for "ovs-ofctl dump-flows".

On Wed, Jun 14, 2017 at 02:26:04PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > It's pretty common to want to omit statistics from output, to make it > > easier to read. This commit adds an ovs-ofctl option to make that easy. > > > > A lot of the OVS internal tests could

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional misaligned reference to ovs_u128.

On Wed, Jun 14, 2017 at 01:23:35PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Cc: "Ben Pfaff" > > Sent: Wednesday, 14 June, 2017 12:24:57 PM > > Subject: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional > >

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

On Wed, Jun 14, 2017 at 2:40 PM, Miguel Angel Ajo Pelayo wrote: > Hi, sorry, I didn't see your comments this morning. Thanks a lot for all the > feedback, I'll shuffle things around. > > I thought about something like adding new columns too, but I didn't manage > to come up

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

On 14 June 2017 at 05:04, wei wrote: > ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be > executed together. Hi, thanks for the contribution. There's a few things in this patch that do not match standard OVS contribution guidelines. Using

Re: [ovs-dev] [PATCH 11/31] fixup: Wrap docs to 79 columns.

On Wed, Jun 14, 2017 at 06:28:17PM +, Jan Scheurich wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org > > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > > Sent: Tuesday, 13 June, 2017 00:29 > > To: d...@openvswitch.org > > Cc: Ben Pfaff

Re: [ovs-dev] [PATCH 16/31] ofp-util: Remove prototype for unimplemented function.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 16/31] ofp-util: Remove prototype

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

Hi, sorry, I didn't see your comments this morning. Thanks a lot for all the feedback, I'll shuffle things around. I thought about something like adding new columns too, but I didn't manage to come up with anything that didn't make it less intuitive. The disadvantage of the current format is

Re: [ovs-dev] [PATCH 14/31] nx-match: Add context argument to nxm_put__().

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 14/31] nx-match: Add context

Re: [ovs-dev] [PATCH 06/31] fixup: Always match on packet_type in datapath flows.

We agree to the proposal to always match on packet_type in the datapath. It also makes sense to suppress packet_type=eth matches in *OpenFlow* flow entries. However, we have noticed that the same format_match() function is apparently also used in formatting Megaflow entries, e.g. in the context

Re: [ovs-dev] [PATCH 13/31] ofpbuf: New function ofpbuf_insert().

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 13/31] ofpbuf: New function

Re: [ovs-dev] [PATCH 12/31] fixup: Move compose_output_action__() code back where it started.

We believe the move was necessary in an earlier version of the patch series that was based on the now reverted patch to avoid recirculation at tx to native tunnel ports. As it is now, we cannot see any strong reason to have it in either place. Perhaps this needs to be revisited when the

Re: [ovs-dev] [PATCH] odp-util: Avoid misaligned references to ip6_hdr.

On Wed, Jun 14, 2017 at 12:32:07PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Cc: "Ben Pfaff" , "Lance Richardson" > > Sent: Wednesday, 14 June, 2017 11:38:07 AM > > Subject: [PATCH] odp-util: Avoid

Re: [ovs-dev] [PATCH 11/31] fixup: Wrap docs to 79 columns.

> -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 11/31] fixup: Wrap docs to 79 columns.

Re: [ovs-dev] [PATCH] ovs-ofctl: New option "--no-stats" for "ovs-ofctl dump-flows".

Ben Pfaff writes: > It's pretty common to want to omit statistics from output, to make it > easier to read. This commit adds an ovs-ofctl option to make that easy. > > A lot of the OVS internal tests could use this, too, in place of > ofctl_strip. This commit adopts it for a

Re: [ovs-dev] [PATCH 10/31] fixup: Revalidate if 'packet-type-aware' setting changes.

Good spot! Definitely needed. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 10/31]

Re: [ovs-dev] [PATCH 07/31] ofp-parse: Allow "packet_type(0, 0)" to be abbreviated "eth".

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 07/31] ofp-parse: Allow

Re: [ovs-dev] [PATCH 09/31] fixup: Need OFPBMC_BAD_TYPE in OF1.0 since it can now be used there.

OK > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 09/31] fixup: Need OFPBMC_BAD_TYPE

Re: [ovs-dev] [PATCH 05/31] fixup: Coding style.

OK. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:29 > To: d...@openvswitch.org > Cc: Ben Pfaff > Subject: [ovs-dev] [PATCH 05/31] fixup: Coding style. > >

Re: [ovs-dev] [PATCH 04/31] fixup: Improve documentation.

These changes look good but need to be subject to major rewriting if property packet-type-aware is removed. > -Original Message- > From: ovs-dev-boun...@openvswitch.org > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff > Sent: Tuesday, 13 June, 2017 00:28 > To:

Re: [ovs-dev] [PATCH 03/31] fixup: Make packet_type formatting more like other fields.

Makes perfect sense to realize packet_type formatting with standard tools. Thanks for simplifying the code. We have noted one thing, though: Previously the ID of packet types in name space Ethertype were formatted in hex, while with your patch in decimal, i.e. (1.2048) instead of (1,0x800) for

Re: [ovs-dev] [PATCH 02/31] fixup: packet_type originated in OpenFlow 1.5, not 1.3.

This is not any kind of rejection. Open vSwitch accepts any OXM as part of a flow for any version of OpenFlow. It is merely a correction to the documentation. On Wed, Jun 14, 2017 at 06:11:42PM +, Jan Scheurich wrote: > Agree, packet type was introduced only in OF 1.5. > > The intention

Re: [ovs-dev] [PATCH 02/31] fixup: packet_type originated in OpenFlow 1.5, not 1.3.

Agree, packet type was introduced only in OF 1.5. The intention with making packet type match field available from OF 1.3 was to allow SDN controllers to consume this functionality without having to implement the OF 1.5 wire protocol and (associated) the support of multiple OF versions in

Re: [ovs-dev] OVN Load Balancing Feedback

On 13 June 2017 at 13:26, Ethan Jackson wrote: > Sure that makes sense. I guess what's a little weird is that the load > balancer lives on the logical switch instead of the logical router. > Typically, when I think of a load balancer in the real world, it *is* > a router that

Re: [ovs-dev] [PATCH 00/31] Packet type aware pipeline

Hi Ben, Thanks a lot for the comprehensive review of our PTAP series and for the constructive improvement proposals. Zoltan and I have now gone through your fixup patches and analyzed them in the context of the overall solution and the use cases we need to cover. We will provide comments in

[ovs-dev] Sync on PTAP, EXT-382 and NSH - Fri 2017-06-16 17:00 CET

Hi, Main purpose of this sync meeting is to agree on final technical solution for PTAP to allow merging of that patch series and to establish a stable base for Generic Encap/Decap and NSH patch series. Target is still to upstream these changes in time for OVS 2.8. Thank you, Jan Link to the

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional misaligned reference to ovs_u128.

> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" > Sent: Wednesday, 14 June, 2017 12:24:57 PM > Subject: [ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional > misaligned reference to ovs_u128. > > nl_msg_put_unspec_uninit() can return a

Re: [ovs-dev] [PATCH 2/3] netlink: Introduce helpers for 128-bit integer attributes.

> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" , "Lance Richardson" > Sent: Wednesday, 14 June, 2017 12:24:56 PM > Subject: [PATCH 2/3] netlink: Introduce helpers for 128-bit integer > attributes. > > Use the helpers in

Re: [ovs-dev] [PATCH 1/3] unaligned: Introduce helpers for 32-bit aligned 128-bit integers.

> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" > Sent: Wednesday, 14 June, 2017 12:24:55 PM > Subject: [ovs-dev] [PATCH 1/3] unaligned: Introduce helpers for 32-bit > aligned 128-bit integers. > > These are analogous to the existing helpers

Re: [ovs-dev] Please Reply

Dear Sir, I am Latifah Seki, the only daughter of late Mr. Benjamin Seki. I am 18 years old and My late father was a wealthy cocoa and farmer and president of the cocoa and coffee farmers cooperative union. I have very important thing to discuss with you, please reply. Thank you, Latifah Seki.

Re: [ovs-dev] [PATCH] odp-util: Avoid misaligned references to ip6_hdr.

> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" , "Lance Richardson" > Sent: Wednesday, 14 June, 2017 11:38:07 AM > Subject: [PATCH] odp-util: Avoid misaligned references to ip6_hdr. > > Found by GCC -fsanitize=undefined. > >

Re: [ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

On Wed, Jun 14, 2017 at 06:21:50PM +0200, Eelco Chaudron wrote: > On 02/06/17 00:25, Ben Pfaff wrote: > >On Thu, Jun 01, 2017 at 02:38:09PM +0200, Eelco Chaudron wrote: > >>When trying to configure a system port as type=internal it could start > >>an infinite port creation loop. When this happens

Re: [ovs-dev] [PATCH] treewide: undefined behavior, passing null in nonnull parameters

On Tue, Jun 13, 2017 at 01:08:52PM -0400, Lance Richardson wrote: > This patch addresses all ubsan errors of the "null vs. nonnull" flavor. > The remaining errors are: > > $ grep runtime tests/testsuite.dir/*/testsuite.log > tests/testsuite.dir/0044/testsuite.log:+tests/test-hash.c:59:40: runtime

[ovs-dev] [PATCH 3/3] ofproto-dpif-xlate: Fix an additional misaligned reference to ovs_u128.

nl_msg_put_unspec_uninit() can return a pointer that is only 4-byte aligned. Signed-off-by: Ben Pfaff --- lib/odp-util.c | 11 +++ ofproto/ofproto-dpif-xlate.c | 11 +-- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/odp-util.c

[ovs-dev] [PATCH 2/3] netlink: Introduce helpers for 128-bit integer attributes.

Use the helpers in appropriate places. In most cases, this fixes a misaligned reference, since ovs_be128 and ovs_u128 require 8-byte alignment but Netlink only guarantees 4-byte. Found by GCC -fsanitize=undefined. Reported-by: Lance Richardson Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH 1/3] unaligned: Introduce helpers for 32-bit aligned 128-bit integers.

These are analogous to the existing helpers for 32-bit aligned 64-bit integers, and will have users in upcoming commits. Signed-off-by: Ben Pfaff --- include/openvswitch/types.h | 12 lib/unaligned.h | 39 +++ 2 files

Re: [ovs-dev] [PATCH] netdev: Fix netdev_open() to adhere to class type if given

On 02/06/17 00:25, Ben Pfaff wrote: On Thu, Jun 01, 2017 at 02:38:09PM +0200, Eelco Chaudron wrote: When trying to configure a system port as type=internal it could start an infinite port creation loop. When this happens you will see the following log messages: ... So the fix as presented

[ovs-dev] [PATCH] odp-util: Avoid misaligned references to ip6_hdr.

Found by GCC -fsanitize=undefined. Reported-by: Lance Richardson Signed-off-by: Ben Pfaff --- lib/odp-util.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/odp-util.c b/lib/odp-util.c index

[ovs-dev] [PATCH] openflow.rst: Update to reflect current status.

OpenFlow 1.1 and 1.2 support is complete. Simon Horman is not known to be working on flow entry notifications. Signed-off-by: Ben Pfaff --- Documentation/topics/openflow.rst | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git

Re: [ovs-dev] [RFC PATCH 00/21] Add OVS DPDK keep-alive functionality

Hi Aaron, >Hi Bhanu, > >I've been playing with this a little bit; is it too late to consider tracking >'threads' >instead of 'cores'? I'm not sure what it means for a particular core ID to be >'healthy' - but I know what 'pmd24' not responding means. That's an interesting input. It's not late

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid read overrun in ofperr_decode_msg().

On Tue, Jun 13, 2017 at 10:59:39PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: "Jarno Rajahalme" > > Cc: d...@openvswitch.org, "Lance Richardson" > > Sent: Tuesday, 13 June, 2017 8:10:22 PM > > Subject: Re: [PATCH] ovs-ofctl:

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

On Tue, Jun 13, 2017 at 06:03:30PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration tc-policy option that controls tc > flower flag. Possible options are none, skip_sw, skip_hw. > The default is none which is to insert the rule both to sw and hw. > This

[ovs-dev] domicile et entreprise

PEURS - TABAC - MINCEUR - STRESS - CONFIANCEETUDES - PHOBIES - TRAVAIL - ENFANTSTROUBLES SEXUELS - MOTIVATION - REGLES DOULOUREUSES ... Mickal Solomon Cliquez ICI pour visiter mon site Hypnothrapeute Coach PNL Formateur en Hypnose Certifi par laNational Guild of Hypnotists (U.S.A. - CANADA)

Re: [ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

that is for this problem [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway https://mail.openvswitch.org/pipermail/ovs-dev/2017-April/330536.html Previous patch [PATCH] ovn-northd: Add logical flows to reply ICMP echo requests for all the other router ports connected to

[ovs-dev] [PATCH] dpif: execute ct together with recirc when slow path

ct(table=X,zone=X) will xlate 2 actions (ct and recirc), so they should be executed together. --- lib/dpif.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index fe6a986c5..72274731a 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@

[ovs-dev] Payment Advice

Dear Sir, Please refer to the attachment for details of payment. Thank & Best Regards Operation Manager --___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

On Wed, Jun 14, 2017 at 10:17:54AM +0200, Simon Horman wrote: > On Tue, Jun 13, 2017 at 06:03:30PM +0300, Roi Dayan wrote: > > From: Paul Blakey > > > > Add a new configuration tc-policy option that controls tc > > flower flag. Possible options are none, skip_sw, skip_hw. > >

Re: [ovs-dev] [PATCH V11 07/33] other-config: Add hw-offload switch to control netdev flow offloading

On Tue, Jun 13, 2017 at 06:03:29PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration option - hw-offload that enables netdev > flow api. Enabling this option will allow offloading flows > using netdev implementation instead of the kernel datapath. > This

Re: [ovs-dev] [PATCH V11 06/33] netdev: Adding a new netdev API to be used for offloading flows

On Tue, Jun 13, 2017 at 06:03:28PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new API interface for offloading dpif flows to netdev. > The API consist on the following: > flow_put - offload a new flow > flow_get - query an offloaded flow > flow_del - delete

Re: [ovs-dev] [PATCH V11 05/33] tc: Add tc flower functions

On Tue, Jun 13, 2017 at 06:03:27PM +0300, Roi Dayan wrote: > Add tc helper functions to query and manipulate the flower classifier. > > Signed-off-by: Paul Blakey > Co-authored-by: Roi Dayan > Signed-off-by: Roi Dayan > Acked-by: Flavio

Re: [ovs-dev] [PATCH V11 04/33] tc: Move functions the create/parse handle to be static inline

On Tue, Jun 13, 2017 at 06:03:26PM +0300, Roi Dayan wrote: > Those functions are just wrappers to available macros for readability. > Move them to tc.h to avoid function-call overhead. > > Signed-off-by: Roi Dayan > Acked-by: Flavio Leitner Thanks, applied

Re: [ovs-dev] [PATCH V11 03/33] tc: Refactor tcm handle assignment when creating filter qdisc

On Tue, Jun 13, 2017 at 06:03:25PM +0300, Roi Dayan wrote: > Use the available TC macros instead of 0x. > > Signed-off-by: Roi Dayan > Acked-by: Flavio Leitner Thanks, applied to master. ___ dev mailing list

Re: [ovs-dev] [PATCH V11 02/33] tc: Introduce tc module

On Tue, Jun 13, 2017 at 06:03:24PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add tc module to expose tc operations to be used by other modules. > Move some tc related functions from netdev-linux.c to tc.c > This patch doesn't change any functionality. > >

Re: [ovs-dev] [PATCH V11 01/33] netdev-linux: Refactor two tc functions

On Tue, Jun 13, 2017 at 06:03:23PM +0300, Roi Dayan wrote: > Refactor tc_make_request and tc_add_del_ingress_qdisc to accept > ifindex instead of netdev struct. > We later want to move those outside netdev-linux module to be > used by other modules. > This patch doesn't change any functionality. >

Re: [ovs-dev] [PATCH V11 08/33] other-config: Add tc-policy switch to control tc flower flag

On Tue, Jun 13, 2017 at 06:03:30PM +0300, Roi Dayan wrote: > From: Paul Blakey > > Add a new configuration tc-policy option that controls tc > flower flag. Possible options are none, skip_sw, skip_hw. > The default is none which is to insert the rule both to sw and hw. > This