Hi Flavio,
I did not configure IP address to the interface, simply brought up the
interface br0 using ifconfig and see this issue consistently.
$ ifconfig br0 up
Regards,
Vishal
-Original Message-
From: Flavio Leitner [mailto:f...@sysclose.org]
Sent: Tuesday, June 20, 2017 12:32 AM
To
The use case is if someone wants to access a VM from on-prem then it is an
l3vpn and we should not do SNAT for it. Both sides should be using their
logical IPs.
However the match for “nosnat” should be on destination IP.
I will rebase it to current master and run the tests.
Regards
- Manoj
Fro
On Fri, Jun 16, 2017 at 7:42 PM, Brian Haley wrote:
> On 06/15/2017 04:39 AM, nusid...@redhat.com wrote:
>
>> From: Numan Siddique
>>
>> Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and
>> renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6
>> Router Advertisement, will
When we use the 'ovs-appctl rstp/show', the root bridge
of rstp is always 'unknown root port'. We don't expect
that. The reason is that the committer added the check
for var 'p'. In the rstp, if a bridge is root bridge,
there is not root port, and we don't use the root port
'p', 'rstp/show' in the
On Mon, Jun 19, 2017 at 07:54:00PM +0100, Bhanuprakash Bodireddy wrote:
> sorted_poll_list() returns the sorted list of rxqs mapped to PMD thread
> along with the rxq count. Skip sorting the list if there are no rxqs
> mapped to the PMD thread. This can be reproduced with manual pinning and
> 'dpif
On Mon, Jun 19, 2017 at 07:54:01PM +0100, Bhanuprakash Bodireddy wrote:
> Clang reports "Argument with 'nonnull' attribute passed null" warning.
>
> Signed-off-by: Bhanuprakash Bodireddy
Thanks! Applied to master and branch-2.7.
___
dev mailing list
d
On Mon, Jun 19, 2017 at 07:53:59PM +0100, Bhanuprakash Bodireddy wrote:
> As part of retrieving system statistics, process status APIs along with
> helper functions were implemented. Some of them are very generic and can
> be reused by other subsystems.
>
> Move the APIs in system-stats.c to proce
Until now, ODP output only showed port names for in_port matches. This
commit shows them in other places port numbers appear.
Signed-off-by: Ben Pfaff
---
lib/dpctl.c | 8 ++--
lib/dpif-netdev.c| 2 +-
lib/dpif.c | 4 +-
lib/odp-util.c
Until now, printing names in "ovs-dpctl dump-flows" was tied to the overall
output verbosity, which in practice meant that to see port names a user had
to see a distracting amount of verbosity. This decouples names from
verbosity.
I'd like to make showing names the default for interactive usage,
This helps to make datapath flows user friendly, like OpenFlow flows are
now as well. There's still room for improvement but I think that this is a
step in the right direction.
I split this off from the packet type aware pipeline series as it wasn't
directly relevant.
Ben Pfaff (2):
ovs-dpctl:
From: Jan Scheurich
Allow packet type namespace OFPHTN_ETHERTYPE as alternative pre-requisite
for matching L3 protocols (MPLS, IP, IPv6, ARP etc).
Change the meta-flow definition of packet_type field to use the new
custom format MFS_PACKET_TYPE representing "(NS,NS_TYPE)".
Parsing routine for M
From: Zoltán Balogh
Introducing packet_type in OF 1.5 packet-out.
Partly based on Jean Tourrilhes's work.
Add test cases for OF1.5 packet-out
Add negative test case for OF1.5 packet-out
Modify wildcarding and packet-out test printout.
Signed-off-by: Jean Tourrilhes
Signed-off-by: Zoltan Balogh
From: Jan Scheurich
ptap - create packet-type-aware bridge
ptap - legal flow entries in ptap bridge
ptap - triangle bridge setup with L2 and L3 GRE tunnels
First and second unit tests perform basic verification.
The third one is a triangular bridge setup test case. It tests dataplane
in non-
In netdev_gre_build_header(), GRE protocol and VXLAN next_potocol is set based
on packet_type of flow. If it's about an Ethernet packet, it is set to
ETP_TYPE_TEB. Otherwise, if the name space is OFPHTN_ETHERNET, it is set
according to the name space type.
Signed-off-by: Jan Scheurich
Signed-off-
From: Jan Scheurich
Send packet_in for non-Ethernet packets.
Include packet_type in Packet In for ptap bridges.
Signed-off-by: Jan Scheurich
Signed-off-by: Ben Pfaff
---
lib/flow.c | 4
lib/ofp-print.c | 7 +++
ofproto/ofproto-dpif-xlate.c | 5 -
3
An upcoming commit will need to pass an extra piece of data from
nx_put_raw() into all of its direct and indirect calls to nxm_put__().
This commit prepares for that by switching from a "struct ofpbuf *"
parameter to a context structure that, currently, contains just a
struct ofpbuf *. The upcomin
This will receive its first users in an upcoming commit.
Signed-off-by: Ben Pfaff
---
include/openvswitch/ofpbuf.h | 1 +
lib/ofpbuf.c | 18 ++
2 files changed, 19 insertions(+)
diff --git a/include/openvswitch/ofpbuf.h b/include/openvswitch/ofpbuf.h
index bc25b
This series is based on Zoltan Balogh's series here:
https://patchwork.ozlabs.org/patch/770490/
https://patchwork.ozlabs.org/patch/770487/
https://patchwork.ozlabs.org/patch/770495/
https://patchwork.ozlabs.org/patch/770498/
https://patchwork.ozlabs.org/patch/770488/
https://patchwork.ozlabs.org/pa
Thanks for reporting that. I changed this paragraph to:
Open vSwitch 2.8 and later implement the ``packet type-aware pipeline''
concept introduced in OpenFlow 1.5. Such a pipeline does not have any root
fields. Instead, a new metadata field, ,
indicates the basic type of the
Thanks. I'll fold that in for the next version.
On Mon, Jun 19, 2017 at 03:53:31PM +, Zoltán Balogh wrote:
> Hi Ben,
>
> The bridge property 'other-config:legacy-l3-pipeline' is obsolete, so the 3
> lines starting at line 4197 in ofproto.at can be removed.
>
> > +AT_CHECK([
> > +ovs-vs
On Mon, Jun 19, 2017 at 01:26:54PM +0530, Satyavalli Rama wrote:
> Hi Ben,
>
> Much Thanks for your initial reveiw comments.
> We have addressed almost all problems and re-submitted the patch except the
> below two lines.
>
> "checkpatch" reports:
>
> warning: 1 line adds whitespace errors.
On Mon, Jun 19, 2017 at 04:11:01PM +, Zoltán Balogh wrote:
> Hi Ben,
>
> I've been testing L2/L3 tunneling and ptap ports receiving/transmitting L2
> and L3 packets.
> I observed, that 'ovs-appctl dpctl/dump-flows' prints out packet_type 'id' in
> decimal format.
> For instance, in case of
On 13 June 2017 at 08:03, Roi Dayan wrote:
> From: Paul Blakey
>
> To use netdev flow offloading api, dpifs needs to iterate over
> added ports. This addition inserts the added dpif ports in a hash map,
> The map will also be used to translate dpif ports to netdevs.
>
> Signed-off-by: Paul Blakey
On Mon, Jun 19, 2017 at 02:29:47PM +, Jan Scheurich wrote:
> Thanks, Ben, for the updated series.
>
> I suggest to decouple the port name related patches.
> We will test and review the remaining patches and have a look at the PTAP
> unit tests and provide fixes to the test (or bugfixes to the
Thanks Jan and Nick, I applied this to master.
On Mon, Jun 19, 2017 at 01:02:17PM +, Jan Scheurich wrote:
> Acked-by: Jan Scheurich
>
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org
> > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
> > Sent: Monday
On Mon, Jun 19, 2017 at 10:26:56AM +, Zoltán Balogh wrote:
> >
> > A new concern came up while thinking about this series. The
> > OVS_ATTR_PACKET_TYPE does not appear to be implemented in the kernel
> > module, and what's more, because of #ifdefs, OVS_ATTR_PACKET_TYPE will
> > actually have
This wasn't clear before.
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-June/334271.html
Signed-off-by: Ben Pfaff
---
datapath/linux/compat/include/linux/openvswitch.h | 4
1 file changed, 4 insertions(+)
diff --git a/datapath/linux/compat/include/linux/openvswitch.h
b
On Mon, Jun 19, 2017 at 07:59:39PM +0100, William Stevenson wrote:
> A few trivial fixes to vhost-user documentation including a syntax
> error in the included xml file.
>
> Signed-off-by: William Stevenson
Thanks! I applied this to master and branch-2.7.
___
On 19 June 2017 at 15:05, Greg Rose wrote:
> On 06/19/2017 02:33 PM, Joe Stringer wrote:
>>
>> Fix minor style variations and unnecessary includes.
>>
>> Signed-off-by: Joe Stringer
>> ---
>> lib/netdev-linux.c | 1 +
>> lib/netdev-tc-offloads.c | 11 ++-
>> lib/tc.c
On 06/19/2017 02:33 PM, Joe Stringer wrote:
Fix minor style variations and unnecessary includes.
Signed-off-by: Joe Stringer
---
lib/netdev-linux.c | 1 +
lib/netdev-tc-offloads.c | 11 ++-
lib/tc.c | 6 --
lib/tc.h | 4 ++--
4 files ch
On 06/19/2017 01:36 PM, Joe Stringer wrote:
On 19 June 2017 at 11:44, Joe Stringer wrote:
> On 16 June 2017 at 16:37, Greg Rose wrote:
>> The attribute __ro_after_init was introduced in Linux kernel 4.5. If
>> a data structure is given this attribute then after the driver module
>> loads the m
linux/pkt_cls.h indirectly includes linux/stddef.h, which may define
__always_inline when using Linux kernel headers 4.6 or later.
netinet/in.h indirectly includes sys/cdefs.h, which before Glibc 2.24
would unconditionally define __always_inline.
This combination of headers causes compilation fai
Fix minor style variations and unnecessary includes.
Signed-off-by: Joe Stringer
---
lib/netdev-linux.c | 1 +
lib/netdev-tc-offloads.c | 11 ++-
lib/tc.c | 6 --
lib/tc.h | 4 ++--
4 files changed, 13 insertions(+), 9 deletions(-)
diff --git
When the openvswitch-switch package is installed, postinst script
is used to make a call to /etc/init.d/openvswitch-switch with
"restart" as the command. openvswitch-switch.init inturn would carefully
restart OVS by saving the openflow flows and replacing the kernel
module only when needed.
With r
The most recent version of debian (and Ubuntu) has
moved towards systemd in a way that many calls to
openvswitch startup scripts get redirected to runtime
generated systemd files.
For e.g commands like 'service openvswitch-switch restart'
or 'invoke-rc.d openvswitch-switch restart' etc will
call '
On 19 June 2017 at 11:44, Joe Stringer wrote:
> On 16 June 2017 at 16:37, Greg Rose wrote:
>> The attribute __ro_after_init was introduced in Linux kernel 4.5. If
>> a data structure is given this attribute then after the driver module
>> loads the memory page where the data resides will be mark
Hi,
Would you be interested in an email lead list of Supply Chain Executives? We
can help you reach out to key Top decision makers like:
Title includes:
* VP of Supply Chain
* Director of Supply Chain
* Supply Chain Manager
* Purchasing Manager
* Purchasing Director
* Procu
On 19 June 2017 at 12:16, Manoj Sharma wrote:
> Hi Guru,
>
> It looked very useful patch. Do you plan to commit it into main?
> Was there any reason to not merge it so far?
>
Is there a use case for which you want to use it? What is the use case?
This is an old patch and if you think it is usefu
On 19 June 2017 at 05:26, Flavio Leitner wrote:
> On Thu, Jun 15, 2017 at 04:36:49PM -0700, Joe Stringer wrote:
>> Currently, the set of flows that may be offloaded is very small compared
>> to the overall capabilities of the OpenFlow support in OVS. In the
>> majority of cases, if a user attempts
Hi Guru,
It looked very useful patch. Do you plan to commit it into main?
Was there any reason to not merge it so far?
Regards
- Manoj
On 11/3/16, 3:46 AM, "dev on behalf of Gurucharan Shetty"
wrote:
>We currently have the ability to add a large network to
>match on the source IP address of
A few trivial fixes to vhost-user documentation including a syntax
error in the included xml file.
Signed-off-by: William Stevenson
---
Documentation/topics/dpdk/vhost-user.rst | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/topics/dpdk/vhost-user.rst
b
Clang reports that value store to 'batch_size' is never read.
Signed-off-by: Bhanuprakash Bodireddy
---
tests/test-conntrack.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/test-conntrack.c b/tests/test-conntrack.c
index f79a9fc..5d2f8b8 100644
--- a/tests/test-conntrack.c
+++ b/tests
Clang reports that array access from 'dumps' variable result in null pointer
dereference.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/netdev.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index 001b7b3..336c141 100644
--- a/li
Clang reports variable 'ifmsg' never been used in the function.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpif-netlink-rtnl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/dpif-netlink-rtnl.c b/lib/dpif-netlink-rtnl.c
index c3c31eb..17ae24a 100644
--- a/lib/dpif-
Clang reports "Argument with 'nonnull' attribute passed null" warning.
Signed-off-by: Bhanuprakash Bodireddy
---
lib/dpctl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 7f44d02..2ad475b 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -555,
As part of retrieving system statistics, process status APIs along with
helper functions were implemented. Some of them are very generic and can
be reused by other subsystems.
Move the APIs in system-stats.c to process.c and util.c and make them
available. This patch doesn't change any functionali
sorted_poll_list() returns the sorted list of rxqs mapped to PMD thread
along with the rxq count. Skip sorting the list if there are no rxqs
mapped to the PMD thread. This can be reproduced with manual pinning and
'dpif-netdev/pmd-rxq-show' command.
Also Clang reports that null argument is passed
Hi Vishal,
On Thu, Jun 08, 2017 at 02:22:38PM -0300, Flavio Leitner wrote:
> On Thu, Jun 08, 2017 at 11:24:58AM +, Vishal Deep Ajmera wrote:
> > Hi Flavio,
> >
> > I am facing some issue with ovs-master on Ubuntu 14.04 system. Here are the
> > steps I followed and the error message I get. C
On 16 June 2017 at 16:37, Greg Rose wrote:
> The attribute __ro_after_init was introduced in Linux kernel 4.5. If
> a data structure is given this attribute then after the driver module
> loads the memory page where the data resides will be marked read only.
>
> The compat code in cache.h always
Hi Ben,
I've been testing L2/L3 tunneling and ptap ports receiving/transmitting L2 and
L3 packets.
I observed, that 'ovs-appctl dpctl/dump-flows' prints out packet_type 'id' in
decimal format.
For instance, in case of receiving a L3 MPLS packet on a ptap port results in:
tunnel(src=20.0.0.1,ds
Hi Ben,
The bridge property 'other-config:legacy-l3-pipeline' is obsolete, so the 3
lines starting at line 4197 in ofproto.at can be removed.
> +AT_CHECK([
> +ovs-vsctl set bridge br0 other-config:legacy-l3-pipeline=false
> +], [0])
Best regards,
Zoltan
> -Original Message-
> From
Hi Ben,
In the lib/meta-flow.xml, you introduced the 'packet type-aware pipeline'
concept.
You mentioned, controllers can turn off legacy behavior by setting
'other-config:packet-type' bridge property to 'ptap'.
As far as I know, you discussed on Friday, there will be only one property for
the
What OVS version is this? What is the platform version? i.e Debian/Ubuntu
etc. Does your OVS have the following fix?
https://github.com/openvswitch/ovs/commit/15af3d44c65eb3cd724378ce1b30c51aa87f4f69
On 19 June 2017 at 07:17, ychen wrote:
> 1. phenomenon
>ifup: waiting for lock on /run/netwo
The Open vSwitch log directory and files are currently set world readable.
However, since only Open vSwitch users and processes need to access this
directory and these files there is no need to allow the world to access them,
since it can result in the exposure of sensitive information.
Signed-of
1. phenomenon
ifup: waiting for lock on /run/network/ifstate.br-int
2. configurations
/etc/network/interfaces
allow-ovs br-int
iface br-int inet manual
ovs_type OVSBridge
ovs_ports tap111
allow-br-int tap111
iface ngwintp inet manual
ovs_bridge br-int
ovs_type OVSIntPort
3. st
Thanks, Ben, for the updated series.
I suggest to decouple the port name related patches.
We will test and review the remaining patches and have a look at the PTAP unit
tests and provide fixes to the test (or bugfixes to the code).
BR, Jan
> -Original Message-
> From: ovs-dev-boun...@op
Acked-by: Jan Scheurich
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org
> [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Monday, 19 June, 2017 01:30
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH v2 02/12] openvswitch.h: Use
Acked-by: Jan Scheurich
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org
> [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
> Sent: Monday, 19 June, 2017 01:30
> To: d...@openvswitch.org
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PATCH v2 01/12] ofp-util: Remove pr
On Thu, Jun 15, 2017 at 04:36:49PM -0700, Joe Stringer wrote:
> Currently, the set of flows that may be offloaded is very small compared
> to the overall capabilities of the OpenFlow support in OVS. In the
> majority of cases, if a user attempts to enable this flag they are
> unlikely to observe a
Thanks for that comments.
[Sugesh] Any reason, why this patch does only the TCP checksum offload??
The command line option says tx_checksum offload (it could be mistakenly
considered for full checksum offload).
[Zhenyu Gao] DPDK nic supports many hw offload feature like IPv4,IPV6,TCP,
UDP,VXLAN,G
Hi, guys
I'm working on NSH patches for kernel path, I think we can change it with new
NSH kernel patches together. You ovs guys have confirmed several times
userspace part can be merged before kernel part isn't there. So I propose we
review and merge userspace part first, kernel part will be p
>
> A new concern came up while thinking about this series. The
> OVS_ATTR_PACKET_TYPE does not appear to be implemented in the kernel
> module, and what's more, because of #ifdefs, OVS_ATTR_PACKET_TYPE will
> actually have a different value in the kernel module than in userspace.
> What's the pl
From: Antonio Fischetti
memcpy replaces the single copies inside dp_packet_clone_with_headroom().
Signed-off-by: Antonio Fischetti
---
lib/dp-packet.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 67aa406..5b1d416
From: Antonio Fischetti
When OVS is configured as a firewall, with thousands of active
concurrent connections, the EMC gets quicly saturated and may come under
heavy thrashing for the reason that original and recirculated packets
keep overwrite existing active EMC entries due to its limited size(
From: Antonio Fischetti
Current time is passed to conntrack_execute so it doesn't have
to recompute it again.
Signed-off-by: Antonio Fischetti
---
lib/conntrack.c| 4 ++--
lib/conntrack.h| 3 ++-
lib/dpif-netdev.c | 2 +-
tests/test-conntrack.c | 8 +---
4 files change
From: Antonio Fischetti
When EMC is disabled the reading of RSS hash is skipped.
For packets that are not recirculated it retrieves the hash
value without considering the recirc id.
This is mostly a preliminary change for the next patch in
this series.
Signed-off-by: Antonio Fischetti
---
In o
Hi Aaron,
>>
>>I've been playing with this a little bit; is it too late to consider tracking
>'threads'
>>instead of 'cores'? I'm not sure what it means for a particular core
>>ID to be 'healthy' - but I know what 'pmd24' not responding means.
>
>That's an interesting input. It's not late and al
Hi Zhenyu,
Thank you for working on this,
I have couple of questions in this patch.
Regards
_Sugesh
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Zhenyu Gao
> Sent: Friday, June 16, 2017 1:54 PM
> To: b...@ovn.org; u
>-Original Message-
>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
>boun...@openvswitch.org] On Behalf Of Bhanuprakash Bodireddy
>Sent: Sunday, June 18, 2017 8:56 PM
>To: d...@openvswitch.org
>Subject: [ovs-dev] [PATCH 0/6 V2] netdev-dpdk: Use intermediate queue
>during packet tran
As link-local addresses are only valid for a single interface, we can allow
to use the same VNI for multiple independent VXLANs, as long as the used
interfaces are distinct. This way, VXLANs can always be used as a drop-in
replacement for VLANs with greater ID space.
This also extends VNI lookup t
If VXLAN is run over link-local IPv6 addresses, it is necessary to store
the ifindex in the FDB entries. Otherwise, the used interface is undefined
and unicast communication will most likely fail.
Support for link-local IPv4 addresses should be possible as well, but as
the semantics aren't as well
* Multicast addresses are never valid as local address
* Link-local IPv6 unicast addresses may only be used as remote when the
local address is link-local as well
* Don't allow link-local IPv6 local/remote addresses without interface
We also store in the flags field if link-local addresses are u
Address families of source and destination addresses must match, and
changelink operations can't change the address family.
In addition, always use the VXLAN_F_IPV6 to check if a VXLAN device uses
IPv4 or IPv6.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: new patch
v3: rebase
drive
There is no good reason to keep the flags twice in vxlan_dev and
vxlan_config.
Signed-off-by: Matthias Schiffer
---
Notes:
v2: new patch
v3: rebase
drivers/net/vxlan.c | 76 +--
include/net/vxlan.h | 1 -
net/openvswitch/vpor
The vxlan_dev_configure function was mixing validation and application of
the vxlan configuration; this could easily lead to bugs with the changelink
operation, as it was hard to see if the function wcould return an error
after parts of the configuration had already been applied.
This commit split
Running VXLANs over IPv6 link-local addresses allows to use them as a
drop-in replacement for VLANs, avoiding to allocate additional outer IP
addresses to run the VXLAN over.
Since v1, I have added a lot more consistency checks to the address
configuration, making sure address families and scopes
Hi Ben,
Much Thanks for your initial reveiw comments.
We have addressed almost all problems and re-submitted the patch except the
below two lines.
"checkpatch" reports:
warning: 1 line adds whitespace errors.
WARNING: Line length is >79-characters long
#137 FILE: include/openvswitch
commit 49a3592b2878a33033e5fd2e6e5ce82ebccef780
Author: Satya Valli
Co-authored-by: Lavanya Harivelam
Co-authored-by: Surya Muttamsetty
OpenVswitch: OF1.5/EXT-334 Extensible Flow Entry Statistics
OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining the
existing
flow entry sta
78 matches
Mail list logo