Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

Hi Sai, I meant that if an entry is returned by this function, it's always going to be "explicitly created", rather than "an existing entry". If that is that case, you can remove all lines that is related to entryCreated in this function and determine whether entryCreated is true from the

[ovs-dev] [PATCH] ofp-actions: Store raw type for NXAST_LEARN2.

Previously, if a controller wrote a flow with action NXAST_LEARN2, then OVS would internally store an ofpact_learn structure with the raw type set to NXAST_LEARN. When re-encoding, if the learn action happened to have a limit or dst_ofs specified (which can only be specified for NXAST_LEARN2),

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

Hi Guru, Please see my answer below: On 19 June 2017 at 23:17, Manoj Sharma > wrote: The use case is if someone wants to access a VM from on-prem then it is an l3vpn and we should not do SNAT for it. > Please expand on the above. What

Re: [ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

Thanks for the patch, please find comments inline. From: ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal Sent: Tuesday, June 20, 2017 1:36 PM To: d...@openvswitch.org Subject: [ovs-dev]

[ovs-dev] [PATCH] datapath-windows: allow catalog creation with local time on WDK 10

When compiling with WDK10 we are using server time when creating the catalog file. This patch enables the use of local time. For reference: https://github.com/cloudbase/ovs/commit/6b3706dc9afb26c3e39985d44a99bc9251bcf792 Signed-off-by: Alin Gabriel Serdean ---

Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function

Alin, Thanks for looking into this! Acked-by: Sairam Venugopal On 6/20/17, 12:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Unit tests are passing. > > > >I

Re: [ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

Acked-by: Sairam Venugopal On 6/20/17, 12:44 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >x->errline is a signed int

Re: [ovs-dev] [PATCH] datapath-windows: Add validations for IP_HEADER_LEN

Thanks for patching this. Acked-by: Sairam Venugopal On 6/15/17, 3:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: >Adds validations in OvsGetIp() to make sure the IHL is >within

[ovs-dev] [PATCH] datapath-windows: Fix potential memory leak while creating conntrack entry

OvsCtAddEntry returns TRUE or FALSE depending on whether OvsNatTranslateCtEntry was successful or not. In the case of an unsuccesful NAT translation, this will fail to insert the newly created entry to the Conntrack Table. This entry needs to be freed and the states should be accordingly in the

[ovs-dev] [PATCH] tests: switch from signed to unsigned when formatting

x->errline is a signed int (https://github.com/openvswitch/ovs/blob/934386dd129a3f15b2546562a775f2f43dd3aac6/tests/test-sflow.c#L88) Flagged by static code analysis. Signed-off-by: Alin Gabriel Serdean --- tests/test-sflow.c | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function

On 16 June 2017 at 10:06, Anand Kumar wrote: > When --syslog-method is passed as a cmd line argument and > ovs daemons are started as a service, --syslog-method argument is not > honoured, as vlog module is initialized by service_start function > before parsing the command

Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from service_start function

Unit tests are passing. I also gave it a test via the installer. Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Saturday, June 17,

Re: [ovs-dev] [PATCH 7/8] netdev-dpdk: Configurable retries while enqueuing to vHost User ports.

>>On 06/07/2017 10:21 AM, Bhanuprakash Bodireddy wrote: >>> This commit adds "vhost-enque-retry" where in the number of retries >>> performed while enqueuing packets to vHostUser ports can be >>> configured in ovsdb. >>> >>> Currently number of retries are set to '8' and a retry is performed >>>

Re: [ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

On 20 June 2017 at 09:31, Alin Serdean wrote: > A lot of tests are failing, due to the open flow ports being outputted > using > names instead of numbers. > i.e.: http://64.119.130.115/ovs/beb75a40fdc295bfd6521b0068b4cd >

Re: [ovs-dev] Supply Chain Management

Did you get a chance to review my previous email? Please let me know if you did like to review few sample records from your target audience. Look forward to hearing back. Regards, Amy From: Amy Spencer Sent: Monday, June 19, 2017 4:31 PM To: 'd...@openvswitch.org' Subject: Supply Chain

[ovs-dev] [PATCH] Use @PYTHON@ directly instead of "#! /usr/bin/env"

In some installed python scripts /usr/bin/env is unnecessarily used in shebang, replace it directly with @PYTHON@. This will also avoid implicit dependency to /usr/bin/env in RPM distributions and it will correctly add implicit dependency to /usr/bin/python instead. Signed-off-by: Timothy

Re: [ovs-dev] [PATCH] datapath-windows: add open flow defines to Types.h

On 20 June 2017 at 07:59, Alin Serdean wrote: > Commit https://github.com/openvswitch/ovs/commit/ > 81765c00a13882acaaf652df23d7fa76fc3ad743 > introduced openflow types to the include interface. > > The Windows datapath needs to be aware of the new types included

Re: [ovs-dev] [PATCH] datapath-windows: add open flow defines to Types.h

Acked-by: Sairam Venugopal On 6/20/17, 7:59 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Commit

Re: [ovs-dev] [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support

From: Matthias Schiffer Date: Mon, 19 Jun 2017 10:03:54 +0200 > Running VXLANs over IPv6 link-local addresses allows to use them as a > drop-in replacement for VLANs, avoiding to allocate additional outer IP > addresses to run the VXLAN over. > > Since v1, I have

Re: [ovs-dev] [PATCH v2 12/12] work on packet aware test

Hi, This patch is based on Jan Scheurich's patch from previous e-mail in this thread. It fixes the PTAP system-userspace tests. Here comes the patch: This commit fixes PTAP system-userspace test and a typo in packet-type-aware.at --- tests/packet-type-aware.at | 2 +-

[ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

A lot of tests are failing, due to the open flow ports being outputted using names instead of numbers. i.e.: http://64.119.130.115/ovs/beb75a40fdc295bfd6521b0068b4cd12f6de507c/testsuite.dir/0464/testsuite.log.gz The issues encountered above is because 'monitor' with 'detach' arguments are

Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes Implementation

> From: "Ben Pfaff" > To: "Rodriguez Betancourt, Esteban" > Cc: d...@openvswitch.org > Sent: Thursday, 2 February, 2017 12:33:24 PM > Subject: Re: [ovs-dev] [PATCH 3/4 v4] ovsdb-idl: IDL Compound Indexes > Implementation > > On Wed, Dec 28, 2016 at 07:41:48PM

Re: [ovs-dev] [PATCH v3 0/7] Packet type aware pipeline

Hi Ben, Do you plan to you spin another v4 series with the fixes Zoltan and I have provided? Zoltan is working on one more fix on the system-userspace suite test for ptap. Then we'll start to rebase the generic encap/decap patch series to ptap v3 (or v4) and push that asap. Thanks, Jan >

Re: [ovs-dev] [PATCH v2 12/12] work on packet aware test

From: Jan Scheurich Re-introduced packet-type-aware unit tests Reverted test with triangular bridge setup to using patch ports to avoid dependency on veth ports and root privilidges. Adapted to changes in Ben's ptap series. Dependent on patches for using port names

Re: [ovs-dev] [ovs-discuss] rpmbuild failure for ovs_dpdk

Correction: ovs-disc...@openvswitch.org On 6/20/17, 9:01 AM, "ovs-discuss-boun...@openvswitch.org on behalf of Darrell Ball" wrote: Again, send to disc...@openvswitch.org Do you see something like this ?

Re: [ovs-dev] rpmbuild failure for ovs_dpdk

Again, send to disc...@openvswitch.org Do you see something like this ? darrell@prmh-nsx-perf-server125:~/ovs/ovs_master$ grep -nr LDFLAGS _gcc/config.status 846:S["OVS_LDFLAGS"]=" -L/usr/src/dpdk-16.11/x86_64-native-linuxapp-gcc/lib" with dpdk-16.07 instead of dpdk-16.11 . . . On 6/20/17,

[ovs-dev] [PATCH] Add configuration option to link ovs binaries statically

Add --enable-static-binaries configuration option for enabling or disabling static linking with libopenvswitch, libsflow, libovsdb, libvtep, libovn and libofproto also when --enable-shared is specified. This is needed to avoid link binaries with position-independent code (PIC) that generates

Re: [ovs-dev] [PATCH v3 3/7] userspace: Add OXM field MFF_PACKET_TYPE

We have found and fixed the root cause for simultaneous matching of packet_type(ns=1,id=0x800) and eth_type(0x800). The fix is below: From: Jan Scheurich Date: Tue, 20 Jun 2017 16:42:34 +0200 Subject: [PATCH] Fix: Unwildcard dl_type only for packet_type=PT_ETH If

[ovs-dev] سلام عزیزم

سلام عزیزم ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] datapath-windows: add open flow defines to Types.h

Commit https://github.com/openvswitch/ovs/commit/81765c00a13882acaaf652df23d7fa76fc3ad743 introduced openflow types to the include interface. The Windows datapath needs to be aware of the new types included in the common interface. Fixes broken build on Windows. Signed-off-by: Alin Gabriel

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

On 19 June 2017 at 23:17, Manoj Sharma wrote: > The use case is if someone wants to access a VM from on-prem then it is an > l3vpn and we should not do SNAT for it. > Please expand on the above. What does "on-prem" mean in the context of OVN? And is the VM a OVN

Re: [ovs-dev] [PATCH v2 12/12] work on packet aware test

Hi Ben, Thanks for working on updating the PTAP test. I have found and fixed three main issues that prevented the triangular bridge test from working. 1. The tunnel ports in (formerly packet-type-aware) bridge br-in2 had to be declared with "packet-type=ptap". 2. A typo in the peer name for

[ovs-dev] [PATCH v1] docs: Use DPDK 16.11.2 stable release.

Modify docs and travis linux build script to use the DPDK 16.11.2 stable branch to benefit from most recent bug fixes. Signed-off-by: Ian Stokes --- .travis/linux-build.sh |2 +- Documentation/faq/releases.rst |2 +-

[ovs-dev] rpmbuild failure for ovs_dpdk

Hi All, I try to build rpm for ovs+dpdk, but met below compiling issue. Does someone know how to fix it? I guess it is related to LDFLAGS='-Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld, but no idea how to fix it. If I follow below guide (non-rpm), everything is OK.

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

On Tue, Jun 20, 2017 at 6:09 AM, Miguel Angel Ajo Pelayo wrote: > I'm working on the implementation changes related to the schema [1] > > And I thought it could be great if we discussed here over the cmdline > changes, so this effort could happen in parallel: > > ovn-nbctl

Re: [ovs-dev] [PATCH v3 7/7] userspace: Introduce packet_type in OF 1.5 packet-out

Hi Ben, Setting "other-config:legacy-l3-pipeline=true" can be removed from the tests/system-userspace-packet-type-aware.at file as well. Sorry, for not indicating this in my previous e-mail. Best regards, Zoltan > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent:

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

On Tue, Jun 20, 2017 at 06:35:11AM +, Vishal Deep Ajmera wrote: > Hi Flavio, > > I did not configure IP address to the interface, simply brought up the > interface br0 using ifconfig and see this issue consistently. > > $ ifconfig br0 up Well, that includes IPv6 automatically, so could you

Re: [ovs-dev] [PATCH v2 00/12] Packet type aware pipeline

> > OVS_KEY_ATTR_PACKET_TYPE is represented with OVS_KEY_ATTR_ETHERNET and > > OVS_KEY_ATTR_ETHERTYPE in the kernel. > > From Google doc: > > "The presence of netlink key attribute OVS_KEY_ATTR_ETHERNET is used to > > indicate if it's about L2 or L3 packet on > the netlink interface. The "L3"

[ovs-dev] [PATCH v2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

Sendmmsg can reduce cpu cycles in sending packets to kernel. Replace sendmsg with sendmmsg in function netdev_linux_send to send batch packets if sendmmsg is available. If kernel side doesn't support sendmmsg, will fallback to sendmsg. netserver || || | container |

Re: [ovs-dev] [PATCH v1 1/4] ovn: l3ha, handling of multiple gateways

I'm working on the implementation changes related to the schema [1] And I thought it could be great if we discussed here over the cmdline changes, so this effort could happen in parallel: ovn-nbctl lrp-add-gw-chassis [priority] ovn-nbctl lrp-set-gw-chassis-prio priority ovn-nbctl

Re: [ovs-dev] [PATCH v2 08/12] userspace: Handling of versatile tunnel ports

Hi Ben, I guess you meant "options:packet_type" instead of "other-config:packet_type", since it's about an interface not a bridge property. Best regards, Zoltan > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, June 20, 2017 4:20 AM > To: Zoltán Balogh

Re: [ovs-dev] [PATCH 1/6] process: Consolidate process related APIs.

Hi Ben, >On Mon, Jun 19, 2017 at 07:53:59PM +0100, Bhanuprakash Bodireddy wrote: >> As part of retrieving system statistics, process status APIs along >> with helper functions were implemented. Some of them are very generic >> and can be reused by other subsystems. >> >> Move the APIs in

[ovs-dev] [PATCH v2] process: Consolidate process related APIs.

As part of retrieving system statistics, process status APIs along with helper functions were implemented. Some of them are very generic and can be reused by other subsystems. Move the APIs in system-stats.c to process.c and util.c and make them available. This patch doesn't change any

[ovs-dev] [PATCH] dpif-netdev: Remove useless port checking.

Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of list+array for tracking ports."), 'is_valid_port_number()' is equal to 'port_no != ODPP_NONE', and the expression below will never be true. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 7 --- 1 file

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: add support for per-flow drop counters

Hi Ben, Thanks for your feedback. I can start working on implementing your suggestions. Please keep in mind that IPFIX counters are based on probability, which means they won't necessarily reflect precise values. As you can see it's difficult to determine, with 100% accuracy, at sampling stage

Re: [ovs-dev] ifup locked when start ovs in debian9 with systemd

thanks Shetty I tried the patch provided by you, it does fix the problem when ovs started. At 2017-06-19 23:00:18, "Guru Shetty" wrote: What OVS version is this? What is the platform version? i.e Debian/Ubuntu etc. Does your OVS have the following fix?

Re: [ovs-dev] [PATCH 2/3] netdev-linux: make tap devices persistent.

Hi Flavio, I did not configure IP address to the interface, simply brought up the interface br0 using ifconfig and see this issue consistently. $ ifconfig br0 up Regards, Vishal -Original Message- From: Flavio Leitner [mailto:f...@sysclose.org] Sent: Tuesday, June 20, 2017 12:32 AM

Re: [ovs-dev] [PATCH 2/3] ovn: Ability to skip some IP addresses for SNAT.

The use case is if someone wants to access a VM from on-prem then it is an l3vpn and we should not do SNAT for it. Both sides should be using their logical IPs. However the match for “nosnat” should be on destination IP. I will rebase it to current master and run the tests. Regards - Manoj