Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

Hi Greg, I just download offical tar bar: wget http://openvswitch.org/releases/openvswitch-2.6.0.tar.gz Then compiling as below: ( I do not see any compiling issue) ./configure --with-linux=/lib/modules/$(uname -r)/build make make install make modules_install Br, Wang Zhike -Original

Re: [ovs-dev] [PATCH 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On 6/27/17, 11:13 AM, "ovs-dev-boun...@openvswitch.org on behalf of Joe Stringer" wrote: Commit 32b77c316d9982("dpif: Save added ports in a port map.") introduced tracking of all dpif ports by taking a reference on each

Re: [ovs-dev] [patch_v2 1/4] Userspace Datapath: Add ALG infra and FTP.

On 6/27/17, 3:00 PM, "Joe Stringer" wrote: On 27 June 2017 at 13:40, Darrell Ball wrote: > > > On 6/27/17, 1:20 PM, "Joe Stringer" wrote: > > On 27 June 2017 at 11:19, Darrell Ball wrote: > >

Re: [ovs-dev] [PATCH 5/6] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

> >On 27.06.2017 23:31, Bodireddy, Bhanuprakash wrote: >>> On 26.06.2017 00:52, Bodireddy, Bhanuprakash wrote: >> + >> +/* Flush the txq if there are any packets available. >> + * dynamic_txqs/concurrent_txq is disabled for vHost User ports >> +as >> + *

Re: [ovs-dev] [ovs-dev, 3/6] netdev-dpdk: Add intermediate queue support.

>At first, this patch should be applied after the patch with flushing on >reconfiguration because we must not reconfigure ports while there are >unsent packets in the intermediate queue. >Otherwise we may destroy the memory pool which contains that packets and >will try to send them after that.

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

On 06/26/2017 05:51 PM, 王志克 wrote: Hi Greg, The exact issue occured on the 20th of check-kmod (sometimes there are other kernel issue: kernel just hangs but without panic). OVS2.6.0 on CentOS7.2 with kernel 3.10.0-327.el7.x86_64. Some info below, which hopes helpful. datapath-sanity 1:

[ovs-dev] Bug#866319: openvswitch-vtep: Fails with an error about missing libs

Package: openvswitch-vtep Version: 2.6.2~pre+git20161223-3 Severity: normal The vtep-ctl binary appears to be missing something, and fails to execute. root@7dd518162735:/usr/src/app# vtep-ctl --version /usr/bin/vtep-ctl: error: '/usr/bin/.libs/vtep-ctl' does not exist This script

[ovs-dev] [PATCH] ovn-controller: avoid crash when vswitchd connection is lost

When ovs-vswitchd has dropped its connection to ovn-controller, rconn_get_version() will return -1. OpenFlow messages built by ofctrl_put() in this condition will have an invalid OpenFlow version value of 255, which eventually leads to ovn-controller crashing due to an assertion failure in

Re: [ovs-dev] [branch-2.5 2/2] Prepare for 2.5.4.

On Wed, Jun 28, 2017 at 09:52:58AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [branch-2.5 1/2] Set release date for 2.5.3.

On Wed, Jun 28, 2017 at 09:52:57AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [branch-2.7 2/2] Prepare for 2.7.2.

On Wed, Jun 28, 2017 at 09:47:20AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

On Wed, Jun 28, 2017 at 09:47:19AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Flavio Leitner Thanks, fbl ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [RFC] Introducing DPDK RTE FLOW HW offload support for openvswitch

Hi, The link provided by Michael below is a diff between OVS release tag v2.7.0 and the commit done for this proposal. It should be equal to a patch against v2.7.0. About the question about 20% performance boost. This is what we actually can measure. The packet has a flow_id included in the

Re: [ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

Acked-by: Anand Kumar Thanks, Anand Kumar On 6/20/17, 9:31 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: A lot of tests are failing, due to the open flow ports

Re: [ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

Hi Alin, I didn’t know that I had to get file handle from _get_osfhandle. I have tried out the code, it works. I will ack the patch. Thanks, Anand Kumar On 6/28/17, 10:30 AM, "Alin Serdean" wrote: Thanks for the review Anand! There are

Re: [ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

Thanks for the review Anand! There are a few issues with your snippet. You need to get the windows `handle` from the `FILE *` (_get_osfhandle), the return type of ` GetConsoleMode` is BOOL. https://msdn.microsoft.com/en-us/library/windows/desktop/ms683167(v=vs.85).aspx If you look at the return

Re: [ovs-dev] [PATCH] datapath: Fix missing "_ATTR" docstrings from some actions.

> On Jun 28, 2017, at 10:17 AM, Joe Stringer wrote: > > On 28 June 2017 at 09:57, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- > > Acked-by: Joe Stringer Thanks, I pushed this to master. --Justin

Re: [ovs-dev] [PATCH] datapath: Fix missing "_ATTR" docstrings from some actions.

On 28 June 2017 at 09:57, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Joe Stringer ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC] Introducing DPDK RTE FLOW HW offload support for openvswitch

Hi Darell, The patch against OVS 2.7 can be found here: https://github.com/napatech/ovs/commit/467f076835143a9d0c17ea514d4e5c0c33d72c98.diff The link was actually further down the post, but somehow it wasn't "clickable". Hope it helps. It is acceptable to provide the patch as above or must it

Re: [ovs-dev] [PATCH v2] Fix nonstandard isatty on Windows

Hi Alin, Thanks for the patch. The patch looks good, I have one comment regarding the GetConsoldeMode function. I’m not sure if it works. I have tried with the below snippet, where I create a new file but the windows api returns saying it’s a console device. int main() { FILE *fp;

[ovs-dev] [PATCH] datapath: Fix missing "_ATTR" docstrings from some actions.

Signed-off-by: Justin Pettit --- datapath/linux/compat/include/linux/openvswitch.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/include/linux/openvswitch.h b/datapath/linux/compat/include/linux/openvswitch.h index

[ovs-dev] [branch-2.5 2/2] Prepare for 2.5.4.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b87b03db442c..d2e62c169255 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.5.4 -

[ovs-dev] [branch-2.5 1/2] Set release date for 2.5.3.

Signed-off-by: Justin Pettit --- NEWS | 4 ++-- debian/changelog | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 6c1d998b3cb1..b87b03db442c 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,6 @@ -v2.5.3 - xx xxx +v2.5.3 - 28 Jun

[ovs-dev] [branch-2.7 1/2] Set release date for 2.7.1.

Signed-off-by: Justin Pettit --- NEWS | 3 ++- configure.ac | 2 +- debian/changelog | 12 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index bbff66af3735..5ed122ae77e7 100644 --- a/NEWS +++ b/NEWS @@ -1,10 +1,11 @@

[ovs-dev] [branch-2.7 2/2] Prepare for 2.7.2.

Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 7 +++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 5ed122ae77e7..6f0768b2657f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.7.2 -

[ovs-dev] KINDLY READ AND INDULGE

My name is Mrs. Gloria Kai, I am a banker here in Ghana. I write you this proposal in good faith. I have packaged a transaction that will be of mutual benefit to us. As the branch manager of the bank, it is my duty to send a financial report to my head office in the capital city, Accra, at the

Re: [ovs-dev] [RFC] Introducing DPDK RTE FLOW HW offload support for openvswitch

Thanks for getting this started. Few initial questions. On 6/28/17, 5:44 AM, "ovs-dev-boun...@openvswitch.org on behalf of Finn Christensen" wrote: We would like to introduce the first OVS patch proposal to a flow

[ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

DPDK provides an API to set the MTU of compatible physical devices - rte_eth_dev_set_mtu(). Prior to DPDK v16.07 however, this API was not implemented in some DPDK PMDs (i40e, specifically). To allow the use of jumbo frames with affected NICs in OvS-DPDK, MTU configuration was achieved by setting

Re: [ovs-dev] [PATCH 4/4] dp-packet: Use memcpy to copy dp_packet fields.

Hi Antonio, > -Original Message- > From: Fischetti, Antonio > Sent: Friday, June 23, 2017 11:06 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH 4/4] dp-packet: Use memcpy to copy > dp_packet fields. > > Hi Billy, thanks for your

Re: [ovs-dev] [ovs-dev, 4/6] dpif-netdev: Flush the packets in intermediate queue.

>At least, you have to flush non-PMD threads too. In case of non PMD threads we don’t have to flush as the packets aren't queued and bursted instantly. The call path on the transmit side is: Vswitchd thread: dp_execute_cb() netdev_send()

[ovs-dev] Sync on PTAP, EXT-382 and NSH - Wed 2017-07-12 17:00 CET

Hi, Focus on getting the remaining series reviewed and merged for OVS 2.8: 1. Generic Encap/Decap (EXT 382) for Ethernet (Ericsson) 2. Basic NSH MD1 including Encap/Decap for NSH (Intel) 3. L3/PTAP tunnel config for kernel datapath (RedHat) Thank you, Jan Link to the Google design doc:

[ovs-dev] Sync on PTAP, EXT-382 and NSH - Minutes of Meeting Wed 2017-06-28 14:00 CET

Participants: Ben P, Zoltan, Jan, Thomas Morin Patch series * PTAP v4 o Merged by Ben last night. Thanks! * Generic Encap/Decap (EXT 382) for Ethernet o Rebased on PTAP v4 and refactored (refined CLI syntax) o Can be posted this week * Support for NSH MD1

Re: [ovs-dev] [PATCH] Add a git-checkpatches script

Wow Ben, I hadn't seen your "updated patch". Sounds great, checkpatch integration is even better :) Best regards, and thanks, Migue Ángel On Wed, Jun 14, 2017 at 10:43 PM, Ben Pfaff wrote: > On Thu, Jun 08, 2017 at 12:39:27PM +, majop...@redhat.com wrote: > > From: Miguel

Re: [ovs-dev] [PATCH v1] vswitchd: Fix IFACE_STAT name error in iface_refresh_stats

ping Thanks Zhenyu Gao 2017-06-26 19:29 GMT+08:00 Zhenyu Gao : > The element of rx_1024_to_1522_packets has wrong > name(rx_1024_to_1518_packets). > Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it > should > record packets between 1024 to 1522.

[ovs-dev] [RFC] Introducing DPDK RTE FLOW HW offload support for openvswitch

We would like to introduce the first OVS patch proposal to a flow classification hw-offload for userspace datapath in OVS. It is implemented on DPDK, using the generic RTE_FLOW API. However, the hook into the userspace datapath is not DPDK dependent. Since OVS still only supports DPDK 16.11,

[ovs-dev] [PATCH 7/8] dpif-netdev: Change pmd selection order.

Up to his point rxqs are sorted by processing cycles they consumed and assigned to pmds in a round robin manner. Ian pointed out that on wrap around the most loaded pmd will be the next one to be assigned an additional rxq and that it would be better to reverse the pmd order when wraparound

[ovs-dev] [PATCH 8/8] dpif-netdev: Add ovs-appctl dpif-netdev/pmd-rxq-rebalance.

Rxqs consumed processing cycles are used to improve the balance of how rxqs are assigned to pmds. Currently some reconfiguration is needed to perform a reassignment. Add an ovs-appctl command to perform a new assignment in order to balance based on the latest rxq processing cycle information.

[ovs-dev] [PATCH 6/8] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple pmds, the rxqs which have consumed the largest

[ovs-dev] [PATCH 5/8] dpif-netdev: Count the rxq processing cycles for an rxq.

Count the cycles used for processing an rxq during the pmd optimization interval. As this is an in flight counter and pmds run independently, also store the total cycles used during the last full interval. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 30

[ovs-dev] [PATCH 4/8] dpif-netdev: Add rxq processing cycle counters.

Add two counters to dp_netdev_rxq which will be used for storing the processing cycles of an rxq. Processing cycles will be stored in reference to a defined interval. One counter is used for storing cycles during the current in progress interval, while the other is used to store the cycles of the

[ovs-dev] [PATCH 3/8] dpif-netdev: Change polled_queue to use dp_netdev_rxq.

Soon we will want to store processing cycle counts in the dp_netdev_rxq, so use that as a basis for the polled_queue that pmd_thread_main uses. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH 2/8] dpif-netdev: Make dpcls optimization interval more generic.

So far the interval was only used for dpcls optimization. Soon, we will use it for storing rxq cycles so make the names more generic. Also, set the interval regardless of whether dpcls optimization has occurred, as the optimization interval will need to be consistent across pmds. Signed-off-by:

[ovs-dev] [PATCH 1/8] dpif-netdev: Change definitions of 'idle' & 'processing' cycles

From: Ciara Loftus Instead of counting all polling cycles as processing cycles, only count the cycles where packets were received from the polling. Signed-off-by: Georg Schmuecking Signed-off-by: Ciara Loftus

[ovs-dev] [PATCH 0/8] OVS-DPDK rxq to pmd assignment improvements.

For the DPDK datapath, by default rxqs are assigned to available pmds in round robin order with no weight or priority. It can happen that some very busy queues are handled by one pmd which does not have enough cycles to prevent packets being dropped on them. While at the same time another pmd

Re: [ovs-dev] [RFC PATCH] Update relevant artifacts to add support for DPDK 17.05.1.

>From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] >On Behalf Of >mweglicx >Sent: Tuesday, June 27, 2017 10:37 AM >To: d...@openvswitch.org >Subject: [ovs-dev] [RFC PATCH] Update relevant artifacts to add support for >DPDK 17.05.1. > >Patch is marked as RFC because

Re: [ovs-dev] Internet Monitoring Unit(FBI).

ANTI-FRAUD AND INTERNET MONITORY CRIMES DIVISION FEDERAL BUREAU OF INVESTIGATION 935 Pennsylvania Avenue, NW. Washington, D.C. 20535-0001 DIRECT LINE: +1-207-618-7982 To You Personally, You have been dictated by our monitoring system, of dealing with fraudulent people(s) and doing illegal

[ovs-dev] [PATCH v8] dpif-netdev: Assign ports to pmds on non-local numa node.

Previously if there is no available (non-isolated) pmd on the numa node for a port then the port is not polled at all. This can result in a non-operational system until such time as nics are physically repositioned. It is preferable to operate with a pmd on the 'wrong' numa node albeit with lower

[ovs-dev] [PATCH] ofp-util: fix memory leak in ofputil_pull_ofp11_buckets

Signed-off-by: zhongbaisong --- lib/ofp-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 0c768ae..9e008aa 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -9206,6 +9206,7 @@ ofputil_pull_ofp11_buckets(struct ofpbuf *msg,

Re: [ovs-dev] [ovs-dev, 3/6] netdev-dpdk: Add intermediate queue support.

At first, this patch should be applied after the patch with flushing on reconfiguration because we must not reconfigure ports while there are unsent packets in the intermediate queue. Otherwise we may destroy the memory pool which contains that packets and will try to send them after that. This

Re: [ovs-dev] [ovs-dev, 4/6] dpif-netdev: Flush the packets in intermediate queue.

At least, you have to flush non-PMD threads too. Best regards, Ilya Maximets. On 18.06.2017 22:56, Bhanuprakash Bodireddy wrote: > Under low rate traffic conditions, there can be 2 issues. > (1) Packets potentially can get stuck in the intermediate queue. > (2) Latency of the packets can

Re: [ovs-dev] [PATCH 5/6] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

On 27.06.2017 23:31, Bodireddy, Bhanuprakash wrote: >> On 26.06.2017 00:52, Bodireddy, Bhanuprakash wrote: > + > +/* Flush the txq if there are any packets available. > + * dynamic_txqs/concurrent_txq is disabled for vHost User ports as > + * 'OVS_VHOST_MAX_QUEUE_NUM' txqs are

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: Fix severe memory leak in ipfix_send_template_msgs().

> On Jun 1, 2017, at 8:46 PM, Ben Pfaff wrote: > > On Thu, Jun 01, 2017 at 05:11:37PM -0700, Justin Pettit wrote: >> >>> On May 26, 2017, at 9:14 PM, Ben Pfaff wrote: >>> >>> This fixes a seemingly severe memory leak in ipfix_send_template_msgs(). >>> This