Re: [ovs-dev] [PATCH v3 0/3] Incremental addition/deletion of PMD threads.

2017-07-11 Thread Ilya Maximets
Patches 1 and 3 are also reviewed by Darrell now. So, maybe we can apply them before we finish our holy war about patch #2 ? We can easily apply #3 without #2 because they have nothing in common. Best regards, Ilya Maximets. On 05.07.2017 17:30, Ilya Maximets wrote: > Hi all. > IMHO, these patch

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-07-11 Thread fukaige
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Saturday, July 08, 2017 5:54 AM > To: fukaige > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: Re: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > On Thu, Jun 15, 2017 at 09:58:57AM +0800, fuka

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-11 Thread Jan Scheurich
I think the dropped packets are indeed noise generated by the host kernel when bringing up interfaces and are dependent on system configuration and timing. Dumping datapath flows seems pretty vulnerable to such noise in system tests and it may be hard to create filters that work reliably on all

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-11 Thread Chandran, Sugesh
Hi Darrell, Please see my comments below, Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, July 11, 2017 1:19 AM > To: Chandran, Sugesh ; Ilya Maximets > ; ovs-dev@openvswitch.org; Ben Pfaff > > Subject: Re: [ovs-dev] [PATCH v3 0/2] co

Re: [ovs-dev] [PATCH v1 3/6] ovn: extend expr symbols for ND

2017-07-11 Thread Numan Siddique
On Tue, Jul 11, 2017 at 2:58 AM, Ben Pfaff wrote: > On Thu, Jun 15, 2017 at 02:08:39PM +0530, nusid...@redhat.com wrote: > > From: Zong Kai LI > > > > This patch updates ND symbols in logical-fields - "nd", "nd.target", > > "nd.sll" and "nd.tll" to describe more clear about "icmp6.type" > > pred

[ovs-dev] [PATCH] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-11 Thread Ilya Maximets
If RSS hash exists in a packet it can be reused instead of 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This leads to increasing the performance of sending packets to the OVS bonding in userspace datapath up to 10-15%. Signed-off-by: Ilya Maximets --- lib/odp-execute.c | 13 +++--

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Christian Ehrhardt
Ping - any update on this thread - anybody looked into considering the config change? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2 0/3] ovn: Add IPv6 Router Solicitation responder support

2017-07-11 Thread nusiddiq
From: Numan Siddique v1 -> v2 --- The patches p1 and p2 of v1 are merged. p3 of v1 is dropped. v1 -- This patch series supports IPv6 Router solicitation responder support. This patch series picks up from the patches from here [1] and reset the version to 1 since few of the patches were acc

[ovs-dev] [PATCH v2 1/3] ovn util: Refactor dhcp_opts_map to make it generic

2017-07-11 Thread nusiddiq
From: Numan Siddique Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6 Router Advertisement, will make use of the refactored code to store the IPv6 ND RA options in 'struct gen_opts_map'. Signed-off-by: Numan Siddique

[ovs-dev] [PATCH v2 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-07-11 Thread nusiddiq
From: Numan Siddique This patch adds a new OVN action 'put_nd_ra_opts' to support native IPv6 Router Advertisement in OVN. This action can be used to respond to the IPv6 Router Solicitation requests. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with 'pause' flag set and th

[ovs-dev] [PATCH v2 3/3] ovn-northd: Add logical flows to support native IPv6 RA

2017-07-11 Thread nusiddiq
From: Zongkai LI This patch adds logical flows which sends IPv6 Router Advertisement packet in response to the IPv6 Router Solicitation request. It uses the actions "put_nd_ra_opts" to transform the RS packet to RA packet in the newly added ingress stage "lr_in_nd_ra_options" in router pipeline.

Re: [ovs-dev] [PATCH v3 0/2] conntrack : Add support for rx chceksum offload.

2017-07-11 Thread Darrell Ball
On 7/11/17, 5:29 AM, "Chandran, Sugesh" wrote: Hi Darrell, Please see my comments below, Regards _Sugesh > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, July 11, 2017 1:19 AM > To: Chandran, Sugesh ; Ily

Re: [ovs-dev] [PATCH v1 3/6] ovn: extend expr symbols for ND

2017-07-11 Thread Ben Pfaff
On Tue, Jul 11, 2017 at 07:56:31PM +0530, Numan Siddique wrote: > On Tue, Jul 11, 2017 at 2:58 AM, Ben Pfaff wrote: > > > On Thu, Jun 15, 2017 at 02:08:39PM +0530, nusid...@redhat.com wrote: > > > From: Zong Kai LI > > > > > > This patch updates ND symbols in logical-fields - "nd", "nd.target",

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-11 Thread Kavanagh, Mark B
>From: Darrell Ball [mailto:db...@vmware.com] >Sent: Tuesday, July 11, 2017 2:03 AM >To: Kavanagh, Mark B ; Chandran, Sugesh >; ovs-dev@openvswitch.org; Varghese, Vipin >; acon...@redhat.com >Subject: Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu > > > >On 7/10/17, 2:44 AM, "Kavanag

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Timothy M. Redaelli
On 07/05/2017 11:19 AM, Christian Ehrhardt wrote: > If available use dpdk pkg-config info of libdpdk to set the right > include paths. > That for example, allows packagers to provide non default include > paths in a common way (pkg-config). I like the idea, but I think it's better to wait for upst

[ovs-dev] [PATCH v5 0/2] conntrack : Add support for rx checksum offload.

2017-07-11 Thread Sugesh Chandran
Conntrack need not verify the checksum of incoming packets if it is validated by DPDK physical NIC ports. Also make use the DPDK rx checksum mask bits along with flags while validating the reported hardware checksum state. v4->v5 (No functional changes in this version) - Rebased on latest master

[ovs-dev] [PATCH v5 1/2] dp-packet : Update DPDK rx checksum validation functions.

2017-07-11 Thread Sugesh Chandran
DPDK ports use masks while reporting rx checksum flags. OVS should use these mask along with reported checksum flag while validating the good checksum. Added two new functions to validate bad checksum reported by DPDK NIC port. These two functions will be used in the following patch for enabling r

[ovs-dev] [PATCH v5 2/2] conntrack : Use Rx checksum offload feature on DPDK ports for conntrack.

2017-07-11 Thread Sugesh Chandran
Avoiding checksum validation in conntrack module if it is already verified in DPDK physical NIC ports. Signed-off-by: Sugesh Chandran Co-authored-by: Darrell Ball Signed-off-by: Darrell Ball --- lib/conntrack.c | 63 - 1 file changed, 40

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-11 Thread Darrell Ball
On 7/11/17, 8:44 AM, "Kavanagh, Mark B" wrote: >From: Darrell Ball [mailto:db...@vmware.com] >Sent: Tuesday, July 11, 2017 2:03 AM >To: Kavanagh, Mark B ; Chandran, Sugesh >; ovs-dev@openvswitch.org; Varghese, Vipin >; acon...@redhat.com >Subject: Re: [ovs-dev] [PATCH v3

[ovs-dev] [PATCH] tests: fix PTAP system test to check only OF stats

2017-07-11 Thread Zoltán Balogh
It turned out, checking datapath flow statistics during system-userspace test is not reliable. Unwanted packets can be injected depending on system configuration. As a workaround, this commit removes checking statistics of datapath flows and does check OpenFlow statistics of the integrator bridges

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-11 Thread Zoltán Balogh
Hi, I've created a new patch, that does check the OpenFlow statistics of integration bridges instead of the statistics of datapath flows. I sent the patch to the dev list: https://patchwork.ozlabs.org/patch/786669/ Best regards, Zoltan > -Original Message- > From: Jan Scheurich > Sen

Re: [ovs-dev] [PATCH] tests: fix PTAP system test to check only OF stats

2017-07-11 Thread Darrell Ball
signoff is missing maybe suggested by Jan ? On 7/11/17, 9:07 AM, "ovs-dev-boun...@openvswitch.org on behalf of Zoltán Balogh" wrote: It turned out, checking datapath flow statistics during system-userspace test is not reliable. Unwanted packets can be injected depending on syst

Re: [ovs-dev] [PATCH v4 0/7] Packet type aware pipeline

2017-07-11 Thread Darrell Ball
dball@ubuntu:~/ovs$ sudo make check-system-userspace TESTSUITEFLAGS='90' -C _gcc make: Entering directory `/home/dball/ovs/_gcc' make all-recursive make[1]: Entering directory `/home/dball/ovs/_gcc' Making all in datapath make[2]: Entering directory `/home/dball/ovs/_gcc/datapath' Making all in li

[ovs-dev] Bug#860786: Bug#860786: README.Debian: include IPv6 in examples for /etc/network/interfaces

2017-07-11 Thread Guru Shetty
On 19 April 2017 at 23:00, Daniel Pocock wrote: > Package: openvswitch-switch > Version: 2.3.0+git20140819-3+deb8u1 > Severity: wishlist > > > Looking at the examples for /etc/network/interfaces, none of them > include IPv6. > > I've tried configuring it using the example below and it appears to

Re: [ovs-dev] [PATCH] acinclude: netdev-dpdk: use pkg-config of libdpdk

2017-07-11 Thread Christian Ehrhardt
On Tue, Jul 11, 2017 at 5:53 PM, Timothy M. Redaelli wrote: > I like the idea, but I think it's better to wait for upstream (DPDK) to > add pkg-config support before pushing something that actually can only > be used in debian-based distributions (libdpdk-dev package). > Thanks Timothy for your

[ovs-dev] [RFC v2 0/4] prioritizing latency sensitive traffic

2017-07-11 Thread Billy O'Mahony
Hi All, rather than waiting for more polished PATCH v1 next week as I suggested this morning please find v2 RFC patchset updated with documentation changes and also some results from testing with this patchset. Initial results: * even when userspace OVS is very much overloaded and dropping sign

[ovs-dev] [RFC v2 1/4] netdev: Add set_ingress_sched to netdev api

2017-07-11 Thread Billy O'Mahony
Passes ingress_sched config item from other_config column of Interface table to the netdev. Signed-off-by: Billy O'Mahony --- lib/netdev-bsd.c | 1 + lib/netdev-dpdk.c | 19 +++ lib/netdev-dummy.c| 1 + lib/netdev-linux.c| 1 + lib/netdev-provider.h | 10 +

[ovs-dev] [RFC v2 2/4] netdev-dpdk: Apply ingress_sched config to dpdk phy ports

2017-07-11 Thread Billy O'Mahony
Ingress scheduling configuration is given effect by way of Flow Director filters. A small subset of the possible ingress scheduling possible is implemented in this patch. Signed-off-by: Billy O'Mahony --- include/openvswitch/ofp-parse.h | 3 ++ lib/dpif-netdev.c | 1 + lib/netd

[ovs-dev] [RFC v2 3/4] dpif-netdev: Add rxq prioritization

2017-07-11 Thread Billy O'Mahony
If an rxq is marked as 'prioritized' then keep reading from this queue until there are no packets available. Only then proceed to other queues. Signed-off-by: Billy O'Mahony --- lib/dpif-netdev.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/lib/dpi

[ovs-dev] [RFC v2 4/4] docs: Document ingress scheduling feature

2017-07-11 Thread Billy O'Mahony
Signed-off-by: Billy O'Mahony --- Documentation/howto/dpdk.rst | 31 +++ vswitchd/vswitch.xml | 31 +++ 2 files changed, 62 insertions(+) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst index 93248b4..07fb97

Re: [ovs-dev] [RFC v2 2/4] netdev-dpdk: Apply ingress_sched config to dpdk phy ports

2017-07-11 Thread Darrell Ball
On 7/11/17, 9:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of Billy O'Mahony" wrote: Ingress scheduling configuration is given effect by way of Flow Director filters. A small subset of the possible ingress scheduling possible is implemented in this patch. Signed-off-b

Re: [ovs-dev] [PATCH] Add configuration option to link ovs binaries statically

2017-07-11 Thread Ben Pfaff
On Tue, Jun 20, 2017 at 05:43:56PM +0200, Timothy Redaelli wrote: > Add --enable-static-binaries configuration option for enabling or disabling > static linking with libopenvswitch, libsflow, libovsdb, libvtep, libovn and > libofproto also when --enable-shared is specified. > > This is needed to a

Re: [ovs-dev] [PATCH] datapath-windows: allow catalog creation with local time on WDK 10

2017-07-11 Thread Ben Pfaff
On Tue, Jun 20, 2017 at 09:33:11PM +, Alin Serdean wrote: > When compiling with WDK10 we are using server time when creating the catalog > file. > > This patch enables the use of local time. > > For reference: > https://github.com/cloudbase/ovs/commit/6b3706dc9afb26c3e39985d44a99bc9251bcf792

Re: [ovs-dev] [RFC v2 4/4] docs: Document ingress scheduling feature

2017-07-11 Thread Darrell Ball
On 7/11/17, 9:58 AM, "ovs-dev-boun...@openvswitch.org on behalf of Billy O'Mahony" wrote: Signed-off-by: Billy O'Mahony --- Documentation/howto/dpdk.rst | 31 +++ vswitchd/vswitch.xml | 31 +++ 2 files change

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-11 Thread Joe Stringer
On 7 July 2017 at 16:44, Yang, Yi Y wrote: > Joe, NSH for kernel datapath will be coming once this series is merged, do we > need to do so yet? Until the patch is merged upstream in the net-next tree, the enum is not officially dedicated to this particular feature and it's plausible that someone

Re: [ovs-dev] incorrect revalidated action for igmp

2017-07-11 Thread Ben Pfaff
On Thu, Jun 22, 2017 at 01:04:48AM +0800, Huanle Han wrote: > In "Normal" action, igmp report packet is expected to processed in slow > path. > However, the igmp_type(flow->tp_src) is not supported to be masked in > datapath. > Then ovs-vswitchd revalidate the flow with igmp_type(flow->tp_src) == 0

Re: [ovs-dev] [PATCH] Fixes: 3f5b5f7b4115 ("db-ctl-base: Always support all tables in schema.")

2017-07-11 Thread Aaron Conole
Hi ZhiPeng, ZhiPeng Lu writes: > This fixes an assertion failure in command "ovs-vsctl list netflow br0", > if bridge br0 without any netflows. > $ovs-vsctl list netflow br0 > ovs-vsctl: lib/ovsdb-idl.c:2407: assertion column_idx < class->n_columns > failed > in ovsdb_idl_read() > Aborted > >

Re: [ovs-dev] [PATCH 1/2] tc: Fix compile with Glibc < 2.24 and Linux > 4.5.

2017-07-11 Thread Joe Stringer
On 10 July 2017 at 11:28, Ben Pfaff wrote: > On Mon, Jun 19, 2017 at 02:33:22PM -0700, Joe Stringer wrote: >> linux/pkt_cls.h indirectly includes linux/stddef.h, which may define >> __always_inline when using Linux kernel headers 4.6 or later. >> >> netinet/in.h indirectly includes sys/cdefs.h, wh

Re: [ovs-dev] [PATCH v2 0/4] rhel/fedora: non-root OvS out of the box

2017-07-11 Thread Aaron Conole
Aaron Conole writes: > Aaron Conole writes: > >> This series attempts to introduce the ability to start and use >> Open vSwitch 'out of the box' as a non-root user. It does this by >> modifying the service files to pass the recently introduced --ovs-user >> argument around, and by making some m

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-11 Thread Eric Garver
Inserting an important note for reviewers/testers. On Mon, Jul 10, 2017 at 03:39:50PM -0400, Eric Garver wrote: > This series enables support for layer3 tunnels VXLAN-GPE and GRE in the kernel > datapath. It includes new system-traffic test cases. The first two patches fix > an issue translating p

Re: [ovs-dev] [PATCH 1/3] Fix: coding style and some typos.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 01:28:20PM +0100, antonio.fische...@intel.com wrote: > From: Antonio Fischetti > > Fixes some lines exceeding 80 chars and a couple of typos. > > Signed-off-by: Antonio Fischetti Thanks, applied to master. ___ dev mailing list

Re: [ovs-dev] [PATCH 2/3] dpctl: add CT Stats for Connections per protocol.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 01:28:21PM +0100, antonio.fische...@intel.com wrote: > From: Antonio Fischetti > > Adds CT stats to report number of connections grouped by > protocol. > By using > utilities/ovs-appctl dpctl/ct-stats-show > it can display something like: > Connections Stats: > Total:

Re: [ovs-dev] [PATCH 3/3] dpctl: Add new 'ct-bkts' command.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 01:28:22PM +0100, antonio.fische...@intel.com wrote: > From: Antonio Fischetti > > With the command: > ovs-appctl dpctl/ct-bkts > shows the number of connections per bucket. > > By using a threshold: > ovs-appctl dpctl/ct-bkts gt=N > for each bucket shows the number of

Re: [ovs-dev] [PATCH 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-07-11 Thread Wang, Yipeng1
Thank you Darrell for the comments. To ones who are interested, this patch is mainly for improving the subtable lookup process when subtable count is large. We heard about use cases that the current sequential search of subtables is not efficient enough. With 30 subtables, this patch could achiev

Re: [ovs-dev] [PATCH v3] dpif-netdev: Fix insertion probability

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 04:59:40PM +0100, Kevin Traynor wrote: > On 06/23/2017 04:31 PM, Ciara Loftus wrote: > > emc_conditional_insert uses pmd->last_cycles and the packet's RSS hash > > to generate a random number used to determine whether or not an emc > > entry should be inserted. This works fo

Re: [ovs-dev] [PATCH] Fix some -Wimplicit-fallthrough warnings building with GCC 7

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 06:12:49PM +0200, Timothy Redaelli wrote: > -Wimplicit-fallthrough warns when a switch case falls through and since this > warning is enabled by -Wextra it breaks building with --enable-Werror. > > Added "/* fall through */" comment when needed in order to avoid the warning

Re: [ovs-dev] [PATCH] dpif-netdev: Remove useless port checking.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 09:43:45AM -0700, Greg Rose wrote: > On 06/20/2017 12:53 AM, Ilya Maximets wrote: > >Since commit ff073a71f9bb ("dpif-netdev: Use hmap instead of > >list+array for tracking ports."), 'is_valid_port_number()' is > >equal to 'port_no != ODPP_NONE', and the expression below wil

Re: [ovs-dev] [PATCH v5 2/4] lib: skiplist implementation

2017-07-11 Thread Ben Pfaff
On Sat, Jun 24, 2017 at 05:01:50PM -0400, Lance Richardson wrote: > Skiplist implementation intended for use in the IDL compound indexes > feature. > > Signed-off-by: Esteban Rodriguez Betancourt > Co-authored-by: Lance Richardson > Signed-off-by: Lance Richardson Thanks for reviving this seri

Re: [ovs-dev] [PATCH v5 2/4] lib: skiplist implementation

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > , "jorge sauma" > , "arnoldo lutz guevara" > Sent: Tuesday, 11 July, 2017 4:18:46 PM > Subject: Re: [ovs-dev] [PATCH v5 2/4] lib: skiplist implementation > > On Sat, Jun 24, 2017 at 0

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-11 Thread Ben Pfaff
On Sat, Jun 24, 2017 at 05:01:51PM -0400, Lance Richardson wrote: > This patch adds support for the creation of multicolumn indexes > in the C IDL to enable for efficient search and retrieval of database > rows by key. > > Signed-off-by: Esteban Rodriguez Betancourt > Co-authored-by: Lance Richar

Re: [ovs-dev] [PATCH v5 4/4] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-11 Thread Ben Pfaff
On Sat, Jun 24, 2017 at 05:01:52PM -0400, Lance Richardson wrote: > Generates and fills in the default comparators for columns with > type int, real, string. Also creates the macros that allow > iteration over the contents of the index, and perform > queries. > > Signed-off-by: Arnoldo Lutz Guevar

Re: [ovs-dev] [PATCH 1/4] Add OF actions for generic encap and decap

2017-07-11 Thread Ben Pfaff
On Fri, Jun 30, 2017 at 03:29:29PM +, Zoltán Balogh wrote: > From: Jan Scheurich > > This commit adds support for the OpenFlow actions generic encap > and decap (as specified in ONF EXT-382) to the OVS control plane. > > CLI syntax for encap action with properties: > encap(hdr=) > encap(

Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes implementation

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > , "jorge sauma" > , "arnoldo lutz guevara" > Sent: Tuesday, 11 July, 2017 5:05:32 PM > Subject: Re: [ovs-dev] [PATCH v5 3/4] ovsdb-idl: idl compound indexes > implementation > > On S

Re: [ovs-dev] [PATCH v5 4/4] ovsdb-idl: Autogenerated functions for compound indexes

2017-07-11 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org, esteb...@hpe.com, "javier albornoz" > , "jorge sauma" > , "arnoldo lutz guevara" > Sent: Tuesday, 11 July, 2017 5:09:04 PM > Subject: Re: [ovs-dev] [PATCH v5 4/4] ovsdb-idl: Autogenerated functions for > compound indexes

[ovs-dev] Wir vergeben Kredite mit einem Zinssatz von jährlich 2%

2017-07-11 Thread Bernhard Stöckl
-- Wir vergeben Kredite mit einem Zinssatz von jährlich 2%. Die Bearbeitung des Antrags erfolgt rasch, wir verlangen keine Gebühren, was sie beantragen werden wir annehmen. Wir bewilligen Kredite von bis zu 40 Millionen Euro und von mindestens 15.000 Euro. Sie können einen geschäftlichen oder

Re: [ovs-dev] [PATCH] Support IPv6 link-local address scopes on Linux.

2017-07-11 Thread Darrell Ball
This looks correct to me and a reasonable subset of support of scoping, although I did not test it. I noticed there was some unrelated cleanup w.r.t. parse_sockaddr_components(), but those changes are minor. Acked-by: Darrell Ball On 7/5/17, 5:20 PM, "ovs-dev-boun...@openvswitch.org on behalf

Re: [ovs-dev] [PATCH 2/4] Translation of generic encap and decap actions

2017-07-11 Thread Ben Pfaff
On Fri, Jun 30, 2017 at 03:29:32PM +, Zoltán Balogh wrote: > From: Jan Scheurich > > This commit implements a skeleton for the translation of generic encap > and decap actions in ofproto-dpif and adds support to encap and decap an > Ethernet header. > > In general translation of encap commit

Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields

2017-07-11 Thread Yang, Yi Y
Ok, will do. -Original Message- From: Joe Stringer [mailto:j...@ovn.org] Sent: Wednesday, July 12, 2017 2:29 AM To: Yang, Yi Y Cc: ovs dev ; Li, Ricky ; Mengke Liu Subject: Re: [ovs-dev] [PATCH 1/6] userspace: Add support for NSH MD1 match fields On 7 July 2017 at 16:44, Yang, Yi Y

Re: [ovs-dev] [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

2017-07-11 Thread Ben Pfaff
On Fri, Jun 30, 2017 at 03:29:35PM +, Zoltán Balogh wrote: > This commit drops packet during xlate if it is a L3 packet and output port > packet_type is legacy_l2. It completes PTAP unit tests with: > > - Send L3 packet over patch port. > - Output L2/L3 packet to ports with different packe

[ovs-dev] Aumente Notablemente sus Ventas

2017-07-11 Thread Técnicas para incrementar sus Ventas
En línea y en Vivo / Para todo su Equipo con una sola Conexión Técnicas Infalibles para Incrementar sus Ventas 04 de Agosto - Online en Vivo - 10:00 a 13:00hrs Si desea incrementar su rentabilidad, ésta es la oportunidad de equipar a su fuerza de ventas con un probado y efectivo proced

Re: [ovs-dev] [PATCH 4/4] netdev: fix crash when interface option is changed to invalid value

2017-07-11 Thread Ben Pfaff
On Fri, Jun 30, 2017 at 03:29:40PM +, Zoltán Balogh wrote: > When trying to modify an interface option (e.g. remote IP of a GRE port) to > an invalid value, the vswitchd does crash. For instance: > ovs-vsctl add-br br0 > ovs-vsctl add-port br0 gre0 -- set interface gre0 type=gre \ >

Re: [ovs-dev] [PATCH 2/4] Translation of generic encap and decap actions

2017-07-11 Thread Yang, Yi Y
Ben, encap action is just adding an empty header, set_field action will set the fields in the encapped header, so encap and set actions can be combined if we defer encap action, this is an optimization. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, July 12, 2

Re: [ovs-dev] [PATCH 2/4] Translation of generic encap and decap actions

2017-07-11 Thread Ben Pfaff
OK. Are you willing to squash the first two patches for the next version? It looks to me like they form a single logical change. On Wed, Jul 12, 2017 at 12:41:10AM +, Yang, Yi Y wrote: > Ben, encap action is just adding an empty header, set_field action will set > the fields in the encapped

Re: [ovs-dev] [PATCH 4/6] dpif-netlink-rtnl: Fix dead store reported by clang.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 07:54:02PM +0100, Bhanuprakash Bodireddy wrote: > Clang reports variable 'ifmsg' never been used in the function. > > Signed-off-by: Bhanuprakash Bodireddy Thanks, applied to master. ___ dev mailing list d...@openvswitch.org htt

Re: [ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by clang.

2017-07-11 Thread Ben Pfaff
On Fri, Jun 23, 2017 at 09:49:19AM +, Kavanagh, Mark B wrote: > >From: ovs-dev-boun...@openvswitch.org > >[mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of > >Bhanuprakash Bodireddy > >Sent: Monday, June 19, 2017 7:54 PM > >To: d...@openvswitch.org > >Subject: [ovs-dev] [PATCH 5/6] test-co

Re: [ovs-dev] [PATCH 6/6] netdev: Fix null pointer dereference reported by clang.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 19, 2017 at 07:54:04PM +0100, Bhanuprakash Bodireddy wrote: > Clang reports that array access from 'dumps' variable result in null pointer > dereference. > > Signed-off-by: Bhanuprakash Bodireddy > --- > lib/netdev.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletio

Re: [ovs-dev] [PATCH] Support IPv6 link-local address scopes on Linux.

2017-07-11 Thread Ben Pfaff
Thanks for the review. I'm very new to the concept of IPv6 link-local address scoping. What does this subset out of the larger feature? On Tue, Jul 11, 2017 at 11:30:29PM +, Darrell Ball wrote: > This looks correct to me and a reasonable subset of support of scoping, > although I did not te

Re: [ovs-dev] [PATCH] ovn: add qos function.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 10:06:17AM +0800, wang.qia...@zte.com.cn wrote: > The current qos function is used for geneve > tunnel to control the traffic out the ovs. And have no to-port qos > control. > > This patch do the modification as follow > 1. change the qos configuration with direction to co

Re: [ovs-dev] [RFC PATCH v1] vswitchd: Fix IFACE_STAT name error in iface_refresh_stats

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 10:30:55AM +, Zhenyu Gao wrote: > The element of rx_1024_to_1522_packets has wrong > name(rx_1024_to_1518_packets). > Change it from rx_1024_to_1518_packets to rx_1024_to_1522_packets, it should > record packets between 1024 to 1522. > > The element of tx_1024_to_1522_

Re: [ovs-dev] [PATCH] ovsdb-types: Fix memory leak on error path.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 08:15:43PM +0800, w00273186 wrote: > From: Yunjian Wang > > Fixes: bd76d25d8b3b("ovsdb: Add simple constraints.") > Signed-off-by: Yunjian Wang Thanks. Good catch! I applied this to master and backported as far as branch-2.0. ___

Re: [ovs-dev] [PATCH] ofproto-dpif-ipfix: Multicast/Broadcast/Unicast counters.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 02:02:05PM +0100, Przemyslaw Szczerbik wrote: > This patch implements following counters: > - postMCastPacketDeltaCount > - postMCastPacketTotalCount > - postMCastOctetDeltaCount > - postMCastOctetTotalCount > - ingressUnicastPacketTotalCount > - ingressMulticastPacketTotalC

Re: [ovs-dev] [RFC 0/3] ovn-controller: applications of IDL index feature

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 11:54:41AM -0400, Lance Richardson wrote: > This RFC series demonstrates how the IDL index feature patch series could > be applied to simplify ovn-controller logic and potentially elimiante the > overhead of creating/destroying existing indexing data structures > during each

Re: [ovs-dev] [PATCH 2/4] Translation of generic encap and decap actions

2017-07-11 Thread Yang, Yi Y
Zoltan will do that. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Wednesday, July 12, 2017 11:59 AM To: Yang, Yi Y Cc: Zoltán Balogh ; 'd...@openvswitch.org' ; Jan Scheurich ; Georg Schmuecking ; Jiri Benc (jb...@redhat.com) Subject: Re: [PATCH 2/4] Translation of g

Re: [ovs-dev] [PATCH] netdev: fix crash when ifa_netmask is null

2017-07-11 Thread Ben Pfaff
On Tue, Jul 04, 2017 at 08:52:57AM +0800, Haifeng Lin wrote: > The ifa_netmask is null when failed to call ioctl > in getifaddrs > > Signed-off-by: Haifeng Lin Thanks for figuring this out. What does it mean if ifa_netmask is null? Does it mean that the address should be ignored entirely? The

Re: [ovs-dev] [PATCH] ovn-controller: avoid crash when vswitchd connection is lost

2017-07-11 Thread Ben Pfaff
On Wed, Jun 28, 2017 at 02:54:47PM -0400, Lance Richardson wrote: > When ovs-vswitchd has dropped its connection to ovn-controller, > rconn_get_version() will return -1. OpenFlow messages built by > ofctrl_put() in this condition will have an invalid OpenFlow version > value of 255, which eventuall

Re: [ovs-dev] [PATCH] ovn-controller: fix use-after-free in physical_run()

2017-07-11 Thread Ben Pfaff
On Sat, Jul 08, 2017 at 05:31:15PM -0400, Lance Richardson wrote: > The hmap "tunnels" is persistent across IDL loop iterations, but > stores pointers to strings in the local db replica which can be > freed as database updates are processed. Fix by storing a copy > of the string in the hmap instead

Re: [ovs-dev] [PATCH v6 1/2] netdev-dpdk: Remove Rx checksum reconfigure.

2017-07-11 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 10:51:50PM +0100, Kevin Traynor wrote: > Rx checksum offload is enabled by default on DPDK physical NICs > where available, with reconfiguration through > options:rx-checksum-offload. However, changing rx-checksum-offload > did not result in a reconfiguration of the NIC and

Re: [ovs-dev] [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

2017-07-11 Thread Jan Scheurich
Yes, this is a bug fix for the merged PTAP series. It could be merged independently from patches 1 and 2. I'm sure it is possible to strip down the PTAP unit tests additions in this patch to cover the fixed issue without using decap action (e.g. by sending a L3 packet from a ptap tunnel to the v