Re: [ovs-dev] [patch_v2] dpdk: Fix device cleanup.

2017-07-30 Thread Fischetti, Antonio
> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Sunday, July 30, 2017 4:19 PM > To: Darrell Ball > Cc: d...@openvswitch.org; Fischetti, Antonio ; > Ilya Maximets > Subject: Re: [ovs-dev] [patch_v2] dpdk: Fix device cleanup. > > Darrell Ball writes: > > >

[ovs-dev] [PATCH 2/5] util: Add C++ compatible definition of PADDED_MEMBERS.

2017-07-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- include/openvswitch/util.h | 12 1 file changed, 12 insertions(+) diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h index 17b06528f1a0..5d6d453f7bdb 100644 --- a/include/openvswitch/util.h +++ b/include/openvswitch/util.h @@ -175,11 +1

[ovs-dev] [PATCH 5/5] Add 'extern "C"' for all relevant public header files, plus a build check.

2017-07-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- include/openvswitch/automake.mk | 20 include/openvswitch/dynamic-string.h | 8 include/openvswitch/flow.h | 8 include/openvswitch/geneve.h | 8 include/openvswitch/list.h | 8 ++

[ovs-dev] [PATCH 4/5] Automatically verify that OVS header files work OK in C++ also.

2017-07-30 Thread Ben Pfaff
This should help address a recurring problem. Signed-off-by: Ben Pfaff --- .travis.yml | 1 + Makefile.am | 1 + configure.ac| 2 ++ include/openvswitch/automake.mk | 14 ++ m4/openvswitch.m4 | 21 ++

[ovs-dev] [PATCH 3/5] ofp-util: Avoid C++ keyword 'public' in name of struct member.

2017-07-30 Thread Ben Pfaff
This allows a C++ program to include ofp-util.h. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-util.h | 2 +- lib/ofp-print.c| 4 ++-- lib/ofp-util.c | 26 +- ofproto/connmgr.c | 14 +++--- ofproto/fail-open.c

[ovs-dev] [PATCH 1/5] ofp-actions: Add casts to placate C++ compilers.

2017-07-30 Thread Ben Pfaff
C++ does not allow for an implicit conversion from void * to pointer to object or incomplete type. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-actions.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/include/openvswitch/ofp-actions.h b/include/openvswit

Re: [ovs-dev] [PATCH] dpif-netdev: Simplify emc replacement policy.

2017-07-30 Thread Darrell Ball
-Original Message- From: on behalf of "Wang, Yipeng1" Date: Friday, July 28, 2017 at 11:04 AM To: Ilya Maximets , "ovs-dev@openvswitch.org" Cc: Heetae Ahn Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Simplify emc replacement policy. Good catch. But I think the hash comparison is

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-30 Thread Darrell Ball
-Original Message- From: Aaron Conole Date: Sunday, July 30, 2017 at 8:22 AM To: Darrell Ball Cc: Michal Weglicki , "d...@openvswitch.org" Subject: Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1. Darrell Ball writes: > -Original

Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-30 Thread Paul Blakey
On 30/07/2017 10:22, Roi Dayan wrote: On 28/07/2017 15:49, Simon Horman wrote: On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. The implications of this change on the

Re: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for DPDK 17.05.1.

2017-07-30 Thread Aaron Conole
Darrell Ball writes: > -Original Message- > From: on behalf of Michal Weglicki > > Date: Tuesday, July 25, 2017 at 5:34 AM > To: "d...@openvswitch.org" > Subject: [ovs-dev] [PATCH v4] Update relevant artifacts to add support for > DPDK 17.05.1. > > Upgrading to DPDK 17.05.1 st

Re: [ovs-dev] [patch_v2] dpdk: Fix device cleanup.

2017-07-30 Thread Aaron Conole
Darrell Ball writes: > Commit 5dcde09c80a8 was introduced to make detaching more > automatic without using an additional command beyond > ovs-vsctl del-port . > > Sometimes, since commit 5dcde09c80a8, dpdk devices are > not detached when del-port is issued; command example: > > sudo ovs-vsctl de

Re: [ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

2017-07-30 Thread Roi Dayan
On 28/07/2017 15:49, Simon Horman wrote: On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote: From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. The implications of this change on the size of struct tc_flower_key seem somewha