[ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-06 Thread wang . qianyu
If we do not add a new type of switch, we should write flag to a reg to indicate the matched packets which are cloned to monitor. This reg should add to all the pipeline stages of logical switch(both ingress and egress) to distinguish from normal flow. Is this right for Russell's point? If we

Re: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue.

2017-08-06 Thread Darrell Ball
-Original Message- From: on behalf of Bhanuprakash Bodireddy Date: Thursday, June 29, 2017 at 3:39 PM To: "d...@openvswitch.org" Subject: [ovs-dev] [PATCH v3 6/6] dpif-netdev: Flush the packets in intermediate queue. Under low rate traffic conditions, there can be 2 issues.

Re: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Add intermediate queue support.

2017-08-06 Thread Darrell Ball
-Original Message- From: on behalf of Bhanuprakash Bodireddy Date: Thursday, June 29, 2017 at 3:39 PM To: "d...@openvswitch.org" Subject: [ovs-dev] [PATCH v3 4/6] netdev-dpdk: Add intermediate queue support. This commit introduces netdev_dpdk_eth_tx_queue() function that im

Re: [ovs-dev] [PATCH v3 2/6] netdev-dpdk: Add netdev_dpdk_txq_flush function.

2017-08-06 Thread Darrell Ball
Hi Bhanu Would it be possible to combine patches 1 and 2, rather than initially defining an empty netdev_txq_flush for dpdk ? I think the combined patch would have more context. Darrell -Original Message- From: on behalf of Bhanuprakash Bodireddy Date: Thursday, June 29, 2017 at 3:3

Re: [ovs-dev] [PATCH v3 0/6] netdev-dpdk: Use intermediate queue during packet transmission.

2017-08-06 Thread Darrell Ball
Sorry, I was multitasking last week and did not get a chance to finish the responses on Friday I looked thru. the code for all the patches The last 3 patches of V3 needed a manual merge; as you know, the series needs a rebase after recent commits. For a full o/p batch case, I see about a 10% dro

[ovs-dev] openvswitch is marked for autoremoval from testing

2017-08-06 Thread Debian testing autoremoval watch
openvswitch 2.6.2~pre+git20161223-3 is marked for autoremoval from testing on 2017-09-05 It (build-)depends on packages with these RC bugs: 853457: ipsec-tools: ftbfs with GCC-7 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mai

[ovs-dev] [PATCH 2/2] netdev-linux: Reduce log level for ENODEV errors getting ifindex

2017-08-06 Thread Roi Dayan
These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-linux.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.

[ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

2017-08-06 Thread Roi Dayan
From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be related. From ovs-dpctl we cannot tell if offload is enabled or not as other_config is not being read. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-vport.c |

[ovs-dev] [PATCH 0/2] Fix for dumping vxlan flows from ovs-dpctl

2017-08-06 Thread Roi Dayan
Hi, The first patches is a fix for dumping vxlan rules with ovs-dpctl. The second patch is to avoid false errors about getting ifindex as the device might disappear already. Thanks, Roi Paul Blakey (1): netdev-vport: Always implement get_ifindex for netdev-vport Roi Dayan (1): netdev-linux

Re: [ovs-dev] 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-06 Thread Ben Pfaff
I am having a very hard time understanding what you're writing here. Russell's point makes sense to me, but I don't understand your response. Can you give some examples? On Mon, Aug 07, 2017 at 09:40:06AM +0800, wang.qia...@zte.com.cn wrote: > Not add new logical_mirror_switch, just use logical_sw

[ovs-dev] 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

2017-08-06 Thread wang . qianyu
Not add new logical_mirror_switch, just use logical_switch of course can capture the use case. But logical_switch pipeline is complex for flow monitor. Flow monitor should ignore some tables such as port_security, lb and so on. And also should consider normal function for normal ports. I think

[ovs-dev] [patch_v11 3/7] Userspace Datapath: Add ALG infra and FTP.

2017-08-06 Thread Darrell Ball
ALG infra and FTP (both V4 and V6) support is added to the userspace datapath. Also, NAT support is included. Signed-off-by: Darrell Ball --- lib/conntrack-private.h | 40 +- lib/conntrack.c | 1048 +++ lib/conntrack.h | 10 +- 3 f

[ovs-dev] [patch_v11 6/7] System tests: Add 4 new ftp and tftp tests.

2017-08-06 Thread Darrell Ball
In order to have full coverage of ALGs for the userspace datapath, it is necessary to add 4 new tests. Three of these will cover passive ftp, including basic V6 passive ftp, V4 passive ftp with NAT and sequence skew and V6 passive ftp with NAT. The last test will cover tftp with NAT. Before these a

[ovs-dev] [patch_v11 7/7] NEWS: Announce userspace datapath ALG support.

2017-08-06 Thread Darrell Ball
Signed-off-by: Darrell Ball --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index 4df823d..7fe5aa7 100644 --- a/NEWS +++ b/NEWS @@ -36,6 +36,7 @@ v2.8.0 - xx xxx abbreviated to 4 hex digits. - Userspace Datapath: * Added NAT support for userspace data

[ovs-dev] [patch_v11 4/7] Userspace Datapath: Add TFTP support.

2017-08-06 Thread Darrell Ball
Both ipv4 and ipv6 are supported. Also, NAT support is included. Signed-off-by: Darrell Ball --- include/sparse/netinet/in.h | 3 ++- lib/conntrack.c | 39 ++- 2 files changed, 40 insertions(+), 2 deletions(-) diff --git a/include/sparse/netinet/

[ovs-dev] [patch_v11 5/7] System tests: Enable ALGs for userspace.

2017-08-06 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 3fc4ef9..f3337f0 100644 --- a/tests/system-userspace-macros.at +++ b/tests/system-u

[ovs-dev] [patch_v11 1/7] string: Implement strcasestr for Windows.

2017-08-06 Thread Darrell Ball
strcasestr is not defined for Windows, so implement a version that could be used on Windows. This is needed for an upcoming patch. Signed-off-by: Darrell Ball Co-authored-by: Ben Pfaff Signed-off-by: Ben Pfaff --- lib/string.c| 22 -- lib/string.h.in | 3 ++- 2 files c

[ovs-dev] [patch_v11 0/7] Userspace Datapath: Add ALG support.

2017-08-06 Thread Darrell Ball
ALG infra is added with support for FTP and TFTP. Both V4 and V6 are supported. Also, NAT is supported. Three passive ftp system tests are added to complete testing coverage of ftp for the userspace datapath, as the existing coverage of passive ftp was limited to one part of one test for V4 only.

[ovs-dev] [patch_v11 2/7] Userspace Datapath: Introduce conn_key_cmp().

2017-08-06 Thread Darrell Ball
A new function conn_key_cmp() is introduced and used to replace memcmp of conn_keys. Given that OVS runs on with many compilers and on many architectures, it seems prudent to avoid memcmp in case existing and future holes in conn_key are not handled by a given compiler for a given architecture. Si

Re: [ovs-dev] [PATCH v4 5/5] redhat: allow dpdk to also run as non-root user

2017-08-06 Thread Aaron Conole
Russell Bryant writes: > On Fri, Aug 4, 2017 at 1:00 PM, Aaron Conole wrote: >> After this commit, users may start a dpdk-enabled ovs setup as a >> non-root user. This is accomplished by exporting the $HOME directory, >> which dpdk uses to fill in it's semi-persistent RTE configuration. >> >> T

[ovs-dev] [PATCH] netdev-tc-offloads: Fix parsing SCTP in dump flows

2017-08-06 Thread Roi Dayan
After splitting the unions of tcp/udp the sctp was forgotten when parsing flower back to match. Fixes: 2b1d9fa90909 ("tc: Split IPs and transport layer ports unions in flower struct") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- lib/netdev-tc-offloads.c |3 +++ 1 files changed, 3