Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

On Mon, Aug 7, 2017 at 8:42 PM, Ben Pfaff wrote: > On Fri, Jul 14, 2017 at 08:36:39AM +0200, Christian Ehrhardt wrote: > > If available use dpdk pkg-config info of libdpdk to set the right > > include paths. > > That for example, allows packagers to provide non default include > >

[ovs-dev] [PATCH net-next] openvswitch: add NSH support

OVS master and 2.8 branch has merged NSH userspace patch series, this patch is to enable NSH support in kernel data path in order that OVS can support NSH in 2.8 release in compat mode by porting this. Signed-off-by: Yi Yang --- drivers/net/vxlan.c | 7 ++

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On 07/08/2017 20:05, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: From: Paul Blakey Always implement get_ifindex without checking if offload is enabled or not as this should not be

[ovs-dev] Payment of $10,178.80

Congratulations! You've just received your first payment through Stripe. Your first payout for this payment of $10,178.80 (minus any fees) will land in your bank account on August 13, 2017. You can view the full details of this payment in your dashboard:

Re: [ovs-dev] [ovs-tests] Questions about ovs tests

For example, in tests/dpif-netdev.at file, there are OVS_VSWITCHD_START( > [add-port br0 p1 -- set interface p1 type=dummy > options:pstream=punix:$OVS_RUNDIR/p0.sock ofport_request=1 -- \ >add-port br0 p7 -- set interface p7 ofport_request=7 type=dummy -- \ >add-br br1 -- \ >set

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Hi Ian Are you interested in reviewing this ? Thanks Darrell -Original Message- From: on behalf of Gao Zhenyu Date: Monday, August 7, 2017 at 6:36 PM To: Ben Pfaff , "Chandran, Sugesh"

Re: [ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check.

Thanks for fixing this Joe -Original Message- From: on behalf of Joe Stringer Date: Monday, August 7, 2017 at 5:35 PM To: Andy Zhou Cc: "" Subject: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH] system-kmod-macros: Load TFTP module.

Thanks Joe for fixing this. Maybe it was not a good day to take the afternoon off. Darrell -Original Message- From: on behalf of Joe Stringer Date: Monday, August 7, 2017 at 5:36 PM To: Andy Zhou Cc:

[ovs-dev] [ovs-tests] Questions about ovs tests

Hi all, I'm working on ovs tests, and I want to add my test, so I have few questions: 1. what testing frame work does ovs-tests use, as I have seen lots of *.at file, lots of AT_*() macro. 2. Will ovs-tests start ovs-vswitchd or ovsdb-server when running test by `make check` command? As if no

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

ping Thanks Zhenyu Gao 2017-07-25 18:27 GMT+08:00 Zhenyu Gao : > In dpdk_do_tx_copy function, all packets were copied to mbuf first, > but QoS checking may drop some of them. > Move the QoS checking in front of copying data to mbuf, it helps to > reduce useless

[ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

Ok, I will make a new version which have no mirror switch. This may need some days. Thanks Gao Zhenyu 2017/08/07 22:34 收件人：Ben Pfaff , 抄送： wang.qia...@zte.com.cn, ovs dev , zhou.huij...@zte.com.cn,

Re: [ovs-dev] [PATCH 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On 7 August 2017 at 17:00, Ben Pfaff wrote: > On Tue, Jun 27, 2017 at 11:13:10AM -0700, Joe Stringer wrote: >> Commit 32b77c316d9982("dpif: Save added ports in a port map.") >> introduced tracking of all dpif ports by taking a reference on each >> available netdev when the dpif is

Re: [ovs-dev] [PATCH] system-kmod-macros: Load TFTP module.

On 7 August 2017 at 16:56, Andy Zhou wrote: > On Mon, Aug 7, 2017 at 2:58 PM, Joe Stringer wrote: >> Just like the FTP module needs to be loaded to ensure that the FTP tests >> work, the TFTP module needs to be loaded to ensure that the TFTP tests >> work. This patch

Re: [ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check.

On 7 August 2017 at 13:35, Andy Zhou wrote: > On Mon, Aug 7, 2017 at 1:05 PM, Joe Stringer wrote: >> This test checked whether FTP support was available rather than TFTP. >> It should check for TFTP, fix it. >> >> Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and

Re: [ovs-dev] [PATCH 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On Tue, Jun 27, 2017 at 11:13:10AM -0700, Joe Stringer wrote: > Commit 32b77c316d9982("dpif: Save added ports in a port map.") > introduced tracking of all dpif ports by taking a reference on each > available netdev when the dpif is opened, but it failed to clear out and > release references to

Re: [ovs-dev] [PATCH] system-kmod-macros: Load TFTP module.

On Mon, Aug 7, 2017 at 2:58 PM, Joe Stringer wrote: > Just like the FTP module needs to be loaded to ensure that the FTP tests > work, the TFTP module needs to be loaded to ensure that the TFTP tests > work. This patch does so. > > Fixes: 200a9af97d1c ("System tests: Add 4 new ftp

Re: [ovs-dev] [PATCH v4 0/5] Generic Encap & Decap based NSH implementation

Thanks! I applied it. On Mon, Aug 07, 2017 at 07:42:04PM +, Yang, Yi Y wrote: > Ben, thank you so much, we're done finally and hit ovs 2.8. Here is the patch > for NEWS. > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/336952.html > > Is it ok? > > -Original

Re: [ovs-dev] [PATCH] Add NSH support information in NEWS

On Tue, Aug 08, 2017 at 03:33:32AM +0800, Yi Yang wrote: > Signed-off-by: Yi Yang Thanks! Applied to master and branch-2.8. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] system-kmod-macros: Load TFTP module.

Just like the FTP module needs to be loaded to ensure that the FTP tests work, the TFTP module needs to be loaded to ensure that the TFTP tests work. This patch does so. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer ---

Re: [ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check.

On Mon, Aug 7, 2017 at 1:05 PM, Joe Stringer wrote: > This test checked whether FTP support was available rather than TFTP. > It should check for TFTP, fix it. > > Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") > Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-ipfix: Use common OVS functions for getting current time.

On Mon, Jun 5, 2017 at 6:04 PM, Ben Pfaff wrote: > OVS has common infrastructure functions for getting the current time, but > this code was not using them. It is not clear why, so this commit changes > it to use them. > > Signed-off-by: Ben Pfaff Acked-by: Andy

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets wrote: > Almost all batch usecases covered by the new API introduced > in commit 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > except unsafe batch addition. It used in dpif-netdev for fast > per-flow batches filling.

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-upcall: Fix key attr iteration.

On 3 August 2017 at 14:35, Ben Pfaff wrote: > On Mon, Jul 31, 2017 at 04:54:22PM -0700, Joe Stringer wrote: >> This call is operating on messages generated by the datapath. If a >> datapath implementation sends improperly formatted netlink attributes, >> then it's possible for a

[ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check.

This test checked whether FTP support was available rather than TFTP. It should check for TFTP, fix it. Fixes: 200a9af97d1c ("System tests: Add 4 new ftp and tftp tests.") Signed-off-by: Joe Stringer --- tests/system-traffic.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

On 3 August 2017 at 14:34, Ben Pfaff wrote: > On Mon, Jul 31, 2017 at 04:54:21PM -0700, Joe Stringer wrote: >> This calls is operating on messages generated by the datapath. If a >> datapath implementation sends improperly formatted netlink attributes, >> then it's possible for a

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-upcall: Fix action attr iteration.

On 2 August 2017 at 17:11, Greg Rose wrote: > On 07/31/2017 04:54 PM, Joe Stringer wrote: >> >> This calls is operating on messages generated by the datapath. If a > > > s/calls/call > >> datapath implementation sends improperly formatted netlink attributes, >> then it's

Re: [ovs-dev] [PATCH v4 0/5] Generic Encap & Decap based NSH implementation

Ben, thank you so much, we're done finally and hit ovs 2.8. Here is the patch for NEWS. https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/336952.html Is it ok? -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Tuesday, August 8, 2017 2:34 AM To: Yang, Yi Y

Re: [ovs-dev] [PATCH] AUTHORS: Add Wang Zhike.

On 3 August 2017 at 11:16, Ben Pfaff wrote: > On Fri, Jul 21, 2017 at 11:29:13AM -0700, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Acked-by: Ben Pfaff Thanks, applied to master and branch-2.8. ___

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

On Fri, Jul 14, 2017 at 08:36:39AM +0200, Christian Ehrhardt wrote: > If available use dpdk pkg-config info of libdpdk to set the right > include paths. > That for example, allows packagers to provide non default include > paths in a common way (pkg-config). > > *update in v2* > - following the

Re: [ovs-dev] [PATCH v4 0/5] Generic Encap & Decap based NSH implementation

Thanks. I applied this series to master and branch-2.8. I'd appreciate it if you'd follow up with a patch that adds an appropriate item to NEWS. On Sat, Aug 05, 2017 at 01:41:07PM +0800, Yi Yang wrote: > v3->v4 > - Merge Ben's incrmental patches > - Rebase to current master > - Fix two

Re: [ovs-dev] [patch_v11 0/7] Userspace Datapath: Add ALG support.

Thanks, applied to master and branch-2.8. On Sun, Aug 06, 2017 at 10:51:11AM -0700, Darrell Ball wrote: > ALG infra is added with support for FTP and TFTP. > Both V4 and V6 are supported. Also, NAT is supported. > > Three passive ftp system tests are added to complete testing > coverage of ftp

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

> > > Acked-by: Ben Pfaff > Thank you! I applied this to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 3/3] ovsdb-idl: Avoid mutable type specifier.

In C++, 'mutable' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'mutable_' to avoid this issue. Signed-off-by: Joe Stringer ---

[ovs-dev] [PATCH 2/3] ovsdb-idl: Avoid new expression.

In C++, 'new' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'new_' to avoid this issue. Signed-off-by: Joe Stringer --- lib/ovsdb-data.h | 4

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

On Mon, Aug 07, 2017 at 10:27:26AM -0700, Guru Shetty wrote: > On 7 August 2017 at 10:14, Ben Pfaff wrote: > > > On Mon, Aug 07, 2017 at 10:10:40AM -0700, Guru Shetty wrote: > > > On 7 August 2017 at 09:50, Ben Pfaff wrote: > > > > > > > On Sun, Aug 06, 2017 at

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

On 7 August 2017 at 10:14, Ben Pfaff wrote: > On Mon, Aug 07, 2017 at 10:10:40AM -0700, Guru Shetty wrote: > > On 7 August 2017 at 09:50, Ben Pfaff wrote: > > > > > On Sun, Aug 06, 2017 at 10:56:30PM -0700, Gurucharan Shetty wrote: > > > > We had one note about the

Re: [ovs-dev] [PATCH] debian: Add another note on interfaces in "auto" section.

On Mon, Aug 07, 2017 at 10:10:40AM -0700, Guru Shetty wrote: > On 7 August 2017 at 09:50, Ben Pfaff wrote: > > > On Sun, Aug 06, 2017 at 10:56:30PM -0700, Gurucharan Shetty wrote: > > > We had one note about the issues with adding OVS interfaces > > > in the "auto" section. This

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote: > On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > > From: Paul Blakey > > > > Always implement get_ifindex without checking if offload is > > enabled or not as this should not be related. From ovs-dpctl >

[ovs-dev] [PATCH 3/7] match: Add helper function to set nw_ttl with mask

From: Paul Blakey Add help function match_set_nw_ttl_masked() Will be used later to set ttl value. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 3 ++- lib/match.c | 7 +++ 2

[ovs-dev] [PATCH V2] netdev-linux: Reduce log level for ENODEV errors getting ifindex

These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- V1->V2: - bring back ratelimiting lib/netdev-linux.c | 8 ++--

[ovs-dev] [PATCH] controller: Remote connection option to OpenFlow switch.

Currently ovn-controller uses default unix domain socket in Open vSwitch's "run" directory to connect to OpenFlow switch. If ovn-controller/ovsdb-server and vswitchd are running on different systems, remote connection method needs to be provided. Added configuration option to override default

[ovs-dev] [PATCH] MAINTAINERS: Add Alin Serdean.

Alin was elected by the Open vSwitch committers on Friday. Welcome to the team, Alin! CC: Alin Serdean Signed-off-by: Ben Pfaff --- MAINTAINERS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst index

Re: [ovs-dev] [PATCH 2/2] netdev-linux: Reduce log level for ENODEV errors getting ifindex

On 07/08/2017 17:01, Ben Pfaff wrote: On Mon, Aug 07, 2017 at 07:32:03AM +0300, Roi Dayan wrote: These are normal and unavoidable, because the vifs disappear from the kernel before they are removed them from the OVS database. Signed-off-by: Roi Dayan Reviewed-by: Paul

Re: [ovs-dev] [PATCH 1/2] netdev-vport: Always implement get_ifindex for netdev-vport

On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote: > From: Paul Blakey > > Always implement get_ifindex without checking if offload is > enabled or not as this should not be related. From ovs-dpctl > we cannot tell if offload is enabled or not as other_config is > not

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

You keep mentioning "a new type of switch". I don't understand this. Who has proposed adding a new type of switch, and what kind of switch would this be? On Mon, Aug 07, 2017 at 01:37:52PM +0800, wang.qia...@zte.com.cn wrote: > If we do not add a new type of switch, we should write flag to a reg

Re: [ovs-dev] [PATCH v3 1/2] dpif-netdev: Decrease range of values for EMC probability.

On 04.08.2017 23:39, Wang, Yipeng1 wrote: > > >> -Original Message- >> From: Darrell Ball [mailto:db...@vmware.com] >> Sent: Friday, August 4, 2017 11:35 AM >> To: Ilya Maximets ; ovs-dev@openvswitch.org >> Cc: Heetae Ahn ; Wang, Yipeng1

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

LGTM Thanks Zhenyu Gao 2017-08-07 18:24 GMT+08:00 Christian Ehrhardt < christian.ehrha...@canonical.com>: > Ping, any update on including this? > > On Fri, Jul 14, 2017 at 8:36 AM, Christian Ehrhardt < > christian.ehrha...@canonical.com> wrote: > > > If available use dpdk pkg-config info of

Re: [ovs-dev] [PATCH v2] acinclude: netdev-dpdk: use pkg-config of libdpdk

Ping, any update on including this? On Fri, Jul 14, 2017 at 8:36 AM, Christian Ehrhardt < christian.ehrha...@canonical.com> wrote: > If available use dpdk pkg-config info of libdpdk to set the right > include paths. > That for example, allows packagers to provide non default include > paths in a

[ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

Hi Zhenyu, Ben and Russell, Thanks for your review. I think function of taas is independent, and have no influence with logical switch. Similar to logcial switch and logical router, I think independent function should use independent pipeline. Here, is there some constraints or problems to add

Re: [ovs-dev] [PATCH v3 00/19] Add OVS DPDK keep-alive functionality.

I understand that using rte_keepalive library was worth in the early RFC because size of RFC was comparable with the size of rte_keepalive library. But now, as so many generic things was implemented in lib/keepalive.{c,h} and the size of the patch-set is pretty large, IMHO, it's better to

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH] ovn: Support for taas(tap-as-a-service) function

I think consuming a bit in reg to indicate if a packet is mirror packet or regular packet is doable as well. And it is easy to implement. Other table like port_security can check if it a mirror packet and do the right actions(drop or forwarding to next table). Thanks Zhenyu Gao 2017-08-07 13:37