Re: [ovs-dev] Query: Getting session state with the server from my-ovsdb-client code

Hi Ben, I'm using ovsdb replication feature. Now when the server transitions from 'Active' to 'Backup' state, the client doesn't get a notification about the server's state(active/backup). Obviously the client can use 'ovsdb-server/sync-status' ctl command to pull the server's state info, but

Re: [ovs-dev] Query: Getting session state with the server from my-ovsdb-client code

On Wed, Aug 30, 2017 at 08:03:39AM +0530, Arunkumar Rg wrote: > I'm using ovsdb_idl in my-ovsdb-client code. In my clide code, when I > create the idl using ovsdb_idl_create(), I set the 'retry' argument has > true, so that if the connection to server gets closed, it does a retry. > > Now from my

Re: [ovs-dev] [PATCHv2] ofproto-dpif: Mark packets as "untracked" after call to ct().

On Mon, 21 Aug 2017 12:56:33 -0700 Justin Pettit wrote: > > On Aug 21, 2017, at 12:38 PM, Joe Stringer wrote: > > > > Overall I think that this is an improvement to consistency of what > > connection tracking metadata is accessible from different points in > >

Re: [ovs-dev] [PATCH] fix ovsdb-server memory growth issues when ovs-vsctl cmd stucking.

We have found a patch (http://patchwork.ozlabs.org/patch/593753/) can resolve this problem. BR. Zeng Ganghui Huawei Technologies Co., Ltd. -Original Message- From: zengganghui Sent: Monday, August 28, 2017 11:15 AM To: 'Ben Pfaff' Cc: d...@openvswitch.org Subject: RE: [PATCH] fix

[ovs-dev] [PATCH] bond: send learning pkg when non active slave failed.

In active-active bond, a non-active slave failure doesn't trigger the sending of learning packets. This patch fixes this issue. Signed-off-by: minglumlu --- ofproto/bond.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ofproto/bond.c b/ofproto/bond.c index

[ovs-dev] Query: Getting session state with the server from my-ovsdb-client code

Hi, I'm using ovsdb_idl in my-ovsdb-client code. In my clide code, when I create the idl using ovsdb_idl_create(), I set the 'retry' argument has true, so that if the connection to server gets closed, it does a retry. Now from my client code, I wanted to know the session state with the server.

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On Wed, Aug 30, 2017 at 02:02:23AM +, Darrell Ball wrote: > > > +#define MAX_RTE_FLOW_ITEMS 100 > > +#define MAX_RTE_FLOW_ACTIONS100 > > > > I guess these are temporary > > Yes, the hardcoded number is really hacky. > > > Do we need

Re: [ovs-dev] [PATCH 2/7] dpif-netdev: retrieve flow directly from the flow mark

On Wed, Aug 30, 2017 at 01:55:28AM +, Darrell Ball wrote: > > > On 8/29/17, 5:09 AM, "Yuanhan Liu" wrote: > > On Tue, Aug 29, 2017 at 07:14:48AM +, Darrell Ball wrote: > > Hi > > > > There is a build issue after patch 2 is applied > > > >

Re: [ovs-dev] [PATCH 0/7 RFC] OVS-DPDK flow offload with rte_flow

On Wed, Aug 30, 2017 at 01:32:10AM +, Darrell Ball wrote: > > > Though that being said, this patchset still has issues > unresolved. The > > major issue is that maybe most NIC (for instance, Mellanox and > Intel) > > can not support a pure MARK action. It

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On 8/29/17, 5:15 AM, "Yuanhan Liu" wrote: On Tue, Aug 29, 2017 at 08:11:23AM +, Darrell Ball wrote: > > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > From: Finn Christensen >

Re: [ovs-dev] [PATCH 2/7] dpif-netdev: retrieve flow directly from the flow mark

On 8/29/17, 5:09 AM, "Yuanhan Liu" wrote: On Tue, Aug 29, 2017 at 07:14:48AM +, Darrell Ball wrote: > Hi > > There is a build issue after patch 2 is applied > > f-netdev.Tpo -c ../lib/dpif-netdev.c -o lib/dpif-netdev.o >

Re: [ovs-dev] [PATCH RFC v3 4/4] dpif-netdev: Time based output batching.

Hi Jan/Ilya/Bhanu Just wondering if we are still pursuing this patch series ? Thanks Darrell On 8/14/17, 8:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Jan Scheurich" wrote: > > We have tested the effect

[ovs-dev] [PATCH] ovn-controller: support configurable acl log file rate limit

Add parameters in local Open_vSwitch DB external-ids for rate- limiting the log file writing: ovn-acl-log-rl-rate ovn-acl-log-rl-burst Note: this has nothing to do with packet-in rate-limiting. Signed-off-by: Han Zhou --- ovn/controller/pinctrl.c | 2 ++

Re: [ovs-dev] OVN: IPv6 Periodic Router Advertisement Plan

On Tue, Aug 29, 2017 at 3:15 PM Brian Haley wrote: > Sorry for the slow review, was on PTO. Comments below. > > On 08/22/2017 05:43 PM, Mark Michelson wrote: > > Hi folks, > > > > For a while now, in a "learn the OVN project from scratch" project, I've > > been

Re: [ovs-dev] OVN: IPv6 Periodic Router Advertisement Plan

Sorry for the slow review, was on PTO. Comments below. On 08/22/2017 05:43 PM, Mark Michelson wrote: Hi folks, For a while now, in a "learn the OVN project from scratch" project, I've been investigating what it would take in order to allow for OVN to send periodic router advertisements (RAs)

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

___ >From: ovs-dev-boun...@openvswitch.org on >behalf of Sairam Venugopal >Sent: Monday, August 28, 2017 4:56 PM >To: d...@openvswitch.org >Subject: [ovs-dev] [PATCH] datapath-windows: Add an upper limit

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

Please check the comments inline. Thanks, Sairam On 8/28/17, 8:55 PM, "Shashank Ram" wrote: > > > > >From: ovs-dev-boun...@openvswitch.org on >behalf of Sairam Venugopal >Sent:

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

Hi Anand, OvsProcessConntrackEntry ensures that the old entry is deleted before creating a new one. So it would prevent newer entries from being created or the limit being hit. I added in the function before processing to exit out quickly only if there was no matching entry and commit was

Re: [ovs-dev] [PATCH] datapath-windows: Add an upper limit to conntrack entries

Hi Sairam, Thanks for the patch. Please find my comment inline. Regards, Anand Kumar On 8/28/17, 4:56 PM, "ovs-dev-boun...@openvswitch.org on behalf of Sairam Venugopal" wrote: The current implementation lacked an upper

Re: [ovs-dev] [PATCH] NEWS: Mark NSH support as experimental in 2.8.

On Tue, 29 Aug 2017 10:50:11 -0700 Ben Pfaff wrote: > This feature landed late in 2.8 and the NSH wire protocol itself is not > completely stable. > > CC: Jiri Benc > CC: Flavio Leitner > Signed-off-by: Ben Pfaff > --- > NEWS

[ovs-dev] [PATCH v5 1/2] nsh: add new flow key 'ttl'

IETF NSH draft will be approved by end of August, NSH header format has been finalized and won't be change anymore, so we need to follow this final spec to implement nsh. kernel data path also needs finalized uAPIs, they can't be changed once they are merged. This patch adds new nsh key 'ttl',

[ovs-dev] [PATCH v5 2/2] nsh: add dec_nsh_ttl action

IETF NSH spec defines a ttl field in NSH header, it is a 6-bit field ranged from 0 to 63, it should be decremented by 1 every hop, if it is 0 or it is so after decremented, the packet should be dropped and a packet-in message is sent to main controller. Signed-off-by: Yi Yang

[ovs-dev] [PATCH v5 0/2] nsh: add new nsh key ttl and action dec_nsh_ttl

v4->v5 - Remove fix patch 1 in v4 because it is merged - Fix several comments by Jan Scheurich v3->v4 - Add new action dec_nsh_ttl - Remove encap_nsh and decap_nsh changes - Remove netlink rework to adapt to OVS 2.8 - Dynamically allocate struct ovs_action_encap_nsh and put

Re: [ovs-dev] [PATCH] NEWS: Mark NSH support as experimental in 2.8.

On Tue, 29 Aug 2017 10:50:11 -0700, Ben Pfaff wrote: > This feature landed late in 2.8 and the NSH wire protocol itself is not > completely stable. Acked-by: Jiri Benc ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

On Wed, Aug 30, 2017 at 01:02:07AM +0800, Jan Scheurich wrote: > Hi Yi, > > Some more comments below. > > /Jan > > > -Original Message- > > From: Yang, Yi [mailto:yi.y.y...@intel.com] > > Sent: Tuesday, 29 August, 2017 08:31 > > To: Jan Scheurich > > Cc:

Re: [ovs-dev] [PATCH] sparse: eliminate "duplicate initialization" warning

On 08/28/2017 08:23 AM, Lance Richardson wrote: Sparse version 0.5.1 will be released in the near future. Prepare for it by eliminating the only new warning (as of 0.5.1-rc5): ofproto/fail-open.c:134:22: error: Initializer entry defined twice ofproto/fail-open.c:135:22: also defined here

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

Hi Yi, Some more comments below. /Jan > -Original Message- > From: Yang, Yi [mailto:yi.y.y...@intel.com] > Sent: Tuesday, 29 August, 2017 08:31 > To: Jan Scheurich > Cc: d...@openvswitch.org; b...@ovn.org > Subject: Re: [PATCH v4 2/3] nsh: add new flow key

Re: [ovs-dev] [PATCH] timeval: Fix misleading function descriptions.

On 08/28/2017 12:08 AM, Ilya Maximets wrote: TIME_UPDATE_INTERVAL was removed long time ago. Now each call leads to time update via syscall and it's granularity is system dependent. Fixes: 31ef9f5178de ("timeval: Remove CACHE_TIME scheme.") Signed-off-by: Ilya Maximets

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

On Tue, Aug 29, 2017 at 02:30:35PM +0800, Yang, Yi wrote: > I'll send out new version after Ben gives me feedbacks. I'd like to see v5. I'm hoping to just go ahead and apply it. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 1/3] nsh: fix an implicit bug in nsh_hdr_len

On Fri, Aug 25, 2017 at 12:02:49PM +0800, Yi Yang wrote: > Operator '*' will be executed prior to operator '>>', > but we expect operator '>>' is executed prior to '*', > this patch fixed the issue. > > Signed-off-by: Yi Yang Applied to master and branch-2.8, thanks!

Re: [ovs-dev] [PATCH v4 3/3] nsh: add dec_nsh_ttl action

On Mon, Aug 28, 2017 at 12:47:52PM +, Jan Scheurich wrote: > > -Original Message- > > From: Yi Yang [mailto:yi.y.y...@intel.com] > > > > +static bool > > +compose_dec_nsh_ttl_action(struct xlate_ctx *ctx) { > > +struct flow *flow = >xin->flow; > > + > > +if ((flow->packet_type

Re: [ovs-dev] [PATCH] dpif: Remove duplicated word in comment for dpif_recv()

On 08/25/2017 07:27 PM, fukaige wrote: From: Kaige Fu Signed-off-by: Kaige Fu --- lib/dpif.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index 79b2e6c..a4471d5 100644 --- a/lib/dpif.c +++

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

On 08/29/2017 04:48 AM, Weglicki, MichalX wrote: Hello Greg, Unfortunately Przemek is not available, but I'm more or less familiar with this patch. Did you manage to fix this issue? I think that your problems lies on connection level, which wasn't modified by this patch. Patch added

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Thanks for rebasing Zhenyu, Will look at this version for testing and review this week. Ian From: Gao Zhenyu [mailto:sysugaozhe...@gmail.com] Sent: Tuesday, August 29, 2017 1:33 PM To: Stokes, Ian Cc: Darrell Ball ; Ben Pfaff ; Chandran,

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Execute QoS Checking before copying to mbuf

Hi Ian, Please take a look at v2 https://patchwork.ozlabs.org/patch/807059/ :) No code change, just rebase to latest master. Thanks Zhenyu Gao 2017-08-28 21:12 GMT+08:00 Stokes, Ian : > Hi Zhenyu, > > > > Sincere apologies for the delay, I’ll be reviewing the patch

Re: [ovs-dev] [PATCH 7/7] netdev-dpdk: set FDIR config

On Tue, Aug 29, 2017 at 08:25:57AM +, Darrell Ball wrote: > > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > From: Finn Christensen > > This is necessary to make Intel nic work. > > Could we add a comment why this

Re: [ovs-dev] [PATCH 6/7] netdev-dpdk: remove offloaded flow on deletion

On Tue, Aug 29, 2017 at 08:21:20AM +, Darrell Ball wrote: > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > Inovke netdev class '->flow_del' method on flow deletion. The dpdk > netdev > implementation will then remove the rte flow associated with the

Re: [ovs-dev] [PATCH 5/7] netdev-dpdk: retry with queue action

On Tue, Aug 29, 2017 at 08:15:56AM +, Darrell Ball wrote: > > > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > From: Finn Christensen > > AFAIK, both Mellanox and Intel's NIC do not support a pure MARK >

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On Tue, Aug 29, 2017 at 08:11:23AM +, Darrell Ball wrote: > > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > From: Finn Christensen > > The basic yet the major part of this patch is to translate the "match" >

Re: [ovs-dev] [PATCH 2/7] dpif-netdev: retrieve flow directly from the flow mark

On Tue, Aug 29, 2017 at 07:14:48AM +, Darrell Ball wrote: > Hi > > There is a build issue after patch 2 is applied > > f-netdev.Tpo -c ../lib/dpif-netdev.c -o lib/dpif-netdev.o > ../lib/dpif-netdev.c: In function 'emc_processing': > ../lib/dpif-netdev.c:4782:21: error: excess elements in

Re: [ovs-dev] [PATCH 0/7 RFC] OVS-DPDK flow offload with rte_flow

On Tue, Aug 29, 2017 at 07:11:42AM +, Darrell Ball wrote: > > On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: > > Hi, > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > offload with the DPDK generic flow

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Hello Greg, Unfortunately Przemek is not available, but I'm more or less familiar with this patch. Did you manage to fix this issue? I think that your problems lies on connection level, which wasn't modified by this patch. Patch added additional counters on reporting level, and based on

[ovs-dev] [PATCH v2] netdev-dpdk: Execute QoS Checking before copying to mbuf

In dpdk_do_tx_copy function, all packets were copied to mbuf first, but QoS checking may drop some of them. Move the QoS checking in front of copying data to mbuf, it helps to reduce useless copy. Signed-off-by: Zhenyu Gao --- lib/netdev-dpdk.c | 55

Re: [ovs-dev] Improved Packet Drop Statistics in OVS

Hi Darrell, Thanks for reviewing the document and providing the feedback. My response inline, pl search for [Rohith] On 29/08/17, 1:20 AM, "Darrell Ball" wrote: Hi Rohith Thanks for the improvement proposal and

[ovs-dev] [PATCH] docs: Add references to git-pw

Now that Patchwork 2.0 is out, folks can start to take advantage of some of the new features that it offers. Chief among these is series support, which is only exposed via the web UI and new REST API and which, in turn, necessitates using git-pw rather than pwclient. As such, this tool is slightly

Re: [ovs-dev] [PATCH] windows, python: remove dead code in send_wait

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

CC: Russell Bryant ; Lance Richardson Can you please take a look? Tested-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Create separate memory pool for each port.

Hi Antonio I plan to look at this more closely tomorrow and hope to get this in this week. Thanks Darrell On 8/25/17, 3:09 AM, "ovs-dev-boun...@openvswitch.org on behalf of antonio.fische...@intel.com" wrote:

Re: [ovs-dev] [PATCH 7/7] netdev-dpdk: set FDIR config

On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: From: Finn Christensen This is necessary to make Intel nic work. Could we add a comment why this is needed ? Signed-off-by: Finn Christensen

Re: [ovs-dev] [PATCH 6/7] netdev-dpdk: remove offloaded flow on deletion

On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: Inovke netdev class '->flow_del' method on flow deletion. The dpdk netdev implementation will then remove the rte flow associated with the ufid. Signed-off-by: Yuanhan Liu

Re: [ovs-dev] [PATCH 5/7] netdev-dpdk: retry with queue action

On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: From: Finn Christensen AFAIK, both Mellanox and Intel's NIC do not support a pure MARK action. They both require to use it together with some other actions, like

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: From: Finn Christensen The basic yet the major part of this patch is to translate the "match" to rte flow patterns. And then, we create a rte flow with a MARK action.

Re: [ovs-dev] [PATCH 2/2] windows,python: remove unnecessary code

Acked-by: Alin Gabriel Serdean > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Balutoiu > Sent: Friday, August 25, 2017 6:03 PM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2]

Re: [ovs-dev] [PATCH 2/7] dpif-netdev: retrieve flow directly from the flow mark

Hi There is a build issue after patch 2 is applied f-netdev.Tpo -c ../lib/dpif-netdev.c -o lib/dpif-netdev.o ../lib/dpif-netdev.c: In function 'emc_processing': ../lib/dpif-netdev.c:4782:21: error: excess elements in struct initializer [-Werror] miniflow_values(_mf),

Re: [ovs-dev] [PATCH 0/7 RFC] OVS-DPDK flow offload with rte_flow

On 8/22/17, 11:24 PM, "Yuanhan Liu" wrote: Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow

Re: [ovs-dev] [PATCH v4 2/3] nsh: add new flow key 'ttl'

On Tue, Aug 29, 2017 at 07:31:22AM +0800, Jan Scheurich wrote: > Hi Yi, > > Thanks for the fixes. Please find my individual comments inline. > > BR, Jan > > > -Original Message- > > -#define OVS_ENCAP_NSH_MAX_MD_LEN 16 > > /* > > * struct ovs_action_encap_nsh -

[ovs-dev] [RFC] Deploy HA for Ovn-controller-vtep

Hi everyone Ovn-controller-vtep is the link of logical switch and pysical switch. Whether we should deploy the Ovn-controller-vtep and vtep db with HA? Thanks. ___ dev mailing list d...@openvswitch.org