Re: [ovs-dev] [PATCH v4 0/7] Add OVS DPDK keep-alive functionality.

Hi Bhanu, I added some comments on patches #2, 5 and 7. Besides that LGTM. I applied this patch series to commit 84d2723305064e25402cb89a16bf7ad1aa2cda70 and it works as expected. -Antonio > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.o

Re: [ovs-dev] [PATCH v4 2/7] Keepalive: Add initial keepalive support.

Comments inline. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] > On Behalf Of Bhanuprakash Bodireddy > Sent: Tuesday, August 22, 2017 10:41 AM > To: d...@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: [ovs-dev] [PATCH v4 2/7]

Re: [ovs-dev] [PATCH v4 5/7] keepalive: Retrieve PMD status periodically.

Comments inline. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] > On Behalf Of Bhanuprakash Bodireddy > Sent: Tuesday, August 22, 2017 10:41 AM > To: d...@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: [ovs-dev] [PATCH v4 5/7]

Re: [ovs-dev] [PATCH v4 7/7] keepalive: Add support to query keepalive status and statistics.

Comments inline. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] > On Behalf Of Bhanuprakash Bodireddy > Sent: Tuesday, August 22, 2017 10:41 AM > To: d...@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: [ovs-dev] [PATCH v4 7/7]

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On Fri, Sep 01, 2017 at 10:38:37PM +, Darrell Ball wrote: > > > On 8/29/17, 7:33 PM, "Yuanhan Liu" wrote: > > On Wed, Aug 30, 2017 at 02:02:23AM +, Darrell Ball wrote: > > > > > +#define MAX_RTE_FLOW_ITEMS 100 > > > +#define MAX_RTE_FLOW_ACT

Re: [ovs-dev] [PATCH 0/7 RFC] OVS-DPDK flow offload with rte_flow

On Fri, Sep 01, 2017 at 10:35:51PM +, Darrell Ball wrote: > > > On 8/31/17, 3:13 AM, "Yuanhan Liu" wrote: > > On Wed, Aug 30, 2017 at 07:28:01PM +, Darrell Ball wrote: > > > > [Finn] > > > > I think we should not further intermix the rxqs distribute

[ovs-dev] [PATCH v2 0/8] OVS-DPDK flow offload with rte_flow

Hi, Here is a joint work from Mellanox and Napatech, to enable the flow hw offload with the DPDK generic flow interface (rte_flow). The basic idea is to associate the flow with a mark id (a unit32_t number). Later, we then get the flow directly from the mark id, bypassing the heavy emc processing

[ovs-dev] [PATCH v2 1/8] dpif-netdev: associate flow with a mark id

This patch associate a flow with a mark id (a uint32_t number) by CMAP. It re-uses the flow API (more precisely, the ->flow_put method) to setup the hw flow. The flow_put implementation then is supposed to create a flow with MARK action. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Li

[ovs-dev] [PATCH v2 2/8] dpif-netdev: retrieve flow directly from the flow mark

So that we could skip the heavy emc processing, notably, the miniflow_extract function. A simple PHY-PHY forwarding testing shows 53% performance improvement. Note that though the heavy miniflow_extract is skipped, we still have to do per packet checking, due to we have to check the tcp_flags. Co

[ovs-dev] [PATCH v2 3/8] netdev-dpdk: convert ufid to dpdk flow

Flows offloaded to DPDK are identified by rte_flow pointer while OVS flows are identified by ufid. This patches adds a hmap to convert ufid to dpdk flow (rte_flow). Most of the code are stolen from netdev-tc-offloads.c, with some modificatons. Some functions are marked as "inline", which is a tri

[ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

From: Finn Christensen The basic yet the major part of this patch is to translate the "match" to rte flow patterns. And then, we create a rte flow with a MARK action. Afterwards, all pkts matches the flow will have the mark id in the mbuf. For any unsupported flows, such as MPLS, -1 is returned,

[ovs-dev] [PATCH v2 5/8] dpif-netdev: record rx queue id for the upcall

From: Shachar Beiser For the DPDK flow offload, which basically just binds a MARK action to a flow, the MARK is required to be used together with a QUEUE action for the most NICs I'm aware of. The QUEUE action then needs a queue index, which is not given in the flow content. Here we record the r

[ovs-dev] [PATCH v2 6/8] netdev-dpdk: retry with queue action

From: Finn Christensen AFAIK, most (if not all) NICs (including Mellanox and Intel) do not support a pure MARK action. It's required to be used together with some other actions, like QUEUE. To workaround it, retry with a queue action when first try failed. Moreover, some Intel's NIC (say XL710

[ovs-dev] [PATCH v2 7/8] netdev-dpdk: remove offloaded flow on deletion

Inovke netdev class '->flow_del' method on flow deletion. The dpdk netdev implementation will then remove the rte flow associated with the ufid. Co-authored-by: Finn Christensen Signed-off-by: Yuanhan Liu Signed-off-by: Finn Christensen --- v2: - check the returned "port" from dp_netdev_lookup

[ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config

From: Finn Christensen The Intel i40e PMD driver requires the fdir mode set to RTE_FDIR_MODE_PERFECT, otherwise, the flow creation would be failed. Co-authored-by: Yuanhan Liu Signed-off-by: Finn Christensen Signed-off-by: Yuanhan Liu --- --- lib/netdev-dpdk.c | 3 +++ 1 file changed, 3 inse

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, 5 Sep 2017 13:51:45 +0800, Yang, Yi wrote: > But if we follow your way, how does nla_for_each_nested handle such > pattern? > > attribute1 > attribute1_mask > attribute2 > attribute2_mask > attribute3 > attribute3_mask Uh? That will just work. Note that nla len contains the size of the wh

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, 5 Sep 2017 14:37:05 +0800, Yang, Yi wrote: > I checked source code but can't find where we can prepopulate it and how > we can deliver the prepopulated header to push_nsh, can you expand it in > order that I can know how to do this in code level? I already said that it's not implemented ye

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Mon, 4 Sep 2017 14:45:50 +, Jan Scheurich wrote: > So what is the correct layout for MASKED_SET action with nested fields? > 1. All nested values, followed by all nested masks, or > 2. For each nested field value followed by mask? > > I guess alternative 1, but just to be sure. It's 2. Alt

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

"Yang, Yi" writes: > I'm not sure what new action you expect to bring here, I think group > action is just for this, as you said it isn't only bound to NSH, you can > start a new thread to discuss this. I don't think it is in scope of NSH. It is in scope of this discussion as you will provide a

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

> From: Jiri Benc [mailto:jb...@redhat.com] > > So what is the correct layout for MASKED_SET action with nested fields? > > 1. All nested values, followed by all nested masks, or > > 2. For each nested field value followed by mask? > > > > I guess alternative 1, but just to be sure. > > It's 2. A

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:47:41AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 14:37:05 +0800, Yang, Yi wrote: > > I checked source code but can't find where we can prepopulate it and how > > we can deliver the prepopulated header to push_nsh, can you expand it in > > order that I can know how to

Re: [ovs-dev] [PATCH net-next v7] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 11:46:45AM +0200, Jiri Benc wrote: > On Tue, 5 Sep 2017 13:51:45 +0800, Yang, Yi wrote: > > But if we follow your way, how does nla_for_each_nested handle such > > pattern? > > > > attribute1 > > attribute1_mask > > attribute2 > > attribute2_mask > > attribute3 > > attribut

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 12:30:09PM +0200, Hannes Frederic Sowa wrote: > "Yang, Yi" writes: > > > I'm not sure what new action you expect to bring here, I think group > > action is just for this, as you said it isn't only bound to NSH, you can > > start a new thread to discuss this. I don't think

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

Hi Hannes, Please have a look at the Google doc that sketches the overall solution to support NSH in OVS. https://drive.google.com/open?id=1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8 In details it is slightly outdated but the NSH MD1 support (and all prerequisites like PTAP and Generic Encap/

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

"Yang, Yi" writes: > On Tue, Sep 05, 2017 at 12:30:09PM +0200, Hannes Frederic Sowa wrote: >> "Yang, Yi" writes: >> >> > I'm not sure what new action you expect to bring here, I think group >> > action is just for this, as you said it isn't only bound to NSH, you can >> > start a new thread to

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

Hello Jan, Jan Scheurich writes: > Please have a look at the Google doc that sketches the overall > solution to support NSH in OVS. > https://drive.google.com/open?id=1oWMYUH8sjZJzWa72o2q9kU0N6pNE-rwZcLH3-kbbDR8 > > In details it is slightly outdated but the NSH MD1 support (and all > prerequisi

Re: [ovs-dev] [PATCH] Set release date for 2.8.0.

On Fri, 1 Sep 2017 11:47:19 -0700 Justin Pettit wrote: > > On Aug 31, 2017, at 1:18 PM, Justin Pettit wrote: > > > >> > >> On Aug 31, 2017, at 1:14 PM, Ben Pfaff wrote: > >> > >> Since you are getting that last revert in for Flavio, and you usually do > >> the releases, do you want to take

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

> > Currently, the dpdk-vhost side in ovs doesn't support tcp/udp tx cksum. > So L4 packets's cksum were calculated in VM side but performance is not > good. > Implementing tcp/udp tx cksum in ovs-dpdk side improves throughput in > VM->phy->phy->VM situation. And it makes virtio-net frontend-drive

[ovs-dev] [PATCH] docs: fix a typo in vhost-user documentation.

This patch fixes a trivial typo in vhost-user documentation: the path to the second socket should be /tmp/dpdkvhostclient1 and not /tmp/dpdkvhostclient0. Signed-off-by: Rami Rosen --- Documentation/topics/dpdk/vhost-user.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc

Re: [ovs-dev] [PATCH 0/7 RFC] OVS-DPDK flow offload with rte_flow

On 9/5/17, 2:01 AM, "Yuanhan Liu" wrote: On Fri, Sep 01, 2017 at 10:35:51PM +, Darrell Ball wrote: > > > On 8/31/17, 3:13 AM, "Yuanhan Liu" wrote: > > On Wed, Aug 30, 2017 at 07:28:01PM +, Darrell Ball wrote: > > > > [Finn] >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Execute QoS Checking before copying to mbuf

Hi Gao How about the following incremental ? Thanks Darrell diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 4808d38..648d719 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1843,64 +1843,58 @@ dpdk_do_tx_copy(struct netdev *netdev, int qid, struct dp_packet_batch *batch)

[ovs-dev] [PATCH] FAQ: Indicate OVS 2.8 supports up to Linux 4.12.

Signed-off-by: Justin Pettit --- Documentation/faq/releases.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index 2ecc24c4d50e..c785529528e9 100644 --- a/Documentation/faq/releases.rst +++ b/Documentation/faq/releases.rst @@

[ovs-dev] Pricelist 05-09-2017

  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rwimoatrf.html )         [ Click here ]( http://r.newsletter.bonescamail.nl/track/click/2n3cr3m25aoatrd ) to find our latest pricelist [ Klicken Sie hier ]( http://r.newsletter.bonescamail.nl/track/click/2n3cr3m2xqoatrd ) fur unse

Re: [ovs-dev] [PATCH v3] ovn: Check for known logical switch port types.

> From: "Mark Michelson" > To: d...@openvswitch.org > Sent: Friday, August 25, 2017 3:14:33 PM > Subject: [ovs-dev] [PATCH v3] ovn: Check for known logical switch port types. > > OVN is lenient with the types of logical switch ports. Maybe too > lenient. This patch attempts to solve this problem

Re: [ovs-dev] [PATCH 1/2] .gitignore: Ignore generated file cxxtest.cc.

On Sun, Sep 3, 2017 at 1:33 PM, Ben Pfaff wrote: > On Fri, Sep 01, 2017 at 09:14:09PM -0400, Russell Bryant wrote: >> Signed-off-by: Russell Bryant > > Acked-by: Ben Pfaff Thanks, I applied this to master and branch-2.8. -- Russell Bryant ___ dev ma

Re: [ovs-dev] [PATCH 1/2] windows, python: create a different event for sockets

Acked-by: Russell Bryant On Tue, Aug 29, 2017 at 5:09 AM, wrote: > CC: Russell Bryant ; Lance Richardson > > Can you please take a look? > > Tested-by: Alin Gabriel Serdean > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >> boun...@openvswitch.org] On

Re: [ovs-dev] 答复: Re: 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

What if a mirror port *only* receives mirrored packets? If the only packets it ever receives are mirrored packets, a new flag would not be necessary. Do you intend for the port to operate as both a regular port *and* to receive a mirror of traffic for another port? On Thu, Aug 24, 2017 at 10:31

[ovs-dev] Saithe filets Iceland

  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rxb2oatrf.html )         MSC Saithe Filets PBO Iceland 3 x 9 kilo FAS   5-8 oz € 3,60 8-16 oz € 3,75 16-32 oz € 3,95 32 oz+ € 3,95   Prices are per single box, bigger volumes prices on request.     This email was sent to d...@

Re: [ovs-dev] [PATCH 2/2] ovn: Support chassis hostname in requested-chassis.

> From: "Russell Bryant" > To: d...@openvswitch.org > Cc: lrich...@redhat.com, "Russell Bryant" > Sent: Friday, September 1, 2017 9:14:10 PM > Subject: [PATCH 2/2] ovn: Support chassis hostname in requested-chassis. > > Previously, OVN expected the Chassis "name" in the "requested-chassis" > opt

[ovs-dev] Tienes una factura sin pagar

Tienes una factura sin pagar Generado el: 05/09/2017 Factura #669790 Descarga la factura con el enlace Attachment(s) : Factura_669790.zip Descarga la factura >> http://bit.ly/2vIaOM0 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.

Re: [ovs-dev] [PATCH 1/2] Set release date for 2.5.4 release.

On Sun, Sep 03, 2017 at 04:00:39PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] Prepare for 2.5.5.

On Sun, Sep 03, 2017 at 04:00:40PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH] ovs-atomic-msvc: Add atomics x64 builds

This patch enables atomics on x64 builds. Reuse the atomics defined for x86 and add atomics for 64 bit reads/writes. Before this patch the cmap test gives us: $ ./tests/ovstest.exe test-cmap benchmark 1000 3 1 Benchmarking with n=1000, 3 threads, 1.00% mutations, batch size 1: cmap insert

[ovs-dev] [PATCH v2] ovs-atomic-msvc: Add atomics x64 builds

This patch enables atomics on x64 builds. Reuse the atomics defined for x86 and add atomics for 64 bit reads/writes. Before this patch the cmap test gives us: $ ./tests/ovstest.exe test-cmap benchmark 1000 3 1 Benchmarking with n=1000, 3 threads, 1.00% mutations, batch size 1: cmap insert

Re: [ovs-dev] [PATCH] ovs-atomic-msvc: Add atomics x64 builds

I sent out a new version changing the commit message. Please disregard this patch. Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Alin Gabriel Serdean > Sent: Wednesday, September 6, 2017 1:30 AM > To: d...@open

[ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

For a given packet, packet counters in conntrack should be accounted only once, even if the packet is processed multiple times by conntrack. When a packet is processed by conntrack, ct_state flag is set to OVS_CS_F_TRACKED. Use this state to identify if a packet has been processed previously by co

Re: [ovs-dev] Improved Packet Drop Statistics in OVS

Hi Rohith There was one minor outstanding comment clarification. Thanks Darrell On 8/29/17, 4:12 AM, "Rohith Basavaraja" wrote: Hi Darrell, Thanks for reviewing the document and providing the feedback. My response inline, pl search for [Rohith]

Re: [ovs-dev] [PATCH net-next v6 3/3] openvswitch: enable NSH support

On Tue, Sep 05, 2017 at 09:12:09PM +0800, Hannes Frederic Sowa wrote: > "Yang, Yi" writes: > > > We can change this later if we really find a better way to handle this > > because it isn't defined in include/uapi/linux/openvswitch.h, so I still > > have backdoor to do this if needed :-) > > Sorr

[ovs-dev] 答复: Re: 答复: Re: 答复: Re: 答复: Re: [PATCH v2] ovn: Support for taas(tap-as-a-service) function

Mirror port only receives mirrored packets. I would remove the flag, and uses inport and outport to mark the mirrored packets. Thanks. Russell Bryant 2017/09/06 02:57 收件人：wang.qia...@zte.com.cn, 抄送： Gao Zhenyu , ovs dev , xurong00037997 , zhou.huij...@zte.com.c

[ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

Hi All, I read below doc about pmd assignment for physical port. I think the limitation “on the same NUMA node” may be not efficient. http://docs.openvswitch.org/en/latest/intro/install/dpdk/ DPDK Physical Port Rx Queues¶

Re: [ovs-dev] [PATCH 4/7] netdev-dpdk: implement flow put with rte flow

On 9/5/17, 1:30 AM, "Yuanhan Liu" wrote: On Fri, Sep 01, 2017 at 10:38:37PM +, Darrell Ball wrote: > > > On 8/29/17, 7:33 PM, "Yuanhan Liu" wrote: > > On Wed, Aug 30, 2017 at 02:02:23AM +, Darrell Ball wrote: > > > > > +#defin

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

This same numa node limitation was already removed, although same numa is preferred for performance reasons. commit c37813fdb030b4270d05ad61943754f67021a50d Author: Billy O'Mahony Date: Tue Aug 1 14:38:43 2017 -0700 dpif-netdev: Assign ports to pmds on non-local numa node. Previo

Re: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state.

Comments inline. Subject: [ovs-dev] [PATCH] datapath-windows: Increment ct packet counters based on ct_state. For a given packet, packet counters in conntrack should be accounted only once, even if the packet is processed multiple times by conntra

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

It is a bit different from my expectation. I have separate CPU and pmd for each NUMA node. However, the physical NIC only locates on NUMA socket0. So only part of CPU and pmd (the ones in same NUMA node) can poll the physical NIC. Since I have multiple rx queue, I hope part queues can be polled

Re: [ovs-dev] OVS DPDK NUMA pmd assignment question for physical port

You could use pmd-rxq-affinity for the queues you want serviced locally and let the others go remote On 9/5/17, 8:14 PM, "王志克" wrote: It is a bit different from my expectation. I have separate CPU and pmd for each NUMA node. However, the physical NIC only locates on NUM

Re: [ovs-dev] [PATCH v2 0/8] OVS-DPDK flow offload with rte_flow

-Original Message- From: on behalf of Yuanhan Liu Date: Tuesday, September 5, 2017 at 2:22 AM To: "d...@openvswitch.org" Subject: [ovs-dev] [PATCH v2 0/8] OVS-DPDK flow offload with rte_flow >Hi, > >Here is a joint work from Mellanox and Napatech, to enable the flow hw >offload with t

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Execute QoS Checking before copying to mbuf

Thanks Derrell, it makes sence to me and I think the code path is more clear. Thanks Zhenyu Gao 2017-09-06 0:24 GMT+08:00 Darrell Ball : > Hi Gao > > How about the following incremental ? > > Thanks Darrell > > > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 4808d38..648d719 10064

Re: [ovs-dev] [PATCH v2 0/8] OVS-DPDK flow offload with rte_flow

-Original Message- From: Patil, Harish [mailto:harish.pa...@cavium.com] Sent: 6. september 2017 08:34 To: Yuanhan Liu ; d...@openvswitch.org Cc: Finn Christensen ; db...@vmware.com Subject: Re: [ovs-dev] [PATCH v2 0/8] OVS-DPDK flow offload with rte_flow -Original Message- From