Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

On Fri, Oct 06, 2017 at 08:19:04PM -0400, Russell Bryant wrote: > This patch introduces an Emeritus status for OVS committers. An > Emeritus Committer is recognized as having made a significant impact > to the project and having been a committer in the past. It is > intended as an option for

Re: [ovs-dev] [PATCH 01/13] replication: Avoid theoretical use-after-free error in reset_database().

On Fri, Oct 06, 2017 at 10:19:59PM -0400, Russell Bryant wrote: > On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > > Code that calls ovsdb_txn_row_delete() should avoid referencing the > > deleted row again, because it might be freed. In practice this shouldn't > > really happen

Re: [ovs-dev] [PATCH 05/13] ofp-print: Avoid trailing white space in OpenFlow dumps.

On Fri, Oct 06, 2017 at 10:27:34PM -0400, Russell Bryant wrote: > On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > > ofp_to_string() sometimes yields a trailing space in its output. This is > > annoying for the test infrastructure, since we have to specially mark the > > trailing

[ovs-dev] [PATCH] util: Fix style in ovs_hex_dump().

Reported-by: Russell Bryant Signed-off-by: Ben Pfaff --- lib/util.c | 82 -- 1 file changed, 43 insertions(+), 39 deletions(-) diff --git a/lib/util.c b/lib/util.c index b7e896b4cdf8..19ee029b8f4e 100644

Re: [ovs-dev] [PATCH 05/13] ofp-print: Avoid trailing white space in OpenFlow dumps.

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > ofp_to_string() sometimes yields a trailing space in its output. This is > annoying for the test infrastructure, since we have to specially mark the > trailing white space in Autotest with a "@@" marker at the end of the > line.

Re: [ovs-dev] [PATCH 04/13] util: Avoid trailing white space in hex dumps.

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > ovs_hex_dump() sometimes yields a trailing space in its output. This is > annoying for the test infrastructure, since we have to specially mark the > trailing white space in Autotest with a "@@" marker at the end of the > line.

Re: [ovs-dev] [PATCH 03/13] table: Avoid trailing white space in tables.

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > Commands that use the table library, such as ovs-vsctl and "ovsdb-client > dump", print trailing white space in tabular output, to fill out the entire > width of their tabular columns. This is annoying whenever we use these >

Re: [ovs-dev] [PATCH 02/13] daemon-unix: With --monitor, only close standard fds if --detach also used.

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > Daemons generally should close the standard fds because they don't want to > hold open an SSH session, etc. that is attached to a tty. But --monitor > without --detach does not daemonize, so do not close fds in that case. > >

Re: [ovs-dev] [PATCH 01/13] replication: Avoid theoretical use-after-free error in reset_database().

On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > Code that calls ovsdb_txn_row_delete() should avoid referencing the > deleted row again, because it might be freed. In practice this shouldn't > really happen in this case because of the particular circumstances, but it > costs

Re: [ovs-dev] [PATCH 2/2] rhel: Skip systemctl redirect.

On 6 October 2017 at 15:27, Ben Pfaff wrote: > On Fri, Oct 06, 2017 at 04:08:23AM -0700, Gurucharan Shetty wrote: > > We still use SysV scripts for RHEL. Currently, invoking > > /etc/init.d/openvswitch will redirect the calls to > > dynamically generated systemd scripts. In the

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Call 'hostname -f' after vswitchd starts.

On 6 October 2017 at 15:25, Ben Pfaff wrote: > On Fri, Oct 06, 2017 at 04:08:22AM -0700, Gurucharan Shetty wrote: > > Currently we call 'hostname -f' when ovs-vswitchd is not > > running. If you are using ovs-vswitchd to provide your > > primary networking, then 'hostname -f' will

[ovs-dev] [PATCH 12/13] json: New function json_nullable_clone().

Signed-off-by: Ben Pfaff --- include/openvswitch/json.h | 1 + lib/json.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/openvswitch/json.h b/include/openvswitch/json.h index 83775ed0efdf..edf53e594eb0 100644 ---

[ovs-dev] [PATCH 13/13] json: New function json_object_put_format().

This will acquire users in an upcoming commit. Signed-off-by: Ben Pfaff --- include/openvswitch/json.h | 6 +- lib/json.c | 12 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/include/openvswitch/json.h b/include/openvswitch/json.h

[ovs-dev] [PATCH 11/13] uuid: New function uuid_random().

Signed-off-by: Ben Pfaff --- lib/uuid.c | 8 lib/uuid.h | 1 + 2 files changed, 9 insertions(+) diff --git a/lib/uuid.c b/lib/uuid.c index 06f8792592d2..13d20ac64977 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -101,6 +101,14 @@ uuid_generate(struct uuid *uuid)

[ovs-dev] [PATCH 10/13] tests: Add support for 1-argument 'seq' in emulation.

The testsuite has an emulation of the common utility 'seq' that only supported 2- and 3-argument forms. This commit adds support for the 1-argument form. Signed-off-by: Ben Pfaff --- tests/ovs-macros.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/ovs-macros.at

[ovs-dev] [PATCH 08/13] jsonrpc: Increment sequence number when connection actually made.

The purpose of the sequence number is to allow the client to figure out when the connection status has changed. The significant event for the client is when a connection completes, not when a connection attempt starts. Thus, this commit changes the code to increment the sequence number at

[ovs-dev] [PATCH 09/13] socket-util: Make parse_bracketed_token() public, as inet_parse_token().

An upcoming commit will introduce a new user outside socket-util. Signed-off-by: Ben Pfaff --- lib/socket-util.c | 14 +++--- lib/socket-util.h | 3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/socket-util.c b/lib/socket-util.c index

[ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

The implementation cycles through the remotes in random order. This allows clients to perform some load balancing across alternative implementations of a service. Signed-off-by: Ben Pfaff --- lib/jsonrpc.c | 53 - lib/jsonrpc.h

[ovs-dev] [PATCH 06/13] reconnect: Add ability to do a number of retries without backoff.

This is aimed at an upcoming database clustering implementation, where it's desirable to try all of the cluster members quickly before backing off to retry them again in sequence. Signed-off-by: Ben Pfaff --- lib/reconnect.c | 52

[ovs-dev] [PATCH 05/13] ofp-print: Avoid trailing white space in OpenFlow dumps.

ofp_to_string() sometimes yields a trailing space in its output. This is annoying for the test infrastructure, since we have to specially mark the trailing white space in Autotest with a "@@" marker at the end of the line. This commit gets rid of the trailing white space and the annoying "@@"

[ovs-dev] [PATCH 04/13] util: Avoid trailing white space in hex dumps.

ovs_hex_dump() sometimes yields a trailing space in its output. This is annoying for the test infrastructure, since we have to specially mark the trailing white space in Autotest with a "@@" marker at the end of the line. This commit gets rid of the trailing white space and the annoying "@@"

[ovs-dev] [PATCH 03/13] table: Avoid trailing white space in tables.

Commands that use the table library, such as ovs-vsctl and "ovsdb-client dump", print trailing white space in tabular output, to fill out the entire width of their tabular columns. This is annoying whenever we use these commands in the test infrastructure, since we have to specially mark the

[ovs-dev] [PATCH 02/13] daemon-unix: With --monitor, only close standard fds if --detach also used.

Daemons generally should close the standard fds because they don't want to hold open an SSH session, etc. that is attached to a tty. But --monitor without --detach does not daemonize, so do not close fds in that case. Signed-off-by: Ben Pfaff --- lib/daemon-unix.c | 4 +++- 1

[ovs-dev] [PATCH 00/13] clustering implementation, part 1

This is a first series of patches that builds up toward clustered OVSDB. This part has very little directly to do with OVSDB itself--most of the patches just fix minor bugs or add minor features. The full series is available at: https://github.com/blp/ovs-reviews/tree/raft8 Ben Pfaff (13):

[ovs-dev] [PATCH 01/13] replication: Avoid theoretical use-after-free error in reset_database().

Code that calls ovsdb_txn_row_delete() should avoid referencing the deleted row again, because it might be freed. In practice this shouldn't really happen in this case because of the particular circumstances, but it costs little to be careful. Signed-off-by: Ben Pfaff ---

[ovs-dev] Internal Ports and Queues

Hello All, I am evaluating openvswitch for implementing a load balancing based on Queue length. I know OVS can set queue to ports attached to the bridge using linux tc utility. I would like to know whether I can assign queues to Internal ports to measure the backlog.Before I split the

[ovs-dev] [PATCH] Introduce Emeritus Committer status.

This patch introduces an Emeritus status for OVS committers. An Emeritus Committer is recognized as having made a significant impact to the project and having been a committer in the past. It is intended as an option for those that do not currently have the time or interest to fulfill committer

Re: [ovs-dev] [PATCH 2/2] rhel: Skip systemctl redirect.

On Fri, Oct 06, 2017 at 04:08:23AM -0700, Gurucharan Shetty wrote: > We still use SysV scripts for RHEL. Currently, invoking > /etc/init.d/openvswitch will redirect the calls to > dynamically generated systemd scripts. In the above case when you call > "/etc/init.d/openvswitch-switch start", it

Re: [ovs-dev] [PATCH 1/2] ovs-ctl.in: Call 'hostname -f' after vswitchd starts.

On Fri, Oct 06, 2017 at 04:08:22AM -0700, Gurucharan Shetty wrote: > Currently we call 'hostname -f' when ovs-vswitchd is not > running. If you are using ovs-vswitchd to provide your > primary networking, then 'hostname -f' will "hang" till it > times out. On the system this issue was discovered,

[ovs-dev] [PATCH 2/2] rhel: Skip systemctl redirect.

We still use SysV scripts for RHEL. Currently, invoking /etc/init.d/openvswitch will redirect the calls to dynamically generated systemd scripts. In the above case when you call "/etc/init.d/openvswitch-switch start", it inturn calls "/bin/systemctl start openvswitch-switch.service" and that

[ovs-dev] [PATCH 1/2] ovs-ctl.in: Call 'hostname -f' after vswitchd starts.

Currently we call 'hostname -f' when ovs-vswitchd is not running. If you are using ovs-vswitchd to provide your primary networking, then 'hostname -f' will "hang" till it times out. On the system this issue was discovered, this was as long as 40 seconds. This is a problem during OVS restarts or

[ovs-dev] Info Poli Olivas / Bonesca

  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28k4f2oatrf.html )     Buenos días, Informar que recientemente he llegado a un acuerdo de colaboración con la empresa holandesa BONESCA IMPORT & EXPORT (www.bonesca.nl) para España, Portugal y Italia. BONESCA tiene gran

Re: [ovs-dev] [PATCH v1] utilities: Use FQDN for external_ids:hostname in Openvswitch table

On 24 November 2016 at 01:36, Babu Shanmugam wrote: > From: Babu Shanmugam > > Openstack compute manager uses FQDN to check for the hypervisors to > which the ports are bound. > > Without this fix, no instances can be launched as the hypervisor's

[ovs-dev] LANGOSTINO ENTERO CON CABEZA "BLACK TIGER"

  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28k2u6oatrf.html )     [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48y8bcdaoatrd )      LANGOSTINO ENTERO CON CABEZA "BLACK TIGER"   TALLA 16/20 NOMBRE CIENTIFICO: PENAEUS MONODON FORMATO: 10 x 1 kg (750 g) FECHA

Re: [ovs-dev] OVS-DPDK public meeting

04th October 2017 Attendees: Georg, Rohith, Thomas, Eelco, Antonio, Johann, Ben, Frikkie, Ciara, Michael, Ian, Sugesh, Billy, Bhannu, Simon, Flavio, Kevin As always, feel free to add/correct. === GENERAL === - Ian will take over collecting the DPDK patches into a pull request (Ben) -

Re: [ovs-dev] [PATCH] ovs-atomic: Reintroduce atomic_uint64_t and atomic_int64_t.

On Wed, Oct 04, 2017 at 10:15:30AM +0200, Simon Horman wrote: > On Fri, Sep 29, 2017 at 10:18:52AM -0700, Ben Pfaff wrote: > > This is essentially a revert of commit e09d61c41b4f ("ovs-atomic: Remove > > atomic_uint64_t and atomic_int64_t.") My fear that some 32-bit platforms > > did not support

[ovs-dev] [PATCH v4 6/6] netdev-dpdk: Rename dpdk_mp_put as dpdk_mp_free.

Rename dpdk_mp_put as dpdk_mp_free, add other comments to mempool functions. CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole Signed-off-by: Antonio Fischetti --- lib/netdev-dpdk.c | 15

[ovs-dev] [PATCH v4 5/6] netdev-dpdk: Reword mp_size as n_mbufs.

Rename mp_size as n_mbufs in dpdk_mp structure. This parameter is passed to rte mempool creation functions and is meant to contain the number of elements inside the requested mempool. CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole

[ovs-dev] [PATCH v4 4/6] netdev-dpdk: assert mempool names.

Replace if statement with an assert. CC: Darrell Ball CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole Signed-off-by: Antonio Fischetti --- lib/netdev-dpdk.c | 4 +--- 1 file

[ovs-dev] [PATCH v4 3/6] netdev-dpdk: skip init for existing mempools.

Skip initialization of mempool packet areas if this was already done in a previous call to dpdk_mp_create. CC: Darrell Ball CC: Ciara Loftus CC: Kevin Traynor CC: Aaron Conole Signed-off-by: Antonio Fischetti

[ovs-dev] [PATCH v4 2/6] netdev-dpdk: Fix mempool names to reflect socket id.

Create mempool names by considering also the NUMA socket number. So a name reflects on what socket the mempool is allocated on. This change is needed for the NUMA-awareness feature. CC: Kevin Traynor CC: Aaron Conole Reported-by: Ciara Loftus

[ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

This adds a ct_clear action for clearing conntrack state. ct_clear is currently implemented in OVS userspace, but is not backed by an action in the kernel datapath. This is useful for flows that may modify a packet tuple after a ct lookup has already occurred. Signed-off-by: Eric Garver

[ovs-dev] [PATCH v4 1/6] netdev-dpdk: fix management of pre-existing mempools.

Fix an issue on reconfiguration of pre-existing mempools. This patch avoids to call dpdk_mp_put() - and erroneously release the mempool - when it already exists. CC: Kevin Traynor CC: Aaron Conole CC: Darrell Ball Reported-by: Ciara

Re: [ovs-dev] [dpdk-users] adding dpdk ports sharing same pci address to ovs-dpdk bridge

> > On Thu, Sep 21, 2017 at 1:58 PM, Loftus, Ciara > wrote: > > 21/09/2017 10:04, Loftus, Ciara: > > > > 20/09/2017 19:33, Kevin Traynor: > > > > > On 09/08/2017 10:56 AM, Loftus, Ciara wrote: > > > > > > It seems the DPDK function rte_eth_dev_get_port_by_name() will > >

[ovs-dev] [PATCH RFC] netdev-dpdk: Allow specification of index for PCI devices

Some NICs have only one PCI address associated with multiple ports. This patch extends the dpdk-devargs option's format to cater for such devices. Whereas before only one of N ports associated with one PCI address could be added, now N can. This patch allows for the following use of the

Re: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management with vhu client.

Thanks Ciara, will respin a v4. Comments inline. Antonio > -Original Message- > From: Loftus, Ciara > Sent: Friday, October 6, 2017 11:40 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool

Re: [ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

On 10/06/2017 12:50 PM, Ilya Maximets wrote: Currently, rx and tx functions for vhost interfaces always obtain 'vid' twice. First time inside 'is_vhost_running' for checking the value and the second time in enqueue/dequeue function calls to send/receive packets. But second time we're not

[ovs-dev] Offer Black Tiger HOSO 16/20

  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28k21qoatrf.html )     [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48y886laoatrd )    SPECIAL OFFER FOR TODAY'S NEW ARRIVAL:   BLACK TIGER SHRIMPS HOSO 16/20 10 X 1 KILO   PRODUCT: HEAD ON SHELL ON BLACK TIGER SHRIMPS

[ovs-dev] [PATCH] netdev-dpdk: Fix calling vhost API with negative vid.

Currently, rx and tx functions for vhost interfaces always obtain 'vid' twice. First time inside 'is_vhost_running' for checking the value and the second time in enqueue/dequeue function calls to send/receive packets. But second time we're not checking the returned value. If vhost device will be

Re: [ovs-dev] [PATCH v3 1/5] netdev-dpdk: fix mempool management with vhu client.

> > In a PVP test where vhostuser ports are configured as > clients, OvS crashes when QEMU is launched. > This patch avoids to call dpdk_mp_put() - and erroneously > release the mempool - when it already exists. Thanks for investigating this issue and for the patch. I think the commit message

[ovs-dev] [PATCH] tests: Add timeout to OVS_APP_EXIT_AND_WAIT.

ovs-appctl can wait indefinitely while executing an exit for a dead service. Let's add a timeout (10 seconds should be reasonable) to exit calls to avoid hanging up of the testsuite in such cases. Signed-off-by: Ilya Maximets --- tests/ovs-macros.at | 6 +++--- 1 file