Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

2017-10-09 Thread Pravin Shelar
On Fri, Oct 6, 2017 at 9:44 AM, Eric Garver wrote: > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet tuple

Re: [ovs-dev] [PATCH net-next] openvswitch: add ct_clear action

2017-10-09 Thread David Miller
From: Eric Garver Date: Fri, 6 Oct 2017 12:44:26 -0400 > This adds a ct_clear action for clearing conntrack state. ct_clear is > currently implemented in OVS userspace, but is not backed by an action > in the kernel datapath. This is useful for flows that may modify a > packet

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

2017-10-09 Thread Iwase Yusuke
Hi Ben and Andy, Thank you very much! I'm looking forward to review comments. On 2017年10月10日 12:08, Ben Pfaff wrote: You submitted the patch correctly. It is my fault because I've been slow about reviews lately. I think that Andy Zhou should take a look at this patch since he added the

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

2017-10-09 Thread Ben Pfaff
You submitted the patch correctly. It is my fault because I've been slow about reviews lately. I think that Andy Zhou should take a look at this patch since he added the assertions. I sent him a message asking about it. On Tue, Oct 10, 2017 at 11:39:42AM +0900, Iwase Yusuke wrote: > Hi, > >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

2017-10-09 Thread Ben Pfaff
Andy, can you take a quick look at this? It appears to me that it is trivial to trigger this assertion by specifying a max_len in any OpenFlow output action. I guess that wasn't the intention, but maybe there is some other importance purpose for the assertion that should be retained. Thanks,

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

2017-10-09 Thread Iwase Yusuke
Hi, I'm very sorry for disturbing you. Could someone review this patch? Or are there some more procedures for submitting patch? Thanks, Iwase On 2017年10月04日 22:54, IWASE Yusuke wrote: Because OpenFlow Spec does not clearly stipulate that "max_len" in OUTPUT action must be zero when "port"

Re: [ovs-dev] [PATCH] netdev-dpdk: New option 'hw_strip_crc' fields for DPDK interfaces

2017-10-09 Thread wenxu
Hi Zhenyu, I think add a option maybe better. 1. It keep unchange the action with default value is false 2. It can be try one more time but if there some other different config, there should be more times to try 3. For some user who want to enable this feature, it can be configurable 在

[ovs-dev] Rania_Hassan

2017-10-09 Thread Anaïs
Madame, Monsieur, Cher(e) Adhérent(e), A companhia Lhe anuncia seus (ganho) tem a loteria de um soma quatrocentos cinqüenta mil euro. Para mais informação adquira em contato com Mr Giroux Alex Sgiroux.alex(At)gmail.com MO meu nome é Rania Hassan. É viúvo e sem família. Solicito o

Re: [ovs-dev] [PATCH] include/openvswitch/utils.h:

2017-10-09 Thread Greg Rose
On 10/09/2017 04:34 PM, Ben Pfaff wrote: On Mon, Oct 09, 2017 at 03:59:37PM -0700, Greg Rose wrote: > Fix macro for case where build is done with NDEBUG > > Signed-off-by: Greg Rose > --- > include/openvswitch/util.h | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH] include/openvswitch/utils.h:

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 03:59:37PM -0700, Greg Rose wrote: > Fix macro for case where build is done with NDEBUG > > Signed-off-by: Greg Rose > --- > include/openvswitch/util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[ovs-dev] [PATCH] include/openvswitch/utils.h:

2017-10-09 Thread Greg Rose
Fix macro for case where build is done with NDEBUG Signed-off-by: Greg Rose --- include/openvswitch/util.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/openvswitch/util.h b/include/openvswitch/util.h index abebf96..72299e7 100644 ---

Re: [ovs-dev] [PATCH 13/13] json: New function json_object_put_format().

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 04:08:54PM -0400, Russell Bryant wrote: > On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > > This will acquire users in an upcoming commit. > > > > Signed-off-by: Ben Pfaff > > --- > > include/openvswitch/json.h | 6 +- > > lib/json.c

Re: [ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

2017-10-09 Thread Russell Bryant
On Mon, Oct 9, 2017 at 4:11 PM, Ben Pfaff wrote: > On Mon, Oct 09, 2017 at 03:57:18PM -0400, Russell Bryant wrote: >> On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: >> > The implementation cycles through the remotes in random order. This allows >> > clients to

Re: [ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 03:57:18PM -0400, Russell Bryant wrote: > On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > > The implementation cycles through the remotes in random order. This allows > > clients to perform some load balancing across alternative implementations > > of a

Re: [ovs-dev] [PATCH 13/13] json: New function json_object_put_format().

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > This will acquire users in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > include/openvswitch/json.h | 6 +- > lib/json.c | 12 > 2 files changed, 17 insertions(+), 1

Re: [ovs-dev] [PATCH 12/13] json: New function json_nullable_clone().

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > include/openvswitch/json.h | 1 + > lib/json.c | 8 +++- > 2 files changed, 8 insertions(+), 1 deletion(-) Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH 11/13] uuid: New function uuid_random().

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/uuid.c | 8 > lib/uuid.h | 1 + > 2 files changed, 9 insertions(+) Acked-by: Russell Bryant ___ dev mailing

Re: [ovs-dev] [PATCH 10/13] tests: Add support for 1-argument 'seq' in emulation.

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > The testsuite has an emulation of the common utility 'seq' that only > supported 2- and 3-argument forms. This commit adds support for the > 1-argument form. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant

Re: [ovs-dev] [PATCH 09/13] socket-util: Make parse_bracketed_token() public, as inet_parse_token().

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > An upcoming commit will introduce a new user outside socket-util. > > Signed-off-by: Ben Pfaff Acked-by: Russell Bryant -- Russell Bryant ___ dev

Re: [ovs-dev] [PATCH 08/13] jsonrpc: Increment sequence number when connection actually made.

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > The purpose of the sequence number is to allow the client to figure out > when the connection status has changed. The significant event for the > client is when a connection completes, not when a connection attempt > starts. Thus,

Re: [ovs-dev] [PATCH 07/13] jsonrpc: Allow jsonrpc_session to have more than one remote.

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > The implementation cycles through the remotes in random order. This allows > clients to perform some load balancing across alternative implementations > of a service. > > Signed-off-by: Ben Pfaff > --- >

Re: [ovs-dev] [PATCH 06/13] reconnect: Add ability to do a number of retries without backoff.

2017-10-09 Thread Russell Bryant
On Fri, Oct 6, 2017 at 8:44 PM, Ben Pfaff wrote: > This is aimed at an upcoming database clustering implementation, where it's > desirable to try all of the cluster members quickly before backing off to > retry them again in sequence. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

2017-10-09 Thread Russell Bryant
On Mon, Oct 9, 2017 at 1:42 PM, Ben Pfaff wrote: > On Mon, Oct 09, 2017 at 01:25:57PM -0400, Russell Bryant wrote: >> On Sat, Oct 7, 2017 at 12:22 AM, Ben Pfaff wrote: >> > 2. Do we need a vote of the committers to approve this change? I >> >think that I

Re: [ovs-dev] locks for clustered OVSDB

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 01:13:56PM -0400, Russell Bryant wrote: > On Mon, Sep 25, 2017 at 2:29 PM, Ben Pfaff wrote: > > On Mon, Sep 25, 2017 at 11:09:49AM -0700, Han Zhou wrote: > >> On Mon, Sep 25, 2017 at 2:36 AM, Miguel Angel Ajo Pelayo < > >> majop...@redhat.com> wrote: > >> > >

Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 01:25:57PM -0400, Russell Bryant wrote: > On Sat, Oct 7, 2017 at 12:22 AM, Ben Pfaff wrote: > > 2. Do we need a vote of the committers to approve this change? I > >think that I would be more comfortable if we did have one. > > Yes, I think that

Re: [ovs-dev] [PATCH] util: Fix style in ovs_hex_dump().

2017-10-09 Thread Ben Pfaff
On Mon, Oct 09, 2017 at 01:15:01PM -0400, Russell Bryant wrote: > On Sat, Oct 7, 2017 at 12:01 AM, Ben Pfaff wrote: > > Reported-by: Russell Bryant > > Signed-off-by: Ben Pfaff > > Thanks :-) > > Acked-by: Russell Bryant Thanks

[ovs-dev] [PATCH] faq: Better document how to add vendor extensions.

2017-10-09 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- Documentation/faq/contributing.rst | 44 +++--- include/openvswitch/ofp-errors.h | 4 +++- 2 files changed, 34 insertions(+), 14 deletions(-) diff --git a/Documentation/faq/contributing.rst

[ovs-dev] [PATCH v2] Introduce Emeritus Committer status.

2017-10-09 Thread Russell Bryant
This patch introduces an Emeritus status for OVS committers. An Emeritus Committer is recognized as having made a significant impact to the project and having been a committer in the past. It is intended as an option for those that do not currently have the time or interest to fulfill committer

Re: [ovs-dev] [PATCH] Introduce Emeritus Committer status.

2017-10-09 Thread Russell Bryant
On Sat, Oct 7, 2017 at 12:22 AM, Ben Pfaff wrote: > On Fri, Oct 06, 2017 at 08:19:04PM -0400, Russell Bryant wrote: >> This patch introduces an Emeritus status for OVS committers. An >> Emeritus Committer is recognized as having made a significant impact >> to the project and having

Re: [ovs-dev] [PATCH] util: Fix style in ovs_hex_dump().

2017-10-09 Thread Russell Bryant
On Sat, Oct 7, 2017 at 12:01 AM, Ben Pfaff wrote: > Reported-by: Russell Bryant > Signed-off-by: Ben Pfaff Thanks :-) Acked-by: Russell Bryant ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] locks for clustered OVSDB

2017-10-09 Thread Russell Bryant
On Mon, Sep 25, 2017 at 2:29 PM, Ben Pfaff wrote: > On Mon, Sep 25, 2017 at 11:09:49AM -0700, Han Zhou wrote: >> On Mon, Sep 25, 2017 at 2:36 AM, Miguel Angel Ajo Pelayo < >> majop...@redhat.com> wrote: >> > >> > I believe Lucas Alvares could give you valuable feedback on this as >>

[ovs-dev] Black Tigers Peeled and HLSO

2017-10-09 Thread Bonesca Import en Export BV
  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28k6seoatrf.html )     [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48y8r59aoatrd )    SPECIAL PROMO JONA & BONEMER    NEW ARRIVALS BLACK TIGER SHRIMPS FROM BANGLADESH :   JONA PEELED DEVEINED BLACK TIGER SHRIMPS SIZE

Re: [ovs-dev] [ovs-discuss] Internal Ports and Queues

2017-10-09 Thread Ben Pfaff
On Fri, Oct 06, 2017 at 07:24:15PM -0500, Prabhu wrote: > I am evaluating openvswitch for implementing a load balancing based on Queue > length. > > I know OVS can set queue to ports attached to the bridge using linux tc > utility. > > I would like to know whether I can assign queues to Internal

Re: [ovs-dev] SWIFT COPY OF PAYMENT

2017-10-09 Thread alsoja trading
Urgent!!! please confirm below payment . VIEW BELOW | DOWNLOAD BELOW :102KB SWIFT COPY OF PAYMENT. SAMUEL KOMORA. Medical Department Jubilee Insurance Company of Kenya Mob: +254 709901176 Tel: +254 20 3281176 WWW.JUBILEEINSURANCE.COM [1] Links: -- [1]

Re: [ovs-dev] [PATCH] netdev-dpdk: New option 'hw_strip_crc' fields for DPDK interfaces

2017-10-09 Thread Gao Zhenyu
Thanks for working on it. I want to know if we can have a patch to try one more time if we hit the hw_strip_crc error since we had introduce many options in ovs-dpdk now. (Just like function dpdk_eth_dev_queue_setup, it figures out queue number by retrying) Thanks Zhenyu Gao 2017-10-09 17:09

Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add commands to r/w CT parameters.

2017-10-09 Thread Fischetti, Antonio
Thanks Kevin, I'll rework a v3. Antonio > -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, October 3, 2017 11:11 AM > To: Fischetti, Antonio ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2 0/4] Conntrack: add

Re: [ovs-dev] [PATCH v4 2/6] netdev-dpdk: Fix mempool names to reflect socket id.

2017-10-09 Thread Loftus, Ciara
> > Create mempool names by considering also the NUMA socket number. > So a name reflects on what socket the mempool is allocated on. > This change is needed for the NUMA-awareness feature. > > CC: Kevin Traynor > CC: Aaron Conole > Reported-by: Ciara

[ovs-dev] [PATCH] netdev-dpdk: New option 'hw_strip_crc' fields for DPDK interfaces

2017-10-09 Thread wenxu
From: wenxu Some vf driver like i40evf can't disable the hw_strip_crc, with err 'dpdk|ERR|i40evf_dev_configure(): VF can't disable HW CRC Strip' so hw_strip_crc feature should can be configurable Signed-off-by: wenxu --- NEWS | 2 ++

Re: [ovs-dev] [PATCH v4 3/7] netdev: Remove unused may_steal.

2017-10-09 Thread Ilya Maximets
On 09.10.2017 09:42, Gao Zhenyu wrote: > But the netdev_dpdk_send__ function may release whole batch packets. Yes, sure. Look at reply to my previous message. > > static inline void > netdev_dpdk_send__(struct netdev_dpdk *dev, int qid, >    struct dp_packet_batch *batch, bool

Re: [ovs-dev] [PATCH v4 3/7] netdev: Remove unused may_steal.

2017-10-09 Thread Ilya Maximets
On 09.10.2017 09:16, Ilya Maximets wrote: > On 08.10.2017 12:32, Gao Zhenyu wrote: >> Hi llya, >> >>   Thanks for working it. Your patch tried to eliminate the may_steal in dpdk >> qos, because may_steal handled on dpif-netdev layer and always true. >>   But in function dpdk_do_tx_copy, it set

Re: [ovs-dev] [PATCH v4 3/7] netdev: Remove unused may_steal.

2017-10-09 Thread Gao Zhenyu
But the netdev_dpdk_send__ function may release whole batch packets. static inline void netdev_dpdk_send__(struct netdev_dpdk *dev, int qid, struct dp_packet_batch *batch, bool may_steal, bool concurrent_txq) { ... if (OVS_UNLIKELY(!may_steal ||

Re: [ovs-dev] [PATCH v4 3/7] netdev: Remove unused may_steal.

2017-10-09 Thread Ilya Maximets
On 08.10.2017 12:32, Gao Zhenyu wrote: > Hi llya, > >   Thanks for working it. Your patch tried to eliminate the may_steal in dpdk > qos, because may_steal handled on dpif-netdev layer and always true. >   But in function dpdk_do_tx_copy, it set the may_steal to false, because the > packet