Re: [ovs-dev] [PATCH] ovsdb-idl: fix index row setting with references.

2017-10-27 Thread Han Zhou
On Thu, Oct 26, 2017 at 2:28 PM, Ben Pfaff wrote: > > On Sat, Oct 14, 2017 at 11:53:23PM -0700, Han Zhou wrote: > > IDL index should be able to be used without having to be in a > > transaction. However, current implementation leads to crash if > > a reference type column is being

[ovs-dev] [PATCH v2] ovsdb-idl: fix index row setting with references.

2017-10-27 Thread Han Zhou
IDL index should be able to be used without having to be in a transaction. However, current implementation leads to crash if a reference type column is being set in an index row for querying purpose when it is not in a transaction. It is because of the uninitialized arcs and unnecessary updates of

Re: [ovs-dev] [PATCH v2 3/3] system-traffic: Add conntrack floating IP test

2017-10-27 Thread William Tu
On Thu, Oct 26, 2017 at 12:30 PM, Eric Garver wrote: > This test cases uses floating IP (FIP) addresses for each endpoint. If > the destination is a FIP, the packet will undergo a transformation of > the form (dst=FIP, src=non-FIP) --> (dst=non-FIP, src=FIP) before > egress.

Re: [ovs-dev] OVS Pull Request for DPDK_MERGE

2017-10-27 Thread Ben Pfaff
On Fri, Oct 27, 2017 at 07:57:25AM +, Stokes, Ian wrote: > I've submitted a pull request for the dpdk_merge branch. > > This merge request aims to resolve the mem pool management issues affecting > master for OVS DPDK. > > Pull request and details can be found at : >

Re: [ovs-dev] [PATCH v5 5/7] timeval: Add functions with microsecond granularity.

2017-10-27 Thread Ben Pfaff
On Fri, Oct 27, 2017 at 07:19:45PM +0300, Ilya Maximets wrote: > Signed-off-by: Ilya Maximets I applied this patch to master. Thanks! I don't plan to review the rest of the series myself, except upon request. ___ dev mailing

Re: [ovs-dev] [PATCH] ovn: Add LB flows for logical router with gateway port

2017-10-27 Thread Ben Pfaff
On Fri, Oct 27, 2017 at 10:03:07AM -0700, Guru Shetty wrote: > On 27 October 2017 at 08:35, Ben Pfaff wrote: > > > This patch is one where I need help. I asked Guru because it's an area > > he knows, but if you feel confident about it, Mark, then I'll merge it. > > > > No

[ovs-dev] Blue Swimming Crab Jona

2017-10-27 Thread Bonesca - Jona
If you are not able to see this mail, click http://r.newsletter.bonescamail.nl/7xa28keouoatrf.html  [ ]( http://r.newsletter.bonescamail.nl/track/click/vp48y9mr1aoatrd )    SPECIAL OFFER TOPQUALITY JONA BLUE SWIMMING CRABS  12 X 1000 GRS / 800 GRS NET WEIGHT!!!   5515 Blue Swimming Cut Crab

Re: [ovs-dev] [PATCH v2] Introduce Emeritus Committer status.

2017-10-27 Thread Ben Pfaff
Thanks Ethan and Justin. I applied this to master. On Thu, Oct 26, 2017 at 02:40:48PM -0700, Ethan J. Jackson wrote: > Acked-by: Ethan J. Jackson > > On Thu, Oct 26, 2017 at 2:33 PM, Ben Pfaff wrote: > > From: Russell Bryant > > > > This patch

[ovs-dev] [PATCH] treewide: Get rid of "echo -n", and add a test to prevent regression.

2017-10-27 Thread Ben Pfaff
"echo -n" is not POSIX and has spotty support in shells. CC: Timothy Redaelli CC: Flavio Leitner Signed-off-by: Ben Pfaff --- Makefile.am | 11 +++ tests/automake.mk | 2 +- tests/ofp-print.at| 10 +-

Re: [ovs-dev] [PATCH v2 3/3] ovs-save: Replace "echo -n" with "printf"

2017-10-27 Thread Ben Pfaff
On Tue, Oct 17, 2017 at 03:27:59PM -0200, Flavio Leitner wrote: > On Mon, 25 Sep 2017 16:44:06 +0200 > Timothy Redaelli wrote: > > > This is neeed since "echo -n" is not POSIX and may not work with some > > shells. > > > > Signed-off-by: Timothy Redaelli

Re: [ovs-dev] [PATCH v2 2/3] ovs-save: Use a file to restore flows instead of heredoc

2017-10-27 Thread Ben Pfaff
On Tue, Oct 17, 2017 at 03:27:31PM -0200, Flavio Leitner wrote: > On Mon, 25 Sep 2017 16:44:05 +0200 > Timothy Redaelli wrote: > > > This patch makes ovs-save to use a file to restore flows instead of using > > shell script here-document. > > This is needed since eval +

Re: [ovs-dev] [PATCH v2 1/3] ovs-save: Use --bundle to restore flows (on OpenFlow 1.4+)

2017-10-27 Thread Ben Pfaff
On Mon, Sep 25, 2017 at 04:44:04PM +0200, Timothy Redaelli wrote: > If possible, use OpenFlow 1.4 atomic bundle transaction to restore flows. > The patch uses also the highest enabled OpenFlow version to do the queries. > > With the actual implementation, if you have the default OpenFlow version

[ovs-dev] Dwarf Tuna

2017-10-27 Thread Bonesca - Jona
If you are not able to see this mail, click http://r.newsletter.bonescamail.nl/7xa28kdweoatrf.html      NEW ARRIVAL   ATLANTIC LITTLE TUNNY / DWARFTUNA  KAWA KAWA / CÁ NGÙ CHÃM / 白卜鲔   1 - 1.5 KILO PACKED IN 10 KILO BOX    CODE 1920     [ Click here for our latest pricelist  ](

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Yifeng Sun
Thanks a lot. I will keep your guidance in mind. On Fri, Oct 27, 2017 at 9:29 AM, Mark Michelson wrote: > Usually the software that performs DNS lookups and caches results is > referred to as a "DNS forwarder". You configure resolv.conf's nameserver as > 127.0.0.1. This

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Mark Michelson
Usually the software that performs DNS lookups and caches results is referred to as a "DNS forwarder". You configure resolv.conf's nameserver as 127.0.0.1. This way, DNS queries go to the DNS forwarder running on localhost. The forwarder then has real nameservers configured to send the queries to.

[ovs-dev] [PATCH v5 7/7] dpif-netdev: Count sent packets and batches.

2017-10-27 Thread Ilya Maximets
Acked-by: Eelco Chaudron Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 2c05494..10b046d 100644 ---

[ovs-dev] [PATCH v5 6/7] dpif-netdev: Time based output batching.

2017-10-27 Thread Ilya Maximets
This allows to collect packets from more than one RX burst and send them together with a configurable intervals. 'other_config:tx-flush-interval' can be used to configure time that a packet can wait in output batch for sending. dpif-netdev turned to microsecond resolution for time measuring to

[ovs-dev] [PATCH v5 5/7] timeval: Add functions with microsecond granularity.

2017-10-27 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- lib/timeval.c | 35 +++ lib/timeval.h | 4 2 files changed, 39 insertions(+) diff --git a/lib/timeval.c b/lib/timeval.c index 2c7f43a..b50ff85 100644 --- a/lib/timeval.c +++ b/lib/timeval.c @@ -231,6

[ovs-dev] [PATCH v5 4/7] netdev: Remove useless cutlen.

2017-10-27 Thread Ilya Maximets
Cutlen already applied while processing OVS_ACTION_ATTR_OUTPUT. Acked-by: Eelco Chaudron Signed-off-by: Ilya Maximets --- lib/netdev-bsd.c | 2 +- lib/netdev-dpdk.c | 5 - lib/netdev-dummy.c | 2 +- lib/netdev-linux.c | 4 ++-- 4 files

[ovs-dev] [PATCH v5 3/7] netdev: Remove unused may_steal.

2017-10-27 Thread Ilya Maximets
Not needed anymore because 'may_steal' already handled on dpif-netdev layer and always true. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 2 +- lib/netdev-bsd.c | 4 ++-- lib/netdev-dpdk.c | 25 +++-- lib/netdev-dummy.c| 4

[ovs-dev] [PATCH v5 2/7] dpif-netdev: Output packet batching.

2017-10-27 Thread Ilya Maximets
While processing incoming batch of packets they are scattered across many per-flow batches and sent separately. This becomes an issue while using more than a few flows. For example if we have balanced-tcp OvS bonding with 2 ports there will be 256 datapath internal flows for each dp_hash

[ovs-dev] [PATCH v5 1/7] dpif-netdev: Keep latest measured time for PMD thread.

2017-10-27 Thread Ilya Maximets
In current implementation 'now' variable updated once on each receive cycle and passed through the whole datapath via function arguments. It'll be better to keep this variable inside PMD thread structure to be able to get it at any time. Such solution will save the stack memory and simplify

[ovs-dev] [PATCH v5 0/7] Output packet batching.

2017-10-27 Thread Ilya Maximets
This patch-set inspired by [1] from Bhanuprakash Bodireddy. Implementation of [1] looks very complex and introduces many pitfalls [2] for later code modifications like possible packet stucks. This version targeted to make simple and flexible output packet batching on higher level without

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Yifeng Sun
Mark, thanks a lot for the detailed and thorough explanation. Do you happen to know any other projects that we can take a peek? On Fri, Oct 27, 2017 at 8:57 AM, Mark Michelson wrote: > Yep, that makes good sense. I'd recommend having some min and max > threshold though.

Re: [ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

2017-10-27 Thread Ben Pfaff
On Wed, Sep 13, 2017 at 09:35:32AM +0200, Timothy Redaelli wrote: > Add a systemd service file that is only executed the first time > ovsdb-server starts after boot and that removes all transient ports > (--delete-transient-ports). > > This is important on certain environments where some ports

Re: [ovs-dev] [PATCH] ovn: Add LB flows for logical router with gateway port

2017-10-27 Thread Mark Michelson
Go ahead and do this one first. It won't be too difficult for me to update the IPv6 one. On Fri, Oct 27, 2017 at 10:36 AM Ben Pfaff wrote: > This patch is one where I need help. I asked Guru because it's an area > he knows, but if you feel confident about it, Mark, then I'll

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Mark Michelson
Yep, that makes good sense. I'd recommend having some min and max threshold though. That way, if a record has a TTL of multiple days, you can round that down to something more reasonable. Similarly, a ridiculously low TTL can be rounded up. There's another aspect to DNS caching that I briefly

Re: [ovs-dev] OVS-DPDK public meeting

2017-10-27 Thread Kevin Traynor
Canceling for 1st Nov, as not much agenda items. On 07/25/2017 02:25 PM, Kevin Traynor wrote: > Hi All, > > The OVS-DPDK public meetings have moved to Wednesday's at the same time. > Everyone is welcome, it's a chance to share status/plans etc. > > It's scheduled for every 2 weeks starting 26th

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix null pointer dereference on exit.

2017-10-27 Thread Ben Pfaff
When revalidation occurs at the same time that a bridge is being removed or ovs-vswitchd is exiting, xlate_lookup_ofproto() races with deletion of the ofproto. This caused a null pointer dereference if revalidation lost the race. This commit fixes the problem. Reported-by: Jakub Sitnicki

Re: [ovs-dev] [PATCH] ovn: Add LB flows for logical router with gateway port

2017-10-27 Thread Ben Pfaff
This patch is one where I need help. I asked Guru because it's an area he knows, but if you feel confident about it, Mark, then I'll merge it. Do you have a preference on ordering? On Fri, Oct 27, 2017 at 03:26:56PM +, Mark Michelson wrote: > I've had a look over this and it looks fine by

Re: [ovs-dev] [PATCH] ovn: Add LB flows for logical router with gateway port

2017-10-27 Thread Mark Michelson
I've had a look over this and it looks fine by me. Ben, do you plan to merge this soon? If so, I'll need to update my IPv6 load balancer patch since it will conflict with this a bit. On Thu, Sep 21, 2017 at 10:53 AM wrote: > From: Numan Siddique > >

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Ben Pfaff
Does it make sense to cache the entry until its declared TTL expires? On Fri, Oct 27, 2017 at 01:30:41PM +, Mark Michelson wrote: > This opens the can of worms that is DNS caching. > > On one end of the spectrum, you can always perform a full DNS lookup of a > target and never store the

Re: [ovs-dev] DNS support feature (was: Re: DNS support options)

2017-10-27 Thread Mark Michelson
This opens the can of worms that is DNS caching. On one end of the spectrum, you can always perform a full DNS lookup of a target and never store the result. If the result of the lookup changes, then you will know about it as soon as possible. However, the repeated DNS lookups are very expensive,

Re: [ovs-dev] [PATCH 2/2] ovn-northd; Treat logical ports of router type as always being up

2017-10-27 Thread Miguel Angel Ajo Pelayo
Can we move this patch forward and get a backport to 2.8 / 2.7 branches? Otherwise we get a failure on openstack's: neutron.tests.tempest.api.test_routers.RoutersTest.test_router_interface_status Cheers & thanks. On Mon, Oct 2, 2017 at 6:25 PM, Miguel Angel Ajo Pelayo

Re: [ovs-dev] [PATCH 1/2] ovn-northd: Refactor logic for logical port 'up' state update

2017-10-27 Thread Miguel Angel Ajo Pelayo
Can we move this patches forward and get a backport to 2.8 / 2.7 branches? Otherwise we get a failure on openstack's: neutron.tests.tempest.api.test_routers.RoutersTest.test_router_interface_status On Mon, Oct 2, 2017 at 1:33 PM, Miguel Angel Ajo Pelayo wrote: >

Re: [ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

2017-10-27 Thread Flavio Leitner
On Wed, 13 Sep 2017 09:35:32 +0200 Timothy Redaelli wrote: > Add a systemd service file that is only executed the first time > ovsdb-server starts after boot and that removes all transient ports > (--delete-transient-ports). > > This is important on certain environments

[ovs-dev] [PATCH] rhel: Use python2-sphinx as BuildRequires on Fedora

2017-10-27 Thread Timothy Redaelli
python-* package names are deprecated on Fedora (https://fedoraproject.org/wiki/Packaging:Naming#Python2_binary_package_naming) so use python2-sphinx, when available, instead. CC: Lance Richardson Fixes: cd6121410b52 ("rhel: add python-sphinx as a build dependency")

[ovs-dev] [PATCH] fedora: Use python2-sphinx as dependency instead of python-sphinx

2017-10-27 Thread Timothy Redaelli
python-* package names are deprecated (https://fedoraproject.org/wiki/Packaging:Naming#Python2_binary_package_naming) so use python2-sphinx instead. CC: Gurucharan Shetty Fixes: fc9669525f3f ("rhel, fedora: Add python-sphinx as a dependency.") Signed-off-by: Timothy Redaelli

Re: [ovs-dev] [PATCH v4 6/7] dpif-netdev: Time based output batching.

2017-10-27 Thread Ilya Maximets
On 13.10.2017 17:33, Bodireddy, Bhanuprakash wrote: >> This allows to collect packets from more than one RX burst and send them >> together with a configurable intervals. >> >> 'other_config:tx-flush-interval' can be used to configure time that a packet >> can wait in output batch for sending. >>

Re: [ovs-dev] [PATCH v4 1/7] dpif-netdev: Keep latest measured time for PMD thread.

2017-10-27 Thread Ilya Maximets
On 11.10.2017 11:51, Eelco Chaudron wrote: > On 05/10/17 17:05, Ilya Maximets wrote: >> In current implementation 'now' variable updated once on each >> receive cycle and passed through the whole datapath via function >> arguments. It'll be better to keep this variable inside PMD >> thread

Re: [ovs-dev] race condition in "ovn: l3ha ensure no master bouncing when ovn-controller is restarted" test?

2017-10-27 Thread Miguel Angel Ajo Pelayo
Hi Ben, Thank you for reporting this, I will investigate/think what can make it fail on high concurrency to fix the issue. The test simulates what happens when you restart ovn-controller on an specific chassis, the chassis entry goes away for a small interval of time, the issue for us was

[ovs-dev] OVS Pull Request for DPDK_MERGE

2017-10-27 Thread Stokes, Ian
Hi Ben, I've submitted a pull request for the dpdk_merge branch. This merge request aims to resolve the mem pool management issues affecting master for OVS DPDK. Pull request and details can be found at : https://github.com/openvswitch/ovs/pull/211 Thanks Ian

Re: [ovs-dev] [PATCH v8 0/6] netdev-dpdk: Fix mempool management and other cleanup.

2017-10-27 Thread Stokes, Ian
> Patch #1, #2 and #4 contain the fixes. > All other patches in this series are a clean up for code readability or > small improvements. > Thanks for working on this Antonio and for all the reviews, all comments seem to be resolved and I've validated the patch series. I pushed this to the

Re: [ovs-dev] recent OVS upload (was: Re: Bug#878249: Please package >= 2.7.0)

2017-10-27 Thread Ben Pfaff
On Thu, Oct 26, 2017 at 03:45:48PM -0700, Ben Pfaff wrote: > I see a number of failed builds here: > https://buildd.debian.org/status/package.php?p=openvswitch=experimental > > Let me analyze them: > > * mips, powerpc, and ppc64 should be fixed by this commit that is > already on branch-2.8: >

[ovs-dev] race condition in "ovn: l3ha ensure no master bouncing when ovn-controller is restarted" test?

2017-10-27 Thread Ben Pfaff
Hi, I've been running the OVN unit tests in a loop with -j10 (to run faster and cause load) today, and one failure that I see is the following: 2364. ovn.at:8454: testing ovn -- ensure one gw controller restart in HA doesn't bounce the master ... creating ovn-sb database creating