Re: [ovs-dev] [PATCH v2 1/3] dpif: Add support for OVS_ACTION_ATTR_CT_CLEAR

2017-11-17 Thread Flavio Leitner
On Thu, 26 Oct 2017 15:30:42 -0400 Eric Garver wrote: > This supports using the ct_clear action in the kernel datapath. To > preserve compatibility with current ct_clear behavior on old kernels, we > only pass this action down to the datapath if a probe reveals the > datapath actually supports it

Re: [ovs-dev] [PATCH v2 3/3] system-traffic: Add conntrack floating IP test

2017-11-17 Thread Flavio Leitner
On Thu, 26 Oct 2017 15:30:44 -0400 Eric Garver wrote: > This test cases uses floating IP (FIP) addresses for each endpoint. If > the destination is a FIP, the packet will undergo a transformation of > the form (dst=FIP, src=non-FIP) --> (dst=non-FIP, src=FIP) before > egress. Otherwise the packet

Re: [ovs-dev] [PATCH v2 2/3] system-common-macros: Check for ct_clear action in datapath

2017-11-17 Thread Flavio Leitner
On Thu, 26 Oct 2017 15:30:43 -0400 Eric Garver wrote: > New macro OVS_CHECK_CT_CLEAR() to check if ct_clear action is supported > by the datapath. > > Signed-off-by: Eric Garver > Tested-by: William Tu > --- > tests/system-common-macros.at | 4 > 1 file changed, 4 insertions(+) > > diff

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-17 Thread Aaron Conole
Hi Hailin, Hailin Chen writes: > The stp could not work on netdev-dpdk if network is loop. > Because the stp protocol negotiates designate port by sending > BPDU packets which contains MAC address. > However the device doesn't have MAC address in vhostuser type. > Thus, function send_bpdu_cb wou

Re: [ovs-dev] [PATCH 7/8] net: ovs: remove unused hardirq.h

2017-11-17 Thread Yang Shi
It looks the email address of Pravin in MAINTAINERS file is obsolete, sent to the right address. Yang On 11/17/17 3:02 PM, Yang Shi wrote: Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by openvswitch at all. So, remove the

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Darrell Ball
On 11/17/17, 3:01 PM, "Flavio Leitner" wrote: On Fri, 17 Nov 2017 19:34:49 + Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. > > 1/OVS prefers variable declarations near their usage and

[ovs-dev] [PATCH 7/8] net: ovs: remove unused hardirq.h

2017-11-17 Thread Yang Shi
Preempt counter APIs have been split out, currently, hardirq.h just includes irq_enter/exit APIs which are not used by openvswitch at all. So, remove the unused hardirq.h. Signed-off-by: Yang Shi Cc: Pravin Shelar Cc: "David S. Miller" Cc: d...@openvswitch.org --- net/openvswitch/vport-intern

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Flavio Leitner
On Fri, 17 Nov 2017 19:34:49 + Darrell Ball wrote: > This patch mostly breaks OVS coding style in many instances and also invents > its own coding guidelines. > > 1/OVS prefers variable declarations near their usage and your patch violates > extensively. Documentation/internals/contributi

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

2017-11-17 Thread Simon Horman
On Fri, Nov 17, 2017 at 04:45:05PM -0200, Flavio Leitner wrote: > On Fri, 17 Nov 2017 14:36:22 +0100 > Paolo Abeni wrote: > > Currently, when an offloaded DP flow is deleted, the related stats > > are unconditionally cleared. As a result the counters for the > > originating open flow are corrupted

Re: [ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Darrell Ball
This patch mostly breaks OVS coding style in many instances and also invents its own coding guidelines. 1/OVS prefers variable declarations near their usage and your patch violates extensively. Most of this patch is related to this. I’ll point out a few to provide examples, but I don’t like this

[ovs-dev] OVS DPDK: dpdk_merge pull request

2017-11-17 Thread Stokes, Ian
Hi Ben, The following changes since commit 1ae83bb20677b42d63dbb2140fa8ed3144c6260f: netdev-tc-offloads: Add support for action set (2017-11-16 08:10:29 -0800) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to af5b0dad30359d14d

Re: [ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

2017-11-17 Thread Flavio Leitner
On Fri, 17 Nov 2017 14:36:22 +0100 Paolo Abeni wrote: > Currently, when an offloaded DP flow is deleted, the related stats > are unconditionally cleared. As a result the counters for the > originating open flow are corrupted. > > This change addresses the issue updating the DP stats with the curr

Re: [ovs-dev] [PATCH 3/3] bfd: Fix memory leak

2017-11-17 Thread Gregory Rose
On 11/15/2017 6:59 AM, Yifeng Sun wrote: Valgrind complains in test 2359 (): 864 (576 direct, 288 indirect) bytes in 18 blocks are definitely lost in loss record 96 of 101 by 0x4A6D64: xmalloc (util.c:120) by 0x40BC04: gateway_chassis_get_ordered (gchassis.c:73) by 0x408CF0: bfd_calc

[ovs-dev] [PATCH] conntrack: coding style fixes.

2017-11-17 Thread Flavio Leitner
No functional change, just fixing coding style. Signed-off-by: Flavio Leitner --- lib/conntrack.c | 335 +++- 1 file changed, 188 insertions(+), 147 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index f5a3aa9fa..022a0737b 100644

Re: [ovs-dev] [PATCH 2/3] dpif: Fix memory leak

2017-11-17 Thread Gregory Rose
On 11/15/2017 6:59 AM, Yifeng Sun wrote: Valgrind complains in test 2322 (ovn -- 3 HVs, 3 LS, 3 lports/LS, 1 LR): 31,584 (26,496 direct, 5,088 indirect) bytes in 48 blocks are definitely lost in loss record 422 of 427 by 0x5165F4: xmalloc (util.c:120) by 0x466194: dp_packet_new (dp-packe

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Fix memory leak

2017-11-17 Thread Gregory Rose
On 11/15/2017 6:59 AM, Yifeng Sun wrote: Valgrind complains in test 1019 (dpctl - add-if set-if del-if): 4,850,896 (4,850,240 direct, 656 indirect) bytes in 1 blocks are definitely lost in loss record 364 of 364 by 0x517062: xcalloc (util.c:103) by 0x46CBBC: dp_netdev_set_nonpmd (dpif-ne

[ovs-dev] [PATCH] OVN pacemaker: Add the monitor action for Master role

2017-11-17 Thread nusiddiq
From: Numan Siddique Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action periodically to check the status. But the OVN OCF script doesn't add the action "monitor" for the role "Master" because of which the pacemaker resource agent do not call the "monitor" action at all for

[ovs-dev] [PATCH] memory: kill ovs-vswitchd under super high memory usage.

2017-11-17 Thread William Tu
When deploying OVS on a large scale testbed, we occationally see OVS gets killed by the oom (out-of-memory) killer, after installing 100k rules and seeing ovs-vswitchd consumes more than 4GB of memory. Unfortunately, there is no better way to debug and root cause the memory leak. The patch tries t

[ovs-dev] [PATCH v2] netdev-tc-offloads: update stats properly on flow deletion

2017-11-17 Thread Paolo Abeni
Currently, when an offloaded DP flow is deleted, the related stats are unconditionally cleared. As a result the counters for the originating open flow are corrupted. This change addresses the issue updating the DP stats with the current values provided by the flower APIs before deleting the tc fil

[ovs-dev] [PATCH] packets: Prefetch the packet metadata in cacheline1.

2017-11-17 Thread Bhanuprakash Bodireddy
pkt_metadata_prefetch_init() is used to prefetch the packet metadata before initializing the metadata in pkt_metadata_init(). This is done for every packet in userspace datapath and is performance critical. Commit 99fc16c0 prefetches only cachline0 and cacheline2 as the metadata part of respective