[ovs-dev] [PATCH] datapath-windows: Correct endianness for deleting zone.

The zone Netlink attribute is supposed to be in network-byte order, but the Windows code for deleting conntrack entries was treating it as host-byte order. Found by inspection. Signed-off-by: Justin Pettit --- datapath-windows/ovsext/Conntrack.c | 2 +- lib/netlink-conntrack.c

[ovs-dev] [PATCH] lib/conntrack: remove unnecessary addr check for ICMP.

From: wangzhike ICMP response (Unreachable/fragmentationRequired/...) may be created at devices in the middle, and such packets are tagged as invalid in user space conntrack. In fact it does not make sense to validate the src and dest address. Signed-off-by: wang zhike

[ovs-dev] I NEED YOUR HELP

Confidential Request Attn: Sir/Madam, My family have an urgent inheritance fund of US$15 Million that we would like to invest with you. We are looking for a reliable and capable foreign partner that will assist my family and I to receive

Re: [ovs-dev] [PATCH v6 0/7] Output packet batching.

Hi Ilya, I have retested your "Output patches batching" v6 in our standard PVP L3-VPN/VXLAN benchmark setup [1]. The configuration is a single PMD serving a physical 10G port and a VM running DPDK testpmd as IP reflector with 4 equally loaded vhostuser ports. The tests are run with 64 byte

Re: [ovs-dev] [PATCH 2/2] ovsschema: Avoid using 'protected' as variable name

> We can't change the name of the "protected" column in the database > schema, because that breaks backward compatibility. Another approach > would be to make ovsdb-idlc use a different name for columns whose names > are C or C++ keywords; for example, it could append an underscore. Hi Ben,

[ovs-dev] [PATCH v2] ofproto, ovsdb, vswitchd: Avoid using protected as variable name

In C++, 'protected' is a keyword. This patch renames 'protected' to 'protected_' in a couple files so that C++ compiler will not get confused. Signed-off-by: Yi-Hung Wei --- ofproto/ofproto-dpif.c | 10 +- ofproto/ofproto.h | 2 +- ovsdb/ovsdb-idlc.1 | 6

Re: [ovs-dev] [PATCH RFC 3/5] util: Extend ovs_prefetch_range to include prefetch type.

>On Mon, Dec 04, 2017 at 08:16:48PM +, Bhanuprakash Bodireddy wrote: >> With ovs_prefetch_range(), large amounts of data can be prefetched in >> to caches. Prefetch type gives better control over data caching >> strategy; Meaning where the data should be prefetched(L1/L2/L3) and if >> the data

Re: [ovs-dev] [PATCH RFC 2/5] configure: Include -mprefetchwt1 explicitly.

On Mon, Dec 04, 2017 at 08:59:47PM +, Bodireddy, Bhanuprakash wrote: > >On Mon, Dec 04, 2017 at 08:16:47PM +, Bhanuprakash Bodireddy wrote: > >> Processors support prefetch instruction in anticipation of write but > >> compilers(gcc) won't use them unless explicitly asked to do so even >

Re: [ovs-dev] [PATCH RFC 1/5] compiler: Introduce OVS_PREFETCH variants.

Hi Ben, >On Mon, Dec 04, 2017 at 08:16:46PM +, Bhanuprakash Bodireddy wrote: >> This commit introduces prefetch variants by using the GCC built-in >> prefetch function. >> >> The prefetch variants gives the user better control on designing data >> caching strategy in order to increase cache

Re: [ovs-dev] [PATCH RFC 3/5] util: Extend ovs_prefetch_range to include prefetch type.

On Mon, Dec 04, 2017 at 08:16:48PM +, Bhanuprakash Bodireddy wrote: > With ovs_prefetch_range(), large amounts of data can be prefetched in to > caches. Prefetch type gives better control over data caching strategy; > Meaning where the data should be prefetched(L1/L2/L3) and if the data >

Re: [ovs-dev] [PATCH RFC 1/5] compiler: Introduce OVS_PREFETCH variants.

On Mon, Dec 04, 2017 at 08:16:46PM +, Bhanuprakash Bodireddy wrote: > This commit introduces prefetch variants by using the GCC built-in > prefetch function. > > The prefetch variants gives the user better control on designing data > caching strategy in order to increase cache efficiency and

[ovs-dev] [PATCH RFC 5/5] dpif-netdev: Prefetch the cacheline having the cycle stats.

Prefetch the cacheline having the cycle stats so that we can speed up the cycles_count_start() and cycles_count_intermediate(). Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH RFC 4/5] util: Use OPCH_NTR type while prefetching packet metadata.

OVS_PREFETCH by default uses OPCH_HTR(High Temporal Read), meaning the prefetch is in preparation for a future read and the prefetched data is made available in all levels of caches. However the pkt_metadata_prefetch_init() prefetches the metadata so that the data is readily available when

[ovs-dev] [PATCH RFC 3/5] util: Extend ovs_prefetch_range to include prefetch type.

With ovs_prefetch_range(), large amounts of data can be prefetched in to caches. Prefetch type gives better control over data caching strategy; Meaning where the data should be prefetched(L1/L2/L3) and if the data reference is temporal or non-temporal. Signed-off-by: Bhanuprakash Bodireddy

[ovs-dev] [PATCH RFC 2/5] configure: Include -mprefetchwt1 explicitly.

Processors support prefetch instruction in anticipation of write but compilers(gcc) won't use them unless explicitly asked to do so even with '-march=native' specified. [Problem] Case A: OVS_PREFETCH_CACHE(addr, OPCH_HTW) __builtin_prefetch(addr, 1, 3) leaq-112(%rbp),

[ovs-dev] [PATCH RFC 1/5] compiler: Introduce OVS_PREFETCH variants.

This commit introduces prefetch variants by using the GCC built-in prefetch function. The prefetch variants gives the user better control on designing data caching strategy in order to increase cache efficiency and minimize cache pollution. Data reference patterns here can be classified in to -

[ovs-dev] [PATCH v2] packets: Prefetch the packet metadata in cacheline1.

pkt_metadata_prefetch_init() is used to prefetch the packet metadata before initializing the metadata in pkt_metadata_init(). This is done for every packet in userspace datapath and is performance critical. Commit 99fc16c0 prefetches only cachline0 and cacheline2 as the metadata part of

Re: [ovs-dev] [PATCH] odp-util: Enlarge local buffer to hold Geneve options.

On Tue, Nov 28, 2017 at 04:09:25PM -0800, Ben Pfaff wrote: > The 'mask' buffer in parse_odp_action() is supposed to always be big > enough: > /* 'mask' is big enough to hold any key. */ > > Geneve options can be really big and the comment was wrong. This commit > fixes the problem. > >

[ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

The 'mask' buffer in parse_odp_action() is supposed to always be big enough: /* 'mask' is big enough to hold any key. */ Geneve options can be really big and the comment was wrong. In addition, the user might supply more options than can really fit in any case, so we might as well just

Re: [ovs-dev] [patch v1 4/4] conntrack: Change established state to match kernel.

Lots to digest - responses below Jan Scheurich writes: > Hi Darrel, > Let me try respond to your points below. > Regards, Jan >> -Original Message- >> From: Darrell Ball [mailto:db...@vmware.com] >> Sent: Thursday, 30 November, 2017 01:33 >> >> The idea of

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

On Mon, Dec 04, 2017 at 08:47:38AM +, Vishal Deep Ajmera wrote: > As per OpenFlow v1.3 specification, when an action list contains a group > action a copy of the packet is passed to the group for processing by the > group. This means that if there is an error encountered during group >

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Applied, thanks. On Mon, Dec 04, 2017 at 03:06:39PM +0100, Daniel Alvarez Sanchez wrote: > Acked-by: Daniel Alvarez > > From [0] one can expect this column to be present in all tables. > [0] https://github.com/openvswitch/ovs/blob/v2.8.1/ovn/ovn-nb.xml#L19 > > On Mon, Dec

[ovs-dev] [PATCH] DNS: Add basic support for asynchronous DNS resolving

This patch is a simple implementation for the proposal discussed in https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337038.html and https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340013.html. It enables ovs-vswitchd to use DNS names when specifying OpenFlow and OVSDB

Re: [ovs-dev] [PATCH] datapath: Fix kernel panic for uninitialized tun_dst of ovs_gso_cb.

On 12/4/2017 9:45 AM, Ben Pfaff wrote: On Mon, Dec 04, 2017 at 09:00:56AM -0800, Gregory Rose wrote: On 11/18/2017 2:01 AM, w00273186 wrote: From: Yunjian Wang The variable tun_dst in struct ovs_gso_cb isn't necessarily all-zeros which came from the Netlink layer.

[ovs-dev] Terminar relaciones laborales conforme a la ley

Todo lo que necesita saber para negociar los términos de relaciones laborales Taller práctico de finiquitos y liquidaciones 08 de Diciembre - MCE. Abdón Guzmán - 9am-3pm Cuando no se cuenta con los conocimientos de derecho laboral y fiscal, así como las formas y procedimientos sólidos para

Re: [ovs-dev] [PATCH] Upcall/Slowpath rate limiter for OVS

Hi, This was one of the items discussed in the last OVS-DPDK public meeting (29-Nov). Considering that this change is passive (disabled by default and does not come in fast-path) and makes OVS (when enabled) more secure for potential DOS-attack, could this be considered for OVS 2.9? In any

Re: [ovs-dev] [PATCH] datapath: Fix kernel panic for uninitialized tun_dst of ovs_gso_cb.

On Mon, Dec 04, 2017 at 09:00:56AM -0800, Gregory Rose wrote: > On 11/18/2017 2:01 AM, w00273186 wrote: > >From: Yunjian Wang > > > >The variable tun_dst in struct ovs_gso_cb isn't necessarily all-zeros which > >came from the Netlink layer. When delete a netdev port and

Re: [ovs-dev] [PATCH][branch-2.8] tests: Fix some ofproto-dpif.at conntrack tests

On Sun, Dec 03, 2017 at 08:09:02PM +0200, Alin Gabriel Serdean wrote: > The tests: > ofproto-dpif - conntrack - controller > ofproto-dpif - conntrack - force commit > ofproto-dpif - conntrack - recirc,commit > > are broken on branch-2.8, because they are missing "ip," in the receive > packet. >

Re: [ovs-dev] [PATCH] datapath: Fix kernel panic for uninitialized tun_dst of ovs_gso_cb.

On 11/18/2017 2:01 AM, w00273186 wrote: From: Yunjian Wang The variable tun_dst in struct ovs_gso_cb isn't necessarily all-zeros which came from the Netlink layer. When delete a netdev port and immediately add a vxlan port, they maybe use the same port_no. So the

Re: [ovs-dev] [PATCH] sflow: Correctly document setup command.

On Mon, Dec 04, 2017 at 08:32:28AM -0800, Gregory Rose wrote: > On 11/30/2017 10:38 AM, Ben Pfaff wrote: > >Reported-by: Shivaram Mysore > >Signed-off-by: Ben Pfaff > >--- > > Documentation/howto/sflow.rst | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH] datapath: Fix kernel panic for uninitialized tun_dst of ovs_gso_cb.

On 12/3/2017 8:51 PM, Ben Pfaff wrote: I'm the wrong one to review it, I don't know the datapath well enough anymore. Perhaps Greg could take a look. I'll have a look at it today. Thanks, - Greg On Mon, Dec 04, 2017 at 01:36:52AM +, wangyunjian wrote: Can we review this patch? It's

Re: [ovs-dev] [PATCH v2] coding-style: Explain when to break lines before or after binary operators.

On Mon, Dec 04, 2017 at 10:26:13AM -0200, Flavio Leitner wrote: > On Fri, 1 Dec 2017 11:22:59 -0800 > Ben Pfaff wrote: > > The coding style has never been explicit about this. This commit adds some > > explanation of why one position or the other might be favored in a given > >

Re: [ovs-dev] [PATCH v2] coding-style: Explain when to break lines before or after binary operators.

On Fri, Dec 01, 2017 at 11:41:12PM +, Tiago Lam wrote: > Thanks, Ben! > > This clarifies things for me. I've also tried to render the file and > everything looks fine. > > Only one small nit below, but it doesn't affect the rendering, thus, for > what it's worth: > > Acked-by: Tiago Lam

Re: [ovs-dev] [PATCH] sflow: Correctly document setup command.

On 11/30/2017 10:38 AM, Ben Pfaff wrote: Reported-by: Shivaram Mysore Signed-off-by: Ben Pfaff --- Documentation/howto/sflow.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/howto/sflow.rst

Re: [ovs-dev] [patch v2 3/3] conntrack: Disable algs by default.

On 11/30/17, 8:02 AM, "Aaron Conole" wrote: Darrell Ball writes: > There is a bug here in that the control connection should still be created even though it is likely an unused control connection. > The following incremental fixes it.

[ovs-dev] [patch v3 3/3] conntrack: Disable algs by default.

Presently, alg processing is enabled by default to better exercise code. This is similar to kernels before 4.7 as well. The recommended default behavior in the newer kernels is to only process algs if a helper is supplied in a conntrack rule. The behavior is changed to match the later kernels.

[ovs-dev] [patch v3 2/3] conntrack: Allow specified alg port numbers.

Algs can use variable control port numbers for servers. The main use case is a kind of feeble security measure; the thinking being by some is that it obscures the alg traffic. It is really not very effective, but the kernel has this capability. This patch mimics the capability. Signed-off-by:

[ovs-dev] [patch v3 0/3] conntrack: Alg improvements.

Some refactoring of alg support is done. Also allow for non-standard alg conntrol port specification. Also algs are now disabled by default, unless an alg specifier is supplied; this allows for enhanced security and matches later kernels. v2->v3: 1/ A bit more refactoring for patch 1. 2/

[ovs-dev] [patch v3 1/3] conntrack: Refactor algs.

Upcoming requirements for new algs make it desirable to split out alg helpers more cleanly. Signed-off-by: Darrell Ball --- lib/conntrack.c | 156 1 file changed, 101 insertions(+), 55 deletions(-) diff --git

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

On Mon, Dec 4, 2017 at 7:39 PM, Numan Siddique wrote: > > > On Mon, Dec 4, 2017 at 7:12 PM, Russell Bryant wrote: > >> On Mon, Dec 4, 2017 at 12:29 AM, wrote: >> > From: Numan Siddique >> > >> > Pacemaker

[ovs-dev] [PATCH v4] OVN pacemaker: Add the monitor action for Master role

From: Numan Siddique Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action periodically to check the status. But the OVN OCF script doesn't add the action "monitor" for the role "Master" because of which the pacemaker resource agent do not call the

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

On Mon, Dec 4, 2017 at 7:12 PM, Russell Bryant wrote: > On Mon, Dec 4, 2017 at 12:29 AM, wrote: > > From: Numan Siddique > > > > Pacemaker Resource agent periodically calls the OVN OCF's "monitor" > action > > periodically to check

Re: [ovs-dev] [PATCH v2 1/8] netlink: provide network namespace id from a msg.

On Mon, 4 Dec 2017 11:44:19 -0200, Flavio Leitner wrote: > It is only positive numbers if you review the kernel sources today, > but the API is exposing signed 32bit, so not sure what can happen > in the future if the kernel decides to expand the range. I think you can assume that it will always

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Acked-by: Daniel Alvarez >From [0] one can expect this column to be present in all tables. [0] https://github.com/openvswitch/ovs/blob/v2.8.1/ovn/ovn-nb.xml#L19 On Mon, Dec 4, 2017 at 2:16 PM, wrote: > From: Lucas Alvares Gomes

Re: [ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

Acked-by: Miguel Angel Ajo On Mon, Dec 4, 2017 at 2:16 PM, wrote: > From: Lucas Alvares Gomes > > The external_ids column is missing from the NAT and > Logical_Router_Static_Route tables. > > Signed-off-by: Lucas Alvares Gomes

Re: [ovs-dev] [PATCH v2 2/8] netdev-linux: initialize netns as invalid.

On Fri, 1 Dec 2017 13:15:06 -0800 Ben Pfaff wrote: > On Thu, Nov 09, 2017 at 03:31:01PM -0200, Flavio Leitner wrote: > > A port might be already in another netns, so initialize it > > as invalid to force a state update. > > > > Signed-off-by: Flavio Leitner >

Re: [ovs-dev] [PATCH V4 1/2] netdev-dpdk: DPDK v17.11 upgrade

Hello, I tested it. It is ok for my meter patch: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341544.html This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in

Re: [ovs-dev] [PATCH v2 3/8] vport: retrieve the netnsid if available.

On Tue, 14 Nov 2017 10:55:44 -0800 Gregory Rose wrote: > On 11/9/2017 9:31 AM, Flavio Leitner wrote: > > Recent kernels provide the network namespace ID of a port, > > so use that to discover where the port currently is. > > > > Signed-off-by: Flavio Leitner

Re: [ovs-dev] [PATCH v2 1/8] netlink: provide network namespace id from a msg.

On Fri, 1 Dec 2017 13:14:07 -0800 Ben Pfaff wrote: > On Thu, Nov 09, 2017 at 03:31:00PM -0200, Flavio Leitner wrote: > > The netlink notification's ancillary data contains the network > > namespace id (netnsid) needed to identify the device correctly. > > (ifindex and netnsid). > >

Re: [ovs-dev] [PATCH v3] OVN pacemaker: Add the monitor action for Master role

On Mon, Dec 4, 2017 at 12:29 AM, wrote: > From: Numan Siddique > > Pacemaker Resource agent periodically calls the OVN OCF's "monitor" action > periodically to check the status. But the OVN OCF script doesn't add the > action "monitor" for the role

[ovs-dev] [PATCH v1] OVN: Add external_ids to NAT and Logical_Router_Static_Route tables.

From: Lucas Alvares Gomes The external_ids column is missing from the NAT and Logical_Router_Static_Route tables. Signed-off-by: Lucas Alvares Gomes --- ovn/ovn-nb.ovsschema | 14 ++ ovn/ovn-nb.xml | 14 ++ 2 files

Re: [ovs-dev] [PATCH v2] coding-style: Explain when to break lines before or after binary operators.

On Fri, 1 Dec 2017 11:22:59 -0800 Ben Pfaff wrote: > The coding style has never been explicit about this. This commit adds some > explanation of why one position or the other might be favored in a given > situation. > > Suggested-by: Flavio Leitner >

[ovs-dev] [PATCH V4 1/2] netdev-dpdk: DPDK v17.11 upgrade

This commit adds support for DPDK v17.11: - minor updates to accomodate DPDK API changes - update references to DPDK version in Documentation - update DPDK version in travis' linux-build script Signed-off-by: Mark Kavanagh Acked-by: Maxime Coquelin

[ovs-dev] [PATCH V4 2/2] netdev-dpdk: vHost IOMMU support

DPDK v17.11 introduces support for the vHost IOMMU feature. This is a security feature, which restricts the vhost memory that a virtio device may access. This feature also enables the vhost REPLY_ACK protocol, the implementation of which is known to work in newer versions of QEMU (i.e. v2.10.0),

[ovs-dev] [PATCH V4 0/2] DPDK v17.11 Support

This patchset adds support for DPDK v17.11: - the first patch introduces minor code updates to accomodate DPDK API changes, and also updates Documentation and travis scripts. - the second patch adds a new global configuration option, vhost-iommu-support; this is required in order to take

Re: [ovs-dev] [PATCH V3 0/2] DPDK v17.11 Support

>From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Friday, December 1, 2017 5:34 AM >To: Kavanagh, Mark B ; d...@openvswitch.org >Cc: ktray...@redhat.com; maxime.coque...@redhat.com; >jan.scheur...@ericsson.com; Mooney, Sean K ; Stokes,

[ovs-dev] Saludos de la Sra. Gloria Febian

Saludos de la Sra. Gloria Febian Me pongo en contacto con usted en base a sus buenos perfiles que leo. Y por buenas razones, estoy en busca de una propiedad para comprar en su país, ya que tenía la intención de venir a su país para la inversión. Aunque no me he encontrado con usted antes, pero

[ovs-dev] Do you need any help on Wordpress/Woocommerce, Magento or Drupal?

Hi Business Owners,         I amvirendra singh pal, and I work with experienced IT professionals who specializein the following services.   1. Website Designing 2. Web Development 3. Responsive Websites 4. PHP Development 5. E-Commerce Solutions 6. Magento Website Development   May I

[ovs-dev] [PATCH] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

As per OpenFlow v1.3 specification, when an action list contains a group action a copy of the packet is passed to the group for processing by the group. This means that if there is an error encountered during group processing, only the copy of packet should be dropped, but subsequent actions in

Re: [ovs-dev] [PATCH v3] ovn: OVN Support QoS meter

Hello Ben: I have sent a new patch serial, based on your review comments: https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341543.html https://mail.openvswitch.org/pipermail/ovs-dev/2017-December/341544.html Thanks, Guoshuai On Mon, Nov 13, 2017 at 08:23:29PM +0800, Guoshuai

[ovs-dev] [PATCH V4 2/2] ovn: OVN Support QoS meter

This feature is used to limit the bandwidth of flows, such as floating IP. ovn-northd changes: 1. add bandwidth column in NB's QOS table. 2. add QOS_METER stages in Logical switch ingress/egress. 3. add set_meter() action in SB's LFlow table. ovn-controller changes: add meter_table for meter

[ovs-dev] [PATCH V4 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

The structure and function of the group table and meter table are similar, refactoring code is used to extend for add the meter table. The following function as lib: table init/destroy/clear, install contents from desired, remove contents from existing, Move the contents of desired to existing.