Re: [ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

Hi Ben, I did consider updating the definition of BUILD_ASSERT, however, that would involve changing all existing definitions (even non-expression context). This issue is prevalent on both Linux and Windows when we start compiling in C++ 11. Associated post:

Re: [ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

On Tue, Dec 19, 2017 at 03:32:27PM -0800, Sairam Venugopal wrote: > A static assert declaration may appear at block scope (as a block > declaration) and inside a class body (as a member declaration). However, > unlike sizeof, static_assert cannot be used as an expression and this is > strictly

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On Tue, Dec 05, 2017 at 02:55:20PM +, Michal Weglicki wrote: > - New get_custom_stats interface function is added to netdev. It > allows particular netdev implementation to expose custom > counters in dictionary format (counter name/counter value). > - New statistics are retrieved using

[ovs-dev] [PATCH] lib/unaligned.h - Fix C++ compiler issue with BUILD_ASSERT on Windows

A static assert declaration may appear at block scope (as a block declaration) and inside a class body (as a member declaration). However, unlike sizeof, static_assert cannot be used as an expression and this is strictly enforced on MSVC. error C2059: syntax error : static_assert Signed-off-by:

Re: [ovs-dev] [PATCH v5 0/4] Fixing C++ compiltation issues

Thanks. I applied this series to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in corner case in ovsdb_txn_commit_().

Thanks for the fix. Reviewed-by: Yifeng Sun On Tue, Dec 19, 2017 at 2:20 PM, Ben Pfaff wrote: > Reported-by: Yifeng Sun > Signed-off-by: Ben Pfaff > --- > ovsdb/transaction.c | 1 + > 1 file changed, 1

Re: [ovs-dev] [PATCH] ovsdb-server: Drop 'txn' member from struct db.

Thanks for pointing that out. I sent out a fix: https://patchwork.ozlabs.org/patch/851073/ On Tue, Dec 19, 2017 at 02:13:38PM -0800, Yifeng Sun wrote: > At the start of ovsdb_txn_commit_, if there is an error, it looks like that > txn doesn't get freed. > After that, it surely is freed,

[ovs-dev] [PATCH] ovsdb: Fix memory leak in corner case in ovsdb_txn_commit_().

Reported-by: Yifeng Sun Signed-off-by: Ben Pfaff --- ovsdb/transaction.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ovsdb/transaction.c b/ovsdb/transaction.c index 2e315804a19e..f47d45fca397 100644 --- a/ovsdb/transaction.c +++

Re: [ovs-dev] [PATCH v6 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

I think that's OK. On Tue, Dec 19, 2017 at 10:51:53AM +, Stokes, Ian wrote: > Hi Greg, > > You had previously tested/reviewed this patchset when it was v5. Do you have > any more comments on the v6? > > If not I was going to validate and merge this to the DPDK_MERGE branch today. > >

Re: [ovs-dev] [PATCH] ovsdb-server: Drop 'txn' member from struct db.

At the start of ovsdb_txn_commit_, if there is an error, it looks like that txn doesn't get freed. After that, it surely is freed, as you said. error = for_each_txn_row(txn, determine_changes); if (error) { return OVSDB_WRAP_BUG("can't happen", error); } On Tue, Dec

Re: [ovs-dev] [PATCH] ovsdb-server: Drop 'txn' member from struct db.

Thank you for the review. ovsdb_txn_commit() is at least meant to free its argument whether it succeeds or not. Do you see a bug there? I applied this to master. On Tue, Dec 19, 2017 at 09:50:45AM -0800, Yifeng Sun wrote: > It seems that txn is not freed when ovsdb_txn_commit returns an error.

Re: [ovs-dev] [PATCH v3 8/8] ovsdb-tool: Add new "db-name" and "schema-name" commands.

Thank you for the testing and review. I applied this patch to master. On Mon, Dec 18, 2017 at 08:15:10PM -0800, Yifeng Sun wrote: > Tested this patch and it works, thanks. > > Tested-by: Yifeng Sun > > Reviewed-by: Yifeng Sun > > On Wed, Dec

[ovs-dev] Medios de Defensa para las Finanzas Empresariales

La mejor forma de defenderse es conocer la normatividad Revisiones Electrónicas, Prevención y Medios de Defensa para las Finanzas Empresariales. 18 de Enero - : LC. Y LD. Jacobo Meraz Sotelo - 9am-3pm Para efectos de las revisiones electrónicas, las autoridades fiscales deberán atender a lo

Re: [ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

On Tue, Dec 19, 2017 at 03:42:47PM -0500, Eric Garver wrote: > On Tue, Dec 19, 2017 at 08:39:29PM +0100, Jiri Benc wrote: > > On Tue, 19 Dec 2017 13:57:53 -0500, Eric Garver wrote: > > > --- a/net/openvswitch/flow.c > > > +++ b/net/openvswitch/flow.c > > > @@ -559,8 +559,9 @@ static int

Re: [ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

On Tue, Dec 19, 2017 at 08:39:29PM +0100, Jiri Benc wrote: > On Tue, 19 Dec 2017 13:57:53 -0500, Eric Garver wrote: > > --- a/net/openvswitch/flow.c > > +++ b/net/openvswitch/flow.c > > @@ -559,8 +559,9 @@ static int parse_nsh(struct sk_buff *skb, struct > > sw_flow_key *key) > > * of a

Re: [ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

On Tue, 19 Dec 2017 13:57:53 -0500, Eric Garver wrote: > --- a/net/openvswitch/flow.c > +++ b/net/openvswitch/flow.c > @@ -559,8 +559,9 @@ static int parse_nsh(struct sk_buff *skb, struct > sw_flow_key *key) > * of a correct length, otherwise the same as skb->network_header. > * For

[ovs-dev] [PATCH net] openvswitch: Fix pop_vlan action for double tagged frames

skb_vlan_pop() expects skb->protocol to be a valid TPID for double tagged frames. As such don't override skb->protocol for normal ethernet frames when extracting the key. Fixes: 5108bbaddc37 ("openvswitch: add processing of L3 packets") Signed-off-by: Eric Garver ---

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

hi Ilya, On 12/14/2017 11:59 AM, Ilya Maximets wrote: > This allows to collect packets from more than one RX burst > and send them together with a configurable intervals. > > 'other_config:tx-flush-interval' can be used to configure > time that a packet can wait in output batch for sending. > >

[ovs-dev] [PATCHv3] DNS: Add basic support for asynchronous DNS resolving

This patch is a simple implementation for the proposal discussed in https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337038.html and https://mail.openvswitch.org/pipermail/ovs-dev/2017-October/340013.html. It enables ovs-vswitchd to use DNS names when specifying OpenFlow and OVSDB

Re: [ovs-dev] [PATCH v2 0/3] Fix tunnel neighbor cache population

On 12/14/2017 12:56 AM, Zoltan Balogh wrote: Currenlty, OVS snoops any ARP or ND packets in any bridge and populates the tunnel neighbor cache with the retreived data. For instance, when ARP reply originated by a tenant is received on an overlay bridge, the ARP message is snooped and tunnel

Re: [ovs-dev] [PATCH v6 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

On 12/19/2017 2:51 AM, Stokes, Ian wrote: Hi Greg, You had previously tested/reviewed this patchset when it was v5. Do you have any more comments on the v6? If not I was going to validate and merge this to the DPDK_MERGE branch today. No, I did not have any further comments.  The testing

Re: [ovs-dev] [PATCH] ovsdb-server: Drop 'txn' member from struct db.

It seems that txn is not freed when ovsdb_txn_commit returns an error. Other than that, this patch looks good to me. Thanks, Yifeng On Fri, Dec 15, 2017 at 11:01 AM, Ben Pfaff wrote: > This member was only used in one particular code path, so this commit > adds code to pass it

[ovs-dev] [PATCH v7] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

Enabled per port like so: ovs-vsctl set Interface dpdkvhostuserclient0 options:dq-zero-copy=true If the device is already active at the point of enabling/disabling the feature via ovs-vsctl, one must reload the guest driver or reboot the VM in order for the feature to be successfully

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Tuesday, December 19, 2017 3:07 PM > To: Weglicki, MichalX ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] netdev: Custom statistics. > > On 12/05/2017 02:55 PM, Michal

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

> > > Should this have some additional cover for the ENOSPC case? Meaning, > > we > > > will now increment a failure condition, but I'm not sure it should be > > > considered an 'upcall' failure? After all, we'll still perform the > > actions. > > > > Good question. I inherited

Re: [ovs-dev] [PATCH v2] netdev: Custom statistics.

On 12/05/2017 02:55 PM, Michal Weglicki wrote: > - New get_custom_stats interface function is added to netdev. It > allows particular netdev implementation to expose custom > counters in dictionary format (counter name/counter value). > - New statistics are retrieved using experimenter code

[ovs-dev] [PATCH v2] docs: Describe output packet batching in DPDK guide.

Added information about output packet batching and a way to configure 'tx-flush-interval'. Signed-off-by: Ilya Maximets Co-authored-by: Jan Scheurich Signed-off-by: Jan Scheurich --- Version 2: * Returned

Re: [ovs-dev] [PATCH] docs: Describe output packet batching in DPDK guide.

Sorry, I forget about pmd-rxq-show. Will send v2. On 19.12.2017 16:04, Ilya Maximets wrote: > Added information about output packet batching and a way to > configure 'tx-flush-interval'. > > Signed-off-by: Ilya Maximets > Co-authored-by: Jan Scheurich

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

> > > The only correction I need to make is that for us 50 us showed good > improvements in a "PVP" scenario with iperf3 as kernel application > > in the guest (not VM-VM). > > > > OK. Thanks. I'll send this version with above correction as a proper > [PATCH] soon. > > Jan, I also would like to

[ovs-dev] 60+ Offers & 5% Discount On Your Orders!

Exactly what you wanted :) We believe that you already know about https://chaldal.com/offers Chaldal.com [ https://chaldal.com/offers ] :). So lets make it short & simple! Place an order worth https://www.facebook.com/chaldalcom/videos/810539925798750/ 499 tk [

Re: [ovs-dev] [PATCH v4 1/3] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Darrell Ball writes: > On 12/18/17, 2:41 PM, "Jan Scheurich" wrote: > > Hi Aaron, > Thanks for the review. Answers in-line. > Regards, Jan > > > -Original Message- > > From: Aaron Conole [mailto:acon...@redhat.com] >

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

> > The only correction I need to make is that for us 50 us showed good > > improvements in a "PVP" scenario with iperf3 as kernel application > in the guest (not VM-VM). > > OK. Thanks. I'll send this version with above correction as a proper [PATCH] > soon. > Jan, I also would like to add you

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

On 19.12.2017 14:56, Jan Scheurich wrote: > I am OK with Ilya's proposal. > > The only correction I need to make is that for us 50 us showed good > improvements in a "PVP" scenario with iperf3 as kernel application in the > guest (not VM-VM). OK. Thanks. I'll send this version with above

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

I am OK with Ilya's proposal. The only correction I need to make is that for us 50 us showed good improvements in a "PVP" scenario with iperf3 as kernel application in the guest (not VM-VM). BR, Jan > -Original Message- > From: Stokes, Ian [mailto:ian.sto...@intel.com] > Sent:

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

> On 19.12.2017 13:39, Stokes, Ian wrote: > >> Hi Ilya, > >> > >> Some more suggestions below to expand a bit on the use cases for > >> tx-flush- interval. > >> > >> BR, Jan > > > > Hi Ilya, > > > > I agree with Jans input here. I've finished validating the output > batching patchset today bit

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

On 19.12.2017 13:39, Stokes, Ian wrote: >> Hi Ilya, >> >> Some more suggestions below to expand a bit on the use cases for tx-flush- >> interval. >> >> BR, Jan > > Hi Ilya, > > I agree with Jans input here. I've finished validating the output batching > patchset today bit would like to include

Re: [ovs-dev] [PATCH v6 2/2] ofproto-dpif-ipfix: add interface Information Elements to flow key

Hi Greg, You had previously tested/reviewed this patchset when it was v5. Do you have any more comments on the v6? If not I was going to validate and merge this to the DPDK_MERGE branch today. Thanks Ian > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >

Re: [ovs-dev] [RFC v2] docs: Describe output packet batching in DPDK guide.

> Hi Ilya, > > Some more suggestions below to expand a bit on the use cases for tx-flush- > interval. > > BR, Jan Hi Ilya, I agree with Jans input here. I've finished validating the output batching patchset today bit would like to include this documentation also. Are you planning to re-spin

[ovs-dev] Need help with adding custom IPv6 extension header match and tag support.

Hello, I hope this is the correct mailing list. I need to add a custom feature to OVS for my research where it can match on a custom IPv6 extension header, and be able to perform the action of appending a datagram with a custom IPv6 extension header. I cloned the latest version and followed