[ovs-dev] Swift Copy - December 21st, 2017

2017-12-21 Thread PT. Akbar Nusantera
Dear d...@openvswitch.org, PT. Akbar Nusantera sent you this email message with the following file attachments: - Swift copy.zip (706.7 KB) Comment: Good Morning, Here is the payment slip. Confirm and get back to me. Best regards, Rachmat Yanuar (Fery) PT. Akbar Nusantera Jl. Cimanuk No.

[ovs-dev] 5000+ Grocery Products For Your Whole Family

2017-12-21 Thread Chaldal.com
Quickest Home Delivery in Dhaka https://www.chaldal.com https://www.chaldal.com At Chaldal, our main focus is to provide top class service before ,during & after sales to each of our customers. Our team of 375+ members have only one mission & that is to save your

Re: [ovs-dev] [PATCH] jsonrpc-server: Enforce uniqueness of monitor IDs.

2017-12-21 Thread Justin Pettit
> On Dec 21, 2017, at 4:30 PM, Ben Pfaff wrote: > > What do you think of this version? Yes, it's much clearer to me. Thanks! > @@ -1458,10 +1466,12 @@ ovsdb_jsonrpc_monitor_cond_change(struct > ovsdb_jsonrpc_session *s, > } > > /* Change monitor id */ > -

Re: [ovs-dev] [PATCH v3 6/8] ovsdb-client: Add new "restore" command.

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 02:23:54PM -0800, Justin Pettit wrote: > > On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > diff --git a/Documentation/ref/ovsdb.7.rst b/Documentation/ref/ovsdb.7.rst > > index ddc573a47c94..1f860768df2d 100644 > > --- a/Documentation/ref/ovsdb.7.rst > > +++

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Use customary types for buffer.

2017-12-21 Thread Justin Pettit
> On Nov 27, 2017, at 1:53 PM, Ben Pfaff wrote: > > This function uses local array set_buff[] to store Netlink attributes. > It declares set_buff as an array of character pointers, which is a strange > type for a buffer of non-character-pointer objects. In OVS it is > customary

[ovs-dev] WAITING TO HEAR FROM YOU

2017-12-21 Thread John Frank
Good day, Mr.John frank is my name, I work in a Bank here in Benin. And I personally handles transactions of Mr. Hamza Yaqoob who eventually died on the 5th of February 2015 from injuries he sustained in auto crash that happened 2:30pm 2years ago. Before his death, Mr. Hamza Yaqoob lived

Re: [ovs-dev] [PATCH] jsonrpc-server: Enforce uniqueness of monitor IDs.

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 03:03:37PM -0800, Justin Pettit wrote: > > > > On Dec 8, 2017, at 1:01 PM, Ben Pfaff wrote: > > > > This oversight allowed monitor IDs to be duplicated when the > > monitor_cond_change request changed them. > > > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2] odp-util: Use flexible sized buffer to hold Geneve options.

2017-12-21 Thread Justin Pettit
> On Dec 4, 2017, at 11:51 AM, Ben Pfaff wrote: > > The 'mask' buffer in parse_odp_action() is supposed to always be big > enough: >/* 'mask' is big enough to hold any key. */ > > Geneve options can be really big and the comment was wrong. In addition, > the user might

Re: [ovs-dev] [PATCH] ovsdb-client: Show even constraint-breaking data in "dump" output.

2017-12-21 Thread Justin Pettit
> On Dec 8, 2017, at 12:37 PM, Ben Pfaff wrote: > > The ovsdb-client "dump" command is a fairly low-level tool that can be > used, among other purposes, to debug the OVSDB protocol. It's better if > it just prints what the server sends without being too judgmental about it. >

Re: [ovs-dev] [PATCH] ovs-vswitchd: Allow more convenient 0x short form for specifying DPIDs.

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 03:09:09PM -0800, Justin Pettit wrote: > > > > On Oct 23, 2017, at 2:01 PM, Ben Pfaff wrote: > > > > Until now, ovs-vswitchd has insisted that other-config:datapath-id be > > exactly 16 hex digits. This commit allows shorter forms prefixed by 0x. > > This

Re: [ovs-dev] [PATCH] ovsdb-server: Forbid user-specified databases with reserved names.

2017-12-21 Thread Justin Pettit
> On Dec 8, 2017, at 12:53 PM, Ben Pfaff wrote: > > +if (argc > 2 && argv[1][0] == '_') { > +unixctl_command_reply_error(conn, "cannot compact built-in > databases"); > +return; > +} This error condition seems a little odd to me. I think it will only

Re: [ovs-dev] [PATCH] table: Add --max-column-width option.

2017-12-21 Thread Justin Pettit
> On Dec 8, 2017, at 12:54 PM, Ben Pfaff wrote: > > This can make it easier to read tables that contain wide data in some > columns. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH] dpif: Use spaces instead of tabs.

2017-12-21 Thread Justin Pettit
> On Dec 21, 2017, at 3:24 PM, Gregory Rose wrote: > > On 12/21/2017 2:28 PM, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- >> lib/dpif.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/lib/dpif.h

Re: [ovs-dev] [PATCH] xcache: Handle null argument for xlate_cache_uninit().

2017-12-21 Thread Justin Pettit
> On Dec 21, 2017, at 10:05 AM, Yifeng Sun wrote: > > Thanks, looks good to me. > > Reviewed-by: Yifeng Sun Thanks. I pushed this with yours and Ben's acks. --Justin ___ dev mailing list

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix a couple minor issues in comments.

2017-12-21 Thread Justin Pettit
> On Dec 21, 2017, at 10:21 AM, Ben Pfaff wrote: > > On Wed, Dec 20, 2017 at 07:42:39PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this with yours and Yufeng's acks. --Justin

Re: [ovs-dev] [PATCH] dpif: Use spaces instead of tabs.

2017-12-21 Thread Gregory Rose
On 12/21/2017 2:28 PM, Justin Pettit wrote: Signed-off-by: Justin Pettit --- lib/dpif.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dpif.h b/lib/dpif.h index ab898f4be2dd..2e739dc784be 100644 --- a/lib/dpif.h +++ b/lib/dpif.h @@ -787,9

[ovs-dev] [PATCH] dpif: Use spaces instead of tabs.

2017-12-21 Thread Justin Pettit
Signed-off-by: Justin Pettit --- lib/dpif.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/dpif.h b/lib/dpif.h index ab898f4be2dd..2e739dc784be 100644 --- a/lib/dpif.h +++ b/lib/dpif.h @@ -787,9 +787,9 @@ const char *dpif_upcall_type_to_string(enum

[ovs-dev] [no-slow 6/6] ofproto-dpif: Don't slow-path controller actions with pause.

2017-12-21 Thread Justin Pettit
A previous patch removed slow-pathing for controller actions with the exception of ones that specified "pause". This commit removes that restriction so that no controller actions are slow-pathed. Signed-off-by: Justin Pettit --- lib/odp-util.h | 2 +-

[ovs-dev] [no-slow 3/6] ofp-actions: Add action "debug_slow" for testing slow-path.

2017-12-21 Thread Justin Pettit
It isn't otherwise useful and in fact hurts performance so it's disabled without --enable-dummy. An upcoming commit will make use of this. Signed-off-by: Justin Pettit --- include/openvswitch/ofp-actions.h | 1 + lib/ofp-actions.c | 48

[ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2017-12-21 Thread Justin Pettit
- This reduces the number of times upcall cookies are processed. - It separate true miss calls from slow-path actions. The reorganization will also be useful for a future commit. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif-upcall.c | 91

[ovs-dev] [no-slow 1/6] ofproto-dpif: Add ability to look up an ofproto by UUID.

2017-12-21 Thread Justin Pettit
This will have callers in the future. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif-trace.c | 2 +- ofproto/ofproto-dpif.c | 92 +++- ofproto/ofproto-dpif.h | 13 +-- 3 files changed, 77 insertions(+), 30

Re: [ovs-dev] Maintaining openvswitch-switch-dpdk in Debian

2017-12-21 Thread Ben Pfaff
On Thu, Dec 21, 2017 at 09:28:20AM -0500, Josh Knight wrote: > I'm interested in using the openvswitch-switch-dpdk package (currently in > the Ubuntu repos) on a Debian system, however it does not appear to be in > the Debian repos. > > Are there any efforts or plans to maintain this package in

[ovs-dev] Criptomonedas

2017-12-21 Thread Información actualizada a su alcance
Nuevos esquemas tecnológicos para la conservación y transmisión de valor Criptomonedas: innovación, aplicación e impacto en el sector financiero 19 de enero- Lic. Jonathan H. Stahl Ducker - 9am-3pm No puede perderse la oportunidad de acudir a este seminario en el que conocerá el sistema

Re: [ovs-dev] [PATCH] xcache: Handle null argument for xlate_cache_uninit().

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 07:42:41PM -0800, Justin Pettit wrote: > Most other OVS libraries' delete and uninitialization functions allow a > null argument, but this one would cause a segfault. > > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix a couple minor issues in comments.

2017-12-21 Thread Ben Pfaff
On Wed, Dec 20, 2017 at 07:42:39PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] xcache: Handle null argument for xlate_cache_uninit().

2017-12-21 Thread Yifeng Sun
Thanks, looks good to me. Reviewed-by: Yifeng Sun On Wed, Dec 20, 2017 at 7:42 PM, Justin Pettit wrote: > Most other OVS libraries' delete and uninitialization functions allow a > null argument, but this one would cause a segfault. > > Signed-off-by:

Re: [ovs-dev] [PATCH net v3] openvswitch: Fix pop_vlan action for double tagged frames

2017-12-21 Thread David Miller
From: Eric Garver Date: Wed, 20 Dec 2017 15:09:22 -0500 > skb_vlan_pop() expects skb->protocol to be a valid TPID for double > tagged frames. So set skb->protocol to the TPID and let skb_vlan_pop() > shift the true ethertype into position for us. > > Fixes: 5108bbaddc37

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix a couple minor issues in comments.

2017-12-21 Thread Yifeng Sun
Thanks for the change. Reviewed-by: Yifeng Sun On Wed, Dec 20, 2017 at 7:42 PM, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > ofproto/ofproto-dpif-upcall.h | 2 +- > ofproto/ofproto-dpif-xlate.c | 2 +- > 2 files

[ovs-dev] [PATCH v2 RESEND] openvswitch: Trim off padding before L3+ netfilter processing

2017-12-21 Thread Ed Swierk via dev
IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device. In the normal IPv4 receive path, ip_rcv() trims the packet to

[ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2017-12-21 Thread Ed Swierk via dev
IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device. In the normal IPv4 receive path, ip_rcv() trims the packet to

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

2017-12-21 Thread Ilya Maximets
Thanks everyone for working on this. For now, I've incorporated changes from incremental patch and re-splitted it for simpler review. Rebased on current istokes/dpdk_merge and sent as v9. Documentation patch sent together with the series + change to NEWS. Best regards, Ilya Maximets. On

[ovs-dev] [PATCH v9 5/5] NEWS: Mark output packet batching support.

2017-12-21 Thread Ilya Maximets
New feature should be mentioned in news, especially because it has user-visible configuration options. Signed-off-by: Ilya Maximets --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 057df93..9b86912 100644 --- a/NEWS +++ b/NEWS @@ -27,6

[ovs-dev] [PATCH v9 4/5] docs: Describe output packet batching in DPDK guide.

2017-12-21 Thread Ilya Maximets
Added information about output packet batching and a way to configure 'tx-flush-interval'. Signed-off-by: Ilya Maximets Co-authored-by: Jan Scheurich Signed-off-by: Jan Scheurich ---

[ovs-dev] [PATCH v9 3/5] dpif-netdev: Time based output batching.

2017-12-21 Thread Ilya Maximets
This allows to collect packets from more than one RX burst and send them together with a configurable intervals. 'other_config:tx-flush-interval' can be used to configure time that a packet can wait in output batch for sending. 'tx-flush-interval' has microsecond resolution. Signed-off-by: Ilya

[ovs-dev] [PATCH v9 2/5] dpif-netdev: Count cycles on per-rxq basis.

2017-12-21 Thread Ilya Maximets
Upcoming time-based output batching will allow to collect in a single output batch packets from different RX queues. Lets keep the list of RX queues for each output packet and collect cycles for them on send. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 93

[ovs-dev] [PATCH v9 1/5] dpif-netdev: Use microsecond granularity.

2017-12-21 Thread Ilya Maximets
Upcoming time-based output batching will require microsecond granularity for it's flexible configuration. Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git

[ovs-dev] [PATCH v9 0/5] Output packet batching (Time-based).

2017-12-21 Thread Ilya Maximets
This patch-set inspired by [1] from Bhanuprakash Bodireddy. Implementation of [1] looks very complex and introduces many pitfalls [2] for later code modifications like possible packet stucks. This version targeted to make simple and flexible output packet batching on higher level without

[ovs-dev] TNB End of Year Gift

2017-12-21 Thread Tenaga Nasional Berhad
Tenaga Nasional Berhad (TNB HQ) 129 Jalan Bangsar, 59200 Kuala Lumpur, Malaysia Ini adalah satu pemberitahuan rasmi daripada ibu pejabat daripada Tenaga Nasional Berhad sempena Persatuan Air Malaysia (PAM) untuk memaklumkan anda mengenai Hadiah Khas Eksklusif Tenaga Nasional Berhad Akhir Tahun

Re: [ovs-dev] [PATCH] tunnel: fix tnl_find() after packet_type changed

2017-12-21 Thread Zoltán Balogh
Hi, I sent a new version to dev list. Please ignore this one. I changed the subject, since the problem does not seem to be restricted to tunnel handling. https://patchwork.ozlabs.org/patch/851949/ Best regards, Zoltan > -Original Message- > From: ovs-dev-boun...@openvswitch.org >

[ovs-dev] [PATCH] xlate: don't add dummy eth header when doing recirc

2017-12-21 Thread Zoltán Balogh
In xlate_actions(), when packet comes from a L3 port and its packet_type is not Ethernet, then a dummy Ethernet header is added to the packet by setting flow->packet_type to Ethernet and zero out flow->dl_src and flow->dl_dst. This process should be avoided if packet is recirculated, i.e.

[ovs-dev] [PATCH] xlate: fix xport lookup for recirc

2017-12-21 Thread Zoltán Balogh
Xlate_lookup and xlate_lookup_ofproto_() provides in_port and ofproto based on xport determined using flow, which is extracted from packet. The lookup can happen due to recirculation as well. It can happen, that packet_type has been modified during xlate before recirculation is triggered, so the

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

2017-12-21 Thread Kevin Traynor
On 12/21/2017 12:27 PM, Jan Scheurich wrote: I had a cheaper solution in mind that would accept the inaccuracy of the accounting of tx cycles during rx batch processing (it >> statistically slightly biases the load distribution towards the more heavily >> loaded rx queues). And instead

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

2017-12-21 Thread Jan Scheurich
> >> I had a cheaper solution in mind that would accept the inaccuracy of the > >> accounting of tx cycles during rx batch processing (it > statistically slightly biases the load distribution towards the more heavily > loaded rx queues). And instead of attributing the tx cycles outside > the rx

[ovs-dev] [PATCH] tests: Flunk OVN tests if populating ARP tables failed.

2017-12-21 Thread Jakub Sitnicki
If we cannot talk to ovs-vswitchd process for some reason, e.g. it has terminated prematurely, we want to fail the test as soon as possible. Otherwise the test will likely fail later on due to ARP tables not being populated, which will make the troubleshooting the failure harder. Signed-off-by:

Re: [ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

2017-12-21 Thread Jan Scheurich
> >> DP_PACKET_BATCH_FOR_EACH (packet, packets_) { > >> + > >> p->output_pkts_rxqs[dp_packet_batch_size(>output_pkts)] = > >> + > >> pmd->ctx.last_rxq; > >> dp_packet_batch_add(>output_pkts,