Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Jan 5, 2018 22:17, "Pravin Shelar" wrote: On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk wrote: > On Fri, Jan 5, 2018 at 10:14 AM, Ed Swierk > wrote: >> On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar wrote:

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk wrote: > On Fri, Jan 5, 2018 at 10:14 AM, Ed Swierk > wrote: >> On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar wrote: >>> OVS already pull all required headers in skb linear data,

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > > Signed-off-by: Yi Yang > > > In odp_execute_actions(), this looks bogus: there is nothing to > guarantee that 'buffer' is properly aligned for

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > Signed-off-by: Yi Yang > > This fails to build with Clang (and, I would guess, MSVC): > ../lib/odp-execute.c:497:21: error: fields must have a

[ovs-dev] [PATCH v7 4/4] nsh: add dec_nsh_ttl action

NSH ttl is a 6-bit field ranged from 0 to 63, it should be decremented by 1 every hop, if it is 0 or it is so after decremented, the packet should be dropped and a packet-in message is sent to main controller. Signed-off-by: Yi Yang --- include/openvswitch/ofp-actions.h |

[ovs-dev] [PATCH v7 3/4] nsh: fix nested mask for OVS_KEY_ATTR_NSH

NSH kernel implementation used nested mask for OVS_KEY_ATTR_NSH, so NSH userspace must adapt to it, OVS hasn't used nested mask for any key attribute so far, OVS_KEY_ATTR_NSH is the first use case. Signed-off-by: Yi Yang --- lib/odp-execute.c | 56 +--

[ovs-dev] [PATCH v7 2/4] nsh: add new flow key 'ttl'

IETF NSH draft added a new filed ttl in NSH header, this patch is to add new nsh key 'ttl' for it. Signed-off-by: Yi Yang --- datapath/linux/compat/include/linux/openvswitch.h | 2 +- include/openvswitch/flow.h| 6 +-

[ovs-dev] [PATCH v7 1/4] nsh: rework NSH netlink keys and actions

This patch changes OVS_KEY_ATTR_NSH to nested attribute and adds three new NSH sub attribute keys: OVS_NSH_KEY_ATTR_BASE: for length-fixed NSH base header OVS_NSH_KEY_ATTR_MD1: for length-fixed MD type 1 context OVS_NSH_KEY_ATTR_MD2: for length-variable MD type 2 metadata Its

[ovs-dev] [PATCH v7 0/4] nsh: add new nsh key ttl and action dec_nsh_ttl

v6->v7 - Fix comments for v6 from Ben Pfaff - Fix checkpatch warnings - Fix static code analysis warnings v5->v6 - Rebase v5 to master - Refactor netlink message format to align to NSH kernel implementation - Add dec_nsh_ttl unit test into tests/nsh.at - Fix unit test unstable

[ovs-dev] [PATCH V2] Documentation: Update Faucet tutorial.

Updates Faucet tutorial to work with newer versions than 1.6.7: * Tutorial now shows how to check out latest tag from Faucet's git. * Set minimum_ip_size_check flag to False so that the payloadless packets generated by ofproto/trace aren't dropped by Faucet. * Update Faucet ACL syntax *

[ovs-dev] [PATCH 1/3] ofp-actions: Make formatting and parsing functions take a struct argument.

An upcoming commit will add another parameter for parsing and formatting actions. It is much easier to add these parameters if they are encapsulated in a struct, so this commit first makes that change. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-actions.h | 32 +-

[ovs-dev] [PATCH 2/3] ofp-util: New data structure for mapping between table names and numbers.

This shares the infrastructure for mapping port names and numbers. It will be used in an upcoming commit. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-util.h | 33 +++-- lib/ofp-util.c | 150 ++--- 2 files changed,

[ovs-dev] [PATCH 0/3] support table names in CLI

These patches are not intended to be applied until we've branched for 2.9, since I didn't finish or send them out in time for 2.9. Ben Pfaff (3): ofp-actions: Make formatting and parsing functions take a struct argument. ofp-util: New data structure for mapping between table names and

Re: [ovs-dev] Userspace space conntrack tcp issue

Hi Wang Pls see inline Thanks Darrell On 1/1/18, 10:57 PM, "ovs-dev-boun...@openvswitch.org on behalf of 王志克" wrote: Hi, I am testing below scenario, and I think there is some issue on TCP conntrack

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Fri, Jan 5, 2018 at 10:14 AM, Ed Swierk wrote: > On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar wrote: >> OVS already pull all required headers in skb linear data, so no need >> to redo all of it. only check required is the ip-checksum validation.

[ovs-dev] [PATCH] Documentation: Update Faucet tutorial.

Updates Faucet tutorial to work with newer versions than 1.6.7. Tutorial now shows how to check out latest tag from Faucet's git. Tutorial now sets minimum_ip_size_check flag to False so that the payloadless packets generated by ofproto/trace aren't dropped by Faucet. Signed-off-by: Brad Cowie

Re: [ovs-dev] [PATCH] ofp-print: Include full hex dump of messages that fail decode.

On Fri, Jan 05, 2018 at 10:58:45AM -0800, Guru Shetty wrote: > On 4 January 2018 at 22:40, Ben Pfaff wrote: > > > In debugging issues with a controller that appears to send invalid > > OpenFlow messages, it can be difficult to actually see the important > > details of those

[ovs-dev] Conozca qué es, su aplicación práctica y beneficios

Conocimientos de actualidad al servicio de su empresa Business Analytics: Información financiera clave para la toma de decisiones empresariales 24 de enero- Dr. Mauricio Carrera Abarca - 9am-6pm La minería de datos es el proceso de detectar la información procesable de los conjuntos grandes

Re: [ovs-dev] [PATCH 3/3] rhel: add "force-reload-kmod" support in "ovs-systemd-reload"

On 12/22/2017 7:00 AM, Timothy Redaelli wrote: Since you can't use "ovs-ctl force-reload-kmod" on Fedora/RHEL, due to systemd dependencies, this commit adds the "force-reload-kmod" feature on ovs-systemd-reload. Signed-off-by: Timothy Redaelli ---

Re: [ovs-dev] [PATCH 2/3] rhel: use the functions in ovs-lib.in in ovs-systemd-reload

On 12/22/2017 7:00 AM, Timothy Redaelli wrote: To avoid code duplication use the functions from ovs-lib.in Signed-off-by: Timothy Redaelli --- ...sr_share_openvswitch_scripts_ovs-systemd-reload | 37 ++ 1 file changed, 23 insertions(+), 14

Re: [ovs-dev] [PATCH 1/3] utilities: move some functions from ovs-ctl.in to ovs-lib.in

On 12/22/2017 7:00 AM, Timothy Redaelli wrote: Move the functions related to "force-reload-kmod" and "restart" from ovs-ctl.in to ovs-lib.in in order to permit other scripts to use them. Signed-off-by: Timothy Redaelli --- utilities/ovs-ctl.in | 173

[ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Fixes compile errors on 3.16 series kernels from 3.16.50 on. Signed-off-by: Greg Rose --- V2 - Fix typo ---

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

On 1/5/2018 10:46 AM, Justin Pettit wrote: On Jan 5, 2018, at 8:05 AM, Gregory Rose wrote: For now that's about as far as I can take my investigation since I have a few other things I need to work on. If you can think of another test I should run or something for me to

Re: [ovs-dev] [PATCH] ofp-print: Include full hex dump of messages that fail decode.

On 4 January 2018 at 22:40, Ben Pfaff wrote: > In debugging issues with a controller that appears to send invalid > OpenFlow messages, it can be difficult to actually see the important > details of those messages, because OpenFlow message logging (in the vconn > log module) will

Re: [ovs-dev] [PATCH] compat:inet_frag.h: Check for frag_percpu_counter_batch

On 1/5/2018 10:37 AM, Greg Rose wrote: Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Fixes compile errors on 3.16 series kernels from 3.16.50 on. Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH] xlate: fix xport lookup for recirc

Hello Jan, > As far as I can see the frozen state already contains the ofproto UUID and in > frozen_metadata the OF port ID. > Together these should be sufficient to look up the xport in > xlate_lookup_ofproto_(): I know, that ofproto_uuid (bridge to resume from) and in_port (incoming port)

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

> On Jan 5, 2018, at 8:05 AM, Gregory Rose wrote: > > For now that's about as far as I can take my investigation since I have a few > other things I need to work > on. If you can think of another test I should run or something for me to > check into let me know. Ben

[ovs-dev] [PATCH] compat:inet_frag.h: Check for frag_percpu_counter_batch

Fix up the compat layer to check for frag_percpu_counter_batch and if not present then use atomic_sub and atomic_add as per the backport in the 3.16.50 LTS kernel. Fixes compile errors on 3.16 series kernels from 3.16.50 on. Signed-off-by: Greg Rose ---

Re: [ovs-dev] [PATCH] gre: strip gre-tso offload flags

On 12/28/2017 8:45 PM, we...@ucloud.cn wrote: From: wenxu if the gro enable, ipgre receive a gre-tso package. After pop the gre-tunnel the encapsulation and GSO_ENCAP flags should be striped. or the packet encap again and will be dropped in ovs_iptunnel_handle_offloads

Re: [ovs-dev] [PATCH] lex: Fix parsing of long tokens.

On 1/2/2018 11:15 AM, Ben Pfaff wrote: When a token is longer than the built-in 256-byte buffer, a buffer is malloc()'d but it was not properly null-terminated. Found by afl-fuzz. Reported-by: Bhargava Shastry Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar wrote: > On Wed, Jan 3, 2018 at 7:49 PM, Ed Swierk wrote: >> On Fri, Dec 22, 2017 at 3:31 PM, Pravin Shelar wrote: >>> On Thu, Dec 21, 2017 at 7:17 AM, Ed Swierk

[ovs-dev] [PATCH] OVN: remove useless ds_clear() on actions ds

Remove ds_clear() on actions dynamic string in build_acls() since they have just been initialized to DS_EMPTY_INITIALIZER Signed-off-by: Lorenzo Bianconi --- ovn/northd/ovn-northd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ovn/northd/ovn-northd.c

Re: [ovs-dev] [PATCH v6 2/2] OVN: Add support for periodic router advertisements.

On Wed, Nov 29, 2017 at 03:59:48PM -0600, Mark Michelson wrote: > This change adds three new options to the Northbound > Logical_Router_Port's ipv6_ra_configs option: > > * send_periodic: If set to "true", then OVN will send periodic router > advertisements out of this router port. > *

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

On Thu, Jan 4, 2018 at 5:41 PM, Wang, Yipeng1 wrote: > I agree with you guys on the issue with RSS hash. > > RSS is not originally designed for hash table so it is not flexible enough to > be configured > in the NICs. Smart NICs will be more capable to offload hash

[ovs-dev] [PATCH v8] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

On 1/3/2018 9:37 AM, Gregory Rose wrote: On 1/2/2018 11:42 AM, Justin Pettit wrote: On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote: SFAICT it emulates exactly what the system-traffic.at test 001 does.  And it works fine... /shrug. What distribution, kernel, etc are

Re: [ovs-dev] master now "frozen" for forking

> Hello everyone. We are at the point in the release cycle where > traditionally we would fork a branch from master for release. We have > tried a slightly different approach a few times and I'd like to propose > that we do it again. Instead of forking immediately, I propose that we > "freeze"

Re: [ovs-dev] [PATCH] ofp-print: Include full hex dump of messages that fail decode.

Hi Guru, can u please help us to pick up Ben's change to nsx-dgo brach? Suneel will rerun the test after that. Thx a lot, Su From: Ben Pfaff Sent: Thursday, January 4, 2018 10:40:01 PM To: d...@openvswitch.org Cc: Ben Pfaff; Su Wang Subject:

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

OK. Acked-by: Ben Pfaff On Fri, Jan 05, 2018 at 03:59:02PM +0200, aserd...@ovn.org wrote: > Sure. Do you mind if I add your acked-by on each one? > > Thanks, > Alin. > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Thursday, January 4, 2018

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

Hi Yipeng, Thank you very much for your comments. Please find my answers inline. Regards, Jan > -Original Message- > From: Wang, Yipeng1 [mailto:yipeng1.w...@intel.com] > Sent: Wednesday, 20 December, 2017 00:09 > To: Jan Scheurich ; d...@openvswitch.org >

Re: [ovs-dev] [PATCH v2 3/3] xlate: call tnl_neigh_snoop() from terminate_native_tunnel()

Hi Ben, Let me try to explain the motivation of this patch. It actually fixes a severe design flaw in the native tunnel handling of OVS in the context of SDN-controlled cloud systems, which we found and had to fix downstream in our NFVI solution. To implement tunnels (e.g. VXLAN, GRE) in the

Re: [ovs-dev] [PATCH 0/3] Fixes while compiling with 1709 and VS2017

Sure. Do you mind if I add your acked-by on each one? Thanks, Alin. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:37 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH 0/3] Fixes

Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg location

Thanks for the review. Applied on master. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, January 4, 2018 11:36 PM > To: Alin Gabriel Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] MSI: Use platform specific netcfg

Re: [ovs-dev] [PATCH] xlate: fix xport lookup for recirc

Hi Zoltan, As far as I can see the frozen state already contains the ofproto UUID and in frozen_metadata the OF port ID. Together these should be sufficient to look up the xport in xlate_lookup_ofproto_(): First look up the xbridge through xbridge_lookup_by_uuid() and afterwards scan the

Re: [ovs-dev] [PATCH v3 0/6] Add minimum network namespace support.

Hi, I know this change is not easy to review, but at the same time we are getting close to the release date. I am afraid that delaying the acceptance will reduce its exposure and testing. Please let me know the questions you might have to help you reviewing this patchset. Thanks, fbl On

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-sflow: propagate actions within clone

> On Thu, Dec 14, 2017 at 09:56:19AM +0100, Zoltan Balogh wrote: > > By avoiding Tx recirculation and embracing tnl_push action within clone, > > the tunnel metadata is not propagated. Unless clone action is handled in > > the dpif_sflow_read_actions() function as well. This commit resolves > >

Re: [ovs-dev] [PATCH] xlate: fix xport lookup for recirc

> On Thu, Dec 21, 2017 at 02:22:43PM +, Zoltán Balogh wrote: > > Xlate_lookup and xlate_lookup_ofproto_() provides in_port and ofproto > > based on xport determined using flow, which is extracted from packet. > > The lookup can happen due to recirculation as well. It can happen, that > >

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Hi Jan and Ben, Please find the inline responses. -Ben Pfaff wrote: - To: Jan Scheurich From: Ben Pfaff Date: 01/05/2018 02:35AM Cc: SatyaValli , "d...@openvswitch.org" , Manasa

Re: [ovs-dev] [PATCH V2] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

Thanks Ben for reviewing the patch. I have sent V3 patch after rebasing with master. Warm Regards, Vishal Ajmera -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Friday, January 05, 2018 2:29 AM To: Vishal Deep Ajmera Cc:

Re: [ovs-dev] [PATCH v2] ofproto: Delete all groups and meters when (un)configuring a controller.

Just one small observation below. Otherwise LGTM. I have tested the patch and it worked for all cases. I couldn't test the case that the switch loses connection to a controller in stand-alone fail mode. Acked-by: Jan Scheurich Tested-by: Jan Scheurich

[ovs-dev] [PATCH] ovn-northd: Avoid duplicate logical flows in SB db

When there are two ACLs in a Logical Switch with same direction, priority, match and action fields, ovn-northd will generate the exact same logical flow for them into SB database. This will make ovn-controller log messages (INFO) saying that the duplicate flow is going to be dropped. This patch

[ovs-dev] [PATCH V3] ofproto-dpif-xlate: Incorrect handling of errors in group action processing

As per OpenFlow v1.3 specification, when an action list contains a group action a copy of the packet is passed to the group for processing by the group. This means that if there is an error encountered during group processing, only the copy of packet should be dropped, but subsequent actions in

[ovs-dev] is there any performance consideration for max emc cache numbers and megaflow cache numbers?

Hi: in ovs code, MAX_FLOWS = 65536 // for megaflow #define EM_FLOW_HASH_SHIFT 13 #define EM_FLOW_HASH_ENTRIES (1u << EM_FLOW_HASH_SHIFT) // for emc cache so why choose 65536 and 8192? is there any performance consideration? can I just larger these numbers to make packet only lookup emc cache