Re: [ovs-dev] [PATCH v2] openvswitch: Trim off padding before L3+ netfilter processing

2018-01-06 Thread Pravin Shelar
On Fri, Jan 5, 2018 at 10:59 PM, Ed Swierk wrote: > > > On Jan 5, 2018 22:17, "Pravin Shelar" wrote: > > On Fri, Jan 5, 2018 at 3:20 PM, Ed Swierk > wrote: >> On Fri, Jan 5, 2018 at 10:14 AM, Ed Swierk >> wrote: >>> On Thu, Jan 4, 2018 at 7:36 PM, Pravin Shelar wrote: OVS already pull all

[ovs-dev] [PATCH] ofp-errors: Send as much of a message as possible in an error reply.

2018-01-06 Thread Ben Pfaff
When an OpenFlow switch sends an error message in reply to a request from a controller, it includes an excerpt from the original request. The OpenFlow specification only requires the switch to send at least the first 64 bytes of the request. Until now, Open vSwitch has only sent that much. This c

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-06 Thread Ben Pfaff
On Sat, Jan 06, 2018 at 01:56:20PM +0800, Yang, Yi wrote: > On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > Signed-off-by: Yi Yang > > > > This fails to build with Clang (and, I would guess, MSVC): > > ../lib/odp-ex

Re: [ovs-dev] [PATCH v6 1/4] nsh: rework NSH netlink keys and actions

2018-01-06 Thread Ben Pfaff
On Sat, Jan 06, 2018 at 02:03:09PM +0800, Yang, Yi wrote: > On Fri, Jan 05, 2018 at 04:42:00AM +0800, Ben Pfaff wrote: > > On Fri, Dec 08, 2017 at 10:04:22PM +0800, Yi Yang wrote: > > > > > > Signed-off-by: Yi Yang > > > > > > In odp_execute_actions(), this looks bogus: there is nothing to > >

[ovs-dev] [PATCH V2] netdev-dpdk: fix ingress_policer leak on error path

2018-01-06 Thread zhangliping
From: zhangliping We forgot to free the policer if rte_meter_srtcm_config failed, so memory leak would happen. Fixes: 9509913aa722 ("netdev-dpdk.c: Add ingress-policing functionality.") Signed-off-by: zhangliping --- V2: Improve the commit log, and add the Fixes tag, suggested by Ian Stok

Re: [ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error path

2018-01-06 Thread zhangliping
Hi Ian, At 2018-01-06 02:29:50, "Stokes, Ian" wrote: >> Subject: [ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error >> path >Patch looks ok to me, validated on my setup. 2 minor knits. > >I'd like to see an expanded commit message rather than just the subject header >above. > >> >