[ovs-dev] FYI: NSH is an ITEF standard RFC 8300 now

2018-01-17 Thread Yang, Yi Y
NSH RFC: https://tools.ietf.org/html/rfc8300 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

2018-01-17 Thread Ilya Maximets
On 18.01.2018 02:21, Jan Scheurich wrote: > Thanks for the review. Answers inline. > Regards, Jan > > >> From: Ilya Maximets [mailto:i.maxim...@samsung.com] >> Sent: Wednesday, 17 January, 2018 11:47 >> Subject: Re: [PATCH v7 1/3] netdev: Add rxq callback function rxq_length() >> >> On

Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

2018-01-17 Thread Yuanhan Liu
I was told more tests and reviews are needed from yesterday's meeting. For testing, as you can see below, Finn already have done some performance testing covering quite few testcases. I have also done some very basic performance testing, basically just with rxonly. Besides that, I have actually

Re: [ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Gregory Rose
On 1/17/2018 4:15 PM, Flavio Leitner wrote: On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote: On minimal install RHEL 7 servers (and perhaps other types of installs) you need to enable a couple of optional repositories for the yum-builddep utility to work correctly. This patch

Re: [ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 10:15:31PM -0200, Flavio Leitner wrote: > On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote: > > On minimal install RHEL 7 servers (and perhaps other types of installs) > > you need to enable a couple of optional repositories for the yum-builddep > > utility to work

Re: [ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 01:24:21PM -0800, Greg Rose wrote: > On minimal install RHEL 7 servers (and perhaps other types of installs) > you need to enable a couple of optional repositories for the yum-builddep > utility to work correctly. This patch documents those two optional > repositories. >

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 10:10:17AM -0800, Ben Pfaff wrote: > On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote: > > > You mean add more details to NEWS file explaining that change? > > > > I am not much familiar with documentation part of ovs. It will help if > > others can

[ovs-dev] [PATCH v4] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
Today OVS pushes packets to the TAP interface ignoring its current state. That works because the kernel will return -EIO when it's not UP and OVS will just ignore that as it is not an OVS issue. However, it causes a huge impact when broadcasts happen when using userspace datapath accelerated with

Re: [ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

2018-01-17 Thread Jan Scheurich
Thanks for the review. Answers inline. Regards, Jan > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Wednesday, 17 January, 2018 11:47 > Subject: Re: [PATCH v7 1/3] netdev: Add rxq callback function rxq_length() > > On 16.01.2018 04:51, Jan Scheurich wrote: > > If implememented,

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 09:42:34AM -0800, Guru Shetty wrote: > On 17 January 2018 at 07:57, Flavio Leitner wrote: > > > > > Hi, > > > > One of the reasons is to clean up a bit because today it is not > > obvious that openvswitch.spec uses initscripts and shouldn't be > > used

Re: [ovs-dev] [PATCH] rhel: Ensure proper OVS kernel modules load - rhel6

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 08:01:38AM -0800, Greg Rose wrote: > Patch c49889cf3e "rhel: Ensure proper OVS kernel modules load after upgrade" > did not address the RHEL 6 kmod rpm spec file. This patch addresses > that error. > > Fixes: c49889cf3e ("rhel: Ensure proper OVS kernel modules...") > CC:

Re: [ovs-dev] [PATCH v2] odp-util: fix a compiler warning

2018-01-17 Thread Justin Pettit
Thanks for the fix. I'd like to add the compiler to the description, since I didn't see it on gcc 5.4.0. --Justin > On Jan 16, 2018, at 6:05 AM, Aaron Conole wrote: > > The result of a ternary operation will be promoted at least to int > type. As such, the compiler may

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.9.0 (2.9.90).

2018-01-17 Thread Justin Pettit
> On Jan 17, 2018, at 10:05 AM, Ben Pfaff wrote: > > On Wed, Jan 17, 2018 at 09:54:40AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin

Re: [ovs-dev] [PATCH 1/2] Prepare for 2.9.0.

2018-01-17 Thread Justin Pettit
> On Jan 17, 2018, at 10:04 AM, Ben Pfaff wrote: > > On Wed, Jan 17, 2018 at 09:54:39AM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff I created branch-2.9, and pushed this to master and there. --Justin

[ovs-dev] [PATCH] Documentation: Document optional RHEL7 repositories

2018-01-17 Thread Greg Rose
On minimal install RHEL 7 servers (and perhaps other types of installs) you need to enable a couple of optional repositories for the yum-builddep utility to work correctly. This patch documents those two optional repositories. Signed-off-by: Greg Rose ---

[ovs-dev] Normas de Información Financiera 2018

2018-01-17 Thread Nuevas normas 2018 y su impacto en su empresa
Datos aplicados de forma clara, detallada y estratégica Nuevas Normas de Información Financiera 2018 26 de enero- CPC. José Frank González Sánchez - 9am-8pm Las NIF (Normas de Información Financiera, antes Principios de Contabilidad), emitidas por el Consejo Mexicano de Normas de Información

Re: [ovs-dev] [PATCH 0/3] Check gso_size of packets when forwarding

2018-01-17 Thread David Miller
From: Daniel Axtens Date: Tue, 16 Jan 2018 13:09:17 +1100 > When regular packets are forwarded, we validate their size against the > MTU of the destination device. However, when GSO packets are > forwarded, we do not validate their size against the MTU. We > implicitly assume

[ovs-dev] mbuf pool sizing

2018-01-17 Thread Venkatesan Pradeep
Hi, Assuming that all ports use the same MTU, in OVS2.8 and earlier, a single mempool of 256K buffers (MAX_NB_MBUF = 4096 * 64) will be created and shared by all the ports With the OVS2.9 mempool patches, we have port specific allocation and the number of mbufs created for each port is based

[ovs-dev] OVS DPDK: dpdk_merge pull request

2018-01-17 Thread Stokes, Ian
Hi Ben, The following changes since commit 1fb924b8091b7ee33020b28c2826e096a7d42ef0: Documentation: Update Faucet tutorial. (2018-01-17 10:18:27 -0800) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to

Re: [ovs-dev] [PATCH v2] odp-util: fix a compiler warning

2018-01-17 Thread Stokes, Ian
> The result of a ternary operation will be promoted at least to int type. > As such, the compiler may generate a warning as: > format specifies type 'unsigned char' but the argument has type 'int' > > Squelch this by preferring the %d format specifier to print 1/0 values. > > Fixes:

Re: [ovs-dev] [PATCH] Documentation: Update Faucet tutorial.

2018-01-17 Thread Ben Pfaff
On Mon, Jan 15, 2018 at 01:38:48PM +1300, Brad Cowie wrote: > Drop use of minimum_ip_size_check in Faucet tutorial which is no longer > needed after we fixed a bug that was causing packet length checks to be > calculated wrong. Thanks! Applied to master.

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Ben Pfaff
On Wed, Jan 17, 2018 at 04:51:20PM +, Vishal Deep Ajmera wrote: > > You mean add more details to NEWS file explaining that change? > > I am not much familiar with documentation part of ovs. It will help if > others can comment on where this change should be documented. vswitchd/vswitch.xml

Re: [ovs-dev] [PATCH] rhel: Ensure proper OVS kernel modules load - rhel6

2018-01-17 Thread Ansis Atteka
On 17 January 2018 at 08:01, Greg Rose wrote: > Patch c49889cf3e "rhel: Ensure proper OVS kernel modules load after upgrade" > did not address the RHEL 6 kmod rpm spec file. This patch addresses > that error. > > Fixes: c49889cf3e ("rhel: Ensure proper OVS kernel

Re: [ovs-dev] branch today?

2018-01-17 Thread Ben Pfaff
On Wed, Jan 17, 2018 at 09:55:40AM -0800, Justin Pettit wrote: > > > On Jan 17, 2018, at 7:47 AM, Ben Pfaff wrote: > > > > Justin, do you want to set up the branch for 2.9 today? > > Yes. I sent out the patches just now. Thanks, acked.

Re: [ovs-dev] [PATCH 2/2] Prepare for post-2.9.0 (2.9.90).

2018-01-17 Thread Ben Pfaff
On Wed, Jan 17, 2018 at 09:54:40AM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] Prepare for 2.9.0.

2018-01-17 Thread Ben Pfaff
On Wed, Jan 17, 2018 at 09:54:39AM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v3 1/2] dpif-netlink-rtnl: Use 65000 instead of 65535 as tunnel MTU.

2018-01-17 Thread Ben Pfaff
Most of the existing tunnels accept 65535 for MTU and internally reduce it to the maximum value actually supported. However, in RTM_SETLINK calls, at least GRE tunnels reject MTU larger than actually supported. This commit changes the MTU used in RTM_NEWLINK calls to use a value that should be

[ovs-dev] [PATCH v2 2/2] dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver.

2018-01-17 Thread Ben Pfaff
The kernel GRE driver ignores IFLA_MTU in RTM_NEWLINK requests and overrides the MTU to 1472 bytes. This commit works around the problem by following up a request to create a GRE device with a second request to set the MTU. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1488484

[ovs-dev] [PATCH v2 1/2] dpif-netlink-rtnl: Use 65000 instead of 65535 as tunnel MTU.

2018-01-17 Thread Ben Pfaff
Most of the existing tunnels accept 65535 for MTU and internally reduce it to the maximum value actually supported. However, in RTM_SETLINK calls, at least GRE tunnels reject MTU larger than actually supported. This commit changes the MTU used in RTM_NEWLINK calls to use a value that should be

[ovs-dev] [PATCH v2 0/2] Fix GRE tunnel MTU issues.

2018-01-17 Thread Ben Pfaff
v1->v2: - Patch 1 is new. - Patch 2 is revised to use MTU 65000 instead of 65535. Ben Pfaff (2): dpif-netlink-rtnl: Use 65000 instead of 65535 as tunnel MTU. dpif-netlink-rtnl: Work around MTU bug in kernel GRE driver. lib/dpif-netlink-rtnl.c | 24 +++- 1 file

Re: [ovs-dev] branch today?

2018-01-17 Thread Justin Pettit
> On Jan 17, 2018, at 7:47 AM, Ben Pfaff wrote: > > Justin, do you want to set up the branch for 2.9 today? Yes. I sent out the patches just now. Thanks, --Justin ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH 1/2] Prepare for 2.9.0.

2018-01-17 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/NEWS b/NEWS index cb020d00d00c..a736b3159751 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -Post-v2.8.0

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Guru Shetty
On 17 January 2018 at 07:57, Flavio Leitner wrote: > > Hi, > > One of the reasons is to clean up a bit because today it is not > obvious that openvswitch.spec uses initscripts and shouldn't be > used for Fedora or RHEL-7. > > Then we have openvswitch-fedora.spec which is not

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Vishal Deep Ajmera
> You mean add more details to NEWS file explaining that change? I am not much familiar with documentation part of ovs. It will help if others can comment on where this change should be documented. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v4 1/2] dpif-netdev: Add percentage of pmd/core used by each rxq.

2018-01-17 Thread Stokes, Ian
> It is based on the length of history that is stored about an rxq > (currently 1 min). > > $ ovs-appctl dpif-netdev/pmd-rxq-show > pmd thread numa_id 0 core_id 4: > isolated : false > port: dpdkphy1 queue-id: 0pmd usage: 70 % > port: dpdkvhost0

[ovs-dev] [PATCH] rhel: Ensure proper OVS kernel modules load - rhel6

2018-01-17 Thread Greg Rose
Patch c49889cf3e "rhel: Ensure proper OVS kernel modules load after upgrade" did not address the RHEL 6 kmod rpm spec file. This patch addresses that error. Fixes: c49889cf3e ("rhel: Ensure proper OVS kernel modules...") CC: Ansis Atteka CC: Flavio Leitner

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Flavio Leitner
Hi, One of the reasons is to clean up a bit because today it is not obvious that openvswitch.spec uses initscripts and shouldn't be used for Fedora or RHEL-7. Then we have openvswitch-fedora.spec which is not obvious if it works or not in RHEL-7 too. We could document that somehow, but it

[ovs-dev] branch today?

2018-01-17 Thread Ben Pfaff
Justin, do you want to set up the branch for 2.9 today? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

2018-01-17 Thread Stokes, Ian
> On Wed, Jan 17, 2018 at 11:44:08AM +, Stokes, Ian wrote: > > > -Original Message- > > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > > boun...@openvswitch.org] On Behalf Of Flavio Leitner > > > Sent: Tuesday, January 16, 2018 4:22 AM > > > To: d...@openvswitch.org > > >

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 12:43:08PM +, Vishal Deep Ajmera wrote: > Hi Flavio, Hi Vishal, > I was testing your patch and comparing the stats of tap port for both > ovs-master > and your patch. The drop stats are now matching with master. Thanks for doing that work, I appreciate it! >

Re: [ovs-dev] [PATCH] Drop support for RHEL 5 and 6

2018-01-17 Thread Russell Bryant
OK - fine with me. So an alternative patch would be to document that this spec is now just an alternative for RHEL7 vs one for 5 / 6? On Tue, Jan 16, 2018 at 11:56 PM, Guru Shetty wrote: > We use RHEL6 spec to build rpms for RHEL7 as we still use sysV scripts. We > will need quite

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

2018-01-17 Thread Flavio Leitner
On Wed, Jan 17, 2018 at 11:44:08AM +, Stokes, Ian wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Flavio Leitner > > Sent: Tuesday, January 16, 2018 4:22 AM > > To: d...@openvswitch.org > > Subject:

Re: [ovs-dev] [PATCH v3] netdev-linux: do not send packets to down tap ifaces.

2018-01-17 Thread Vishal Deep Ajmera
Hi Flavio, I was testing your patch and comparing the stats of tap port for both ovs-master and your patch. The drop stats are now matching with master. However I still see one more difference, in earlier case the "tx_packets" were also incremented along with "tx_dropped" when the tap port is

Re: [ovs-dev] [PATCH v7 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-01-17 Thread Ilya Maximets
Not a full review. Comments inline. On 16.01.2018 04:51, Jan Scheurich wrote: > This patch instruments the dpif-netdev datapath to record detailed > statistics of what is happening in every iteration of a PMD thread. > > The collection of detailed statistics can be controlled by a new >

Re: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status.

2018-01-17 Thread Stokes, Ian
> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Flavio Leitner > Sent: Tuesday, January 16, 2018 4:22 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v2] netdev-dpdk: add vhost-user get_status. > > Expose

Re: [ovs-dev] [PATCH v7 1/3] netdev: Add rxq callback function rxq_length()

2018-01-17 Thread Ilya Maximets
On 16.01.2018 04:51, Jan Scheurich wrote: > If implememented, this function returns the number of packets in an rx > queue of the netdev. If not implemented, it returns -1. To be conform with other netdev functions it should return meaningful error codes. As 'rte_eth_rx_queue_count' could return

Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

2018-01-17 Thread Yuanhan Liu
On Mon, Jan 15, 2018 at 05:28:18PM +, Stokes, Ian wrote: > > Hi, > > > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > > offload with the DPDK generic flow interface (rte_flow). > > > > The basic idea is to associate the flow with a mark id (a unit32_t > > number).