Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

2018-01-24 Thread Manohar Krishnappa Chidambaraswamy
Ben, On 23/01/18, 2:01 AM, "Ben Pfaff" wrote: I guess I'm probably the wrong one to ultimately review this patch, since it's really a DPDK patch. It's difficult to say for sure that this is really an improvement, since it also causes traffic to be dropped (that is, the traff

[ovs-dev] [PATCH v2 4/4] net: check the size of a packet in validate_xmit_skb

2018-01-24 Thread Daniel Axtens
There are a number of paths where an oversize skb could be sent to a driver. The driver should not be required to check for this - the core layer should do it instead. Add a check to validate_xmit_skb that checks both GSO and non-GSO packets and drops them if they are too large. Signed-off-by: Da

[ovs-dev] [PATCH v2 3/4] net: is_skb_forwardable: check the size of GSO segments

2018-01-24 Thread Daniel Axtens
is_skb_forwardable attempts to detect if a packet is too large to be sent to the destination device. However, this test does not consider GSO skbs, and it is possible that a GSO skb, when segmented, will be larger than the device can transmit. Create skb_gso_validate_mac_len, and use that to check

[ovs-dev] [PATCH v2 2/4] net: move skb_gso_mac_seglen to skbuff.h

2018-01-24 Thread Daniel Axtens
We're about to use this elsewhere, so move it into the header with the other related functions like skb_gso_network_seglen(). Signed-off-by: Daniel Axtens --- include/linux/skbuff.h | 15 +++ net/sched/sch_tbf.c| 10 -- 2 files changed, 15 insertions(+), 10 deletions(-)

[ovs-dev] [PATCH v2 1/4] net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len

2018-01-24 Thread Daniel Axtens
If you take a GSO skb, and split it into packets, will the network length (L3 headers + L4 headers + payload) of those packets be small enough to fit within a given MTU? skb_gso_validate_mtu gives you the answer to that question. However, we're about to add a way to validate the MAC length of a sp

[ovs-dev] [PATCH v2 0/4] Check size of packets before sending

2018-01-24 Thread Daniel Axtens
There are a few ways we can send packets that are too large to a network driver. When non-GSO packets are forwarded, we validate their size, based on the MTU of the destination device. However, when GSO packets are forwarded, we do not validate their size. We implicitly assume that when they are s

[ovs-dev] [PATCH] rhel: Change depmod configuration

2018-01-24 Thread Greg Rose
A previous patch added post install and post uninstall scripts which use the weak-modules utility to make sure that openvswitch kernel modules are copied to the correct kernel directory. While this patch did fix some issues there are two remaining issues we have found. 1) In the case where the OS

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

2018-01-24 Thread JunhanYan
On 01/24/2018 11:46 AM, Ben Pfaff wrote: On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: On Wed, Oct 25, 2017 at 11:41:27AM +0800, ju...@redhat.com wrote: When there is only one bridge,create tunnel in the bridge, then delete the bridge directly. the system tunnel interface still

Re: [ovs-dev] [PATCH 07/15] ovsdb-idl: Break out database-specific stuff into new data structure.

2018-01-24 Thread Justin Pettit
> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > +struct ovsdb_idl { > +struct ovsdb_idl_db server; > +struct ovsdb_idl_db db; /* XXX rename 'data'? */ Did you want to change this? > @@ -353,51 +379,54 @@ ovsdb_idl_set_remote(struct ovsdb_idl *idl, const char > *remote, >

[ovs-dev] [PATCH v2] Fix incorrect handling of return value.

2018-01-24 Thread huanglili
From: Lili Huang The value cookie_offset should be 'size_t' type. Signed-off-by: Lili Huang --- ofproto/ofproto-dpif-xlate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 40c04cc..e7e8321 100644 --- a/ofp

[ovs-dev] Infracciones y sanciones

2018-01-24 Thread Outsourcing y sus consecuencias fiscales.
OUTSOURCING Y SUS CONSECUENCIAS FISCALES Febrero 07 - webinar Interactivo Este webinar está diseñado para las empresas que prestan servicios de outsourcing de personal o las interesadas en contratar personal bajo la figura del outsourcing. TEMARIO: El Outsourcing en términos de la Ley Federa

Re: [ovs-dev] [PATCH v2 4/5] ofproto-dpif-upcall: Slow path flows that datapath can't fully match.

2018-01-24 Thread Ben Pfaff
I'm just shocked that we didn't notice for 5 years. On Wed, Jan 24, 2018 at 02:24:50PM -0800, Ethan J. Jackson wrote: > Nice! I, for one, never understood the TOO_LITTLE stuff ... glad to see it > clarified and fixed. > > Ethan > > On Wed, Jan 24, 2018 at 11:40 AM, Ben Pfaff wrote: > > > In t

[ovs-dev] Información valiosa para evitar pérdidas

2018-01-24 Thread pólizas que las aseguradoras evitan pagar
Sepa cómo hacer cumplir sus derechos como asegurado Lo que todo el mundo debe saber sobre las pólizas que las aseguradoras evitan pagar. 26 de enero- Mtra. Yanira Domínguez - 9am-3pm Las aseguradoras pueden rechazar el pago de una reclamación por muchas causas. En algunas ocasiones el siniestr

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

2018-01-24 Thread Justin Pettit
> On Jan 24, 2018, at 9:14 AM, Ben Pfaff wrote: > > On Wed, Jan 24, 2018 at 01:55:18PM +, Stokes, Ian wrote: >>> -Original Message- >>> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >>> boun...@openvswitch.org] On Behalf Of Justin Pettit >>> Sent: Wednesday, January 24, 2018

Re: [ovs-dev] [PATCH v2 4/5] ofproto-dpif-upcall: Slow path flows that datapath can't fully match.

2018-01-24 Thread Ethan J. Jackson
Nice! I, for one, never understood the TOO_LITTLE stuff ... glad to see it clarified and fixed. Ethan On Wed, Jan 24, 2018 at 11:40 AM, Ben Pfaff wrote: > In the OVS architecture, when a datapath doesn't have a match for a packet, > it sends the packet and the flow that it extracted from it to

Re: [ovs-dev] [RFC 0/2] 'Graceful restart' of OvS

2018-01-24 Thread Aaron Conole
Ben Pfaff writes: > What I'd really like to start from is a high-level description of how an > upgrade would take place. This patch set covers one low-level part of > that upgrade, but (as you recognize in your description) there is a > bigger set of issues. There have to be handoffs at multipl

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix typo in comment.

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 01:48:11PM -0800, Justin Pettit wrote: > > > On Jan 24, 2018, at 9:47 AM, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > --- > > ofproto/ofproto-dpif-upcall.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ofproto/ofproto-dpif-upcal

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix typo in comment.

2018-01-24 Thread Justin Pettit
> On Jan 24, 2018, at 9:47 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-upcall.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c > index 5ddf08a75ec0..035233d5adc8 100644 > -

Re: [ovs-dev] Please revert 822afef74f (compat: inet_frag.h: Check for frag_percpu_counter_batch)

2018-01-24 Thread Gregory Rose
On 1/24/2018 12:20 PM, Ben Pfaff wrote: On Wed, Jan 24, 2018 at 10:51:54AM -0800, Gregory Rose wrote: Looks like it fails on 3.16.47 on Travis builds. My apologies but it looks like it needs another approach. OK, I reverted this from master and branch-2.9. Thanks Ben. ___

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 09:31:32AM -0500, Eric Garver wrote: > On Tue, Jan 23, 2018 at 07:46:47PM -0800, Ben Pfaff wrote: > > On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: > > > On Wed, Oct 25, 2017 at 11:41:27AM +0800, ju...@redhat.com wrote: > > > > When there is only one bridge,cr

Re: [ovs-dev] [PATCH v6 7/8] Documentation: Update DPDK doc with Keepalive feature.

2018-01-24 Thread Aaron Conole
Hi Bhanu, This time around I just reviewed the documentation. I'll spend some time on the other patches as I can, but I think at least the documentation needs more work. Comments inline. Bhanuprakash Bodireddy writes: > Keepalive feature is aimed at achieving Fastpath Service Assurance > in

Re: [ovs-dev] [PATCH v6 0/2] OVN Support QoS meter

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 08:39:07PM +0800, Guoshuai Li wrote: > v3-v4: > 1. Fix checkpatch error. > 2. The local rate variable uses uint64_t. > This can support a very large rate. > 3. Fix formatting mismatch issues. > 4. Repair meter can not be the last table problem. > 5. Add a note

Re: [ovs-dev] Please revert 822afef74f (compat: inet_frag.h: Check for frag_percpu_counter_batch)

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 10:51:54AM -0800, Gregory Rose wrote: > Looks like it fails on 3.16.47 on Travis builds. > > My apologies but it looks like it needs another approach. OK, I reverted this from master and branch-2.9. ___ dev mailing list d...@open

[ovs-dev] [PATCH v2 5/5] odp-util: Always report ODP_FIT_TOO_LITTLE for IGMP.

2018-01-24 Thread Ben Pfaff
OVS datapaths don't understand or parse IGMP fields, but OVS userspace does, so this commit updates odp_flow_key_to_flow() to report that properly to the caller. Reported-by: Huanle Han Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343665.html Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH v2 4/5] ofproto-dpif-upcall: Slow path flows that datapath can't fully match.

2018-01-24 Thread Ben Pfaff
In the OVS architecture, when a datapath doesn't have a match for a packet, it sends the packet and the flow that it extracted from it to userspace. Userspace then examines the packet and the flow and compares them. Commonly, the flow is the same as what userspace expects, given the packet, but the

[ovs-dev] [PATCH v2 3/5] Remove last mentions of 'facet' from comments.

2018-01-24 Thread Ben Pfaff
How did these survive so long?! OVS hasn't had facets since 2013. Signed-off-by: Ben Pfaff --- lib/odp-util.h| 2 +- ofproto/ofproto-dpif-mirror.c | 11 +-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/odp-util.h b/lib/odp-util.h index 55c922c9fdd1

[ovs-dev] [PATCH v2 2/5] ofproto-dpif-upcall: Fix typo in comment.

2018-01-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 5ddf08a75ec0..035233d5adc8 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcal

[ovs-dev] [PATCH v2 1/5] xlate: fix packets loopback caused by duplicate read of xcfgp.

2018-01-24 Thread Ben Pfaff
From: Huanle Han Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle pointers equality to avoid sending packet back to in bundle. However, xbundle pointers port from different xcfgp for same port are inequal. This may lead to the packet loopback. This commit stores xcfgp on ct

[ovs-dev] [PATCH v2 0/5] Fix flow translation bugs.

2018-01-24 Thread Ben Pfaff
This series is based on Huanle Han's series available at https://patchwork.ozlabs.org/project/openvswitch/list/?series=25163&archive=both&state=* I have revised it in the following ways: - Dropped patch 3, not because it's bad but because I don't understand it yet and believe that it can

Re: [ovs-dev] [PATCH 3/3] mirror: do not mirror packet on recirculation

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 09:41:12AM -0800, Ben Pfaff wrote: > From: Huanle Han > > Signed-off-by: Huanle Han > --- > ofproto/ofproto-dpif-xlate.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c > index 9d6ca94afc82..23938c

Re: [ovs-dev] [PATCH 1/3] igmp: do not mask igmp type

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 09:41:10AM -0800, Ben Pfaff wrote: > From: Huanle Han > > Currently, ovs datapath doesn't support to mask igmp type. Masking igmp > type made flow_wildcards_has_extra() always true when revalidate. And > igmp flow is never kept in datapath. > > Signed-off-by: Huanle Han

[ovs-dev] [patch v1 9/9] tests: Enable v4 fragmentation tests for userspace datapath.

2018-01-24 Thread Darrell Ball
Enable v4 fragmentation tests for the userspace datapath. Signed-off-by: Darrell Ball --- tests/system-kmod-macros.at | 14 +++--- tests/system-traffic.at | 27 +-- tests/system-userspace-macros.at | 36 3 files c

[ovs-dev] [patch v1 8/9] tests: Add missed local stack check.

2018-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-traffic.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index dbd5640..aee7391 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2093,6 +2093,7 @@ AT_SETUP([conntrack - Fragm

[ovs-dev] [patch v1 7/9] ipf: Add command to get fragmentation handling status.

2018-01-24 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status as well as fragment counters. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 15 +++ lib/ct-

[ovs-dev] [patch v1 6/9] ipf: Add command to set maximum fragments supported.

2018-01-24 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-set-maxfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31 +++

[ovs-dev] [patch v1 5/9] ipf: Add command to set minimum fragment size supported.

2018-01-24 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-set-minfragment" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31 +

[ovs-dev] [patch v1 4/9] ipf: Add command to enable fragmentation handling.

2018-01-24 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-set-enabled" is added to enable/disable userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 31 +++

[ovs-dev] [patch v1 2/9] Userspace datapath: Add v4 fragmentation handling.

2018-01-24 Thread Darrell Ball
Fragmentation handling is added for supporting conntrack. Presently, only v4 is supported, with v6 coming soon. Signed-off-by: Darrell Ball --- lib/automake.mk | 2 + lib/ipf.c | 858 lib/ipf.h | 53 3 files changed, 91

[ovs-dev] [patch v1 3/9] conntrack: Support v4 fragmentation.

2018-01-24 Thread Darrell Ball
The conntrack module now calls fragmentation support apis. Signed-off-by: Darrell Ball --- NEWS| 3 ++- lib/conntrack.c | 6 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index d7c83c2..d5af504 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,7 @@ Post-v2.9

[ovs-dev] [patch v1 1/9] dp-packet: Add const qualifiers for checksum apis.

2018-01-24 Thread Darrell Ball
Signed-off-by: Darrell Ball --- lib/dp-packet.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index b4b721c..61d4cd4 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -637,7 +637,7 @@ dp_packet_mbuf_init(struct dp_packet *p OVS_UNUSE

[ovs-dev] [patch v1 0/9] Userspace datapath: Add fragmentation support.

2018-01-24 Thread Darrell Ball
Fragmentation support for userspace datapath conntrack is added; see patches for additional details. Patch 5 has line length checkpatch warning in NEWS which will be fixed later :-). Darrell Ball (9): dp-packet: Add const qualifiers for checksum apis. Userspace datapath: Add v4 fragmentation

Re: [ovs-dev] [PATCH 4/4] ovs-ofctl: Add "compose-packet" command for testing flow_compose().

2018-01-24 Thread Yifeng Sun
Sorry, I found it. Somehow I missed that patch. On Wed, Jan 24, 2018 at 11:07 AM, Yifeng Sun wrote: > I can't find the patch that enables flow_compose to accept 4 parameters. > Can you please check that? thanks. > > Yifeng > > On Thu, Jan 18, 2018 at 2:45 PM, Ben Pfaff wrote: > >> I don't fee

Re: [ovs-dev] [PATCH 4/4] ovs-ofctl: Add "compose-packet" command for testing flow_compose().

2018-01-24 Thread Yifeng Sun
I can't find the patch that enables flow_compose to accept 4 parameters. Can you please check that? thanks. Yifeng On Thu, Jan 18, 2018 at 2:45 PM, Ben Pfaff wrote: > I don't feel obligated to add a bunch of automatic tests for > flow_compose(), but this is handy for manual testing or for simpl

[ovs-dev] Please revert 822afef74f (compat: inet_frag.h: Check for frag_percpu_counter_batch)

2018-01-24 Thread Gregory Rose
Looks like it fails on 3.16.47 on Travis builds. My apologies but it looks like it needs another approach. Thanks - Greg ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/4] flow: Simplify flow_compose_l4().

2018-01-24 Thread Yifeng Sun
Thanks for the refactor that makes code much cleaner. Reviewed-by: Yifeng Sun On Thu, Jan 18, 2018 at 2:45 PM, Ben Pfaff wrote: > Each of the cases in flow_compose_l4() separately tracked the number of > bytes of L4 data added to the packet. This commit makes the function do > that in a sing

Re: [ovs-dev] [PATCH 1/4] ofproto-dpif-trace: Generalize syntax for ofproto/trace.

2018-01-24 Thread Yifeng Sun
Thanks for the patch, looks good to me. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Thu, Jan 18, 2018 at 2:45 PM, Ben Pfaff wrote: > ofproto/trace takes a bunch of options that have weird placement and > syntax. This commit changes the syntax so that the options can be placed > anywher

[ovs-dev] Mrs.Cyndia Hermann

2018-01-24 Thread Cyndia Hermann
Dearest in Christ, Greetings in the name of our Lord Jesus Christ. I’m Mrs.Cyndia Hermann a widow of late Mr Edward Hermann, I’m 65 year sold. I am a Christian , suffering from prolonged cancer of the breast, from all medical indications my condition has really deteriorated and it’s pretty o

[ovs-dev] 答复: [PATCH 2/3] xlate: fix packets loopback caused by duplicate read of xcfgp.

2018-01-24 Thread Lilijun (Jerry)
I have tested your patch and can fix my problem described in the following patch. https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/343423.html Thanks. -邮件原件- 发件人: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-boun...@openvswitch.org] 代表 Ben Pfaff 发送时间: 2018年1月25日 1:41 收件人:

[ovs-dev] [PATCH] ofproto-dpif-upcall: Fix typo in comment.

2018-01-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-upcall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-upcall.c b/ofproto/ofproto-dpif-upcall.c index 5ddf08a75ec0..035233d5adc8 100644 --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcal

Re: [ovs-dev] [PATCH 2/3] xlate: fix packets loopback caused by duplicate read of xcfgp.

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 09:41:11AM -0800, Ben Pfaff wrote: > From: Huanle Han > > Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle > pointers equality to avoid sending packet back to in bundle. However, > xbundle pointers port from different xcfgp for same port are inequal.

[ovs-dev] [PATCH 3/3] mirror: do not mirror packet on recirculation

2018-01-24 Thread Ben Pfaff
From: Huanle Han Signed-off-by: Huanle Han --- ofproto/ofproto-dpif-xlate.c | 4 1 file changed, 4 insertions(+) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 9d6ca94afc82..23938c8c8cf3 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-x

[ovs-dev] [PATCH 1/3] igmp: do not mask igmp type

2018-01-24 Thread Ben Pfaff
From: Huanle Han Currently, ovs datapath doesn't support to mask igmp type. Masking igmp type made flow_wildcards_has_extra() always true when revalidate. And igmp flow is never kept in datapath. Signed-off-by: Huanle Han --- ofproto/ofproto-dpif-xlate.c | 1 - 1 file changed, 1 deletion(-) d

[ovs-dev] [PATCH 2/3] xlate: fix packets loopback caused by duplicate read of xcfgp.

2018-01-24 Thread Ben Pfaff
From: Huanle Han Some functions, such as xlate_normal_mcast_send_mrouters, test xbundle pointers equality to avoid sending packet back to in bundle. However, xbundle pointers port from different xcfgp for same port are inequal. This may lead to the packet loopback. This commit stores xcfgp on ct

Re: [ovs-dev] OVS-DPDK public meeting

2018-01-24 Thread Flavio Leitner
24th January 2018 Attendees: Flavio, Thomas, Jan, satananda, Michael, Ian, Zoltan, John, Aaron, Ben, Johann, Pradeep, Simon, Olga, Frikkie, === GENERAL === OVS 2.9 Release - New features deadline for 2.9: 31/Jan. - Pull requests on a weekly basis, on Friday. - Patches on DPDK_MERGE_2_9

Re: [ovs-dev] [PATCH v5 1/5] dpif-netdev: associate flow with a mark id

2018-01-24 Thread Stokes, Ian
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, December 20, 2017 2:45 PM > To: d...@openvswitch.org > Cc: Finn Christensen ; Darrell Ball ; > Chandran, Sugesh ; Simon Horman > ; Stokes, Ian ; Yuanhan > Liu > Subject: [PATCH v5 1/5] dpif-netdev: as

Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

2018-01-24 Thread Stokes, Ian
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Wednesday, December 20, 2017 2:45 PM > To: d...@openvswitch.org > Cc: Finn Christensen ; Darrell Ball ; > Chandran, Sugesh ; Simon Horman > ; Stokes, Ian ; Yuanhan > Liu > Subject: [PATCH v5 0/5] OVS-DPDK flow o

Re: [ovs-dev] [PATCH v1] ofproto-dpif-xlate: Fix incorrect handling of return value.

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 09:56:09AM +0800, huanglili wrote: > From: Lili Huang > > The value cookie_offset should be 'size_t' type. > > Signed-off-by: Lili Huang > --- > ofproto/ofproto-dpif-xlate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ofproto/ofproto-dpif-x

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 01:55:18PM +, Stokes, Ian wrote: > > -Original Message- > > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > > boun...@openvswitch.org] On Behalf Of Justin Pettit > > Sent: Wednesday, January 24, 2018 2:31 AM > > To: d...@openvswitch.org > > Subject: [ovs

Re: [ovs-dev] [PATCH v4] netdev-linux: do not send packets to down tap ifaces.

2018-01-24 Thread Ben Pfaff
On Wed, Jan 24, 2018 at 10:10:16AM -0200, Flavio Leitner wrote: > On Tue, Jan 23, 2018 at 12:31:53PM -0800, Ben Pfaff wrote: > > On Wed, Jan 17, 2018 at 10:09:58PM -0200, Flavio Leitner wrote: > > > Today OVS pushes packets to the TAP interface ignoring its > > > current state. That works because t

Re: [ovs-dev] [PATCH v6 0/8] Add OVS DPDK keep-alive functionality.

2018-01-24 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >>Hi, >> >>Sorry to jump on this at v6 only, but I skimmed over the code and I am >>struggling to understand what problem you're trying to solve. Yes, I realize >>you want some sort of feedback about the PMD processing, but it's not clear >>to me what exactly you

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-24 Thread Eelco Chaudron
On 24/01/18 15:50, Róbert Mulik wrote: Hi Eelco and Ian, Thank you for the comments. I uploaded patch v3 based on them. I'll try to look at this asap, but I'm on a trip the rest of this week, and next. There is only one comment I have problem with: "This function is not catching this sequence:

[ovs-dev] Incentivos económicos y su aplicación

2018-01-24 Thread Compensación e Incentivos para la Fuerza de Ventas
En línea y en Vivo / Para todo su Equipo con una sola Conexión Compensación e Incentivos para la Fuerza de Ventas 14 de febrero - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs Las compañías que prosperan en un entorno económico turbulento son, invariablemente, aquéllas que cuentan c

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-24 Thread Róbert Mulik
Hi Eelco and Ian, Thank you for the comments. I uploaded patch v3 based on them. There is only one comment I have problem with: "This function is not catching this sequence: ovs-vsctl set interface dpdk0 options:dpdk-lsc-interrupt=true ovs-vsctl remove interface dpdk0 options dpdk-lsc-interrupt"

[ovs-dev] [PATCH v3] netdev-dpdk: Configurable Link State Change (LSC) detection mode

2018-01-24 Thread Róbert Mulik
It is possible to change LSC detection mode to polling or interrupt mode for DPDK interfaces. The default is polling mode. To set interrupt mode, option dpdk-lsc-interrupt has to be set to true. In polling mode more processor time is needed, since the OVS repeatedly reads the link state with a sho

Re: [ovs-dev] [PATCH] ofproto-dpif: Delete system tunnel interface when remove ovs bridge

2018-01-24 Thread Eric Garver
On Tue, Jan 23, 2018 at 07:46:47PM -0800, Ben Pfaff wrote: > On Thu, Oct 26, 2017 at 10:24:46AM -0400, Eric Garver wrote: > > On Wed, Oct 25, 2017 at 11:41:27AM +0800, ju...@redhat.com wrote: > > > When there is only one bridge,create tunnel in the bridge, > > > then delete the bridge directly. the

Re: [ovs-dev] [PATCH v12] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

2018-01-24 Thread Ilya Maximets
On 24.01.2018 16:48, Ciara Loftus wrote: > Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' > option to 'true' when configuring the Interface: > > ovs-vsctl set Interface dpdkvhostuserclient0 > options:vhost-server-path=/tmp/dpdkvhostuserclient0 > options:dq-zero-copy=true >

Re: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments.

2018-01-24 Thread Stokes, Ian
> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Justin Pettit > Sent: Wednesday, January 24, 2018 2:31 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH] checkpatch.py: Add check for "xxx" in comments. > > "xxx"

[ovs-dev] [PATCH v12] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

2018-01-24 Thread Ciara Loftus
Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy enable

Re: [ovs-dev] [PATCH v5 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2018-01-24 Thread Guoshuai Li
On Wed, Dec 06, 2017 at 12:32:39PM +0800, Guoshuai Li wrote: The structure and function of the group table and meter table are similar, refactoring code is used to extend for add the meter table. The following function as lib: table init/destroy/clear, install contents from desired, remove cont

[ovs-dev] [PATCH v6 2/2] ovn: OVN Support QoS meter

2018-01-24 Thread Guoshuai Li
This feature is used to limit the bandwidth of flows, such as floating IP. ovn-northd changes: 1. add bandwidth column in NB's QOS table. 2. add QOS_METER stages in Logical switch ingress/egress. 3. add set_meter() action in SB's LFlow table. ovn-controller changes: add meter_table for meter acti

[ovs-dev] [PATCH v6 1/2] ovn-controller: Add extend_table instead of group_table to expand meter.

2018-01-24 Thread Guoshuai Li
The structure and function of the group table and meter table are similar, refactoring code is used to extend for add the meter table. The following function as lib: table init/destroy/clear/lookup/remove, assign id for contents, Move the contents of desired to existing. Signed-off-by: Guoshuai Li

[ovs-dev] [PATCH v6 0/2] OVN Support QoS meter

2018-01-24 Thread Guoshuai Li
v3-v4: 1. Fix checkpatch error. 2. The local rate variable uses uint64_t. This can support a very large rate. 3. Fix formatting mismatch issues. 4. Repair meter can not be the last table problem. 5. Add a note and description of the rate unit. 6. Supplementary test cases. v4-v5:

Re: [ovs-dev] [PATCH v11] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

2018-01-24 Thread Ilya Maximets
On 24.01.2018 11:30, Ciara Loftus wrote: > Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' > option to 'true' when configuring the Interface: > > ovs-vsctl set Interface dpdkvhostuserclient0 > options:vhost-server-path=/tmp/dpdkvhostuserclient0 > options:dq-zero-copy=true >

Re: [ovs-dev] [PATCH OVS 1/1] tc flower: reorder tunnel encap/decap actions

2018-01-24 Thread Simon Horman
On Tue, Jan 23, 2018 at 02:08:42PM +, John Hurley wrote: > The tc_flower conversion struct does not consider the order of actions. > If an OvS rule matches on a tunnel (decap) and outputs to a new tunnel, > the netlink conversion to TC will add the set tunnel key action before the > unset, lead

Re: [ovs-dev] [PATCH v4] netdev-linux: do not send packets to down tap ifaces.

2018-01-24 Thread Flavio Leitner
On Tue, Jan 23, 2018 at 12:31:53PM -0800, Ben Pfaff wrote: > On Wed, Jan 17, 2018 at 10:09:58PM -0200, Flavio Leitner wrote: > > Today OVS pushes packets to the TAP interface ignoring its > > current state. That works because the kernel will return -EIO > > when it's not UP and OVS will just ignore

Re: [ovs-dev] [PATCH v2] ovn-controller: add new external_id 'ovn-cms-options' to Chassis table

2018-01-24 Thread Miguel Angel Ajo Pelayo
Thank you Ben, that was very quick. It's very helpful. On Tue, Jan 23, 2018 at 6:58 PM Ben Pfaff wrote: > I agree that this seems harmless and potentially useful, so I applied it > to master and branch-2.9. > > On Tue, Jan 23, 2018 at 03:47:23PM +, Miguel Angel Ajo Pelayo wrote: > > Awesome

Re: [ovs-dev] mbuf pool sizing

2018-01-24 Thread Venkatesan Pradeep
Hi Kevin, My primary concern is that someone upgrading to OVS2.9 may find that configurations that were previously working fine no longer do because the memory dimensioned for OVS may not be sufficient. It could be argued that since the shared mempool method allocates a fixed number of buffers

[ovs-dev] Bug#663051: marked as done (openvswitch-datapath-dkms ships unneeded files)

2018-01-24 Thread Debian Bug Tracking System
Your message dated Wed, 24 Jan 2018 09:49:40 +0100 with message-id <5c5e39fd-ec0e-cc7f-0855-a70b2d405...@debian.org> and subject line Closing bug has caused the Debian Bug report #663051, regarding openvswitch-datapath-dkms ships unneeded files to be marked as done. This means that you claim that

[ovs-dev] Bug#690712: marked as done (openvswitch-datapath-dkms: bashism in /bin/sh script)

2018-01-24 Thread Debian Bug Tracking System
Your message dated Wed, 24 Jan 2018 09:49:40 +0100 with message-id <5c5e39fd-ec0e-cc7f-0855-a70b2d405...@debian.org> and subject line Closing bug has caused the Debian Bug report #663051, regarding openvswitch-datapath-dkms: bashism in /bin/sh script to be marked as done. This means that you claim

[ovs-dev] Bug#740355: marked as done (openvswitch-datapath-source: module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64)

2018-01-24 Thread Debian Bug Tracking System
Your message dated Wed, 24 Jan 2018 09:44:42 +0100 with message-id <2086b2a6-ef8f-fdd3-b211-63646a324...@debian.org> and subject line Closing bug has caused the Debian Bug report #740355, regarding openvswitch-datapath-source: module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64 to be

[ovs-dev] [PATCH v11] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

2018-01-24 Thread Ciara Loftus
Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy enable

[ovs-dev] Bug#726035: marked as done (openvswitch-controller: typo in /etc/default/openvswitch-controller)

2018-01-24 Thread Debian Bug Tracking System
Your message dated Wed, 24 Jan 2018 09:26:01 +0100 with message-id <7fd8726c-da03-923e-9525-271b76648...@debian.org> and subject line Closing this bug has caused the Debian Bug report #726035, regarding openvswitch-controller: typo in /etc/default/openvswitch-controller to be marked as done. This

[ovs-dev] Bug#860479: marked as done (openvswitch-datapath-dkms (and openvswitch-datapath-source) fail compiling on fresh install of 7.11)

2018-01-24 Thread Debian Bug Tracking System
Your message dated Wed, 24 Jan 2018 09:22:02 +0100 with message-id and subject line Closing bug has caused the Debian Bug report #860479, regarding openvswitch-datapath-dkms (and openvswitch-datapath-source) fail compiling on fresh install of 7.11 to be marked as done. This means that you claim