Re: [ovs-dev] [PATCH 20/20] Documentation: Update NEWS and faq

> On Jan 31, 2018, at 7:55 PM, Pravin Shelar wrote: > > On Wed, Jan 31, 2018 at 10:50 AM, Justin Pettit wrote: >> >> Pravin, thank you for reviewing the patches. When you're going though them, >> can you make a decision whether you think they're safe enough

Re: [ovs-dev] [PATCH v4] openvswitch: Remove padding from packet before L3+ conntrack processing

On Wed, Jan 31, 2018 at 6:48 PM, Ed Swierk wrote: > IPv4 and IPv6 packets may arrive with lower-layer padding that is not > included in the L3 length. For example, a short IPv4 packet may have > up to 6 bytes of padding following the IP payload when received on an >

Re: [ovs-dev] [PATCH v7 0/6] OVS-DPDK flow offload with rte_flow

On Mon, Jan 29, 2018 at 02:59:42PM +0800, Yuanhan Liu wrote: > Hi, > > Here is a joint work from Mellanox and Napatech, to enable the flow hw > offload with the DPDK generic flow interface (rte_flow). > > The basic idea is to associate the flow with a mark id (a unit32_t number). > Later, we

Re: [ovs-dev] [PATCH] learn: improve test case

On Wed, Jan 31, 2018 at 6:32 PM, William Tu wrote: > Current learn test cases use only ovs-ofctl add/del flows. > The patch add a new test case for learn with delete_learned and > limit option enabled. > > Signed-off-by: William Tu > --- > tests/learn.at

[ovs-dev] [PATCH v1 1/2] datapath-windows: Allow compiling all targets using SDK 10.0

Previously, Win8/8.1 targets would use SDK8.1. However, its recommended to use the newer SDK as newer VS versions typically drop support for older SDKs later on. This patch adds support to compile all targets (Win8/8.1/10) using the 10.0 SDK. Note that his patch does not drop support for older

[ovs-dev] [PATCH v4] openvswitch: Remove padding from packet before L3+ conntrack processing

IPv4 and IPv6 packets may arrive with lower-layer padding that is not included in the L3 length. For example, a short IPv4 packet may have up to 6 bytes of padding following the IP payload when received on an Ethernet device with a minimum packet length of 64 bytes. Higher-layer processing

[ovs-dev] [PATCH] learn: improve test case

Current learn test cases use only ovs-ofctl add/del flows. The patch add a new test case for learn with delete_learned and limit option enabled. Signed-off-by: William Tu --- tests/learn.at | 38 ++ 1 file changed, 38 insertions(+) diff

Re: [ovs-dev] [PATCH 10/15] ovsdb-server: Add new RPC "set_db_change_aware".

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > + Traditionally, ovsdb-server disconnects all of its clients > + when a significant configuration change occurs, because this prompts a > + well-written client to reassess what is available from the server when >

[ovs-dev] Balanced Scorecard

Logre sus objetivos a través de una gestión estratégica Balanced Scorecard: Una herramienta para la estrategia empresarial 15 de Febrero- C.P. Hugo Coca Chávez - 9am- 8pm El Balanced Scorecard da una serie de resultados que favorecen la administración de su organización, a través de la

Re: [ovs-dev] [PATCH] util: Document and rely on ovs_assert() always evaluating its argument.

Thanks, looks good to me. Reviewed-by: Yifeng Sun On Wed, Jan 31, 2018 at 11:23 AM, Ben Pfaff wrote: > The ovs_assert() macro always evaluates its argument, even when NDEBUG is > defined so that failure is ignored. This behavior wasn't documented, and >

[ovs-dev] Redes sociales y la atracción de talento

Reclutamiento 3.0 Febrero 14 - webinar Interactivo Dirigido a Personal de RRHH, Departamento de reclutamiento y selección de las empresas y cualquier persona que intervenga en el proceso de reclutamiento, selección y contratación de personal. Temario: Panorama actual y antecedentes de la

[ovs-dev] [PATCHv2] ovs-router: fix router entry cast

The offsetof(struct ovs_router_entry, cr) should always be 0, thus the else statement should never be reached. Signed-off-by: William Tu --- lib/ovs-router.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

On Wed, Jan 31, 2018 at 02:12:14PM +, Yang, Yi Y wrote: > Hi, Eric > > My kernel is 4.13.0-rc6, so I'm very sure it can support vxlan-gpe, I > can add vxlan-gpe port without any issue by command line, so I don't > know what happened. Your output below indicates this is failing on this line:

Re: [ovs-dev] [PATCH 07/15] ovsdb-idl: Break out database-specific stuff into new data structure.

On Wed, Jan 24, 2018 at 05:44:05PM -0800, Justin Pettit wrote: > > > > On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: > > > > +struct ovsdb_idl { > > +struct ovsdb_idl_db server; > > +struct ovsdb_idl_db db; /* XXX rename 'data'? */ > > Did you want to change this? I

[ovs-dev] OVS DPDK: dpdk_merge pull request for branch-2.9

Hi Ben, The following changes since commit 448a18458328655539599eb4d24b525d311d13df: netdev-dpdk: Fix xstats leak on port destruction. (2018-01-26 20:40:52 +) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge_2_9 for you to fetch changes up to

[ovs-dev] OVS DPDK: dpdk_merge pull request for master

Hi Ben, The following changes since commit 186667a83c2b09ed9ae08b35c596987cf7d33cfb: classifier: Fix typo in comment. (2018-01-30 13:00:52 -0800) are available in the git repository at: https://github.com/istokes/ovs dpdk_merge for you to fetch changes up to

Re: [ovs-dev] [PATCH] ovs-router: fix router entry cast

On Wed, Jan 31, 2018 at 11:27 AM, Ben Pfaff wrote: > On Wed, Jan 31, 2018 at 11:03:04AM -0800, William Tu wrote: >> The offsetof(struct ovs_router_entry, cr) should always be 0, >> thus the else statement should never be reached. >> >> Signed-off-by: William Tu

Re: [ovs-dev] [PATCH v2 0/3] support table names in CLI

I just noticed these acks. No need for individual acks. Thank you for the reviews. Since I sent out v3 already, I'll give it a few days and then apply this if there are no further comments. On Mon, Jan 15, 2018 at 02:49:09PM -0600, Mark Michelson wrote: > Hi Ben, > > For the series: >

Re: [ovs-dev] [PATCH v2 3/3] Support accepting and displaying table names in OVS tools.

On Fri, Jan 12, 2018 at 01:07:24PM -0800, Kei Nohguchi wrote: > Hi Ben, > > On Fri, Jan 12, 2018 at 12:57:22PM -0800, Ben Pfaff wrote: > > OpenFlow has little-known support for naming tables. Open vSwitch has > > supported table names for ages, but it has never used or displayed them > > outside

Re: [ovs-dev] [PATCH v2 2/3] ofp-util: New data structure for mapping between table names and numbers.

Thanks for the reviews of patches 1 and 2. Do you plan to review patch 3 as well? I rebased and sent out v3 just now. On Tue, Jan 30, 2018 at 01:29:56PM -0800, Yifeng Sun wrote: > Looks good to me, thanks. > > Reviewed-by: Yifeng Sun > > > On Fri, Jan 12, 2018 at

[ovs-dev] [PATCH v3 3/3] Support accepting and displaying table names in OVS tools.

OpenFlow has little-known support for naming tables. Open vSwitch has supported table names for ages, but it has never used or displayed them outside of commands dedicated to table manipulation. This commit adds support for table names in ovs-ofctl. When a table has a name, it displays that

[ovs-dev] [PATCH v3 1/3] ofp-actions: Make formatting and parsing functions take a struct argument.

An upcoming commit will add another parameter for parsing and formatting actions. It is much easier to add these parameters if they are encapsulated in a struct, so this commit first makes that change. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun ---

[ovs-dev] [PATCH v3 2/3] ofp-util: New data structure for mapping between table names and numbers.

This shares the infrastructure for mapping port names and numbers. It will be used in an upcoming commit. Signed-off-by: Ben Pfaff Reviewed-by: Yifeng Sun --- include/openvswitch/ofp-util.h | 33 +++-- lib/ofp-util.c | 150

[ovs-dev] [PATCH v3 0/3] support table names in CLI

These patches are intended for master only. v1->v2: Rebase and fix up against concurrent changes in master. v2->v3: Rebase and fix up against master. Ben Pfaff (3): ofp-actions: Make formatting and parsing functions take a struct argument. ofp-util: New data structure for mapping between

Re: [ovs-dev] [PATCH] ovs-router: fix router entry cast

On Wed, Jan 31, 2018 at 11:03:04AM -0800, William Tu wrote: > The offsetof(struct ovs_router_entry, cr) should always be 0, > thus the else statement should never be reached. > > Signed-off-by: William Tu > --- > lib/ovs-router.c | 2 +- > 1 file changed, 1 insertion(+), 1

[ovs-dev] [PATCH] util: Document and rely on ovs_assert() always evaluating its argument.

The ovs_assert() macro always evaluates its argument, even when NDEBUG is defined so that failure is ignored. This behavior wasn't documented, and thus a lot of code didn't rely on it. This commit documents the behavior and simplifies bits of code that heretofore didn't rely on it.

Re: [ovs-dev] [PATCH] classifier: Refactor interface for classifier_remove().

Thanks for the review! Sorry about duplicating your work--I think that we both prepared the same change at the same time. I applied this to master. On Tue, Jan 30, 2018 at 01:16:26PM -0800, Yifeng Sun wrote: > Thanks for the patch, which is better than the one I submitted. > > Tested-by:

[ovs-dev] [PATCH] ovs-router: fix router entry cast

The offsetof(struct ovs_router_entry, cr) should always be 0, thus the else statement should never be reached. Signed-off-by: William Tu --- lib/ovs-router.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-router.c b/lib/ovs-router.c index

Re: [ovs-dev] [PATCH 20/20] Documentation: Update NEWS and faq

> On Jan 30, 2018, at 3:49 PM, Gregory Rose wrote: > > On 1/30/2018 3:43 PM, Justin Pettit wrote: >> >>> On Jan 30, 2018, at 3:40 PM, Greg Rose wrote: >>> >>> Signed-off-by: Greg Rose >>> --- >>>

Re: [ovs-dev] kernel crash bug caused by ixgbevf kernel module of centos-3.10.0-229.20.1.el7

On 1/29/2018 6:23 PM, Sam wrote: detail as below, bug is happened on bond of enp1s16 and enp1s16f1 [huanghuai-test@yf-mos-test-net14 ~]$ sudo /usr/local/share/openvswitch/scripts/dpdk_nic_bind --status Network devices using DPDK-compatible driver

Re: [ovs-dev] [PATCH V2] rhel: Fix support for root user using DPDK

Marcos Felipe Schwarz writes: > Since 2.8.0 OVS runs as non-root user on rhel distros, but the current > implementation breaks the ability to run as root with DPDK and as a > consequence there is no way possible to use UIO drivers on kernel 4.0 and > newer [1, 2]. > [1]

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

On 1/31/2018 6:12 AM, Yang, Yi Y wrote: Hi, Eric My kernel is 4.13.0-rc6, so I'm very sure it can support vxlan-gpe, I can add vxlan-gpe port without any issue by command line, so I don't know what happened. Greg, I checked unit tests in tests/system-traffic.at and

Re: [ovs-dev] OVS-DPDK public meeting

31th January 2018 Attendees: Flavio, Johann, Olga, Aaron, Ben, Michael, Jan, Ian, Frikkie, Sugesh, Yipeng === GENERAL === OVS 2.9 Release - New features deadline for 2.9: 31/Jan. - Patches on DPDK_MERGE_2_9 -- VHost Zero Copy (Experimental) Potential patches for DPDK_MERGE_2_9

Re: [ovs-dev] [PATCH] openvswitch: meter: Use 64-bit arithmetic instead of 32-bit

From: "Gustavo A. R. Silva" Date: Tue, 30 Jan 2018 22:55:33 -0600 > Add suffix LL to constant 1000 in order to give the compiler > complete information about the proper arithmetic to use. Notice > that this constant is used in a context that expects an expression > of

Re: [ovs-dev] [PATCH v13] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

> -Original Message- > From: Loftus, Ciara > Sent: Wednesday, January 31, 2018 10:45 AM > To: d...@openvswitch.org > Cc: Loftus, Ciara ; Stokes, Ian > > Subject: [PATCH v13] netdev-dpdk: Add support for vHost dequeue zero copy > (experimental)

Re: [ovs-dev] [PATCH v1 0/5] datapath: enable NSH support in kernel compat mode

Hi, Eric My kernel is 4.13.0-rc6, so I'm very sure it can support vxlan-gpe, I can add vxlan-gpe port without any issue by command line, so I don't know what happened. Greg, I checked unit tests in tests/system-traffic.at and tests/system-layer3-tunnels.at for vxlan and vxlan-gpe, I think they

[ovs-dev] [PATCH v2 5/5] datapath: enable NSH support

Upstream commit: commit b2d0f5d5dc53532e6f07bc546a476a55ebdfe0f3 Author: Yi Yang Date: Tue Nov 7 21:07:02 2017 +0800 openvswitch: enable NSH support OVS master and 2.8 branch has merged NSH userspace patch series, this patch is to enable NSH support

[ovs-dev] [PATCH v2 4/5] datapath: nsh: add GSO support

Upstream commit: commit c411ed854584a71b0e86ac3019b60e4789d88086 Author: Jiri Benc Date: Mon Aug 28 21:43:24 2017 +0200 nsh: add GSO support Add a new nsh/ directory. It currently holds only GSO functions but more will come: in particular, code shared by

[ovs-dev] [PATCH v2 3/5] datapath: net: add NSH header structures and helpers

Upstream commit: commit 1f0b7744c50573df464ca33d8e5275be509f852b Author: Yi Yang Date: Mon Aug 28 21:43:23 2017 +0200 net: add NSH header structures and helpers NSH (Network Service Header)[1] is a new protocol for service function chaining, it can be

[ovs-dev] [PATCH v2 2/5] datapath: vxlan: factor out VXLAN-GPE next protocol

Upstream commit: commit fa20e0e32cb3dfc1760b6254b64977f2fb5bd851 Author: Jiri Benc Date: Mon Aug 28 21:43:22 2017 +0200 vxlan: factor out VXLAN-GPE next protocol The values are shared between VXLAN-GPE and NSH. Originally probably by coincidence but I

[ovs-dev] [PATCH v2 1/5] datapath: ether: add NSH ethertype

Upstream commit: commit 155e6f649757c902901e599c268f8b575ddac1f8 Author: Jiri Benc Date: Mon Aug 28 21:43:21 2017 +0200 ether: add NSH ethertype The NSH draft says: An IEEE EtherType, 0x894F, has been allocated for NSH. Signed-off-by: Jiri Benc

[ovs-dev] [PATCH v2 0/5] datapath: enable NSH support in kernel compat mode

v1->v2 - Fix compilation error in linux-3.10.107 This patch series is to backport NSH support patches in Linux net-next tree to OVS in order that it can support NSH in kernel compat mode. Yi Yang (5): datapath: ether: add NSH ethertype datapath: vxlan: factor out VXLAN-GPE next protocol

[ovs-dev] [PATCH v13] netdev-dpdk: Add support for vHost dequeue zero copy (experimental)

Zero copy is disabled by default. To enable it, set the 'dq-zero-copy' option to 'true' when configuring the Interface: ovs-vsctl set Interface dpdkvhostuserclient0 options:vhost-server-path=/tmp/dpdkvhostuserclient0 options:dq-zero-copy=true When packets from a vHost device with zero copy

Re: [ovs-dev] [PATCH v2] tests: Add system-dpdk-testsuite

> -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Marcin Rybka > Sent: Tuesday, January 2, 2018 2:36 PM > To: d...@openvswitch.org > Cc: Rybka, MarcinX > Subject: [ovs-dev] [PATCH v2] tests: Add

Re: [ovs-dev] [PATCH V2] rhel: Fix support for root user using DPDK

Hello, On 31/01/18 00:07, Marcos Felipe Schwarz wrote: > diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c > index adb549c98..06528e9ab 100644 > --- a/lib/daemon-unix.c > +++ b/lib/daemon-unix.c > @@ -1047,5 +1047,6 @@ daemon_set_new_user(const char *user_spec) > } > } > > -