Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 5:31 PM, Pravin Shelar wrote: > > Sorry, I misread it, NSH is in 2.9. > I think rest of patches should be easy to backport those patches, I > can work on it tomorrow. If it's not too bad, that would be great. Thank you very much! --Justin

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Fri, Feb 16, 2018 at 2:16 PM, Justin Pettit wrote: > > >> On Feb 16, 2018, at 1:25 PM, Pravin Shelar wrote: >> >> On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit wrote: >>> >> At this point 2.9 supports 4.13, so we will need to pull in patch

Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

I think it makes sense to allow the rate limit to be set through the database, no objection there. On Fri, Feb 16, 2018 at 11:47:41PM +, Jan Scheurich wrote: > Hi Ben, > > Thanks, I didn't know about the pseudo OFPM_SLOWPATH meter defined in > OpenFlow. It appears to have been introduced

Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

Hi Ben, Thanks, I didn't know about the pseudo OFPM_SLOWPATH meter defined in OpenFlow. It appears to have been introduced roughly for what we need here. So it seems like a good idea to be able to support a Meter Mod message with a drop band for the OFPM_SLOWPATH to configure the upcall rate

Re: [ovs-dev] [PATCH] odp.at: fix sed string matching typo.

On Fri, Feb 16, 2018 at 03:15:43PM -0800, William Tu wrote: > On Fri, Feb 16, 2018 at 3:12 PM, Ben Pfaff wrote: > > On Fri, Feb 16, 2018 at 10:42:42AM -0800, William Tu wrote: > >> Replace 'set' with 'sed'. > >> > >> Signed-off-by: William Tu > >> --- > >>

Re: [ovs-dev] [PATCH] odp.at: fix sed string matching typo.

On Fri, Feb 16, 2018 at 3:12 PM, Ben Pfaff wrote: > On Fri, Feb 16, 2018 at 10:42:42AM -0800, William Tu wrote: >> Replace 'set' with 'sed'. >> >> Signed-off-by: William Tu >> --- >> tests/odp.at | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>

Re: [ovs-dev] [PATCH] odp.at: fix sed string matching typo.

On Fri, Feb 16, 2018 at 10:42:42AM -0800, William Tu wrote: > Replace 'set' with 'sed'. > > Signed-off-by: William Tu > --- > tests/odp.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/odp.at b/tests/odp.at > index

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

On Fri, Feb 16, 2018 at 05:10:29PM +0100, Jakub Sitnicki wrote: > Ben, > > On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is > > expensive, so this should improve ovn-northd performance. > > > > Reported-by: Jakub

Re: [ovs-dev] [PATCH] osv-ofctl: Make ofp-print able to read raw data from a file.

Thanks for the review. You are right about the leak (thank you!); I fixed it. I applied this to master. On Fri, Feb 16, 2018 at 09:59:25AM -0800, Yifeng Sun wrote: > It seems for me that buffer is leaked for the below line: > > buffer = ds_steal_cstr(); > > Or it doesn't matter since

[ovs-dev] [PATCH 5/6] ofp-match: Make some public functions static.

These were only used inside ofp-match itself. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-match.h | 5 - lib/ofp-match.c | 4 ++-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/include/openvswitch/ofp-match.h

[ovs-dev] [PATCH 6/6] ofp-print: Move much of the printing code into message-specific files.

Until now, the ofp-print code has had a lot of logic specific to individual messages. This code is better put with the other code specific to those messages, so this commit starts to migrate it. There is more work of a similar type to do, but this is a reasonable start. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH 4/6] ofp-flow: Move parse_ofp_flow_mod_str() into correct file.

This function was left behind by accident in the patch that split up ofp-parse. Signed-off-by: Ben Pfaff --- lib/ofp-flow.c | 30 ++ lib/ofp-parse.c | 30 -- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git

[ovs-dev] [PATCH 3/6] ofp-packet: Better abstract packet-in format.

This commit relieves the caller of code that deals with the format of packet-in messages from some of the burden of understanding the packet format. It also renames the constants to appear to be at a higher level of abstraction. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH 2/6] ofp-protocol: Better abstract changing the protocol used for flow matches.

The previous interface here required the client to understand, to some extent, the low-level NXFF_* values and the encoding format for the NXT_SET_FLOW_FORMAT and NXT_SET_FLOW_MOD_TABLE_ID messages. This commit changes the interface so that the client only has to understand the ofputil_protocol

[ovs-dev] [PATCH 1/6] ofp-util: Use consistent naming convention.

Most of the tree now uses "encode" as the verb for making an OpenFlow message, so adopt it here in this very old code as well. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-util.h | 4 ++-- lib/learning-switch.c | 2 +- lib/ofp-util.c | 4 ++--

Re: [ovs-dev] [PATCH v2] Upcall/Slowpath rate limiter for OVS

OK. We do need some kind of special case here. I think I was I was thinking of something different: metering for datapath flows that need to go to the slowpath. For those, we have a set of datapath actions and those datapath actions can include a meter action, and that's what we're planning to

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 1:25 PM, Pravin Shelar wrote: > > On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit wrote: >> > At this point 2.9 supports 4.13, so we will need to pull in patch > series for 4.14 and 4.15 to the branch 2.9. > OVS 2.9 missing datapath

[ovs-dev] Cómo liderar a los millenials.

Solicite AHORA MISMO el temario con toda la información de este EXCLUSIVO EVENTO PRESIONE AQUI o responda "Millenials"+TELÉFONO + NOMBRE+ COMPAÑÍA 045 + 5515546630 Cómo liderar a los millenials. Marzo 07 - webinar Interactivo En este webinar buscaremos explicar estas y otras preguntas

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Fri, Feb 16, 2018 at 1:44 AM, Justin Pettit wrote: > > >> On Feb 16, 2018, at 12:52 AM, Pravin Shelar wrote: >> >> On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: >>> Pull in the remaining available upstream bug fixes for the

[ovs-dev] [RFC 2/2] ingress scheduling: Provide per interface ingress priority

Allow configuration to specify an ingress priority for interfaces. Modify ovs-netdev datapath to act on this configuration so that packets on interfaces with a higher priority will tend be processed ahead of packets on lower priority interfaces. This protects traffic on higher priority interfaces

[ovs-dev] [RFC 1/2] ingress scheduling: schema and docs

Signed-off-by: Billy O'Mahony --- Documentation/howto/dpdk.rst | 18 ++ vswitchd/vswitch.ovsschema | 9 +++-- vswitchd/vswitch.xml | 40 3 files changed, 65 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [RFC 0/2] Ingress Scheduling

This patch set implements the 'preferential read' part of the feature of ingress scheduling described at OvS 2017 Fall Conference https://www.slideshare.net/LF_OpenvSwitch/lfovs17ingress-scheduling-82280320. It allows configuration to specify an ingress priority for and entire interface. This

Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

Acked-by: Anand Kumar Thanks, Anand Kumar From: Shashank Ram Sent: Tuesday, February 6, 2018 1:29 PM To: d...@openvswitch.org Cc:

[ovs-dev] [PATCH] odp.at: fix sed string matching typo.

Replace 'set' with 'sed'. Signed-off-by: William Tu --- tests/odp.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/odp.at b/tests/odp.at index ea8f40ede78b..cdf3d6645ea4 100644 --- a/tests/odp.at +++ b/tests/odp.at @@ -30,9 +30,9 @@

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On 2/16/2018 12:52 AM, Pravin Shelar wrote: On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: Pull in the remaining available upstream bug fixes for the openvswitch Linux kernel datapath. In addition, allow building the openvswitch OOT kernel datapath on kernels up to

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

Ben, On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is > expensive, so this should improve ovn-northd performance. > > Reported-by: Jakub Sitnicki > Reported-at: >

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

Hi Jan, Specifically, in v5 the global configuration was removed from the code, and the documentation were updated with this information, and changes were done in the docs based on the comments by Eelco. Regards, Robert -Original Message- From: Jan Scheurich Sent: Thursday, February

Re: [ovs-dev] [PATCH v5] Configurable Link State Change (LSC) detection mode

Hi Jan, This is the diff between v4 and v5. Regards, Robert diff --git a/Documentation/intro/install/dpdk.rst b/Documentation/intro/install/dpdk.rst index 14a6684..e3872e7 100644 --- a/Documentation/intro/install/dpdk.rst +++ b/Documentation/intro/install/dpdk.rst @@ -634,47 +634,34 @@ Link

Re: [ovs-dev] [PATCH] dpif-netdev: Refactor datapath flow cache

> >>-Original Message- >>> >>> [Wang, Yipeng] In my test, I compared the proposed EMC with current >EMC with same 16k entries. >>> If I turned off THP, the current EMC will cause many TLB misses because of >its larger entry size, which I profiled with vTunes. >>> Once I turned on THP with

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

> On Feb 16, 2018, at 12:52 AM, Pravin Shelar wrote: > > On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: >> Pull in the remaining available upstream bug fixes for the openvswitch >> Linux kernel datapath. In addition, allow building the openvswitch >>

Re: [ovs-dev] [PATCH] ofp-meter: Fix use-after-free for decoding meter mods.

ofputil_pull_bands may change bands->data. Thanks for the fix. Reviewed-by: Yifeng Sun On Wed, Feb 14, 2018 at 2:36 PM, Ben Pfaff wrote: > Found by libfuzzer-ngram. > > Reported-by: Bhargava Shastry > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH 15/15] ovsdb: Introduce experimental support for clustered databases. (1/2)

> On Dec 31, 2017, at 9:16 PM, Ben Pfaff wrote: I still haven't finished, but I think there are a few items you could start looking at while I finish the review later today. > diff --git a/Documentation/ref/ovsdb.5.rst b/Documentation/ref/ovsdb.5.rst > index

Re: [ovs-dev] [PATCH 0/8] Linux upstream kernel backports and updates

On Wed, Feb 14, 2018 at 3:18 PM, Greg Rose wrote: > Pull in the remaining available upstream bug fixes for the openvswitch > Linux kernel datapath. In addition, allow building the openvswitch > OOT kernel datapath on kernels up to and including Linux kernel release > 4.15.